Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-15 Thread Haojian Zhuang
On 02/15/2018 11:41 PM, Leif Lindholm wrote: > On Mon, Feb 12, 2018 at 11:45:06AM +, Leif Lindholm wrote: >> On Sat, Feb 10, 2018 at 01:31:06AM +0800, Haojian Zhuang wrote: >>> With the SerialPortLib and DebugLib, Dxe runtime driver can't >>> be executed well on HiKey. Serial logs are missing.

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-15 Thread Leif Lindholm
On Mon, Feb 12, 2018 at 11:45:06AM +, Leif Lindholm wrote: > On Sat, Feb 10, 2018 at 01:31:06AM +0800, Haojian Zhuang wrote: > > With the SerialPortLib and DebugLib, Dxe runtime driver can't > > be executed well on HiKey. Serial logs are missing. > > "Can't be executed well"? Does this mean

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-12 Thread Guo Heyi
On Tue, Feb 13, 2018 at 12:59:50AM +, Haojian Zhuang wrote: > On 02/13/2018 08:23 AM, Guo Heyi wrote: > > Hi Haojian, > > > > Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there > > isn't such device on Hikey, then you can't use this library instance indeed. > > > >

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-12 Thread Haojian Zhuang
On 02/13/2018 08:23 AM, Guo Heyi wrote: > Hi Haojian, > > Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there > isn't such device on Hikey, then you can't use this library instance indeed. > > But I think PeiDxeDebugLibReportStatusCode should be some common code, however

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-12 Thread Guo Heyi
Hi Haojian, Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there isn't such device on Hikey, then you can't use this library instance indeed. But I think PeiDxeDebugLibReportStatusCode should be some common code, however it depends on ReportStatusCodeLib and Status Code

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-12 Thread Haojian Zhuang
>Cc: Leif Lindholm; edk2-devel@lists.01.org; heyi@linaro.org; >>>ard.sheu...@linaro.org; linaro-u...@lists.linaro.org >>>Subject: Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime >>>lib from common file >>> >>>>On 12 February 20

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-12 Thread Ard Biesheuvel
>>ard.sheu...@linaro.org; linaro-u...@lists.linaro.org >>Subject: Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime >>lib from common file >> >>On 12 February 2018 at 11:47, Haojian Zhuang <haojian.zhu...@linaro.org> >>wrote: >>>

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-12 Thread Haojian Zhuang
>From: Ard Biesheuvel <ard.biesheu...@linaro.org> >Sent: Monday, February 12, 2018 12:05 PM >To: Haojian Zhuang >Cc: Leif Lindholm; edk2-devel@lists.01.org; heyi@linaro.org; >ard.sheu...@linaro.org; linaro-u...@lists.linaro.org >Subject: Re: [edk2] [PATCH v2 3/4] Plat

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-12 Thread Ard Biesheuvel
On 12 February 2018 at 11:47, Haojian Zhuang wrote: >>From: Leif Lindholm >>Sent: Monday, February 12, 2018 11:45 AM >>To: Haojian Zhuang >>Cc: edk2-devel@lists.01.org; linaro-u...@lists.linaro.org; >>ard.sheu...@linaro.org;

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-12 Thread Haojian Zhuang
>From: Leif Lindholm >Sent: Monday, February 12, 2018 11:45 AM >To: Haojian Zhuang >Cc: edk2-devel@lists.01.org; linaro-u...@lists.linaro.org; >ard.sheu...@linaro.org; heyi@linaro.org >Subject: Re: [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from

Re: [edk2] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

2018-02-12 Thread Leif Lindholm
On Sat, Feb 10, 2018 at 01:31:06AM +0800, Haojian Zhuang wrote: > With the SerialPortLib and DebugLib, Dxe runtime driver can't > be executed well on HiKey. Serial logs are missing. "Can't be executed well"? Does this mean it crashes? > Contributed-under: TianoCore Contribution Agreement 1.1 >