Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

2018-04-23 Thread Girish Pathak
Hi Leif, > -Original Message- > From: Leif Lindholm > Sent: 23 April 2018 17:22 > To: Girish Pathak > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Matteo Carlini > ; Stephanie Hughes-Fitt f...@arm.com>;

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

2018-04-23 Thread Leif Lindholm
On Mon, Apr 23, 2018 at 04:06:43PM +, Girish Pathak wrote: > > From: Leif Lindholm > > Sent: 23 April 2018 12:32 > > To: Girish Pathak > > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Matteo Carlini > > ;

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

2018-04-23 Thread Girish Pathak
Hi Leif, > -Original Message- > From: Leif Lindholm > Sent: 23 April 2018 12:32 > To: Girish Pathak > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; Matteo Carlini > ; Stephanie Hughes-Fitt f...@arm.com>;

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

2018-04-23 Thread Leif Lindholm
Hmm, I did find a few minor things below that I need to hear back on before pushing. On Tue, Mar 20, 2018 at 04:12:12PM +, Girish Pathak wrote: > This change introduces a new SCMI protocol driver for > Arm systems. The driver currently supports only clock > and performance management

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd > -Original Message- > From: edk2-devel On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd ; Stephanie Hughes-Fitt f...@arm.com>;