Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-11 Thread Marcin Wojtas
2017-10-11 11:14 GMT+02:00 Leif Lindholm : > On Wed, Oct 11, 2017 at 10:43:14AM +0200, Marcin Wojtas wrote: >> >> I think it's fairly easy thing, needlessly twisted... How does above >> >> reflect the requirement to add contributor sign-off to someone else's >> >> patch

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-11 Thread Leif Lindholm
On Wed, Oct 11, 2017 at 10:43:14AM +0200, Marcin Wojtas wrote: > >> I think it's fairly easy thing, needlessly twisted... How does above > >> reflect the requirement to add contributor sign-off to someone else's > >> patch (with his authorship and original sign-off - should they be > >> removed?)?

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-11 Thread Marcin Wojtas
Leif, 2017-10-11 10:32 GMT+02:00 Leif Lindholm : > On Wed, Oct 11, 2017 at 06:53:05AM +0200, Marcin Wojtas wrote: >> >> I think Contibuted-under: still needs to come first. >> >> >> >> I don't think we have an explicit policy for how to deal with >> >> multi-contributor

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-11 Thread Leif Lindholm
On Wed, Oct 11, 2017 at 06:53:05AM +0200, Marcin Wojtas wrote: > >> I think Contibuted-under: still needs to come first. > >> > >> I don't think we have an explicit policy for how to deal with > >> multi-contributor patches. The ones we do see tend to just keep a > >> single commit message and

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-10 Thread Marcin Wojtas
2017-10-10 22:36 GMT+02:00 Ard Biesheuvel : > On 10 October 2017 at 16:26, Leif Lindholm wrote: >> On Tue, Oct 10, 2017 at 05:06:42PM +0200, Marcin Wojtas wrote: >>> 2017-10-10 17:03 GMT+02:00 Leif Lindholm : >>> > On

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-10 Thread Ard Biesheuvel
On 10 October 2017 at 16:26, Leif Lindholm wrote: > On Tue, Oct 10, 2017 at 05:06:42PM +0200, Marcin Wojtas wrote: >> 2017-10-10 17:03 GMT+02:00 Leif Lindholm : >> > On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: >> >> Hi Leif,

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-10 Thread Leif Lindholm
On Tue, Oct 10, 2017 at 05:06:42PM +0200, Marcin Wojtas wrote: > 2017-10-10 17:03 GMT+02:00 Leif Lindholm : > > On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: > >> Hi Leif, > >> > >> 2017-10-10 16:37 GMT+02:00 Leif Lindholm : > >>

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-10 Thread Marcin Wojtas
2017-10-10 17:03 GMT+02:00 Leif Lindholm : > On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: >> Hi Leif, >> >> 2017-10-10 16:37 GMT+02:00 Leif Lindholm : >> > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: >> >> In

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-10 Thread Leif Lindholm
On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: > Hi Leif, > > 2017-10-10 16:37 GMT+02:00 Leif Lindholm : > > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: > >> In order to enable modification of dynamic PCD's for the libraries > >> and

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-10 Thread Marcin Wojtas
Hi Leif, 2017-10-10 16:37 GMT+02:00 Leif Lindholm : > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: >> In order to enable modification of dynamic PCD's for the libraries >> and DXE drivers, this patch introduces new driver. It is >> executed prior to

Re: [edk2] [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver

2017-10-10 Thread Leif Lindholm
On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: > In order to enable modification of dynamic PCD's for the libraries > and DXE drivers, this patch introduces new driver. It is > executed prior to other drivers. Mpp, ComPhy and Utmi libraries > initialization were moved from PrePi