subject:"Re\: \[edk2\] \[staging\/FmpDevicePkg\-master\]\[PATCH 2\/2\] FmpDevicePkg FmpDxe\: Use Attributes to know whether reset is required"

Re: [edk2] [staging/FmpDevicePkg-master][PATCH 2/2] FmpDevicePkg FmpDxe: Use Attributes to know whether reset is required

2018-07-20 Thread Zeng, Star

Cc: Zeng, Star Subject: RE: [edk2] [staging/FmpDevicePkg-master][PATCH 2/2] FmpDevicePkg FmpDxe: Use Attributes to know whether reset is required Star, I think the logic may be reversed. The original logic tested !Pcd value. The new logic checks if the attribute and setting are != 0. I think

Re: [edk2] [staging/FmpDevicePkg-master][PATCH 2/2] FmpDevicePkg FmpDxe: Use Attributes to know whether reset is required

2018-07-20 Thread Kinney, Michael D

Star, I think the logic may be reversed. The original logic tested !Pcd value. The new logic checks if the attribute and setting are != 0. I think it should check if the attribute and setting are 0. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org]