Re: [edk2] [patch] Clean up unused data type - BOOL.

2015-08-13 Thread Zhang, Chao B
It is good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Friday, August 14, 2015 2:08 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [patch] Clean up unused data type - BOOL. Contributed-under: Tia

[edk2] [patch] Clean up unused data type - BOOL.

2015-08-13 Thread jiewen yao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" CC: "Zhang, Chao B" --- MdePkg/Include/IndustryStandard/Tpm20.h | 1 - 1 file changed, 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/Tpm20.h b/MdePkg/Include/IndustryStandard/Tpm20.h index 2abfc57

Re: [edk2] [Patch] NetworkPkg: Fix hang issue after system reconnected when IPSec has set up

2015-08-13 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Thursday, August 13, 2015 10:10 PM To: edk2-devel@lists.01.org Cc: Ye, Ting Subject: [Patch] NetworkPkg: Fix hang issue after system reconnected when IPSec has set up IpSecStop() is incompetent to send out the delete infor

Re: [edk2] [PATCH] MdeModulePkg Variable: Handle variable Attributes mismatch case

2015-08-13 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni -Original Message- From: Zeng, Star Sent: Monday, August 10, 2015 6:10 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [PATCH] MdeModulePkg Variable: Handle variable Attributes mismatch case between variable HOB and NV storage. Variable HOB may be built by

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread Scott Duplichan
David Woodhouse [mailto:dw...@infradead.org] wrote: ]Sent: Thursday, August 13, 2015 02:15 PM ]To: Scott Duplichan ; 'Ard Biesheuvel' ]Cc: 'Justen, Jordan L' ; 'edk2-devel@lists.01.org' ; 'Liu, ]Yingke D' ; 'Gao, Liming' ]Subject: Re: [edk2] [RFC PATCH 0/4] unify GCC command line options ] ]O

[edk2] [Patch] BaseTools: Add /arch:IA32 option in VS2012 and VS2013

2015-08-13 Thread Liming Gao
VS2012 and VS2013 turn on optimizations by default that generate the use of CMOV instruction. This is a change from previous version VS2008. This means when you build with VS2012 or VS2013, it will generate UD exceptions on Quark. To resolve it, add /arch:IA32 options to not use enhanced instructi

Re: [edk2] [Patch] MdeModulePkg: Fix issue about Ip4Dxe implementation for DHCP DORA process

2015-08-13 Thread Wu, Jiaxin
Yes, Samer, I will create a new patch to fix this issue. Thanks. Jiaxin -Original Message- From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com] Sent: Friday, August 14, 2015 1:49 AM To: Wu, Jiaxin; Ye, Ting; edk2-devel@lists.01.org Cc: Fu, Siyuan; Subramanian, Sriram (System

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Ard Biesheuvel had to walk into mine at 12:25:31 on Thursday 13 August 2015 and say: > On 13 August 2015 at 21:14, David Woodhouse wrote: > > On Thu, 2015-08-13 at 13:25 -0500, Scott Duplichan wrote: > >> A while back I experimented with m

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread David Woodhouse
On Thu, 2015-08-13 at 21:25 +0200, Ard Biesheuvel wrote: > Another reason to unify the GCC compiler and linker flags: we do use > -ffunction-sections -fdata-sections and --gc-sections, but only for > GCC44 - GCC49, and these flags are not inherited by UNIXGCC et al Ah, I didn't realise we did. Th

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread Ard Biesheuvel
On 13 August 2015 at 21:14, David Woodhouse wrote: > On Thu, 2015-08-13 at 13:25 -0500, Scott Duplichan wrote: >> A while back I experimented with mingw as a Windows hosted gcc tool >> chain for EDK2. It is usable, but has limitations. From a 2014 email >> to this list: > >> 1) Image is big due to

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread David Woodhouse
On Thu, 2015-08-13 at 13:25 -0500, Scott Duplichan wrote: > A while back I experimented with mingw as a Windows hosted gcc tool > chain for EDK2. It is usable, but has limitations. From a 2014 email > to this list: > 1) Image is big due to dead library code in final image. > 2) Default calling con

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

2015-08-13 Thread Scott Duplichan
Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] wrote: ]Sent: Thursday, August 13, 2015 01:40 AM ]To: David Woodhouse ]Cc: Justen, Jordan L ; edk2-devel@lists.01.org ; Liu, Yingke D ]; Gao, Liming ]Subject: Re: [edk2] [RFC PATCH 0/4] unify GCC command line options ] ]On 13 August 2015 at 08:

Re: [edk2] [Patch] MdeModulePkg: Fix issue about Ip4Dxe implementation for DHCP DORA process

2015-08-13 Thread El-Haj-Mahmoud, Samer
Thanks Jiaxin. Are you going to submit a patch to fix the ifconfig issue caused by this change? -Original Message- From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Wednesday, August 12, 2015 8:54 PM To: El-Haj-Mahmoud, Samer ; Ye, Ting ; edk2-devel@lists.01.org Cc: Fu, Siyuan ; Sub

[edk2] [PATCH] ArmPkg: Bug fix for UncachedMemoryAllocationLib

2015-08-13 Thread Heyi Guo
NewNode is the node we found, while Node is the last node in the list. Also update mFreedBufferSize. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo Cc: Leif Lindholm Cc: Ard Biesheuvel --- .../UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c | 7 +

[edk2] [Patch] NetworkPkg: Fix hang issue after system reconnected when IPSec has set up

2015-08-13 Thread Jiaxin Wu
IpSecStop() is incompetent to send out the delete information since the underlying IP child has been destroyed. Delete all established IKE SAs and related Child SAs directly. Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- NetworkPkg/IpSecDxe/Ik

Re: [edk2] [patch] MdeModulePkg:Fix the issue that Commit changes and Exit fail when add driver option

2015-08-13 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Thursday, August 13, 2015 4:40 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [edk2] [patch] MdeModulePkg:Fix the issue that Commit changes a

Re: [edk2] [patch] MdeModulePkg:Fix the issue that Commit changes and Exit fail when add driver option

2015-08-13 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Thursday, August 13, 2015 4:40 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [edk2] [patch] MdeModulePkg:Fix the issue that Commit changes an

[edk2] [patch] MdeModulePkg:Fix the issue that Commit changes and Exit fail when add driver option

2015-08-13 Thread Dandan Bi
When add driver option using file,input the description and then commit changes and exit, it doesn't work.it caused by the commit 18216.When variable DriverOrderList in Variable.c is NULL,it also need do the follow path,shouldn't return.Now change the code. Contributed-under: TianoCore Contribut

Re: [edk2] Library refinement: OptionRomPkg/BltLib

2015-08-13 Thread Jordan Justen
Did you get a chance to review the commit message on caebd915 / r11520? On 2015-08-09 20:09:54, Ni, Ruiyu wrote: >Jordan and Laszlo, > >I reviewed the OptionRomPkg/BltLib again and would like to discuss with >you about the potential API refinement. > >I attached two versions of t

Re: [edk2] Status of porting acpidump to edk2 ?

2015-08-13 Thread Moore, Robert
A couple of things jumped out at me: > It has only > two lines of changes to the ACPICA code, and the intent was to get those > two lines rolled into ACPICA if possible. We certainly would like to see these ASAP. > I propose that this get pulled > into AppPkg since the code is modelled after th