Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Correct CPUID leaf used to detect SMM mode

Reviewed-by: Jeff Fan -Original Message- From: Kinney, Michael D Sent: Wednesday, December 23, 2015 7:51 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Correct CPUID leaf used to detect SMM mode Use Bit 29 of CPUID leaf

Re: [edk2] [PATCH v3 0/7] Add Ipmi related libraries.

Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Wednesday, December 23, 2015 12:03 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v3 0/7] Add Ipmi related libraries. Update Ipmi2.0 definitions header file and MdeModulePkg.dsc

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Fix failure when PcdCpuSmmDebug is TRUE

Reviewed-by: Jeff Fan -Original Message- From: Kinney, Michael D Sent: Wednesday, December 23, 2015 7:51 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Fix failure when PcdCpuSmmDebug is TRUE If PcdCpuSmmDebug is set to

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

Aaron, This patch just follow UEFI spec 2.5 chapter 31.2.11.1 description to enable this feature. I think in OS environment, OS utility can just partial change the configuration data. We can't export config access protocol to OS environment. Thanks, Eric From: aaron@congatec.com

[edk2] [PATCH v4 2/3] MdeModulePkg: Add IpmiLib and Ppi/Protocol into MdeModulePkg.dec.

Add IpmiLib and Ppi/Protocol into MdeModulePkg.dec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao --- MdeModulePkg/MdeModulePkg.dec | 101 +++--- 1 file changed,

Re: [edk2] [patch] MdeModulePkg:Make HII configuration settings available to OS runtime

I have a question about this. Making the Hii Configuration data available to the OS at run time only exports the data from the Hii database. It does not make the Hii Configuration Access protocols (or their callback functions) available to the OS? So if a 3rd party OpRom was making using

Re: [edk2] [PATCH v3 2/7] MdeModulePkg: Add IpmiLib and Ppi/Protocol header file.

Daocheng Bu, This patch appears to contain both additions to the DEC file and white space clean up of the DEC file. Can you please split these into separate patches? Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Daocheng

[edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Correct CPUID leaf used to detect SMM mode

Use Bit 29 of CPUID leaf CPUID_EXTENDED_CPU_SIG (0x8001) to determine the SMM save state mode. The previous version of this code used CPUID leaf CPUID_VERSION_INFO (0x0001). Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael

[edk2] [PATCH v4 0/3] Add Ipmi related libraries.

Update Ipmi2.0 MdeModulePkg.dec as 1 patch. Update local variable name to IpmiPpi. Daocheng Bu (3): MdeModulePkg: Add IpmiLib and Ppi/Protocol header file. MdeModulePkg: Add IpmiLib and Ppi/Protocol into MdeModulePkg.dec. MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Instance.

[edk2] [PATCH v4 1/3] MdeModulePkg: Add IpmiLib and Ppi/Protocol header file.

Add IpmiLib and Ppi/Protocol header file. Update dec file for new IpmiLib and Ppi/Protocol header file. In V4,Split header file and Dec file in new patch. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao

[edk2] how to develop an UEFI runtime driver

Dear Sir/Madam, My name is Owen and I am a senior student in college. Recently I was asked to develop a simple runtime driver but have no idea about it. I’ve had some basic knowledge about UEFI and can write some simple applications. However I can not find much information about runtime

Re: [edk2] how to develop an UEFI runtime driver

A good place to start is the UEFI Driver Writer's Guide https://github.com/tianocore/tianocore.github.io/wiki/UEFI-Driver-Writer's-Guide Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > LiHongcheng > Sent: Tuesday, December 22, 2015

Re: [edk2] [PATCH v2 3/4] ShellPkg: Fix memory leak in ShellProtocol.

Shumin, You need to add "ShellInfoNode->Handle = NULL" after "EfiShellClose" otherwise "EfiShellFreeFileList" in line 2372 may hang on closing the file again. >Status = ShellSearchHandle(NextFilePatternStart, > UnicodeCollation, ShellInfoNode->Handle, FileList, ShellInfoNode,

[edk2] [PATCH v3 2/4] ShellPkg: Refine the code logic of 'command history'.

Add the PCD to PcdShellMaxHistoryCommandCount indicate the max count of history commands. Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Ruiyu Ni

[edk2] [Patch] Nt32Pkg/WinNtSimpleFileSystemDxe: Fix memory leak

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jiewen Yao --- Nt32Pkg/WinNtSimpleFileSystemDxe/WinNtSimpleFileSystem.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[edk2] [PATCH v4 1/3] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library instance.

Add PeiIpmiLibIpmiPpi Library Instance based on Ipmi Ppi. In V4, update local variable name to IpmiPpi. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao ---

[edk2] [PATCH v4 3/3] MdeModulePkg: White space clean up for MdeModulePkg.dec

White space clean up for MdeModulePkg.dec Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao --- MdeModulePkg/MdeModulePkg.dec | 90 +-- 1 file changed, 45

[edk2] [PATCH v4 2/3] MdeModulePkg: Add IpmiLib and Ppi/Protocol header file.

Add IpmiLib and Ppi/Protocol header file. Update dec file for new IpmiLib and Ppi/Protocol header file. In V4,split white space from V3. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao ---

Re: [edk2] [PATCH v4 0/3] Add Ipmi related libraries.

Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Wednesday, December 23, 2015 11:59 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v4 0/3] Add Ipmi related libraries. Daocheng Bu (3): MdeModulePkg: Add PeiIpmiLibIpmiPpi Library

[edk2] [PATCH v4 3/3] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Instance.

Add PeiIpmiLibIpmiPpi Library Instance based on Ipmi Ppi. In V4, update local variable name to IpmiPpi. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao ---

Re: [edk2] GenFds error to build SMM file in fdf

SMM driver FILE type is SMM per FDF spec. Please try it again. FILE DXE_SMM_DRIVER ==> FILE SMM Thanks Liming From: 王晓峰 [mailto:winggundu...@163.com] Sent: Wednesday, December 23, 2015 1:23 PM To: edk2-devel@lists.01.org; Gao, Liming Subject: [edk2] GenFds error to build SMM file in fdf Hi

[edk2] [PATCH v3 3/7] MdeModulePkg: Add BaseIpmiLib Null Library Instance.

Add BaseIpmiLib Null Library Instance for BMC-LESS platform. In V3, change return value from 0 to EFI_STATUS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao ---

[edk2] [PATCH v3 0/7] Add Ipmi related libraries.

Update Ipmi2.0 definitions header file and MdeModulePkg.dsc file for Ipmi libraries. Add Ipmi realted libraries to support generic Ipmi submit command. Also add Ppi/Protocol definitions that will be produced by Ipmi Peim and drivers. Daocheng Bu (7): MdePkg: Update Ipmi2.0 definitions header

Re: [edk2] [PATCH v2 2/7] MdeModulePkg: Add IpmiLib and Ppi/Protocol header file.

Daocheng: Please remove the first _ in _IPMI_PROTOCOL_GUID and _SMM_IPMI_PROTOCOL_GUID name. Thanks Liming -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 2/7] MdeModulePkg: Add IpmiLib and

Re: [edk2] [PATCH v2 3/7] MdeModulePkg: Add BaseIpmiLib Null Library Instance.

The return value should be EFI_STATUS, not 0. Please update. -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 3/7] MdeModulePkg: Add BaseIpmiLib Null Library Instance. Add BaseIpmiLib Null

Re: [edk2] [PATCH v2 4/7] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Instance.

mIpmiPpi should be local variable. The static global variable can't be updated in XIP module. Thanks Liming -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 4/7] MdeModulePkg: Add

Re: [edk2] [PATCH v2 5/7] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Instance.

Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 5/7] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Instance. Add DxeIpmiLibIpmiProtocol

Re: [edk2] [PATCH v2 1/7] MdePkg: Update Ipmi2.0 definitions header file.

Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 1/7] MdePkg: Update Ipmi2.0 definitions header file. Update Ipmi2.0 definitions header files for

Re: [edk2] [PATCH v2 7/7] MdeModulePkg: Update MdeModulePkg.dsc file for IpmiLib.

Reviewed-by: Liming Gao -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 7/7] MdeModulePkg: Update MdeModulePkg.dsc file for IpmiLib. Update MdeModulePkg.dsc file to

Re: [edk2] [PATCH v2 6/7] MdeModulePkg: Add SmmIpmiLibSmmIpmiProtocol Library Instance.

Minor comments: 1) UefiBootServicesTableLib is not used. It can be removed. 2) Smm driver should include instead of -Original Message- From: Bu, Daocheng Sent: Tuesday, December 22, 2015 5:27 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v2 6/7] MdeModulePkg: Add

[edk2] [PATCH v2 1/7] MdePkg: Update Ipmi2.0 definitions header file.

Update Ipmi2.0 definitions header files for data structure name suffix for request/response data and completion code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao ---

[edk2] [PATCH v2 7/7] MdeModulePkg: Update MdeModulePkg.dsc file for IpmiLib.

Update MdeModulePkg.dsc file to include Ipmi Libraries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao --- MdeModulePkg/MdeModulePkg.dsc | 4 1 file changed, 4 insertions(+) diff --git

[edk2] [PATCH v2 0/7] Add Ipmi related libraries.

Update Ipmi2.0 definitions header file and MdeModulePkg.dsc file for Ipmi libraries. Add Ipmi realted libraries to support generic Ipmi submit command. Also add Ppi/Protocol definitions that will be produced by Ipmi Peim and drivers. Daocheng Bu (7): MdePkg: Update Ipmi2.0 definitions header

[edk2] [PATCH v2 4/7] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Instance.

Add PeiIpmiLibIpmiPpi Library Instance based on Ipmi Ppi. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao --- .../Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.c | 80 ++

[edk2] [PATCH v2 6/7] MdeModulePkg: Add SmmIpmiLibSmmIpmiProtocol Library Instance.

Add SmmIpmiLibSmmIpmiProtocol Library Instance based on Ipmi smm protocol in SMM mode. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao --- .../SmmIpmiLibSmmIpmiProtocol.c| 82

[edk2] [PATCH v2 2/7] MdeModulePkg: Add IpmiLib and Ppi/Protocol header file.

Add IpmiLib and Ppi/Protocol header file. Update dec file for new IpmiLib and Ppi/Protocol header file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao --- MdeModulePkg/Include/Library/IpmiLib.h

[edk2] [PATCH v2 5/7] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Instance.

Add DxeIpmiLibIpmiProtocol Library Instance based on Ipmi Protocol in DXE phase. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao --- .../DxeIpmiLibIpmiProtocol.c | 80

[edk2] [PATCH v2 3/7] MdeModulePkg: Add BaseIpmiLib Null Library Instance.

Add BaseIpmiLib Null Library Instance for BMC-LESS platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao --- .../Library/BaseIpmiLibNull/BaseIpmiLibNull.c | 50 ++

[edk2] [PATCH v3 2/7] MdeModulePkg: Add IpmiLib and Ppi/Protocol header file.

Add IpmiLib and Ppi/Protocol header file. Update dec file for new IpmiLib and Ppi/Protocol header file. In V3,removed the first '_' in GUID name. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao ---

[edk2] [PATCH v3 5/7] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Instance.

Add DxeIpmiLibIpmiProtocol Library Instance based on Ipmi Protocol in DXE phase. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao --- .../DxeIpmiLibIpmiProtocol.c | 80

[edk2] [PATCH v3 7/7] MdeModulePkg: Update MdeModulePkg.dsc file for IpmiLib.

Update MdeModulePkg.dsc file to include Ipmi Libraries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao --- MdeModulePkg/MdeModulePkg.dsc | 4 1 file changed, 4 insertions(+) diff --git

[edk2] [PATCH v3 6/7] MdeModulePkg: Add SmmIpmiLibSmmIpmiProtocol Library Instance.

Add SmmIpmiLibSmmIpmiProtocol Library Instance based on Ipmi smm protocol in SMM mode. In V3, use right header file for SMM driver and remove unused UefiBootServicesTableLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming

[edk2] [PATCH v3 4/7] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Instance.

Add PeiIpmiLibIpmiPpi Library Instance based on Ipmi Ppi. In V3, change mIpmiPpi from static global variable to local variable. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Cc: Liming Gao ---

Re: [edk2] [PATCH] MdePkg : Update SPCR to use ACPI5 definition

Samer, Thanks. I agree that SPCR spec just uses the term Generic Address Structure without a version. Updating to a newer version of the struct is ok as long as the newer version is backwards compatible with the previous version. Reviewed-by: Michael Kinney Mike

Re: [edk2] [PATCH] MdePkg : Update SPCR to use ACPI5 definition

Committed r19456 Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, > Michael D > Sent: Tuesday, December 22, 2015 8:30 AM > To: El-Haj-Mahmoud, Samer ; > edk2-devel@lists.01.org > Cc: Shifflett,

Re: [edk2] [PATCH] BaseTools: Fix Makefile to correctly break during a build failure

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Hauch, Larry Sent: Wednesday, December 23, 2015 2:16 AM To: edk2-devel@lists.01.org Cc: Hauch, Larry; Zhu, Yonghong Subject: [PATCH] BaseTools: Fix Makefile to correctly break during

[edk2] GenFds error to build SMM file in fdf

Hi All, I tried to build a FFS in fdf with the following statement FILE DXE_SMM_DRIVER = guid{ SECTION SMM_DEPEX = 1.depex SECTION PE32 =1.efi SECTION UI = "1" } and build tool return the following error ,anyone knows how to solve it? Is it a build tool bug? GenFds... : error

[edk2] [PATCH] BaseTools: Fix Makefile to correctly break during a build failure

Updated the Makefile so that nmake will correctly fail if the cxfreeze command fails to complete successfully. Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Larry Hauch --- BaseTools/Source/Python/Makefile

[edk2] [PATCH v5 2/8] MdeModulePkg: Add IpmiLib and Ppi/Protocol header file.

Add IpmiLib and Ppi/Protocol header file. Update dec file for new IpmiLib and Ppi/Protocol header file. In V5,change for coding style. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Reviewed-by: Liming Gao ---

[edk2] [PATCH v5 1/8] MdePkg: Update Ipmi2.0 definitions header file.

Update Ipmi2.0 definitions header files for data structure name suffix for request/response data and completion code. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Reviewed-by: Liming Gao ---

[edk2] [PATCH v5 5/8] MdeModulePkg: Add PeiIpmiLibIpmiPpi Library Instance.

Add PeiIpmiLibIpmiPpi Library Instance based on Ipmi Ppi. In V5, change for code style. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Reviewed-by: Liming Gao --- .../Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.c

[edk2] [PATCH v5 4/8] MdeModulePkg: Add BaseIpmiLib Null Library Instance.

Add BaseIpmiLib Null Library Instance for BMC-LESS platform. In V5, change for coding style. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Reviewed-by: Liming Gao ---

[edk2] [PATCH v5 0/8] Add Ipmi related libraries.

Update Ipmi2.0 definitions header file and MdeModulePkg.dsc file for Ipmi libraries. Add Ipmi realted libraries to support generic Ipmi submit command. Also add Ppi/Protocol definitions that will be produced by Ipmi Peim and drivers. In V5, change for coding style. Daocheng Bu (8): MdePkg:

[edk2] [PATCH v5 6/8] MdeModulePkg: Add DxeIpmiLibIpmiProtocol Library Instance.

Add DxeIpmiLibIpmiProtocol Library Instance based on Ipmi Protocol in DXE phase. In V5,change for coding style. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Reviewed-by: Liming Gao ---

[edk2] [PATCH] ShellPkg: Free memory in 'BufferToFreeList' before return from RunShellCommand.

Free the buffer node allocated by command code in 'BufferToFreeList' to avoid memory leak. Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin ---

Re: [edk2] [PATCH] ShellPkg: Free memory in 'BufferToFreeList' before return from RunShellCommand.

Reviewed-by: Ruiyu Ni -Original Message- From: Qiu, Shumin Sent: Wednesday, December 23, 2015 3:36 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin ; Carsey, Jaben ; Ni, Ruiyu Subject: [PATCH]

[edk2] [PATCH v5 3/8] MdeModulePkg: White space clean up for MdeModulePkg.dec

White space clean up for MdeModulePkg.dec Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Reviewed-by: Liming Gao --- MdeModulePkg/MdeModulePkg.dec | 90 +-- 1 file changed,

[edk2] [PATCH v5 8/8] MdeModulePkg: Update MdeModulePkg.dsc file for IpmiLib.

Update MdeModulePkg.dsc file to include Ipmi Libraries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu Reviewed-by: Liming Gao --- MdeModulePkg/MdeModulePkg.dsc | 4 1 file changed, 4 insertions(+) diff

Re: [edk2] Simple Textoutput is not working

Hi, I just want to give a solution if anyone has similar problems. The EDKII build system does not work for visual studio 2013 but there is a git project called VisualUEFI. It uses the EDKII as well but the guy of this project did an awesome job implementing a new build system. Kind regards and