Re: [edk2] ShellPkg: Difference in behavior of 'dh' between old shell and new

2017-04-19 Thread Carsey, Jaben
That would be welcome; I don't know how it was missed. A caveat is that the shell should use UEFI protocols only. No PI protocols can be required (optional is ok). Only the specific output controlled by "-sfo" is severely constrained by the spec. > -Original Message- > From: Jeff

[edk2] EDK toolkit ramdisk driver

2017-04-19 Thread Leif Lindholm
Hi all, More spring cleaning. Two separate vendors, with quite different platforms, have submitted ports to OpenPlatformPkg making use of the "ramdisk" driver from https://svn.code.sf.net/p/efi-toolkit/code/trunk/efi-toolkit/protocols/ramdisk/ As part of moving their platforms to edk2-platforms

[edk2] ShellPkg: Difference in behavior of 'dh' between old shell and new

2017-04-19 Thread Jeff Westfahl
I noticed a difference in behavior of 'dh' between the old shell and the new shell. With the old shell, 'dh -v' for a LoadedImage handle shows the following: Handle D3 (3A537F98) Image (3A532818) File:MicrocodeUpdate ParentHandle..: 3A64F118 SystemTable...: 3D2A8F18

Re: [edk2] Testing SMM with QEMU, KVM and libvirt

2017-04-19 Thread Blibbet
On 02/21/2017 02:18 AM, Laszlo Ersek wrote: > On 02/21/17 10:22, Shi, Steven wrote: >> Hi Laszlo, >> I wonder if you could offer a Ubuntu version wiki for the >> Testing-SMM-with-QEMU,-KVM-and-libvirt? > > Sorry, I can't do that.[...] FYI, Alex Floyd recently wrote a shell script to codify

Re: [edk2] EDK toolkit ramdisk driver

2017-04-19 Thread Richardson, Brian
The EFI Toolkit is long since dead, and based on the original EDK (also dead), so we definitely need to get that code out of EDK II projects. I'd recommend looking at RamDiskDxe under MdeModulePkg as an alternative ...

[edk2] [edk2-BuildSpecification PATCH 2/3] Make room for new mixed PCD report section

2017-04-19 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=485 The build tools currently require a PCD to use the same access method from all modules. This update still requires modules built from sources to use the same access method, but binary modules are allowed to use alternate access methods. Cc:

[edk2] [edk2-BuildSpecification PATCH 1/3] Add rules for for mixed PCD access

2017-04-19 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=485 The build tools currently require a PCD to use the same access method from all modules. This update still requires modules built from sources to use the same access method, but binary modules are allowed to use alternate access methods. Cc:

[edk2] [edk2-BuildSpecification PATCH 3/3] Add report section for mixed PCD access

2017-04-19 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=485 The build tools currently require a PCD to use the same access method from all modules. This update still requires modules built from sources to use the same access method, but binary modules are allowed to use alternate access methods. Cc:

[edk2] [edk2-BuildSpecification PATCH 0/3] Add support for mixed PCD access

2017-04-19 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=485 GitHub word diff view of the pathes in this series * [1/3] https://github.com/mdkinney/edk2-BuildSpecification/commit/e972f4ae0135704243d04a6da2a177d9990d2340?w=1 * [2/3]

[edk2] [edk2-BuildSpecification PATCH] Add support for HII Image Packs

2017-04-19 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=476 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney ---

[edk2] [edk2-IdfSpecification] Create repository for EDK II Image Definition IDF File Format Specification

2017-04-19 Thread Kinney, Michael D
A new specification is required for the .idf source file format that is used to generate HII Image Packages. https://bugzilla.tianocore.org/show_bug.cgi?id=477 The following are links to a review draft of this new specification in my personal GitHub/Gitbook repositories. Once this review draft

Re: [edk2] The network interface configuration is taking some delay to update in DHCP case

2017-04-19 Thread Wu, Jiaxin
Hi Karunakar, Extractconfig is used to request the current configuration and update it to the IFR data. It reflects the current configuration status. we can't assume the default interface must be configured. Thanks, Jiaxin > -Original Message- > From: Karunakar P

[edk2] [edk2-BuildSpecification PATCH] Add support for HII Image Packs

2017-04-19 Thread Michael Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=476 GitHub word diff view of the pathes in this series * [1/1] https://github.com/mdkinney/edk2-BuildSpecification/commit/4c529d1259c90ef51eea3f5185cfbb1c0574711d?w=1 Cc: Liming Gao Cc: Yonghong Zhu

Re: [edk2] [PATCH] MdePkg/IndustryStandard: add definitions for ACPI 6.0 IORT

2017-04-19 Thread Ard Biesheuvel
On 19 April 2017 at 00:51, Kinney, Michael D wrote: > Ard, > > I found IORT signature defined in Acpi60.h and Acpi61.h, so no > changes required there. > > /// > /// "IORT" I/O Remapping Table > /// > #define EFI_ACPI_6_1_IO_REMAPPING_TABLE_SIGNATURE

Re: [edk2] [edk2-BuildSpecification PATCH] Add NMAKE response file for long command lines

2017-04-19 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Wednesday, April 19, 2017 11:40 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W

Re: [edk2] [edk2-FdfSpecification PATCH] Add FV/FD statement support to

2017-04-19 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Wednesday, April 19, 2017 12:00 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W

Re: [edk2] [RFT PATCH] EmbeddedPkg/AndroidFastbootApp: remove dependency on deprecated BdsLib

2017-04-19 Thread Ard Biesheuvel
On 18 April 2017 at 20:21, Leif Lindholm wrote: > On Tue, Apr 18, 2017 at 07:08:57PM +0100, Ard Biesheuvel wrote: >> On 10 April 2017 at 17:55, Ard Biesheuvel wrote: >> > One of the last remaining modules with a dependency on the deprecated >>

Re: [edk2] [PATCH] MdeModulePkg PiSmmCore: Enhance SMM FreePool to catch buffer overflow

2017-04-19 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Wednesday, April 19, 2017 2:07 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; Wu, > Hao > Subject: [PATCH] MdeModulePkg

Re: [edk2] [PATCH] EmbeddedPkg: import Lan91x Ethernet controller driver

2017-04-19 Thread Ard Biesheuvel
On 19 April 2017 at 12:49, Leif Lindholm wrote: > OpenPlatformPkg (https://git.linaro.org/uefi/OpenPlatformPkg.git) holds a > driver for the SMSC LAN91x, used (among other places) in several ARM Ltd. > software system models. > > Import it to EDK2 EmbeddedPkg in

Re: [edk2] [PATCH] EmbeddedPkg: import Lan91x Ethernet controller driver

2017-04-19 Thread Leif Lindholm
On Wed, Apr 19, 2017 at 12:54:37PM +0100, Ard Biesheuvel wrote: > On 19 April 2017 at 12:49, Leif Lindholm wrote: > > OpenPlatformPkg (https://git.linaro.org/uefi/OpenPlatformPkg.git) holds a > > driver for the SMSC LAN91x, used (among other places) in several ARM Ltd. >

[edk2] [Patch 3/4] BaseTools: Rsa2048Sha256Sign Tool to support OPENSSL_PATH has space

2017-04-19 Thread Yonghong Zhu
Update Rsa2048Sha256Sign Tool to support the case that OPENSSL_PATH has space characters. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

[edk2] [Patch 1/4] BaseTools/VolInfo: Update OPENSSL_PATH to support space characters

2017-04-19 Thread Yonghong Zhu
Update OPENSSL_PATH handling to support space characters in the Path. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/C/VolInfo/VolInfo.c | 13 + 1 file changed, 9

[edk2] [Patch 4/4] BaseTools: Rsa2048Sha256GenerateKeys to support OPENSSL_PATH has space

2017-04-19 Thread Yonghong Zhu
Update Rsa2048Sha256GenerateKeys Tool to support the case that OPENSSL_PATH has space characters. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

[edk2] [Patch 0/4] BaseTools: support OPENSSL_PATH has space character

2017-04-19 Thread Yonghong Zhu
Update related Tools to support OPENSSL_PATH has space characters. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu Yonghong Zhu (4): BaseTools/VolInfo: Update OPENSSL_PATH to support space

[edk2] [Patch 2/4] BaseTools: Pkcs7Sign Tool to support OPENSSL_PATH has space

2017-04-19 Thread Yonghong Zhu
Update Pkcs7Sign Tool to support the case that OPENSSL_PATH has space characters. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Pkcs7Sign/Pkcs7Sign.py | 2 ++ 1 file

Re: [edk2] [PATCH] MdeModulePkg PiSmmCore: Enhance SMM FreePool to catch buffer overflow

2017-04-19 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, > Jiewen > Sent: Wednesday, April 19, 2017 3:27 PM > To: Zeng, Star; edk2-devel@lists.01.org > Cc: Wu, Hao > Subject: Re:

[edk2] [PATCH] EmbeddedPkg: import Lan91x Ethernet controller driver

2017-04-19 Thread Leif Lindholm
OpenPlatformPkg (https://git.linaro.org/uefi/OpenPlatformPkg.git) holds a driver for the SMSC LAN91x, used (among other places) in several ARM Ltd. software system models. Import it to EDK2 EmbeddedPkg in preparation for migrating those model platforms to edk2-platforms. On the way, update the

Re: [edk2] [PATCH 0/2] MdeModulePkg/Ufs: Wait fDeviceInit be cleared by devices during init

2017-04-19 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Wu, Hao A Sent: Wednesday, March 22, 2017 9:28 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Tian, Feng Subject: [PATCH 0/2] MdeModulePkg/Ufs: Wait fDeviceInit be cleared by

Re: [edk2] [edk2-BuildSpecification PATCH] Add support for HII Image Packs

2017-04-19 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Thursday, April 20, 2017 5:24 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W

[edk2] [PATCH] ShellPkg/comp: Fix file tag name.

2017-04-19 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen A Chen Reviewed-by: Ruiyu Ni --- ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[edk2] [PATCH] ShellPkg/pci: Fix VS2012 build failure

2017-04-19 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Hao A Wu Cc: Dandan Bi --- ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH] ShellPkg/pci: Fix VS2012 build failure

2017-04-19 Thread Wu, Hao A
Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, April 20, 2017 10:51 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Bi, Dandan > Subject: [PATCH] ShellPkg/pci: Fix VS2012 build failure > > Contributed-under:

Re: [edk2] [edk2-BuildSpecification PATCH 3/3] Add report section for mixed PCD access

2017-04-19 Thread Zhu, Yonghong
Hi Mike, Is this section 13.5 but not 13.6 ? others are good to me. Reviewed-by: Yonghong Zhu ## 13.6 Mixed PCD Section Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Thursday, April 20, 2017 4:37 AM To: edk2-devel@lists.01.org

[edk2] [PATCH] MdeModulePKg/BDS: Build meaningful description for Wi-Fi boot option

2017-04-19 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Fan Wang Cc: Jiaxin Wu --- .../Library/UefiBootManagerLib/BmBootDescription.c | 28 ++ 1 file changed, 23 insertions(+), 5

Re: [edk2] [PATCH v2] MdePkg/IndustryStandard: add definitions for ACPI 6.0 IORT

2017-04-19 Thread Yao, Jiewen
Hi Ard Is there any special reason that we use INT32 instead of UINT32 in EFI_ACPI_6_0_IO_REMAPPING_TABLE? + INT32 NumNodes; + INT32 NodeOffset; + INT32 Reserved; I am just curious. Thank

[edk2] [PATCH v2] MdePkg/IndustryStandard: add definitions for ACPI 6.0 IORT

2017-04-19 Thread Ard Biesheuvel
This adds #defines and struct typedefs for the various node types in the ACPI 6.0 IO Remapping Table (IORT). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- v2: added PDF link to file header updated comment style to align

Re: [edk2] [PATCH] OptionRomPkg: add firmware loader driver for Renesas PD72020x

2017-04-19 Thread Ard Biesheuvel
On 19 April 2017 at 03:51, Ni, Ruiyu wrote: > Ard, > My understanding is the new driver downloads firmware into the XHCI > controller in Supported(). > The generic XHCI driver can be started successfully only after the firmware > is downloaded. > > But what if the XHCI

Re: [edk2] [PATCH v2] MdePkg/IndustryStandard: add definitions for ACPI 6.0 IORT

2017-04-19 Thread Ard Biesheuvel
On 19 April 2017 at 08:24, Yao, Jiewen wrote: > Hi Ard > Is there any special reason that we use INT32 instead of UINT32 in > EFI_ACPI_6_0_IO_REMAPPING_TABLE? > > + INT32 NumNodes; > + INT32 NodeOffset; >

[edk2] [PATCH] MdeModulePkg PiSmmCore: Enhance SMM FreePool to catch buffer overflow

2017-04-19 Thread Star Zeng
This solution is equivalent to DXE core. AllocatePool() allocates POOL_TAIL after the buffer. This POOL_TAIL is checked at FreePool(). If the there is buffer overflow, the issue can be caught at FreePool(). This patch could also handle the eight-byte aligned allocation requirement. The

[edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Avoid buggy USB short-form expanding

2017-04-19 Thread Ruiyu Ni
When a load option points to a physical UsbIo controller, whose device path contains UsbClass or UsbWwid node, old logic unconditionally treats it as a short-form device path and expands it. But the expanding gets the exactly same device path, and the device path is passed to

Re: [edk2] The network interface configuration is taking some delay to update in DHCP case

2017-04-19 Thread Wu, Jiaxin
Hi Karunakar, May I ask why you want to signal dhcp event before ExtractConfig? In my opinion, it doesn't matter to call ExtractConfig even dhcp is not finished. You know the dhcp MAY be failure, then event will never be called. Thanks, Jiaxin > -Original Message- > From: Karunakar P

Re: [edk2] [PATCH v2] MdePkg/IndustryStandard: add definitions for ACPI 6.0 IORT

2017-04-19 Thread Yao, Jiewen
Thank you. That makes more sense to me. :) Reviewed-by: jiewen@intel.com Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Wednesday, April 19, 2017 3:46 PM To: Yao, Jiewen Cc: Kinney, Michael D

Re: [edk2] The network interface configuration is taking some delay to update in DHCP case

2017-04-19 Thread Karunakar P
Hi Jiaxin, In the case of Ip4FormExtractConfig() we are using 'IpSb->DefaultInterface->Configured' ,which is updated in Ip4Config2OnDhcp4Complete(). So if we call Extractconfig before this event getting Configured value as 0 and in setup Configured is disabled which is false. Thanks,