Re: [edk2] Library refinement: OptionRomPkg/BltLib

2015-08-09 Thread Ni, Ruiyu
Just drew a picture to show the current library APIs, V1 and V2 APIs, to help you understand my point. [cid:image001.png@01D0D37C.E78C2030] -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Monday, August 10, 2015 11:10 AM To: Jus

[edk2] error when use ovmf

2015-08-09 Thread ????
when i used ovmf.fd in qemu manager, then occurcs this tips: Boot Failed. EFI DVD/CDROM Boot Failed. EFI Floopy i don't know what does this mean? ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH v2] BaseTools/GenFds: Fix 'NoneType' object is not iterable error.

2015-08-09 Thread Qiu Shumin
When adding section VERSION in FDF file, for example: FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { SECTION RAW = MdeModulePkg/Logo/Logo.bmp SECTION UI = "Logo" SECTION VERSION = "0001" } GenFds will report the following error: Traceback (most recent ca

Re: [edk2] [RFC PATCH 2/4] BaseTools GCC: unify warning flags for all GCC versions

2015-08-09 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Friday, August 7, 2015 11:05 PM To: edk2-devel@lists.01.org; Justen, Jordan L; Liu, Yingke D Cc: Ard Biesheuvel Subject: [edk2] [RFC PATCH 2/4] BaseTools

Re: [edk2] [PATCH v3 6/7] BaseTools/GenFw: allow AArch64 tiny and small code model relocations

2015-08-09 Thread Gao, Liming
Ard: I am not familiar with ARM arch. Those changes are only for AArch64. I have no comments for them. You can add review-by me. Thanks Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Friday, August 7, 2015 10:23 PM To: edk2-devel@lists.01.org;

Re: [edk2] [PATCH] BaseTools/GenFds: Fix 'NoneType' object is not iterable error.

2015-08-09 Thread Gao, Liming
Shumin: Please highlight what problem resolved by this fix. Thanks Liming -Original Message- From: Qiu, Shumin Sent: Monday, August 10, 2015 1:43 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Gao, Liming; winggundu...@163.com Subject: [PATCH] BaseTools/GenFds: Fix 'NoneType' object i

[edk2] [PATCH] BaseTools/GenFds: Fix 'NoneType' object is not iterable error.

2015-08-09 Thread Qiu Shumin
In GenFdsGlobalVariable.py line 401 'list' requires a iteralbe object as parameter while the 'Input' is None. Cc: Liming Gao Cc: winggundu...@163.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Yingke Liu --- BaseTools/Source/Python/GenFds/Ve

[edk2] Library refinement: OptionRomPkg/BltLib

2015-08-09 Thread Ni, Ruiyu
Jordan and Laszlo, I reviewed the OptionRomPkg/BltLib again and would like to discuss with you about the potential API refinement. I attached two versions of the refined BltLib.h. The common part of the two versions is: 1. BltLibGetSizes() is removed. Because the size information is actual

Re: [edk2] [patch] MdeModulePkg: HttpLib BodyParseComplete Event should indicate the end of message body

2015-08-09 Thread Wu, Jiaxin
The patch looks good. Reviewed-by: Jiaxin Wu -Original Message- From: Zhang, Lubo Sent: Monday, August 10, 2015 9:20 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Wu, Jiaxin Subject: [patch] MdeModulePkg: HttpLib BodyParseComplete Event should indicate the end of message body In HttpLi

[edk2] [patch] MdeModulePkg: HttpLib BodyParseComplete Event should indicate the end of message body

2015-08-09 Thread Zhang Lubo
In HttpLib, the Event BodyParseComplete should return to the callback function when the whole message body has been parsed Cc: Ye Ting CC: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 44 ++

[edk2] [Patch] NetworkPkg: Stop and release DHCP4 child after boot info is ready

2015-08-09 Thread Jiaxin Wu
HttpBootDxe need to stop and release the DHCP4 child when it's not used so the NBP could create new DHCP4 child and use it. Cc: Ye Ting Cc: Zhang Lubo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- NetworkPkg/HttpBootDxe/HttpBootImpl.c | 12 1

Re: [edk2] Core TPL and interrupt state

2015-08-09 Thread Benjamin Herrenschmidt
On Sun, 2015-08-09 at 15:54 -0500, Scott Duplichan wrote: > 6) TimerInterruptHandler calls RestoreTPL. RestoreTPL executes a loop for >"Dispatch any pending events". Interrupts are re-enabled if all pending >event have TPL < HIGH. CoreDispatchEventNotifies calls CoreAcquireEventLock >wh

Re: [edk2] Core TPL and interrupt state

2015-08-09 Thread Scott Duplichan
Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] wrote: ]Sent: Sunday, August 09, 2015 06:28 AM ]To: edk2-de...@ml01.01.org ]Subject: [edk2] Core TPL and interrupt state ] ]Hi ! ] ]Yet another somewhat newbie question, I apologize if I missed the right ]piece of doc... ] ]I found some kind

[edk2] Problem with CorebootPayloadPkg startup

2015-08-09 Thread Scott Duplichan
Hello, Starting with SVN revision 18146, CorebootPayload will no longer boot on my board. The reason is that the code rearrangement of rev 18146 (MdeModulePkg DxeCore: Move ProcessLibraryConstructorList) causes low memory to be cleared before a call to FindCbTag scans low memory. Prior to 18146, l

[edk2] Core TPL and interrupt state

2015-08-09 Thread Benjamin Herrenschmidt
Hi ! Yet another somewhat newbie question, I apologize if I missed the right piece of doc... I found some kind of disconnect between the core idea of TPL and the interrupt enable state of the processor. The core will enable or disable processor interrupts based on TPL state changes. However the