Re: [edk2] [Patch] UefiCpuPkg/CpuMpPei: Add missing point at function header

2015-12-06 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Monday, December 07, 2015 3:41 PM To: edk2-devel@lists.01.org Cc: Shuming Qiu Subject: [edk2] [Patch] UefiCpuPkg/CpuMpPei: Add missing point at function header

Re: [edk2] [Patch 0/3] Add MtrrSetMemoryAttributeInMtrrSettings()

2015-12-06 Thread Tian, Feng
Looks good to me Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Thursday, December 03, 2015 22:28 To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/3] Add MtrrSetMemoryAttributeInMtrrSettings() Add new A

[edk2] [Patch] UefiCpuPkg/CpuMpPei: Add missing point at function header

2015-12-06 Thread Jeff Fan
Cc: Shuming Qiu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/CpuMpPei/CpuMpPei.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.c b/UefiCpuPkg/CpuMpPei/CpuMpPei.c index ab1260d..2e6e761 100644

Re: [edk2] [Patch 0/8] Reduce hardware operations when program MTRR

2015-12-06 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Thursday, December 03, 2015 22:28 To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/8] Reduce hardware operations when program MTRR Try to avoid access hardw

[edk2] [PATCH] ArmPkg: update InvalidateInstructionCacheRange to flush only to PoU

2015-12-06 Thread Ard Biesheuvel
From: "Cohen, Eugene" This patch updates the ArmPkg variant of InvalidateInstructionCacheRange to flush the data cache only to the point of unification (PoU). This improves performance and also allows invalidation in scenarios where it would be inappropriate to flush to the point of coherency (li

Re: [edk2] [PATCH v2 03/20] ArmPlatformPkg: Convert all .uni files to utf-8

2015-12-06 Thread Ard Biesheuvel
On 4 December 2015 at 21:13, Jordan Justen wrote: > To convert these files I ran: > > $ python3 BaseTools/Scripts/ConvertUni.py ArmPlatformPkg > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- Acked-by: Ard

Re: [edk2] [PATCH v2 02/20] ArmPkg: Convert all .uni files to utf-8

2015-12-06 Thread Ard Biesheuvel
On 4 December 2015 at 21:13, Jordan Justen wrote: > To convert these files I ran: > > $ python3 BaseTools/Scripts/ConvertUni.py ArmPkg > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen I can't actually review thi

Re: [edk2] [PATCH v2 06/20] EmbeddedPkg: Convert all .uni files to utf-8

2015-12-06 Thread Ard Biesheuvel
On 4 December 2015 at 21:13, Jordan Justen wrote: > To convert these files I ran: > > $ python3 BaseTools/Scripts/ConvertUni.py EmbeddedPkg > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- Acked-by: Ard Bi

Re: [edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

2015-12-06 Thread Ard Biesheuvel
On 4 December 2015 at 19:09, Long, Qin wrote: > Sorry, I missed this patch. Yes, this looks good. > > Reviewed-by: Qin Long > Thanks Qin, Committed as SVN r19135 >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: Saturday, December 5, 2015 12:45 A

Re: [edk2] [Patch] UefiCpuPkg/MtrrLib: Add PCD PcdCpuNumberOfReservedVariableMtrrs

2015-12-06 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Fan, Jeff Sent: Thursday, December 03, 2015 22:28 To: edk2-devel@lists.01.org Cc: Scott Duplichan; Tian, Feng; Kinney, Michael D Subject: [Patch] UefiCpuPkg/MtrrLib: Add PCD PcdCpuNumberOfReservedVariableMtrrs Current MtrrLib reserves 2 va

Re: [edk2] [Patch] BaseTools: Enhance GenFv Tool to report error message

2015-12-06 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Wednesday, December 02, 2015 4:46 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] BaseTools: Enhance GenFv Tool to report error message When two vt

Re: [edk2] MdeModulePkg: DebugAssert enhancement

2015-12-06 Thread Gao, Liming
Reviewed-by: Liming Gao And, I have committed your serial patches into EDKII project at 19127~19128. Thanks Liming -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Saturday, December 05, 2015 4:21 AM To: Gao, Liming; Kinney, Michael D; edk2-devel@lis

Re: [edk2] InsertImageRecord and Section Alignment

2015-12-06 Thread Yao, Jiewen
Hi Mike I agree that we can change this from ERROR to WARNING, and only add 1 ERROR message. However, the \MdeModulePkg\Universal\PropertiesTableAttributesDxe module is optional module, because a platform may use its own module to set attributes for ACPINvs or reserved. How about we add error

[edk2] [PATCH V3 0/3] Enable Customized Secure Boot

2015-12-06 Thread Zhang, Chao B
Zhang, Chao B (3): SecurityPkg: Enable Customized Secure Boot feature SecurityPkg: AuthVariableLib: Customized SecureBoot Mode transition. Implement Customized SecureBoot Mode transition logic according to Mantis 1263, including AuditMode/DeployedMode/PK update management.

[edk2] [PATCH 1/3] SecurityPkg: Enable Customized Secure Boot feature

2015-12-06 Thread Zhang, Chao B
Enable Secure Boot feature defined in UEFI2.5 ECR1263. Add gEfiSecureBootModeGuid definition Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang Reviewed-by: Zeng Star Reviewed-by: Long Qin --- SecurityPkg/Include/Guid/AuthenticatedVariableFormat.h | 1 + Security

[edk2] [PATCH 2/3] SecurityPkg: AuthVariableLib: Customized SecureBoot Mode transition. Implement Customized SecureBoot Mode transition logic according to Mantis 1263, including AuditMode/DeployedMode

2015-12-06 Thread Zhang, Chao B
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang, Chao Reviewed-by: Zeng Star Reviewed-by: Long Qin --- SecurityPkg/Library/AuthVariableLib/AuthService.c | 1414 +--- .../Library/AuthVariableLib/AuthServiceInternal.h | 93 ++ .../Library/AuthVaria

[edk2] [PATCH 3/3] SecurityPkg: SecureBootConfigDxe: SecureBoot UI for Customized SecureBoot Mode Add SecureBoot UI support for Customized SecureBoot Mode transition according to Mantis 1263. User can

2015-12-06 Thread Zhang, Chao B
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang, Chao --- .../SecureBootConfigDxe/SecureBootConfig.vfr | 77 +++- .../SecureBootConfigDxe/SecureBootConfigImpl.c | 432 ++--- .../SecureBootConfigDxe/SecureBootConfigNvData.h | 11 +- .../Se

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

2015-12-06 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: Justen, Jordan L Sent: Saturday, December 05, 2015 4:14 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L; Carsey, Jaben; Qiu, Shumin Subject: [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8 To convert these files I ran: $ p

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-06 Thread Ard Biesheuvel
On 6 December 2015 at 09:03, Jordan Justen wrote: > On 2015-12-05 22:26:53, Ard Biesheuvel wrote: >> On 6 December 2015 at 01:44, Jordan Justen wrote: >> > On 2015-12-04 11:21:18, Ard Biesheuvel wrote: [...] >> >> Is this a clean rebuild? >> > >> > Yes, it was. >> > >> >> And did you regenerate y

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

2015-12-06 Thread Jordan Justen
On 2015-12-05 22:26:53, Ard Biesheuvel wrote: > On 6 December 2015 at 01:44, Jordan Justen wrote: > > On 2015-12-04 11:21:18, Ard Biesheuvel wrote: > >> On 4 December 2015 at 20:13, Jordan Justen > >> wrote: > >> > On 2015-12-04 08:43:29, Ard Biesheuvel wrote: > >> >> On 4 December 2015 at 17:27