[edk2] [MdePkg/Include/Protocol/PxeBaseCode.h]: Possible type mismatch with specification

2015-12-18 Thread David Van Arnem
Hi all, I wanted to check my understanding here before I submit a patch :-) According to page 1140 of the UEFI 2.5 spec, EFI_PXE_BASE_CODE_PROTOCOL.Mtftp()'s parameter "Filename" should be of type CHAR8 * (signed char *). However, it's implementation in MdePkg/Include/Protocol/PxeBaseCode.h

Re: [edk2] Simple Textoutput is not working

2015-12-18 Thread Carsey, Jaben
I do not have experience with that platform and I normally test with UEFI Shell (UEFI not EDK/EFI) and HelloWorld. I am sorry I cant be more helpful. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Daniel > Sent: Thursday, December

Re: [edk2] [PATCH 4/8] PcAtChipsetPkg: make preprocessor constants explicitly unsigned

2015-12-18 Thread Ard Biesheuvel
On 18 December 2015 at 10:45, Zeng, Star wrote: > On 2015/12/17 23:47, Ard Biesheuvel wrote: >> >> On 17 December 2015 at 15:10, Zeng, Star wrote: >>> >>> On 2015/12/17 18:01, Ard Biesheuvel wrote: C99 does not define left-shifting negative values, so make all [positive] prepr

Re: [edk2] [PATCH 2/8] MdeModulePkg: use VA_COPY for assigning va_list types

2015-12-18 Thread Ard Biesheuvel
On 18 December 2015 at 11:15, Zeng, Star wrote: > On 2015/12/17 23:05, Ard Biesheuvel wrote: >> >> On 17 December 2015 at 15:23, Zeng, Star wrote: >>> >>> On 2015/12/17 18:00, Ard Biesheuvel wrote: Clang does not allow straight assignment of va_list types, so use the correct V

[edk2] [Patch] Nt32Pkg: Fix VS2015 Build Failure

2015-12-18 Thread Liming Gao
VS2015 separates vcruntime.lib and ucrt.lib from msvcrt.lib. Per MSDN notes, If you link with the /nodefaultlib option, you will need to link several extra libraries when you link. For example, whereas you previously might have just linked msvcrt.lib in order to use the CRT DLL, you will now also n

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-12-18 Thread Zeng, Star
On 2015/11/11 10:41, Zeng, Star wrote: On 2015/11/10 23:31, Andrew Fish wrote: On Nov 10, 2015, at 7:04 AM, Andrew Fish wrote: On Nov 10, 2015, at 12:06 AM, Gao, Liming wrote: Andrew: The patch is missing. Liming, My sent mail shows these 3 patches attached? 0001-MdeModulePkg-PeiCore

Re: [edk2] MdeModulePkg: Fix Xcode 6.3.2/clang compilation issues.

2015-12-18 Thread Zeng, Star
On 2015/11/11 10:42, Zeng, Star wrote: On 2015/11/10 23:33, Andrew Fish wrote: On Nov 10, 2015, at 7:04 AM, Andrew Fish wrote: On Nov 10, 2015, at 12:06 AM, Gao, Liming mailto:liming@intel.com>> wrote: Andrew: The patch is missing. Liming, My sent mail shows these 3 patches attach

Re: [edk2] [PATCH 2/8] MdeModulePkg: use VA_COPY for assigning va_list types

2015-12-18 Thread Zeng, Star
On 2015/12/17 23:05, Ard Biesheuvel wrote: On 17 December 2015 at 15:23, Zeng, Star wrote: On 2015/12/17 18:00, Ard Biesheuvel wrote: Clang does not allow straight assignment of va_list types, so use the correct VA_COPY() instead. Contributed-under: TianoCore Contribution Agreement 1.0 Signe

Re: [edk2] [PATCH 4/8] PcAtChipsetPkg: make preprocessor constants explicitly unsigned

2015-12-18 Thread Zeng, Star
On 2015/12/17 23:47, Ard Biesheuvel wrote: On 17 December 2015 at 15:10, Zeng, Star wrote: On 2015/12/17 18:01, Ard Biesheuvel wrote: C99 does not define left-shifting negative values, so make all [positive] preprocessor constants unsigned explicitly, so they do not become negative values aft

Re: [edk2] [PATCH 3/8] PcAtChipsetPkg: remove unitialized variable warnings

2015-12-18 Thread Zeng, Star
On 2015/12/17 22:55, Ard Biesheuvel wrote: On 17 December 2015 at 14:59, Zeng, Star wrote: On 2015/12/17 18:00, Ard Biesheuvel wrote: LcrParity and LcrStop may end up being referenced without being initialized, so make sure they always have a value. Contributed-under: TianoCore Contribution

Re: [edk2] [Patch] MdeModulePkg: Add BaseIpmiLibNull Library Class.

2015-12-18 Thread Yao, Jiewen
Reviewed by: jiewen@intel.com -Original Message- From: Bu, Daocheng Sent: Friday, December 18, 2015 12:55 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [Patch] MdeModulePkg: Add BaseIpmiLibNull Library Class. Add BaseIpmiLibNull Library Class for BMC-Less platform. In V2,

Re: [edk2] [Patch] MdeModulePkg: Add IpmiLib header file.

2015-12-18 Thread Yao, Jiewen
Reviewed by: jiewen@intel.com -Original Message- From: Bu, Daocheng Sent: Friday, December 18, 2015 12:44 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [Patch] MdeModulePkg: Add IpmiLib header file. Add IpmiLib header file for ipmi command submit. In V2, change the buffer

Re: [edk2] [patch] NetworkPkg:Fix a bug the 2nd httpboot fail issue.

2015-12-18 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang Lubo Sent: Friday, December 18, 2015 10:32 AM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin Subject: [edk2] [patch] NetworkPkg:Fix a bug the 2nd http