Re: [edk2] [Patch] NetworkPkg: Fix suspicious dereference of pointer before NULL check

Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Thursday, December 24, 2015 2:17 PM To: edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan Subject: [edk2] [Patch] NetworkPkg: Fix suspicious dereference of pointe

Re: [edk2] [PATCH 0/8] add IA32 and X64 support to CLANG35 toolchain

Ard: We verify X64 arch. The build can pass, but the functionality doesn't work. I suggest to add comments for CLANG35 X64 tool chain to describe current statement. Then, we can first commit CLANG35 toolchain, next further investigate how to resolve the functionality issue. Thanks Liming ---

Re: [edk2] [PATCH 0/6] AARCH64 code model and toolchain updates

Reviews this patch serials. Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Thursday, December 24, 2015 9:03 PM To: edk2-devel@lists.01.org; leif.lindh...@linaro.org; ler...@redhat.com; Gao, Liming;

Re: [edk2] [PATCH 8/8] SecurityPkg Tcg2Pei: Fix a typo in function description

Reviewed by: jiewen@intel.com -Original Message- From: Wu, Hao A Sent: Friday, December 25, 2015 9:24 AM To: edk2-devel@lists.01.org; Yao, Jiewen Cc: Wu, Hao A Subject: [PATCH 8/8] SecurityPkg Tcg2Pei: Fix a typo in function description Contributed-under: TianoCore Contribution Agre

Re: [edk2] [PATCH 0/8] Fix typo for 'accroding' to 'according'

Looks good to me for MdeModulePkg changes Reviewed-by: Feng Tian -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Friday, December 25, 2015 09:24 To: edk2-devel@lists.01.org; Yao, Jiewen Cc: Wu, Hao A Subject: [edk2] [PATCH 0/8] Fix t

[edk2] about hacking team UEFI rootkit

Dear Sir/Madam, I was wondering whether there are anyone who`ve been researched about hacking team `s UEFI rootkit. Can you share some related information with me? Thank you very much. Owen 发送自 Windows 10 版邮件应用 ___ edk2-devel mailing list edk2-de

[edk2] [PATCH 8/8] SecurityPkg Tcg2Pei: Fix a typo in function description

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c index 63045f1..3b4b5fe 100644 --- a/Securi

[edk2] [PATCH 6/8] NetworkPkg IpSecDxe: Fix a typo in function description

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- NetworkPkg/IpSecDxe/IpSecImpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/IpSecDxe/IpSecImpl.c b/NetworkPkg/IpSecDxe/IpSecImpl.c index 6df83ec..854a9a5 100644 --- a/NetworkPkg/Ip

[edk2] [PATCH 4/8] MdeModulePkg AcpiTableDxe: Fix a typo in function description

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Universal/Acpi/AcpiTableDxe/AmlOption.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AmlOption.c b/MdeModulePkg/Universal/Acpi/AcpiTableD

[edk2] [PATCH 1/8] MdeModulePkg UhciDxe: Fix a typo in function description

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Bus/Pci/UhciDxe/Uhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Pci/UhciDxe/Uhci.c b/MdeModulePkg/Bus/Pci/UhciDxe/Uhci.c index 179e36c..a4cb27a 100644 --- a/

[edk2] [PATCH 7/8] NetworkPkg IScsiDxe: Fix typos in function descriptions

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- NetworkPkg/IScsiDxe/IScsiMisc.c | 2 +- NetworkPkg/IScsiDxe/IScsiMisc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c index

[edk2] [PATCH 2/8] MdeModulePkg Core/Dxe/Misc: Fix typos in function descriptions

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c b/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c index

[edk2] [PATCH 5/8] MdeModulePkg IScsiDxe: Fix a typo in function description

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.c b/MdeModulePkg/Universal/Network/IScsiDxe/

[edk2] [PATCH 0/8] Fix typo for 'accroding' to 'according'

Fix 'accroding' typos in function descriptions. Hao Wu (8): MdeModulePkg UhciDxe: Fix a typo in function description MdeModulePkg Core/Dxe/Misc: Fix typos in function descriptions MdeModulePkg DxeHttpLib: Fix typos in function descriptions MdeModulePkg AcpiTableDxe: Fix a typo in function

[edk2] [PATCH 3/8] MdeModulePkg DxeHttpLib: Fix typos in function descriptions

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c ind

[edk2] [PATCH v2] ShellPkg : Add UEFI_APPLICATION module type to UefiShellInstall1CommandsLib.inf

Using UEFI_APPLICATION for all Shell app and libraries allows the use of different compiler flags for the Shell application itself and for other applications that are built separately that use Shell libraries. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahm

Re: [edk2] [PATCH] SecurityPkg - Rename TisTpmCommand to avoid name collision

Chao, That is already included in this patch: @@ -478,7 +478,7 @@ TisTpmCommand ( } } DEBUG_CODE ( -DEBUG ((EFI_D_VERBOSE, "TisTpmCommand ReceiveHeader - ")); +DEBUG ((EFI_D_VERBOSE, "Tpm2TisTpmCommand ReceiveHeader - ")); for (Index = 0; Index < sizeof (TPM2_RESPONSE_HEA

[edk2] [PATCH v2] Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image verification failures

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Samer El-Haj-Mahmoud --- .../Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 8 1 file changed, 8 insertions(+) diff --git a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c b/S

[edk2] [PATCH 5/6] ShellPkg AARCH64: remove DEBUG BuildOptions override

The BuildOptions for AARCH64 in Application/Shell/Shell.inf only affect the core Shell binary, and not the Shell component libraries which are merged into the final Shell binary via NULL library class resolution. This means we need to override the UEFI_APPLICATION build options in the platform .DS

[edk2] [PATCH 0/6] AARCH64 code model and toolchain updates

This is a followup to the patch 'BaseTools AARCH64: add -mstrict-align to all AARCH64 GCC flavors' that I sent out yesterday. As it turns out, using strict alignment results in a code size increase which breaks the build for the DEBUG shell using the tiny code model we use for GCC49 and up. (Note

[edk2] [PATCH 6/6] BaseTools AARCH64: add -mstrict-align to all AARCH64 GCC flavors

GCC for AARCH64 recognizes byte swapping sequences and replaces them with rev instructions. In some cases (i.e., with GCC version 5 and later) this may result in unaligned accesses, which are not allowed before we turn the MMU on. So move the -mstrict-align compiler switch to the shared define for

[edk2] [PATCH 4/6] ArmVirtPkg: use small code model for all UEFI_APPLICATION modules

Unfortunately, compiling the DEBUG shell using the small code model is not sufficient in all cases to get a successful build when the toolchain defaults to the tiny code model. The reason is that not only the Shell binary itself should be built using the small code model, all Shell component librar

[edk2] [PATCH 3/6] BaseTools AARCH64: reduce tiny model function alignment

The tiny code model for AARCH64 is the most efficient model, since its symbol references are relative via a single 32-bit ADR instruction. This gives us a range of only +/- 1 MB, but this is sufficient for the vast majority of the modules that make up a typical EDK2 firmware. Since the reference is

[edk2] [PATCH 1/6] BaseTools CLANG35: use GNU target triplets explicitly

Since we are combining Clang with the GNU linker, make that explicit in the target triplet. This affects certain builtin defines and other compiler behavior that may be unspecified otherwise. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- BaseTools/Conf

[edk2] [PATCH 2/6] BaseTools CLANG35: use -target in PP flags as well

The Clang preprocessor may rely on builtin defines that are target dependent, so we should add the -target argument also when invoking the preprocessor directly. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Liming Gao --- BaseTools/Conf/tool

Re: [edk2] [PATCH 7/8] BaseTools CLANG35: use GNU target triplets explicitly

On 17 December 2015 at 11:01, Ard Biesheuvel wrote: > Since we are combining Clang with the GNU linker, make that explicit in > the target triplet. This affects certain builtin defines and other compiler > behavior that may be unspecified otherwise. > > Contributed-under: TianoCore Contribution Ag

Re: [edk2] [Patch] MdeModulePkg/BootManagerMenu: Fix bug that boots to undesired option

Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Thursday, December 24, 2015 3:50 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Dong, Eric Subject: [edk2] [Patch] MdeModulePkg/BootManagerMenu: Fix bug that boot

Re: [edk2] [Patch] NetworkPkg: Support DNS4/6 GeneralLookUp feature

Thanks Ting's comments. I will update it by the comments. -Original Message- From: Ye, Ting Sent: Thursday, December 24, 2015 4:27 PM To: Wu, Jiaxin; edk2-devel@lists.01.org Cc: Subramanian Sriram; El-Haj-Mahmoud Samer; Fu, Siyuan Subject: RE: [Patch] NetworkPkg: Support DNS4/6 GeneralLoo

Re: [edk2] [Patch] NetworkPkg: Support DNS4/6 GeneralLookUp feature

Some comments for the patch: 1. DnsFillQuerytIpQName: a. returns UIN8* though in function description it returns EFI_STATUS. b. better to record how QName is defined in RFC. c. It is an internal function so I don't think it needs EFIAPI attribute. d. when calling DnsFillQuerytIpQName