Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

2016-02-13 Thread Laszlo Ersek
On 02/14/16 06:44, Yao, Jiewen wrote: > HI > Thanks to discuss this properties table issue. > The purpose of this patch is to *add* UEFI2.6 memory attributes table. This > patch does not handle any UEFI2.5 properties table. > If we want to change EDKII code for properties table, I suggest we separ

Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

2016-02-13 Thread Yao, Jiewen
HI Thanks to discuss this properties table issue. The purpose of this patch is to *add* UEFI2.6 memory attributes table. This patch does not handle any UEFI2.5 properties table. If we want to change EDKII code for properties table, I suggest we separate it from this patch. Is there any comment f

Re: [edk2] [PATCH 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

2016-02-13 Thread Fu, Siyuan
Better to make a new patch, I don't know whether Liming has more comments about the patch. Siyuan From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] Sent: Sunday, February 14, 2016 11:47 AM To: edk2-devel@lists.01.org; Fu, Siyuan Subject: RE: [PATCH 2/2] NetworkPkg: Use Http11 de

Re: [edk2] [PATCH 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

2016-02-13 Thread El-Haj-Mahmoud, Samer
Siyuan Either way is fine. Do you want to make the changes yourself or wait for me to submit a patch next week? -Original Message- From: Fu, Siyuan [siyuan...@intel.com] Received: Saturday, 13 Feb 2016, 8:53PM To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; edk2-devel@lists

Re: [edk2] [PATCH 2/2] NetworkPkg: Use Http11 definitions in HttpDxe and HttpBootDxe

2016-02-13 Thread Fu, Siyuan
Hi, Samer I think we'd better not to rename a defined macro in the public header file. How about we keep the macro "HTTP_VERSION" in IndustryStandard/Http11.h, and in HTTP driver we could just use this macro, or #define HTTP_VERSION_STR HTTP_VERSION Best Regards Siyuan > -Origi

Re: [edk2] [PATCH] NetworkPkg: better sanity check on Ipv6 prefix length

2016-02-13 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Friday, February 12, 2016 7:58 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Samer El-Haj-Mahmoud haj-mahm...@hpe.com>; Samer El-Haj-Mahmoud > Subject: [PATCH] Ne

Re: [edk2] [PATCH] NetworkPkg: Reword PXE download message

2016-02-13 Thread Fu, Siyuan
Reviewed-by: Siyuan Fu > -Original Message- > From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Friday, February 12, 2016 8:39 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Samer El-Haj-Mahmoud haj-mahm...@hpe.com>; Samer El-Haj-Mahmoud > Subject: [PATCH] N

Re: [edk2] An unkempt git guide for edk2 contributors and maintainers

2016-02-13 Thread Laszlo Ersek
On 02/12/16 02:09, Laszlo Ersek wrote: > [...] This guide is now available in the TianoCore wiki, at https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers with a few topical fixups (I applied a suggestion from Paolo, thx), and more