[edk2] [PATCH v2] NetworkPkg: Replace ASSERT with error handling in Http boot and IScsi

2016-06-19 Thread Zhang Lubo
v2: *Fix some memory leak issue. This patch is used to replace ASSERT with error handling in Http boot Driver and IScsi driver. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [patch] NetworkPkg: Replace ASSERT with error handling in Http boot and IScsi

2016-06-19 Thread Zhang, Lubo
Yes , you are right, thanks for your comments. Lubo -Original Message- From: Wu, Jiaxin Sent: Monday, June 20, 2016 11:48 AM To: Zhang, Lubo ; edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan Subject: RE: [edk2] [patch]

Re: [edk2] [PATCH v2 0/2] ShellPkg: Use ".." to indicate device path is partially displayed

2016-06-19 Thread Ni, Ruiyu
Laszlo, Jaben, The dotdot style is copied from Shell spec V2.2 page 120 "dh" command output sample. Regards, Ray From: Carsey, Jaben Sent: Saturday, June 18, 2016 5:47 AM To: Laszlo Ersek ; Ni, Ruiyu ; edk2-de...@ml01.01.org Cc: Carsey, Jaben

Re: [edk2] [patch] NetworkPkg: Replace ASSERT with error handling in Http boot and IScsi

2016-06-19 Thread Wu, Jiaxin
Hi Lubo, Two comments as below: 1. In IScsiFormExtractConfig(), you need free IfrNvData and InitiatorName pool first before return EFI_OUT_OF_RESOURCES. 2. In IScsiGetConfigData(), returning EFI_OUT_OF_RESOURCES may be incorrect after HiiSetString() failed? Should be "continue"? Thanks.

Re: [edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-19 Thread Zeng, Star
Hi Marvin, 1. The memory allocate and free in PiSmmCore are SMRAM that is not related to UEFI memory map. 2. According to UEFI 2.6 spec page 222 below, the UEFI OS loader should have got the memory map before ExitBootServices. That means the memory free should not impact the memory map *got by

Re: [edk2] [PATCH v2] NetworkPkg: Replace ASSERT with error handling in DnsDxe

2016-06-19 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Monday, June 20, 2016 9:46 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Zhang, > Lubo > Subject: [PATCH v2]

Re: [edk2] [Patch] NetworkPkg: Replace ASSERT with error handling in DnsDxe

2016-06-19 Thread Wu, Jiaxin
Agree. Patch v2 is ready for review. Thanks. Jiaxin > -Original Message- > From: Ye, Ting > Sent: Friday, June 17, 2016 5:04 PM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Zhang, Lubo ; Fu, Siyuan > Subject: RE: [edk2]

[edk2] [PATCH v2] NetworkPkg: Replace ASSERT with error handling in DnsDxe

2016-06-19 Thread Jiaxin Wu
v2: *Use goto to simplify code logic. This patch is used to replace ASSERT with error handling in DnsDxe driver. Cc: Ye Ting Cc: Fu Siyuan Cc: Zhang Lubo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin

[edk2] [PATCH 0/2] CapsulePei: Validate capsule integrity by memory resource hob

2016-06-19 Thread Star Zeng
Star Zeng (2): MdeModulePkg CapsulePei: Fix some typos MdeModulePkg CapsulePei: Validate capsule integrity by memory resource hob MdeModulePkg/Universal/CapsulePei/Capsule.h| 9 +- MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 +-

[edk2] [PATCH 2/2] MdeModulePkg CapsulePei: Validate capsule integrity by memory resource hob

2016-06-19 Thread Star Zeng
Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Universal/CapsulePei/Capsule.h| 1 + MdeModulePkg/Universal/CapsulePei/CapsulePei.inf | 3 +-

[edk2] [PATCH 1/2] MdeModulePkg CapsulePei: Fix some typos

2016-06-19 Thread Star Zeng
Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Universal/CapsulePei/Capsule.h| 8 +++- MdeModulePkg/Universal/CapsulePei/Common/CapsuleCoalesce.c | 12 ++--

[edk2] AARCH64 "ArmGicDisableInterrupt"

2016-06-19 Thread Narinder Dhillon
Hi All, In "ArmPkg/Drivers/ArmGic/ArmGicLib.c", the "ArmGicDisableInterrupt" function handles cases for GICv2, GICv3. For GICv3, it seems that even for SPI's, the GICR registers are being cleared as opposed to the GICD registers. Thanx, ___ edk2-devel

Re: [edk2] [patch 0/2] Connect all devices in UiApp if needed

2016-06-19 Thread Bi, Dandan
Hi Laszlo, Yes, this is a performance improvement! We remove the connect-all action in BootManagerUiLib, so improve the performance when enter Boot Manager form. Thanks, Dandan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Saturday, June 18, 2016 5:52 AM To:

[edk2] [PATCH v1 1/2] MdeModulePkg: Minimize usage of FreePool() during ExitBS().

2016-06-19 Thread Marvin Häuser
During exiting Boot Services, there should be no changes made to the Memory Map. This patch eliminates calls to FreePool() and CloseEvent() (which calls FreePool()) and instead zero's the memory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser

[edk2] [PATCH v1 2/2] NetworkPkg: Minimize usage of FreePool() during ExitBS().

2016-06-19 Thread Marvin Häuser
During exiting Boot Services, there should be no changes made to the Memory Map. This patch eliminates calls to FreePool() and CloseEvent() (which calls FreePool()) and instead zero's the memory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser