Re: [edk2] [PATCH 0/5] OvmfPkg/QemuVideoDxe: cleanups and tweaks

2016-10-15 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On 2016-10-12 03:09:00, Laszlo Ersek wrote: > Reviewing (part of) Ray's recent FrameBufferBltLib changes gave me the > idea for this. The patches are really small. > > Public branch:

Re: [edk2] [Patch] BaseTools: PatchCheck to align with wiki and report error for EFI_D_*

2016-10-15 Thread Jordan Justen
On 2016-10-13 02:29:46, Yonghong Zhu wrote: > This patch updates PatchCheck.py: Can you split this into 3 separate patches? > 1.Update max line length to 70 that describe in wiki I think we should update PatchCheck.py and the wiki to say that: 1. The subject line of the commit message should

Re: [edk2] [PATCH] ArmVirtPkg: undo bogus component name and driver diagnostics disablement

2016-10-15 Thread Laszlo Ersek
On 10/15/16 18:58, Ard Biesheuvel wrote: > On 15 October 2016 at 17:56, Laszlo Ersek wrote: >> The entry point function of any UEFI_DRIVER that conforms to the UEFI >> driver model must install an instance of the EFI_DRIVER_BINDING_PROTOCOL >> on the image handle. Beyond that,

Re: [edk2] [PATCH] ArmVirtPkg: undo bogus component name and driver diagnostics disablement

2016-10-15 Thread Ard Biesheuvel
On 15 October 2016 at 17:56, Laszlo Ersek wrote: > The entry point function of any UEFI_DRIVER that conforms to the UEFI > driver model must install an instance of the EFI_DRIVER_BINDING_PROTOCOL > on the image handle. Beyond that, the following protocols are optional: > > -

[edk2] [PATCH] ArmVirtPkg: undo bogus component name and driver diagnostics disablement

2016-10-15 Thread Laszlo Ersek
The entry point function of any UEFI_DRIVER that conforms to the UEFI driver model must install an instance of the EFI_DRIVER_BINDING_PROTOCOL on the image handle. Beyond that, the following protocols are optional: - EFI_COMPONENT_NAME_PROTOCOL - EFI_COMPONENT_NAME2_PROTOCOL -

[edk2] Trying to build an uefi application that is out of UDK directory

2016-10-15 Thread Denis Alberto Silverio
Hi guys I've created an uefi application in a directory that is not inside the EDK2015 folder. For example: My UDK folder is: C:\Projects\UEFI\UDK2015_r18552 |- BaseTools |- Conf |- CryptoPkg |-etc My Uefi app is on: C:\Projects\UEFI\Projects\MyApp |- EntryPoint.c |- MyApp.dsc |- .etc

Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg

2016-10-15 Thread Yao, Jiewen
Of course, it is fine to give a good name in MdePkg. :) My concern is only about "Compatibility". This series patch only updated ArmPkg and EmbeddedPkg. But there might be more close source IP protected packages using the original header file. That is why I propose a compatible way: We give a