Re: [edk2] [PATCH] MdePkg/BaseLib: Enhance the return value for string to uint functions

Reviewed-by: Wu Jiaxin > -Original Message- > From: Wu, Hao A > Sent: Thursday, December 8, 2016 2:08 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen ; > Wu, Jiaxin ; Gao, Liming

[edk2] [PATCH] MdeModulePkg VariableSmm: Do not need check CommBufferSize buffer

Current code in SmmVariableHandler() checks CommBufferSize buffer to make sure it points to outside SMRAM in "case SMM_VARIABLE_FUNCTION_GET_STATISTICS". But after eaae7b33b1cf6b9f21db1636f219c2b6a8d88afd, CommBufferSize buffer points to SMRAM that was used by SMM core to cache CommSize from

Re: [edk2] [PATCH RFC 10/14] UefiCpuPkg/BaseXApicX2ApicLib: Fix initialisation on my system and ...

Hi Anthony, Can you provide more details on why you want to expose internal APIs in the library class? What is the specific issue? Is the Local APIC in your environment not behaving the same as real HW? Thanks, Mike > -Original Message- > From: edk2-devel

[edk2] [PATCH] BaseTools/Scripts/PatchCheck.py: Extended patch style check for c code

Fixed reporting signature error for a cover letter. Fixed reporting line size error for a file change information included in the commit message. Fixed line number reported in PatchCheck error messages. It points to the correct line in the diff file. The patch extends style checking for c code:

Re: [edk2] [PATCH v2 2/8] FatPkg/EnhancedFatDxe: Use global variable replace static local variable

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Bi, Dandan >Sent: Friday, December 9, 2016 10:21 AM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [PATCH v2 2/8] FatPkg/EnhancedFatDxe: Use global variable replace >static

[edk2] [PATCH v2 2/8] FatPkg/EnhancedFatDxe: Use global variable replace static local variable

Create global variable "mMonthDays" to replace static local variable "MonthDays" in function FatIsValidTime() in Misc.c. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Misc.c | 4

Re: [edk2] [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command

done. Regards, Ray From: Carsey, Jaben Sent: Friday, December 9, 2016 6:07 AM To: Tapan Shah ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Carsey, Jaben Subject: RE: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls'

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

Got it ! I will submit a new patch. Thanks! Regards, Dandan -Original Message- From: Ni, Ruiyu Sent: Friday, December 9, 2016 8:58 AM To: Bi, Dandan ; edk2-devel@lists.01.org Subject: RE: [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

Re: [edk2] [patch 1/8] FatPkg\EnhancedFatDxe: Avoid Non-Boolean type uses as Boolean

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Bi, Dandan >Sent: Thursday, December 8, 2016 6:54 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [patch 1/8] FatPkg\EnhancedFatDxe: Avoid Non-Boolean type uses as >Boolean >

Re: [edk2] [patch 3/8] FatPkg\EnhancedFatDxe: Make function prototype align with definition

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Bi, Dandan >Sent: Thursday, December 8, 2016 6:54 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [patch 3/8] FatPkg\EnhancedFatDxe: Make function prototype align with

Re: [edk2] [patch 4/8] FatPkg\EnhancedFatDxe: Make the variable name follow rule

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Bi, Dandan >Sent: Thursday, December 8, 2016 6:54 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [patch 4/8] FatPkg\EnhancedFatDxe: Make the variable name follow rule > >Cc:

Re: [edk2] [patch 5/8] FatPkg\EnhancedFatDxe: Use typedef for complex type

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Bi, Dandan >Sent: Thursday, December 8, 2016 6:54 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [patch 5/8] FatPkg\EnhancedFatDxe: Use typedef for complex type > >Cc: Ruiyu

Re: [edk2] [patch 7/8] FatPkg\EnhancedFatDxe: Add comments for functions

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Bi, Dandan >Sent: Thursday, December 8, 2016 6:54 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [patch 7/8] FatPkg\EnhancedFatDxe: Add comments for functions > >Cc: Ruiyu Ni

Re: [edk2] [patch 8/8] FatPkg: Fix format issues in dec/inf/dsc files

Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: Bi, Dandan >Sent: Thursday, December 8, 2016 6:54 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu >Subject: [patch 8/8] FatPkg: Fix format issues in dec/inf/dsc files > >Cc: Ruiyu Ni

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

Dandan, Could you please create a global array mMonthDays? UINT8 mMonthDays[] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 }; Regards, Ray >-Original Message- >From: Bi, Dandan >Sent: Thursday, December 8, 2016 6:54 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

Yes. When I said "read-protect" I mean "protect by making it read-only". I should have said "read-only protect" or "write-protect". K2 -Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Thursday, December 8, 2016 4:37 PM To: Kurt Kennett

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

Hi I found it is using "STATIC" not "CONST". Does a compiler put "STATIC" data to READ-ONLY section? Thank you Yao Jiewen From: af...@apple.com [mailto:af...@apple.com] Sent: Friday, December 9, 2016 8:37 AM To: Kurt Kennett Cc: Yao, Jiewen ;

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

> On Dec 8, 2016, at 4:26 PM, Kurt Kennett wrote: > > Is the data 'variable'? i.e does it ever change? > > A normal compiler should put this data into a section marked read-only if it > is marked as const, and a loader could read-protect the region after load. >

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

Is the data 'variable'? i.e does it ever change? A normal compiler should put this data into a section marked read-only if it is marked as const, and a loader could read-protect the region after load. K2 -Original Message- From: Yao, Jiewen [mailto:jiewen@intel.com] Sent:

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

Agree. Maybe we can move it to be a global variable ? Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kurt > Kennett > Sent: Friday, December 9, 2016 1:28 AM > To: Bi, Dandan ; edk2-devel@lists.01.org

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

> On Dec 8, 2016, at 9:27 AM, Kurt Kennett wrote: > > This seems kind of silly. > Why isn't this just const data? This adds code and memory accesses that are > worthless and happen on every call to the function. > K2, I think this is an attempt to conform to the

Re: [edk2] [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command

Reviewed-by: Jaben Carsey Ray, can you push with your other stuff? > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Thursday, December 8, 2016 9:21 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Tapan

Re: [edk2] [PATCH] ShellPkg/Application: Fix ">v" cannot update environment variable

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, December 7, 2016 5:45 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Carsey, Jaben > > Subject: [PATCH] ShellPkg/Application:

Re: [edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

This seems kind of silly. Why isn't this just const data? This adds code and memory accesses that are worthless and happen on every call to the function. K2 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Thursday, December 8,

[edk2] [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command

Adding a missing header line for 'cls -sfo' command Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tapan Shah --- ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c| 1 +

Re: [edk2] [PATCH] ShellPkg/Application: Fix ">v" cannot update environment variable

Reviewed-by: Tapan Shah -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Wednesday, December 07, 2016 7:45 PM To: edk2-devel@lists.01.org Cc: Jaben Carsey ; Chen A Chen

Re: [edk2] [PATCH] ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe: Set Marvell Yukon MAC address

Thanks to Ryan for reminding me :) On Wed, Oct 05, 2016 at 08:42:51PM -0500, Daniil Egranov wrote: > The patch reads a valid MAC address form the Juno IOFPGA registers > and pushes it into onboard Marvell Yukon NIC. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by:

Re: [edk2] [PATCH] ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe: Set Marvell Yukon MAC address

Hi Leif, On 2 November 2016 at 11:55, Ryan Harkin wrote: > On 1 November 2016 at 21:05, Leif Lindholm wrote: >> On Tue, Nov 01, 2016 at 05:55:11PM +, Ryan Harkin wrote: >>> Hi Daniil, >>> >>> While looking for another patch, I found this on

[edk2] [PATCH RFC 10/14] UefiCpuPkg/BaseXApicX2ApicLib: Fix initialisation on my system and ...

declare more exported function, ReadLocalApicReg and WriteLocalApicReg. On my system (running OVMF inside a Xen PVH guest), writing the interrupt information (to XAPIC_LVT_TIMER_OFFSET) would also reset the init-count register, thus disabling the timer. ---

[edk2] [PATCH RFC 11/14] OvmfPkg/XenOvmf: Adding XenTimerLocalApic

And replacing the ACPI Timer by this one based on the local APIC. ACPI Timer does not work in a PVH guest, but local APIC works on both PVH and HVM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenOvmf.dsc

[edk2] [PATCH RFC 14/14] XenOvmf: Use a different RTC

--- OvmfPkg/XenOvmf.dsc | 5 - OvmfPkg/XenOvmf.fdf | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/XenOvmf.dsc b/OvmfPkg/XenOvmf.dsc index a7a884e..345157b 100644 --- a/OvmfPkg/XenOvmf.dsc +++ b/OvmfPkg/XenOvmf.dsc @@ -567,7 +567,10 @@ }

[edk2] [PATCH RFC 13/14] OvmfPkg: Introduce XenIoPvhDxe to initialize Grant Tables

This "device" use XenIoMmioLib to reserve some space to be use by grant tables. It's use 0xfc00, which might not be a good choice... There is probably a better way that using a device for this. --- OvmfPkg/XenIoPvhDxe/XenIoPvhDxe.c | 263

[edk2] [PATCH RFC 12/14] OvmfPkg/PlatformBootManagerLib: Use a Xen console for ConOut/ConIn

and add OvmfPkg/XenConsoleIo/XenConsoleIo to XenOvmf platform. It actually look for gEfiSerialIoProtocolGuid. --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 33 ++ .../PlatformBootManagerLib.inf | 2 ++ OvmfPkg/XenOvmf.dsc

[edk2] [PATCH RFC 00/14] Specific platform to run OVMF in Xen PVH and HVM guests

Hi, I've started to create a Xen specifig plaform, in OvmfPkg/XenOvmf.dsc with the goal to make it work on both Xen HVM and Xen PVHv2 The first few patches only create the platform and duplicate some code from OvmfPkg and the later patches (from OvmfPkg/XenPlatformPei: Add xen PVH specific code)

[edk2] [PATCH RFC 05/14] OvmfPkg/Library: add XenPciHostBridgeLib

A copy of OvmfPkg/Library/PciHostBridgeLib Removing support for pci bus enumeration, I think, and only use scan of already enumerated pci bus. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD ---

[edk2] [PATCH RFC 04/14] OvmfPkg: Introduce XenPlatformPei

A copy of OvmfPkg/PlatformPei without some of QEMU specific initialization, Xen does not support QemuFwCfg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenOvmf.dsc | 2 +-

[edk2] [PATCH RFC 09/14] OvmfPkg/ResetSystemLib: Add missing dependency on PciLib

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf

[edk2] [PATCH RFC 06/14] OvmfPkg/XenPlatformPei: Add xen PVH specific code

- learn about memory size from the E820 - ignore error if host bridge devid is 0x, PVH does not have PCI and reading from unexisting device return -1. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD ---

[edk2] [PATCH RFC 07/14] OvmfPkg/XenResetVector: Add new entry point for Xen PVH

This one enter directly in 32bits Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm | 79 + OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm | 23 +++

[edk2] [PATCH RFC 01/14] OvmfPkg: Create platform XenOvmf

This is a copy of OvmfX64, removing VirtIO and some SMM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenOvmf.dsc | 793 OvmfPkg/XenOvmf.fdf | 504

[edk2] [PATCH RFC 03/14] OvmfPkg/XenOvmf.dsc: Introduce XenResetVector

Copy of OvmfPkg/ResetVector, with one changes: - default_cr0: enable cache Xen copy the OVMF code to RAM, there is no need for cache. Also, it makes OVMF slow to start on AMD. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD ---

[edk2] [PATCH RFC 02/14] OvmfPkg/XenOvmf: Update debug IO port for Xen

This is a debug IO port that will output directly to the Xen Hypervisor console. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenOvmf.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/OvmfPkg/XenOvmf.dsc

[edk2] [PATCH RFC 08/14] OvmfPkg/PlatformBootManagerLib: Workaround missing PCI bus on Xen PVH

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c

Re: [edk2] GCC needs __attribute__((returns_twice)) for SetJump

On 8 December 2016 at 13:30, Michael Zimmermann wrote: > When compiling with any ARM toolchain and Os, registers can get > trashed when returning for the second time from SetJump because GCC > only handles this correctly when using standard names like 'setjmp' or >

[edk2] GCC needs __attribute__((returns_twice)) for SetJump

When compiling with any ARM toolchain and Os, registers can get trashed when returning for the second time from SetJump because GCC only handles this correctly when using standard names like 'setjmp' or 'getcontext'. When different names are used you have to use the attribute 'returns_twice' to

[edk2] [patch 8/8] FatPkg: Fix format issues in dec/inf/dsc files

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Fat.inf | 2 +- FatPkg/FatPei/FatPei.inf | 6 +++--- FatPkg/FatPkg.dec | 1 - FatPkg/FatPkg.dsc | 3 +--

[edk2] [patch 7/8] FatPkg\EnhancedFatDxe: Add comments for functions

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Fat.c | 64 FatPkg/EnhancedFatDxe/Fat.h | 804 +++ FatPkg/EnhancedFatDxe/Info.c | 40

[edk2] [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after declaration

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Misc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/FatPkg/EnhancedFatDxe/Misc.c

[edk2] [patch 5/8] FatPkg\EnhancedFatDxe: Use typedef for complex type

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Fat.h | 36 --- FatPkg/EnhancedFatDxe/FatFileSystem.h | 10 ++ 2 files changed, 27

[edk2] [patch 0/8] FatPkg: Fix coding style issues

The patch series make the coding style of FatPkg align with EDKII rules. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Dandan Bi (8): FatPkg\EnhancedFatDxe: Avoid Non-Boolean type uses as Boolean

[edk2] [patch 4/8] FatPkg\EnhancedFatDxe: Make the variable name follow rule

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/DirectoryManage.c | 16 - FatPkg/EnhancedFatDxe/DiskCache.c | 50 +--

[edk2] [patch 3/8] FatPkg\EnhancedFatDxe: Make function prototype align with definition

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/Info.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/FatPkg/EnhancedFatDxe/Info.c

[edk2] [patch 1/8] FatPkg\EnhancedFatDxe: Avoid Non-Boolean type uses as Boolean

Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- FatPkg/EnhancedFatDxe/FileName.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/FatPkg/EnhancedFatDxe/FileName.c

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverablePciDevice: add missing cast and EFIAPI modifiers

Reviewed-by: Dandan Bi -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Thursday, December 8, 2016 4:17 PM To: edk2-devel@lists.01.org; Ni, Ruiyu Cc: Ard Biesheuvel

[edk2] [PATCH] MdeModulePkg/NonDiscoverablePciDevice: add missing cast and EFIAPI modifiers

Add missing EFIAPI modifiers to the functions that are exposed via the PCI I/O protocol. At the same time, add a missing UINT8 cast which breaks the build on Visual Studio. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---