In function UfsHcDriverBindingStart(), the return value 'Status' may be
overridden during the original PCI attributes restore process.
This commit refines the logic to avoid such override.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
V2 changes:
Remove assigning the result of restoring original PCI attributes to
'Status'.
V1 history:
1. Remove unused field in UfsHc private struct
2. Avoid overriding return value in BindingStart
Hao Wu (2):
MdeModulePkg/UfsPciHc: Remove unused field in UfsHc private struct
The commit removes the unused field 'EFI_HANDLE Handle' in Ufs host
controller private data structure 'UFS_HOST_CONTROLLER_PRIVATE_DATA'.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Star Zeng
---
Reviewed-by: Star Zeng
Thanks,
Star
-Original Message-
From: Wu, Hao A
Sent: Monday, April 24, 2017 1:46 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star
Subject: [PATCH 1/2] MdeModulePkg/UfsPciHc: Remove unused
Hao,
ASSERT_EFI_ERROR will be null macro in release mode, but the code still needs
to be run in release mode.
I recommend to just remove the Status assignment and ASSERT_EFI_ERROR in the
original PCI attributes restore code.
Thanks,
Star
-Original Message-
From: edk2-devel
1. Remove unused field in UfsHc private struct
2. Avoid overriding return value in BindingStart
Cc: Star Zeng
Hao Wu (2):
MdeModulePkg/UfsPciHc: Remove unused field in UfsHc private struct
MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart
In function UfsHcDriverBindingStart(), the return value 'Status' may be
overriden during the original PCI attributes restore process.
This commit refines the logics to avoid such override.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
The commit removes the unused field 'EFI_HANDLE Handle' in Ufs host
controller private data structure 'UFS_HOST_CONTROLLER_PRIVATE_DATA'.
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
---
Reviewed-by: Ye Ting
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu
Sent: Friday, April 21, 2017 12:58 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin
Got it.
> -Original Message-
> From: Fan, Jeff
> Sent: Monday, April 24, 2017 10:03 AM
> To: Yao, Jiewen ; edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: RE: [PATCH 2/4] MdePkg/SmmIoLib: Add sample instance.
>
> Jiewen,
>
> Could the
*Serach* should be *Search*
Cc: Liming Gao
Cc: Feng Tian
Cc: Michael Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
---
*Serach* should be *Search*. This is an incompatible change of library API name.
But this API was introduced a couple of weeks ago, this fix should be low
impact.
To make sure build pass on each commit, I create one single patch across
packages updating for this typo fix.
Jiewen,
Could the following ASSER() removed and let caller check the return value?
Otherwise, there is no return on DEBUG build for this servcie.
+if (!InValidRegion) {
+ DEBUG ((
+DEBUG_ERROR,
+"SmmIsMmioValid: Not in valid MMIO region: BaseAddress (0x%lx) -
Length
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu,
> Hao A
> Sent: Friday, April 21, 2017 9:39 AM
> To: Suman Prakash; edk2-devel@lists.01.org
> Cc: Tian, Feng
> Subject: Re: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: Handling return
> of
14 matches
Mail list logo