[edk2] [PATCH v2 2/2] MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart

2017-04-23 Thread Hao Wu
In function UfsHcDriverBindingStart(), the return value 'Status' may be overridden during the original PCI attributes restore process. This commit refines the logic to avoid such override. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH v2 0/2] MdeModulePkg/UfsPciHc: Code refinements

2017-04-23 Thread Hao Wu
V2 changes: Remove assigning the result of restoring original PCI attributes to 'Status'. V1 history: 1. Remove unused field in UfsHc private struct 2. Avoid overriding return value in BindingStart Hao Wu (2): MdeModulePkg/UfsPciHc: Remove unused field in UfsHc private struct

[edk2] [PATCH v2 1/2] MdeModulePkg/UfsPciHc: Remove unused field in UfsHc private struct

2017-04-23 Thread Hao Wu
The commit removes the unused field 'EFI_HANDLE Handle' in Ufs host controller private data structure 'UFS_HOST_CONTROLLER_PRIVATE_DATA'. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu Reviewed-by: Star Zeng ---

Re: [edk2] [PATCH 1/2] MdeModulePkg/UfsPciHc: Remove unused field in UfsHc private struct

2017-04-23 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Wu, Hao A Sent: Monday, April 24, 2017 1:46 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star Subject: [PATCH 1/2] MdeModulePkg/UfsPciHc: Remove unused

Re: [edk2] [PATCH 2/2] MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart

2017-04-23 Thread Zeng, Star
Hao, ASSERT_EFI_ERROR will be null macro in release mode, but the code still needs to be run in release mode. I recommend to just remove the Status assignment and ASSERT_EFI_ERROR in the original PCI attributes restore code. Thanks, Star -Original Message- From: edk2-devel

[edk2] [PATCH 0/2] MdeModulePkg/UfsPciHc: Code refinements

2017-04-23 Thread Hao Wu
1. Remove unused field in UfsHc private struct 2. Avoid overriding return value in BindingStart Cc: Star Zeng Hao Wu (2): MdeModulePkg/UfsPciHc: Remove unused field in UfsHc private struct MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart

[edk2] [PATCH 2/2] MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart

2017-04-23 Thread Hao Wu
In function UfsHcDriverBindingStart(), the return value 'Status' may be overriden during the original PCI attributes restore process. This commit refines the logics to avoid such override. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH 1/2] MdeModulePkg/UfsPciHc: Remove unused field in UfsHc private struct

2017-04-23 Thread Hao Wu
The commit removes the unused field 'EFI_HANDLE Handle' in Ufs host controller private data structure 'UFS_HOST_CONTROLLER_PRIVATE_DATA'. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Refine the IPv4 configuration help info

2017-04-23 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Friday, April 21, 2017 12:58 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin

Re: [edk2] [PATCH 2/4] MdePkg/SmmIoLib: Add sample instance.

2017-04-23 Thread Yao, Jiewen
Got it. > -Original Message- > From: Fan, Jeff > Sent: Monday, April 24, 2017 10:03 AM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: RE: [PATCH 2/4] MdePkg/SmmIoLib: Add sample instance. > > Jiewen, > > Could the

[edk2] [PATCH] PeCoffGetEntryPointLib: Fix spelling issue

2017-04-23 Thread Jeff Fan
*Serach* should be *Search* Cc: Liming Gao Cc: Feng Tian Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [PATCH] PeCoffGetEntryPointLib: Fix spelling issue

2017-04-23 Thread Jeff Fan
*Serach* should be *Search*. This is an incompatible change of library API name. But this API was introduced a couple of weeks ago, this fix should be low impact. To make sure build pass on each commit, I create one single patch across packages updating for this typo fix.

Re: [edk2] [PATCH 2/4] MdePkg/SmmIoLib: Add sample instance.

2017-04-23 Thread Fan, Jeff
Jiewen, Could the following ASSER() removed and let caller check the return value? Otherwise, there is no return on DEBUG build for this servcie. +if (!InValidRegion) { + DEBUG (( +DEBUG_ERROR, +"SmmIsMmioValid: Not in valid MMIO region: BaseAddress (0x%lx) - Length

Re: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: Handling return of write to sq and cq db

2017-04-23 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, > Hao A > Sent: Friday, April 21, 2017 9:39 AM > To: Suman Prakash; edk2-devel@lists.01.org > Cc: Tian, Feng > Subject: Re: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: Handling return > of