Re: [edk2] OVMF build fail because of missing Dictionary.py

2018-04-09 Thread Zhu, Yonghong
Hi Fan, The build failure issue was fixed, please help to check it. thanks. Best Regards, Zhu Yonghong -Original Message- From: Zhu, Yonghong Sent: Tuesday, April 10, 2018 2:02 PM To: 'Chen, Farrah' ; edk2-devel@lists.01.org Cc: Hu, Robert ; Guo, Xuelian ; Zhu, Yonghong Subject: RE: O

Re: [edk2] [PATCH v1 1/2] BaseTools: copy a dictionary from InfClassObject to BuildReport

2018-04-09 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Carsey, Jaben Sent: Wednesday, April 04, 2018 11:02 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: [PATCH v1 1/2] BaseTools: copy a dictionary from InfClassObject to BuildReport I

Re: [edk2] [PATCH] BaseTools: Remove EdkIIWorkspaceBuild.py from source code

2018-04-09 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Wednesday, April 04, 2018 1:53 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH] BaseTools: Remove EdkIIWorkspaceBuild.py from source code Remove EdkIIWorks

Re: [edk2] MdePkg: UefiTcgPlatform.h: Fix Startup Locality Indicator Definitions

2018-04-09 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Lin, Derek (HPS UEFI Dev) [mailto:derek.l...@hpe.com] > Sent: Tuesday, April 10, 2018 1:41 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Zhang, Chao B ; Lin, Derek (HPS UEFI Dev) > > Subject: MdePkg: Ue

Re: [edk2] OVMF build fail because of missing Dictionary.py

2018-04-09 Thread Zhu, Yonghong
Thanks. I will fix it soon. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen, Farrah Sent: Tuesday, April 10, 2018 1:55 PM To: edk2-devel@lists.01.org Cc: Hu, Robert ; Guo, Xuelian Subject: [edk2] OVMF build fail

[edk2] OVMF build fail because of missing Dictionary.py

2018-04-09 Thread Chen, Farrah
Hi, When we build OVMF, the following error occurred: File "/home/build/kvm_build/nightly/kvm-next-20180410123610-e01bca2f-915d34c5/kvm/edk2/BaseTools/Source/Python/Common/InfClassObject.py", line 25, in from Dictionary import * ImportError: No module named Dictionary It seems that Diction

[edk2] [Patch 1/2] SignedCapsulePkg/SystemFirmwareUpdateDxe: Single FMP

2018-04-09 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=928 Uninstall all System FMP Protocols for the current FW device. If an FMP Protocol for the current FW device is already present, then install the new System FMP protocol onto the same handle as the FMP Protocol. Otherwise, install the FMP protocol

[edk2] [Patch 0/2] SignedCapsulePkg/SystemFirmwareUpdate:

2018-04-09 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=928 * SystemFirmwareReportDxe: Only looks for System FMP Protocol on same handle as FMP Protocol * SystemFirmwareUpdateDxe: Do not allow multiple FMP Protocols to be installed for the same system firmware device. Cc: Jiewen Yao Signed-off-by: Mi

[edk2] [Patch 2/2] SignedCapsulePkg/SystemFirmwareReportDxe: Pass thru on same handle

2018-04-09 Thread Kinney, Michael D
https://bugzilla.tianocore.org/show_bug.cgi?id=928 Use HandleProtocol() to pass thru a SetImage() call to the System FMP Protocol that must be on the same handle as the FMP Protocol. Cc: Jiewen Yao Signed-off-by: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 --- .../

[edk2] MdePkg: UefiTcgPlatform.h: Fix Startup Locality Indicator Definitions

2018-04-09 Thread Lin, Derek (HPS UEFI Dev)
Fix Locality Indicator Definitions according to Table 8 of PC Client PTP 00.43. https://www.trustedcomputinggroup.org/wp-content/uploads/PC-Client-Specific-Platform-TPM-Profile-for-TPM-2-0-v43-150126.pdf Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chris Phillips --- Md

Re: [edk2] [PATCH 00/13] {Ovmf, Mde, Network, Crypto}Pkg: fixes+features for setting HTTPS cipher suites

2018-04-09 Thread Wu, Jiaxin
Hi Laszlo Appreciate your contribution. I have reviewed the series patches you attached here. First, I assume you have verified the patches on OVMF and the functionality works well, then, below are my comments: 1. The patches for OvmfPkg/NetworkPkg (0001-0004) are good to me. 2. For CryptoP

Re: [edk2] [PATCH] BaseTools: Parse PCD GUID name in FILE statement issue

2018-04-09 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Monday, April 09, 2018 11:31 AM To: edk2-devel@lists.01.org Cc: Feng, YunhuaX ; Gao, Liming Subject: [edk2] [PATCH] BaseTo

Re: [edk2] [PATCH v1 00/14] BaseTools: refactoring the code for readability and simplicity

2018-04-09 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben Carsey Sent: Friday, April 06, 2018 7:14 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v1 00/14] BaseTools: refactoring the code

Re: [edk2] [PATCH 04/13] NetworkPkg/TlsDxe: clean up byte order conversion for EfiTlsCipherList

2018-04-09 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 3, 2018 10:52 PM > To: edk2-devel-01 > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: [PATCH 04/13] NetworkPkg/TlsDxe: clean up byte order conversion > for EfiTlsCipherList > > Fi

Re: [edk2] [PATCH 03/13] NetworkPkg/TlsDxe: verify DataSize for EfiTlsCipherList

2018-04-09 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 3, 2018 10:52 PM > To: edk2-devel-01 > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: [PATCH 03/13] NetworkPkg/TlsDxe: verify DataSize for > EfiTlsCipherList > > TlsSetSessionDa

Re: [edk2] [PATCH 02/13] MdePkg/Include/Protocol/Tls.h: pack structures from the TLS RFC

2018-04-09 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 3, 2018 10:52 PM > To: edk2-devel-01 > Cc: Wu, Jiaxin ; Gao, Liming ; > Kinney, Michael D ; Fu, Siyuan > > Subject: [PATCH 02/13] MdePkg/Include/Protocol/Tls.h: pack struct

[edk2] [PATCH 3/3] BaseTools: fix --genfds-multi-thread generate makefile issue

2018-04-09 Thread Feng, YunhuaX
1. when inf file is binary module, not generate makefile, so need generate ffs with previous method. 2. generate Ui section maybe override and the string is not $(MODULE_NAME) like as: INF RuleOverride = UI MdeModulePkg/Application/UiApp/UiApp.inf 3. Trim generate incorrect Offset.raw when

[edk2] [PATCH 2/3] BaseTools: argument genfds-multi-thread create GenSec command issue

2018-04-09 Thread Feng, YunhuaX
Issue: genfds-multi-thread create makefile before section file generation, so it get alignment is zero from empty file. It is incorrect. solution: GenSec get section alignment from input file when the input alignment is zero. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore C

[edk2] [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue

2018-04-09 Thread Feng, YunhuaX
Free DummyFileBuffer and set DummyFileBuffer to NULL. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yunhua Feng --- BaseTools/Source/C/GenSec/GenSec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BaseTools/Sourc