Re: [edk2] [patch 2/4] Vlv2TbltDevicePkg: Remove DxeSmmPerformanceLib

Reviewed-by: David Wei Thanks, David Wei Intel SSG/STO/UEFI BIOS -Original Message- From: Bi, Dandan Sent: Monday, July 30, 2018 1:45 PM To: edk2-devel@lists.01.org Cc: Wei, David ; Guo, Mang ; Gao, Liming Subject: [patch 2/4] Vlv2TbltDevicePkg:

[edk2] [patch 3/4] ShellPkg: Remove DxeSmmPerformanceLib

DxeSmmPerformanceLib previously is used by DP tool. But in new pweformance infrastructure, we have updated Dp tool to get the performance data from firmware performance data table in ACPI. So remove the usage of DxeSmmPerformanceLib here. Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Liming Gao

[edk2] [patch 2/4] Vlv2TbltDevicePkg: Remove DxeSmmPerformanceLib

DxeSmmPerformanceLib previously is used by DP tool. But in new pweformance infrastructure, we have updated Dp tool to get the performance data from firmware performance data table in ACPI. So remove the usage of DxeSmmPerformanceLib here. Cc: David Wei Cc: Mang Guo Cc: Liming Gao

[edk2] [patch 0/4] Remove DxeSmmPerformanceLib

DxeSmmPerformanceLib previously is used by DP tool. But in new pweformance infrastructure, we have updated Dp tool to get the performance data from firmware performance data table in ACPI. Now the DxeSmmPerformanceLib is not used by any module. So remove it from edk2 code base to avoid being used

[edk2] [patch 4/4] MdeModulePkg: Remove DxeSmmPerformanceLib

DxeSmmPerformanceLib previously is used by DP tool. But in new pweformance infrastructure, we have updated Dp tool to get the performance data from firmware performance data table in ACPI. Now the DxeSmmPerformanceLib is not used by any module. So remove it from edk2 code base to avoid being used

[edk2] [patch 1/4] QuarkPlatformPkg: Remove DxeSmmPerformanceLib

DxeSmmPerformanceLib previously is used by DP tool. But in new pweformance infrastructure, we have updated Dp tool to get the performance data from firmware performance data table in ACPI. So remove the usage of DxeSmmPerformanceLib here. Cc: Michael D Kinney Cc: Kelly Steele Cc: Liming Gao

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

That proposal looks better. Mike > -Original Message- > From: Zeng, Star > Sent: Sunday, July 29, 2018 10:42 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg FmpDxe: Initialize >

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

Normally, FmpDeviceGetLowestSupportedVersion() should not touch input DeviceLibLowestSupportedVersion when returning an error. If we think it is legal that DeviceLibLowestSupportedVersion could be updated in an error case by FmpDeviceGetLowestSupportedVersion(), then we could only add new line

[edk2] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid possible NULL ptr dereference

Within function GetUefiMemoryAttributesTable(), add a check to avoid possible null pointer dereference. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 2 +- 1 file changed, 1 insertion(+), 1

[edk2] [PATCH 1/2] MdePkg/SmmMemLib: Avoid possible NULL ptr dereference

Within function SmmMemLibInternalGetUefiMemoryAttributesTable(), add a check to avoid possible null pointer dereference. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- MdePkg/Library/SmmMemLib/SmmMemLib.c | 2 +- 1 file changed, 1 insertion(+),

[edk2] [PATCH 0/2] Avoid possible NULL ptr dereference

Cc: Jiewen Yao Hao Wu (2): MdePkg/SmmMemLib: Avoid possible NULL ptr dereference UefiCpuPkg/PiSmmCpuDxeSmm: Avoid possible NULL ptr dereference MdePkg/Library/SmmMemLib/SmmMemLib.c | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 2 +- 2 files changed, 2

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

Star, I do not think the logic is identical. The function FmpDeviceGetLowestSupportedVersion() could modify the value of DeviceLibLowestSupportedVersion and return an error. Mike > -Original Message- > From: Zeng, Star > Sent: Sunday, July 29, 2018 7:51 PM > To:

Re: [edk2] [staging/FmpDevicePkg-master 0/8] Fix GenerateCapsule issues

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Kinney, Michael D Sent: Monday, July 30, 2018 2:08 AM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Yao, Jiewen ; Zhu, Yonghong ; Gao, Liming ; Kinney, Michael D Subject: [staging/FmpDevicePkg-master

[edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

Update the title to include "[staging/FmpDevicePkg-master]". Thanks, Star -Original Message- From: Zeng, Star Sent: Monday, July 30, 2018 10:50 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Kinney, Michael D Subject: [PATCH] FmpDevicePkg FmpDxe: Initialize

[edk2] [PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

Some static tool reports "DeviceLibLowestSupportedVersion" is used, but is uninitialized. It is false positive reporting based because DeviceLibLowestSupportedVersion will have assigned value after FmpDeviceGetLowestSupportedVersion() returns SUCCESS. This patch refines the code to initialize

[edk2] [patch 4/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix GCC build failure

Fix following GCC build issues: 1. xxx/SratParser.c:127:47: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] {L"Proximity Domain [31:8]", 3, 9, L"0x%x", DumpSratApicProximity, ^ xxx/SratParser.c:127:47: note:

[edk2] [patch 2/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 build failure

Fix following build error: UefiShellAcpiViewCommandLib\AcpiParser.c(519) : error C2308: concatenating mismatched strings Concatenating wide "ERROR: %a: Offset Mismatch for %s" with narrow "CurrentOffset = %d FieldOffset = %d" cc: Alexei Fedorov cc: Ruiyu Ni cc: Jaben Carsey Contributed-under:

[edk2] [patch 3/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS build failure

Fix following warnings: 1. xxx\GtdtParser.c(179): warning C4244: '=': conversion from 'UINT32' to 'UINT16', possible loss of data xxx\GtdtParser.c(180): warning C4244: '-=': conversion from 'UINT32' to 'UINT16', possible loss of data xxx\GtdtParser.c(196): warning C4244: '-=': conversion from

[edk2] [patch 1/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 build failure

Fix following build error: xxx\AcpiParser.c(487) : error C2275: 'UINTN' : illegal use of this type as an expression xxx\ProcessorBind.h(224) : see declaration of 'UINTN' xxx\AcpiParser.c(487) : error C2146: syntax error : missing ';' before identifier 'OriginalAttribute' xxx\AcpiParser.c(487) :

[edk2] [patch 0/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix build issues

Fix VS and GCC build failure issues cc: Alexei Fedorov cc: Ruiyu Ni cc: Jaben Carsey Dandan Bi (4): ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 build failure ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 build failure ShellPkg/UefiShellAcpiViewCommandLib: Fix VS build failure

Re: [edk2] [PATCH 1/6] MdePkg/UefiLib: introduce EfiOpenFileByDevicePath()

On 7/27/2018 8:06 PM, Laszlo Ersek wrote: On 07/27/18 11:28, Ni, Ruiyu wrote: On 7/19/2018 4:50 AM, Laszlo Ersek wrote: +  // +  // Traverse the device path nodes relative to the filesystem. +  // +  while (!IsDevicePathEnd (*FilePath)) { +    // +    // Keep local variables that relate to

[edk2] [staging/FmpDevicePkg-master 6/8] BaseTools/Capsule: Update file header with tool limitations

Update file header to state that the tool does not support: * Multiple payloads * Drivers * Vendor code bytes https://bugzilla.tianocore.org/show_bug.cgi?id=1031 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [staging/FmpDevicePkg-master 7/8] BaseTools/Capsule: Prevent traceback during signing operations

https://bugzilla.tianocore.org/show_bug.cgi?id=1046 https://bugzilla.tianocore.org/show_bug.cgi?id=1048 https://bugzilla.tianocore.org/show_bug.cgi?id=1050 Remove raise statements that generate Tracebacks that were only intended for development/debug. With the raise statements removed proper

[edk2] [staging/FmpDevicePkg-master 4/8] BaseTools/Capsule: Do not support -o with --dump-info

https://bugzilla.tianocore.org/show_bug.cgi?id=1025 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- BaseTools/Source/Python/Capsule/GenerateCapsule.py | 4 1 file changed, 4

[edk2] [staging/FmpDevicePkg-master 8/8] BaseTools/Capsule: Support capsules without a payload header

https://bugzilla.tianocore.org/show_bug.cgi?id=1028 Update --dump-info and --decode to show auth header infomation even if a payload header is not present. The --decode operation still fails if a payload header is not present. Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao

[edk2] [staging/FmpDevicePkg-master 5/8] BaseTools/Capsule: Update help for --fw-version and --lsv

Update help to state that --fw-version and -=-lsv are required for encode operations that sign a payload. https://bugzilla.tianocore.org/show_bug.cgi?id=1029 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [staging/FmpDevicePkg-master 3/8] BaseTools/Capsule: Fix CertType GUID byte order

https://bugzilla.tianocore.org/show_bug.cgi?id=1024 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- BaseTools/Source/Python/Common/Uefi/Capsule/FmpAuthHeader.py | 2 +- 1 file changed,

[edk2] [staging/FmpDevicePkg-master 2/8] BaseTools/Capsule: Remove support for PopulateSystemTable

https://bugzilla.tianocore.org/show_bug.cgi?id=1030 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney --- BaseTools/Source/Python/Capsule/GenerateCapsule.py | 8 +++- 1 file changed, 3

[edk2] [staging/FmpDevicePkg-master 0/8] Fix GenerateCapsule issues

https://bugzilla.tianocore.org/show_bug.cgi?id=1021 https://bugzilla.tianocore.org/show_bug.cgi?id=1022 https://bugzilla.tianocore.org/show_bug.cgi?id=1026 https://bugzilla.tianocore.org/show_bug.cgi?id=1030 https://bugzilla.tianocore.org/show_bug.cgi?id=1024

[edk2] [staging/FmpDevicePkg-master 1/8] BaseTools/Capsule: Add max value checks to Capsule Generation tools

https://bugzilla.tianocore.org/show_bug.cgi?id=1021 https://bugzilla.tianocore.org/show_bug.cgi?id=1022 https://bugzilla.tianocore.org/show_bug.cgi?id=1026 Cc: Sean Brogan Cc: Jiewen Yao Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [staging/FmpDevicePkg-master][PATCH V2] FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's declaration

Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Star Zeng > Sent: Saturday, July 28, 2018 6:51 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Zeng, Star > Subject: [edk2]