[edk2] [PATCH v4 12/13] OvmfPkg/LockBoxLib: Update the comments for API UpdateLockBox()

2019-02-10 Thread Hao Wu
The previous commit: MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox() adds the support to enlarge a LockBox when using the LockBoxLib API UpdateLockBox(). This commit is to sync the API description comment of UpdateLockBox() with its counterparts in MdeModulePkg. Cc: Laszlo

[edk2] [PATCH v4 10/13] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox()

2019-02-10 Thread Hao Wu
This commit is out of the scope for BZ-1409. It is a refinement for the PEI library instance within SmmLockBoxLib. For the below ASSERT statement within function RestoreLockBox(): Status = SmmCommunicationPpi->Communicate ( SmmCommunicationPpi,

[edk2] [PATCH v4 03/13] MdeModulePkg: Add definitions for Storage Security Command PPI

2019-02-10 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for Storage Security Command (SSC) PPI. This PPI will be be used to abstract mass storage devices to allow code running in the PEI phase to send security protocol commands to mass storage devices without s

[edk2] [PATCH v4 07/13] MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList LockBox

2019-02-10 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 For the NvmExpressPei driver, this commit will update the driver to consume the S3StorageDeviceInitList LockBox in S3 phase. The purpose is to perform an on-demand (partial) NVM Express device enumeration/initialization to benefit the S3 resu

[edk2] [PATCH v4 06/13] MdeModulePkg/NvmExpressPei: Add logic to produce SSC PPI

2019-02-10 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 For the NvmExpressPei driver, this commit will add codes to produce the Storage Security Command PPI if the underlying NVM Express controller supports the Security Send and Security Receive commands. Cc: Jian J Wang Cc: Ray Ni Cc: Eric Don

[edk2] [PATCH v4 05/13] MdeModulePkg/NvmExpressPei: Avoid updating the module-level variable

2019-02-10 Thread Hao Wu
This commit is out of the scope for BZ-1409. The commit will remove the call of RegisterForShadow() at the entry point of the driver. By doing so, the driver is now possible to be executed without being re-loaded into permanent memory. Thus, this commit will update the NvmExpressPei driver to avoi

[edk2] [PATCH v4 11/13] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()

2019-02-10 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the support to enlarge a LockBox when using the LockBoxLib API UpdateLockBox(). Please note that the new support will ONLY work for LockBox with attribute LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY set. The functional uni-te

[edk2] [PATCH v4 00/13] Split the S3 PEI phase HW init codes from Opal driver

2019-02-10 Thread Hao Wu
The series is also available at: https://github.com/hwu25/edk2/tree/opal_remodel_v4 V4 changes: As suggested by Laszlo, add a new patch to sync the API description comment for UpdateLockBox() in file "OvmfPkg/Library/LockBoxLib/LockBoxLib.c" with its counterparts in MdeModulePkg. For patch 13 (c

[edk2] [PATCH v4 09/13] MdeModulePkg/SmmLockBoxLib: Use 'DEBUG_' prefix instead of 'EFI_D_'

2019-02-10 Thread Hao Wu
This commit is out of the scope for BZ-1409. It is a coding style refinement for the SmmLockBoxLib. More specifically, the commit will remove all the debug message display level macros starting with 'EFI_D_' and replace them with macros starting with 'DEBUG_'. Cc: Jian J Wang Cc: Star Zeng Cont

[edk2] [PATCH v4 04/13] MdeModulePkg: Add GUID for LockBox to save storage dev to init in S3

2019-02-10 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the GUID definitions for LockBox which is used to save a list of storage devices that need to get initialized during the S3 resume. The content of the LockBox will be a DevicePath structure that contains zero or more Dev

[edk2] [PATCH v4 02/13] MdeModulePkg: Add definitions for EDKII PEI ATA PassThru PPI

2019-02-10 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for EDKII PEI ATA PassThru PPI. This PPI will provide services that allow ATA commands to be sent to ATA devices attached to an ATA controller in the PEI phase. More specifically, the PPI will provide ser

[edk2] [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Report StatusCode for device init failure

2019-02-10 Thread Hao Wu
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1408 According to the information of the above BZ-1408 and other platform owners, NVM Express devices are becoming more likely to be a critical part during the boot process. This commit will add the calls to 'REPORT_STATUS_COD

[edk2] [PATCH v4 01/13] MdeModulePkg: Add definitions for ATA AHCI host controller PPI

2019-02-10 Thread Hao Wu
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 This commit will add the definitions for ATA AHCI host controller PPI. The purpose of the PPI in to provide: * MMIO base address * Controller identification information (DevicePath) for ATA host controllers working under AHCI mode. Cc: Jia

[edk2] [PATCH] MdeModulePkg/CapsuleApp: Fix memory leak issue.

2019-02-10 Thread Chen A Chen
This issue is caused by FileInfoBuffer variable. This is a pointer array and each elements also pointer to a memory buffer that is allocated and returned by AllocateCopyPool function. Cc: Jian J Wang Cc: Hao Wu Cc: Zhang Chao B Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH] MdeModulePkg/CapsuleApp: Fix potential NULL pointer dereference issue

2019-02-10 Thread Chen A Chen
To avoid potential NULL pointer dereference issue. Initialize them at the beginning of the function. This patch is a supplement which was missed at e98212cb5d59fff8f385d9179ad7f1a3ce9cf215 commit. Cc: Jian J Wang Cc: Hao Wu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH] MdePkg: Change structure parameter types

2019-02-10 Thread Shenglei Zhang
Change parameter Opcode from UINT16 to UINTN in EFI_S3_SAVE_STATE_WRITE and EFI_S3_SAVE_STATE_INSERT. https://bugzilla.tianocore.org/show_bug.cgi?id=1517 Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- MdePkg/Include

Re: [edk2] [PATCH edk2-non-osi 1/1] Platform/Socionext: update TF-A binary to upstream release

2019-02-10 Thread Sumit Garg
On Sat, 9 Feb 2019 at 17:18, Ard Biesheuvel wrote: > > On Tue, 5 Feb 2019 at 09:01, Sumit Garg wrote: > > > > Update TF-A to upstream v2.0 release (Commit: dbc8d9496ead). Also update > > OP-TEE to upstream v3.4.0 release (Commit: 406c609bbf08). > > > > Contributed-under: TianoCore Contribution Ag

Re: [edk2] [PATCH] SecurityPkg/OpalPassword: Update strings on Opal Setup page

2019-02-10 Thread Dong, Eric
Hi Maggie, Thanks for your patch. Please also remember to clean up the code if it is not needed anymore, such as HiiGetDriverNameCB function and STR_MAIN_OPAL_VERSION string. Thanks, Eric > -Original Message- > From: Chu, Maggie > Sent: Friday, February 1, 2019 6:38 PM > To: edk2-deve

Re: [edk2] LocateProtocol - gEfiTcp4ServiceBindingProtocolGuid

2019-02-10 Thread Ye, Ting
Hi Ivan, The code you are using is not from EDKII trunk. You may ask the owner from the github for detailed info about the error. It looks to me that your platform does not include modules required by UEFI network stack. For example, TCP driver which producing Tcp4ServiceBindingProtocol is mis

Re: [edk2] [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 configuration during driver start.

2019-02-10 Thread Wu, Jiaxin
Agree, thanks the comment. I will update the patch. > -Original Message- > From: Ye, Ting > Sent: Monday, February 11, 2019 11:09 AM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Michael Turner ; Fu, Siyuan > > Subject: RE: [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 > confi

Re: [edk2] [PATCH v1] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 configuration during driver start.

2019-02-10 Thread Ye, Ting
Hi Jiaxin, I agree we need start IPv6 stack no matter the configuration is valid or not. However I would suggest to add more comments and pop up warning messages to let user know we continue to start IPv6 stack without using previously saved configuration. Thanks, Ting -Original Message--

Re: [edk2] [PATCH v1 0/2] Uninstall protocols when error happen in Driver Binding Start.

2019-02-10 Thread Ye, Ting
Series Reviewed-By: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Sunday, February 3, 2019 2:23 PM To: edk2-devel@lists.01.org Cc: Michael Turner ; Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [PATCH v1 0/2] Uninstall protocols when error happen in Driver Binding Start. REF: htt

[edk2] [PATCH v2 09/10] OptionRomPkg/ReadMe.txt: Remove CYGGCC

2019-02-10 Thread Shenglei Zhang
Remove CYGGCC in Build Validation. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Ray Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Laszlo Ersek --- OptionRomPkg/ReadMe.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Optio

[edk2] [PATCH v2 08/10] BaseTools/tools_def.template: Remove CYGGCC

2019-02-10 Thread Shenglei Zhang
CYGGCC is too old.There is no verification for it. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Laszlo Ersek --- BaseTools/Conf/tools_def.tem

[edk2] [PATCH v2 03/10] BaseTools/tools_def.template: Remove DDK3790

2019-02-10 Thread Shenglei Zhang
DDK3790 is too old.There is no verification for it. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- BaseTools/Conf/tools_def.template | 350 --

[edk2] [PATCH v2 02/10] OptionRomPkg/ReadMe.txt: Remove VS2005

2019-02-10 Thread Shenglei Zhang
Remove VS2005 in Build Validation. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Ray Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- OptionRomPkg/ReadMe.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/OptionRomPkg/ReadMe.txt b/Option

[edk2] [PATCH v2 10/10] BaseTools/build_rule.template: Remove GCCLD

2019-02-10 Thread Shenglei Zhang
GCCLD will be unused when UNIXGCC, CYGGCC and ELFGCC are removed. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- BaseTools/Conf/build_rule.template | 33

[edk2] [PATCH v2 07/10] BaseTools/tools_def.template: Remove ELFGCC

2019-02-10 Thread Shenglei Zhang
ELFGCC is too old.There is no verification for it. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- BaseTools/Conf/tools_def.template | 80

[edk2] [PATCH v2 06/10] BaseTools: Update MYTOOLS

2019-02-10 Thread Shenglei Zhang
Remove MYTOOLS in tools_def.template and change MYTOOLS to VS2015x86 in target.template. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- BaseTools/Conf/ta

[edk2] [PATCH v2 04/10] BaseTools/tools_def.template: Remove UNIXGCC

2019-02-10 Thread Shenglei Zhang
UNIXGCC is too old.There is no verification for it. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang Reviewed-by: Laszlo Ersek --- BaseTools/Conf/tools_def.te

[edk2] [PATCH v2 01/10] BaseTools/tools_def.template: Remove VS2003 and VS2005

2019-02-10 Thread Shenglei Zhang
VS2003 and VS2005 are too old.There is no verification for them. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang --- BaseTools/Conf/tools_def.template | 694 -

[edk2] [PATCH v2 05/10] OvmfPkg/README: Remove UNIXGCC

2019-02-10 Thread Shenglei Zhang
Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc and OvmfPkgX64.dsc. Remove content related to UNIXGCC in README. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Contributed-under: TianoCore Con

[edk2] [PATCH v2 00/10] Remove unused tool chain configuration

2019-02-10 Thread Shenglei Zhang
VS2003, VS2005, DDK3790, UNIXGCC, ELFGCC, CYGCC and MYTOOLS are too old. There is no verification for them. So remove them from edk2/master. https://bugzilla.tianocore.org/show_bug.cgi?id=1377 v2:1.Combine previous 05/10 and 06/10 to 05/10. 2.Add 10/10(Remove GCCLD). Cc: Bob Feng Cc: Liming G

Re: [edk2] [PATCH v2] CryptoPkg: Fix various typos

2019-02-10 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Antoine Coeur Sent: Friday, February 8, 2019 12:12 AM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v2] CryptoPkg: Fix various typos Fix various typos in CryptoPkg. Cont

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Fix a bug PPB MEM32 BAR isn't restored sometimes

2019-02-10 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, > Hao A > Sent: Thursday, February 07, 2019 10:18 AM > To: Ni, Ray; edk2-devel@lists.01.org > Cc: Bi, Dandan > Subject: Re: [edk2] [PATCH] MdeModulePkg/PciBus: Fix a bug PPB MEM32 BAR > isn't r

Re: [edk2] [PATCH] CorebootModulePkg: Fix various typos

2019-02-10 Thread You, Benjamin
Reviewed-by: Benjamin You > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Antoine Coeur > Sent: Thursday, February 7, 2019 12:47 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] CorebootModulePkg: Fix various typos > > Fix variou

Re: [edk2] [PATCH] CorebootPayloadPkg: Fix various typos

2019-02-10 Thread You, Benjamin
Reviewed-by: Benjamin You > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Antoine Coeur > Sent: Thursday, February 7, 2019 12:49 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] CorebootPayloadPkg: Fix various typos > > Fix variou

[edk2] [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Report StatusCode for device init failure

2019-02-10 Thread Hao Wu
From: Sean Brogan REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1408 According to the information of the above BZ-1408 and other platform owners, NVM Express devices are becoming more likely to be a critical part during the boot process. This commit will add the calls to 'REPORT_STATUS_COD

[edk2] [PATCH v1 0/1] MdeModulePkg/NvmExpressDxe: Report StatusCode for device init failure

2019-02-10 Thread Hao Wu
This patch is also available at: https://github.com/hwu25/edk2/tree/nvme_status_code Please refer to the log message of the patch for more details. Cc: Sean Brogan Cc: Bret Barkelew Cc: Jian J Wang Cc: Ray Ni Sean Brogan (1): MdeModulePkg/NvmExpressDxe: Report StatusCode for device init fa