Re: [edk2] [PATCH 06/10] OvmfPkg/Sec: Disable optimizations for TemporaryRamMigration

2019-02-17 Thread Ard Biesheuvel
On Mon, 18 Feb 2019 at 05:12, Jordan Justen wrote: > This needs an explanation why optimization needs to be disabled. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall >

[edk2] [patch edk2-wiki] Update ECC wiki page

2019-02-17 Thread Dandan Bi
Update ECC wiki page to record how to solve the problem “ModuleNotFoundError: No module named 'antlr4'” when run ECC tool with python3.x. Cc: Liming Gao Cc: Bob Feng Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- ECC-tool.md | 15 --- 1 file

[edk2] [PATCH 1/2] MdeModulePkg: Add a new API ResetSystem

2019-02-17 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API ResetSystem: VOID EFIAPI ResetSystem ( IN EFI_RESET_TYPE ResetType, IN EFI_STATUS ResetStatus, IN UINTNDataSize, IN VOID *ResetData

[edk2] [PATCH 2/2] MdeModulePkg: Add a runtime library instance of ResetSystemLib

2019-02-17 Thread Zhichao Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1461 For now there is no ResetSystemLib instance that can be linked against Runtime driver. And it's improper to extend the existing DxeResetSystemLib to support Runtime driver because no one converts gRT when entering RT phase.

[edk2] [PATCH 0/2] ResetSystemLib changings

2019-02-17 Thread Zhichao Gao
Add a new API ResetSystem in ResetSystemLib. Implement a runtime library instance of ResetSystemLib. The runtime library instance is base on the new API implementation. Cc: Liming Gao Cc: Ray Ni Zhichao Gao (2): MdeModulePkg: Add a new API ResetSystem MdeModulePkg: Add a runtime library

[edk2] [PATCH] IntelSiliconPkg/MicrocodeUpdateDxe: Error message enhancement

2019-02-17 Thread Shenglei Zhang
The error message of ExtendedTableCount is not clear. Add the count number into the debug message. https://bugzilla.tianocore.org/show_bug.cgi?id=1500 Cc: Ray Ni Cc: Rangasai V Chaganty Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Shenglei Zhang ---

Re: [edk2] [PATCH v5 06/13] MdeModulePkg/NvmExpressPei: Add logic to produce SSC PPI

2019-02-17 Thread Dong, Eric
Hi Hao, Got it. In this case, Reviewed-by: Eric Dongfor 6,7,8 patches. Thanks, Eric > -Original Message- > From: Wu, Hao A > Sent: Monday, February 18, 2019 2:07 PM > To: Dong, Eric ; edk2-devel@lists.01.org > Cc: Wang, Jian J ; Ni, Ray > Subject: RE: [PATCH v5 06/13]

[edk2] [PATCH] BaseTools:Fix a ECC issue

2019-02-17 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1522 A property error occurred because the property of the function was not defined. a property is now redefined. Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan ---

[edk2] [PATCH V2] BaseTools:BaseTools supports to the driver combination.

2019-02-17 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1520 To save the image size without the compression, more than one drivers can be combined into single one. When more than one drivers are combined, their depex will be AND together. Below is the example to combine BootManagerPolicyDxe into

Re: [edk2] [PATCH v5 06/13] MdeModulePkg/NvmExpressPei: Add logic to produce SSC PPI

2019-02-17 Thread Wu, Hao A
> -Original Message- > From: Dong, Eric > Sent: Monday, February 18, 2019 10:59 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wang, Jian J; Ni, Ray > Subject: RE: [PATCH v5 06/13] MdeModulePkg/NvmExpressPei: Add logic to > produce SSC PPI > > Hi Hao, > > > -Original Message-

Re: [edk2] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe Fix eMMC HS400 switch sequence

2019-02-17 Thread Wu, Hao A
Hi Mateusz, I found that the patch proposed is actually handling one of the issues reported in the below BZ tracker: https://bugzilla.tianocore.org/show_bug.cgi?id=1140 According to the discussion within the tracker, there are 2 fixes needed for the SdMmcPciHcDxe: 1. Move the clock supply before

Re: [edk2] [PATCH] UefiCpuPkg/Microcode: Fix incorrect checksum issue for extended table

2019-02-17 Thread Yao, Jiewen
Hi ChenChen Thanks! Do you think we also need fix IntelSiliconPkg\Feature\Capsule\MicrocodeUpdateDxe? Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Chen A Chen > Sent: Monday, February 18, 2019 1:54 PM > To:

[edk2] [PATCH] UefiCpuPkg/Microcode: Fix incorrect checksum issue for extended table

2019-02-17 Thread Chen A Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1020 The following Microcode payload format is define in SDM spec. Payload: |MicrocodeHeader|MicrocodeBinary|ExtendedHeader|ExtendedTable|. When we verify the CheckSum32 with ExtendedTable, we should use the fields of ExtendedTable to replace

Re: [edk2] [PATCH] MdeModulePkg[MdePkg]: Add a new API EfiResetSystem()

2019-02-17 Thread Gao, Liming
Zhichao: Based on BZ description, new API should be ResetSystem(). Please clarify it with BZ submitter. Thanks Liming >-Original Message- >From: Gao, Zhichao >Sent: Monday, February 18, 2019 11:17 AM >To: edk2-devel@lists.01.org >Cc: Ni, Ray ; Gao, Liming >Subject: [PATCH]

[edk2] [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration

2019-02-17 Thread Jordan Justen
https://github.com/jljusten/edk2.git temp-ram-support This series fixes an issue that, while rare, is possible based on the way the TemporaryRamSupport PPI is defined along with how it is used by the PEI Core. Liu Yu reported a boot issue with EmulatorPkg, which I believe was caused by this

[edk2] [PATCH 05/10] OvmfPkg/Sec: Swap TemporaryRam Stack and Heap locations

2019-02-17 Thread Jordan Justen
Apparently something depends on the heap being above the stack after TemporaryRamMigration. This is the opposite order that OVMF has always used for TempRam before migration to permanent ram. In 42a83e80f37c (svn r10770), Mike changed OVMF's TemporaryRamMigration to swap the locations of heap and

[edk2] [PATCH 04/10] EmulatorPkg/Sec: Disable optimizations for TemporaryRamMigration function

2019-02-17 Thread Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jordan Justen Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/Sec/Sec.c | 12 1 file changed, 12 insertions(+) diff --git a/EmulatorPkg/Sec/Sec.c b/EmulatorPkg/Sec/Sec.c index bd61e5ac4a..7d5534cb67 100644 ---

[edk2] [PATCH 03/10] EmulatorPkg/Sec: Replace assembly temp-ram support with C code

2019-02-17 Thread Jordan Justen
OvmfPkg uses similar code based on SetJump/LongJump. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jordan Justen Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/Sec/Ia32/SwitchRam.S | 95 -- EmulatorPkg/Sec/Ia32/SwitchRam.asm | 94

[edk2] [PATCH 02/10] EmulatorPkg/Unix/Host: Use PcdInitValueInTempStack to init temp-ram

2019-02-17 Thread Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jordan Justen Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/Unix/Host/Host.c | 2 +- EmulatorPkg/Unix/Host/Host.inf | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/EmulatorPkg/Unix/Host/Host.c

[edk2] [PATCH 08/10] MdeModulePkg/Core/Pei: Use assembly for X64 TemporaryRamMigration

2019-02-17 Thread Jordan Justen
Some compilers may optimize register usage in ways that are incompatible with the TemporaryRamSupport PPI. Using assembly code to call the TemporaryRamMigration function prevents this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jordan Justen Cc: Jian J Wang Cc:

[edk2] [PATCH 09/10] MdeModulePkg/Core/Pei: Use assembly for IA32 TemporaryRamMigration

2019-02-17 Thread Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jordan Justen Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng --- .../Dispatcher/Ia32/TemporaryRamMigration.S | 72 + .../Ia32/TemporaryRamMigration.nasm | 78 +++

[edk2] [PATCH 07/10] MdeModePkg/Core/Pei: Add code path to allow assembly temp-ram migration

2019-02-17 Thread Jordan Justen
There is potential problem with PEI Core's usage of the TemporaryRamMigration PPI. When the TemporaryRamMigration function is called, it returns to C based code after changing the stack to the new permanent memory copy of the stack. But, the C compiler may have stored pointers to addresses on the

[edk2] [PATCH 06/10] OvmfPkg/Sec: Disable optimizations for TemporaryRamMigration

2019-02-17 Thread Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall --- OvmfPkg/Sec/SecMain.c | 12 1 file changed, 12 insertions(+) diff --git a/OvmfPkg/Sec/SecMain.c

[edk2] [PATCH 10/10] OvmfPkg/Sec: Fill Temp Ram after TemporaryRamMigration

2019-02-17 Thread Jordan Justen
On some platforms, the TemporaryRamMigration PPI may cause Temporary RAM to become inaccessible after the RAM is migrated. To emulate this in OVMF, we should initialize memory to a bad state to make sure it isn't accidentally being used after TemporaryRamMigration is called. I tested IA32 booting

[edk2] [PATCH 01/10] EmulatorPkg/build.sh: Fix missing usage of -b BUILDTARGET parameter

2019-02-17 Thread Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jordan Justen Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/build.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh index 2ddcd4..2af6b5f998

[edk2] [PATCH] MdeModulePkg[MdePkg]: Add a new API EfiResetSystem()

2019-02-17 Thread Zhichao Gao
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1460 Add a new API EfiReesetSystem(): VOID EFIAPI EfiResetSystem ( IN EFI_RESET_TYPE ResetType, IN EFI_STATUS ResetStatus, IN UINTNDataSize, IN VOID *ResetData

Re: [edk2] [PATCH v5 07/13] MdeModulePkg/NvmExpressPei: Consume S3StorageDeviceInitList LockBox

2019-02-17 Thread Dong, Eric
Hi Hao, > -Original Message- > From: Wu, Hao A > Sent: Friday, February 15, 2019 2:24 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Ni, Ray ; Dong, Eric > Subject: [PATCH v5 07/13] MdeModulePkg/NvmExpressPei: Consume > S3StorageDeviceInitList LockBox > >

Re: [edk2] [PATCH v5 06/13] MdeModulePkg/NvmExpressPei: Add logic to produce SSC PPI

2019-02-17 Thread Dong, Eric
Hi Hao, > -Original Message- > From: Wu, Hao A > Sent: Friday, February 15, 2019 2:24 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Ni, Ray ; Dong, Eric > Subject: [PATCH v5 06/13] MdeModulePkg/NvmExpressPei: Add logic to > produce SSC PPI > >

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths

2019-02-17 Thread Wu, Hao A
Hello Jeff, Sorry for the delayed response. I have verified your patch with the board on my side and it is working fine. And I saw around 3~4 milliseconds performance boost. So I think the patch will bring performance benefit to the driver. Some minor inline comments below: From: Jeff Brasen

Re: [edk2] [patch V2] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-17 Thread Bi, Dandan
> -Original Message- > From: Zeng, Star > Sent: Friday, February 15, 2019 5:25 PM > To: Bi, Dandan ; edk2-devel@lists.01.org > Cc: Wu, Hao A ; Michael Turner > ; Max Knutsen > ; Gao, Liming ; Zeng, > Star > Subject: RE: [edk2] [patch V2] MdeModulePkg/ReportStatusCodeLib: Avoid > using

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2019-02-17 Thread Jordan Justen
On 2019-02-17 18:25:01, Ni, Ray wrote: > Jordan, > > Study the PeiCore migration logic a bit more, I found since PeiCore > > knows the exact size of new stack in permanent memory, it migrates > > old stack to the top of new stack. > > But the migration logic in above C code (since it doesn't

[edk2] [patch V3] MdeModulePkg/ReportStatusCodeLib: Avoid using AllocatePool if possible

2019-02-17 Thread Dandan Bi
From: Max Knutsen REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1114 V2: simplify the code logic. update if (!mHaveExitedBootServices && (StatusCodeData != (EFI_STATUS_CODE_DATA *) StatusCodeBuffer)) { gBS->FreePool (StatusCodeData); } to if (StatusCodeData != (EFI_STATUS_CODE_DATA *)

Re: [edk2] EmulatorPkg Unix Host Segmentation fault.

2019-02-17 Thread Ni, Ray
Jordan, > Study the PeiCore migration logic a bit more, I found since PeiCore > knows the exact size of new stack in permanent memory, it migrates > old stack to the top of new stack. > But the migration logic in above C code (since it doesn't know the > size of new stack, CopySize is the size of

Re: [edk2] [PATCH v5 04/13] MdeModulePkg: Add GUID for LockBox to save storage dev to init in S3

2019-02-17 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wu, Hao A > Sent: Friday, February 15, 2019 2:23 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Dong, Eric > Subject: [PATCH v5 04/13] MdeModulePkg: Add GUID for LockBox to save > storage dev to init in S3 > >

Re: [edk2] [PATCH v5 03/13] MdeModulePkg: Add definitions for Storage Security Command PPI

2019-02-17 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wu, Hao A > Sent: Friday, February 15, 2019 2:23 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Dong, Eric > Subject: [PATCH v5 03/13] MdeModulePkg: Add definitions for Storage > Security Command PPI > >

Re: [edk2] [PATCH v5 02/13] MdeModulePkg: Add definitions for EDKII PEI ATA PassThru PPI

2019-02-17 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wu, Hao A > Sent: Friday, February 15, 2019 2:23 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Dong, Eric > Subject: [PATCH v5 02/13] MdeModulePkg: Add definitions for EDKII PEI ATA > PassThru PPI > >

Re: [edk2] [PATCH v5 01/13] MdeModulePkg: Add definitions for ATA AHCI host controller PPI

2019-02-17 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Wu, Hao A > Sent: Friday, February 15, 2019 2:23 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Wang, Jian J ; > Dong, Eric > Subject: [PATCH v5 01/13] MdeModulePkg: Add definitions for ATA AHCI > host controller PPI > >

Re: [edk2] [PATCH v3] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 configuration during driver start.

2019-02-17 Thread Fu, Siyuan
Reviewed-by: Siyuan Fu > -Original Message- > From: Wu, Jiaxin > Sent: Monday, February 18, 2019 9:15 AM > To: edk2-devel@lists.01.org > Cc: Michael Turner ; Ye, Ting > ; Fu, Siyuan ; Wu, Jiaxin > > Subject: [PATCH v3] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 configuration > during

[edk2] [PATCH v3] NetworkPkg/Ip6Dxe: Clean the invalid IPv6 configuration during driver start.

2019-02-17 Thread Jiaxin Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1448 *v3: Change the if condition check to only clean the invalid configuration. *v2: Add the warning debug message. This patch is to clean the invalid data and continue to start IP6 driver. Cc: Michael Turner Cc: Ye Ting Cc: Fu Siyuan

Re: [edk2] [PATCH] Maintainers: add TPM2 reviewers for OvmfPkg

2019-02-17 Thread Julien Grall
Hi Leif, On 2/11/19 1:06 PM, Leif Lindholm wrote: On Mon, Feb 11, 2019 at 01:53:43PM +0100, Laszlo Ersek wrote: OVMF can be built with a significant amount of TPM2 code now; add Marc-André and Stefan as Reviewers for TPM2-related patches. Keep the list of "R" entries alphabetically sorted.