Re: [edk2] [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-27 Thread Gao, Zhichao
Thanks for your comments. I will update base on 1, 2, 3. I have tested on Nt32Pkg and OvmfPkg to replace the PEIM debug lib with the new one and add MdeModulePkg/Universal/DebugServicePei/DebugServicePei.inf with the original PEIM DebugLib to dsc and fdf file. The PEIMs which use the DebugLib

Re: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib

2019-03-27 Thread Gao, Zhichao
Sorry for late reply. I have write a very simple test case for these new APIs. And the test result is as expected. Refer to https://github.com/ZhichaoGao/edk2/commit/31938b606c6a6a1fdb560e3d0dd4e41a78e1d7e9 The section to test VerifyEKUsInPkcs7Signature is refer to

[edk2] [PATCH V3] BaseTools:Trim will trig exception when input asl UTF8 format file

2019-03-27 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1641 The command trim --asl-file -o test.i UTF8.asl will trig the exception. There's a problem with the encoding of the file,it only appears in python3. I changed the way I opened it to support reading this file Cc: Bob Feng Cc: Liming Gao

Re: [edk2] [PATCH V2] BaseTools:Trim will trig exception when input asl UTF8 format file

2019-03-27 Thread Gao, Liming
What error message is reported? >-Original Message- >From: Fan, ZhijuX >Sent: Thursday, March 28, 2019 10:13 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Feng, Bob C >Subject: [edk2][PATCH V2] BaseTools:Trim will trig exception when input asl >UTF8 format file >

[edk2] [PATCH V2] BaseTools:Trim will trig exception when input asl UTF8 format file

2019-03-27 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1641 The command trim --asl-file -o test.i UTF8.asl will trig the exception. Trim tool should report error message for unsupported UTF8 file instead of the exception. Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH V4 12/17] IntelFramworkModulePkg/PeiDxeDebugLibReportStatusCode: Add new APIs

2019-03-27 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Gao, Zhichao >Sent: Thursday, March 21, 2019 10:05 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming ; Sean Brogan >; Michael Turner >; Bret Barkelew > >Subject: [PATCH V4 12/17] >IntelFramworkModulePkg/PeiDxeDebugLibReportStatusCode: Add

Re: [edk2] [PATCH V4 15/17] MdeModulePkg: Add a PEIM to install Debug PPI

2019-03-27 Thread Gao, Liming
Zhichao: One .c file is enough for this PEIM. You can implement all in one C file. Thanks Liming >-Original Message- >From: Gao, Zhichao >Sent: Thursday, March 21, 2019 10:05 PM >To: edk2-devel@lists.01.org >Cc: Wang, Jian J ; Wu, Hao A ; >Ni, Ray ; Zeng, Star ; Gao, Liming >; Sean

Re: [edk2] [PATCH V4 16/17] MdeModulePkg/PeiDebugLibDebugPpi: Add PEI debug lib

2019-03-27 Thread Gao, Liming
Zhichao: For new library instance, I have some comments. 1) DebugPrint(). If DebugPpi is not found, directly return instead of CpuDeadLoop(). 2) DebugAssert(). If DebugPpi is not found, bases on PcdDebugPropertyMask value to trig CpuDeadLoop() or CpuBreakPoint(). 3) Please rename mDebugPpi

Re: [edk2] Build SCT with edk2

2019-03-27 Thread Richardson, Brian
Have you tried building with the most recent stable tag instead of the tip? https://github.com/tianocore/edk2/releases/tag/edk2-stable201903 Thanks ... br --- Brian Richardson - brian.richard...@intel.com -- @intel_brian Director of Ecosystem & Business Development, Firmware Integration &

[edk2] Build SCT with edk2

2019-03-27 Thread Ashish Singhal
Hello, It seems building SCT is supported with edk2 UDK2017 and not something recent. When I tried building it with tip, it fails. Is someone already working on making sure SCT can be built with edk2 tip? Thanks Ashish

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

2019-03-27 Thread Ard Biesheuvel
On Tue, 29 Jan 2019 at 14:55, Ryszard Knop wrote: > > +Team > As it turns out, this driver is still broken for non-1:1 mapped DMA. In particular, I am hitting a crash on E1000MemCopy ( (UINT8 *) (UINTN) CpbReceive->BufferAddr, (UINT8 *) (UINTN)

Re: [edk2] [PATCH edk2-platforms] Platform/Hisilicon: update D06 system firmware description

2019-03-27 Thread Ard Biesheuvel
On Tue, 26 Mar 2019 at 21:22, Leif Lindholm wrote: > > Since the D06 port now depends on updated IMP firmware to function > properly, there needs to be a one-way upgrade path. Upgrade to the > current state of things must happen via .hpm. Subsequent capsule updates > cannot be permitted to go