If V4 64 bit address mode is enabled in compatibility register,
program controller to enable V4 host mode and use appropriate
ADMA descriptors supporting 64 bit addresses.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdeModulePkg/Bus/Pci
check as
spec for previous SDMMC versions defines this field as reserved with
default value of 0.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 4 ++--
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe
as in patch 1/4, I am OK submitting a new
patch where I can squash 1/4 and 3/4 together into a single commit and keep API
as in 1/4.
Thanks
Ashish
-Original Message-
From: Gao, Liming
Sent: Sunday, January 6, 2019 5:33 PM
To: Ashish Singhal ; edk2-devel@lists.01.org
Subject: RE: [edk2
During cleanup in case of initialization failure, some driver
bindings are not installed. Using abstractions in UEFILib takes
care of it.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1428
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
in the future. Bug 1429 was found to track this. The first 2 patches
take care of this.
Patch number 1 also simplifies the UEFILib protocol installation and
uninstallation abstraction by adding a helper function doing operations
instead of every public function.
Ashish Singhal (2):
MdePkg
it by itself.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1429
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdePkg/Include/Library/UefiLib.h | 103 +++
MdePkg/Library/UefiLib/UefiDriverModel.c | 1186 --
2
From: Wu, Hao A
Sent: Friday, November 30, 2018 1:03:15 AM
To: Ashish Singhal; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v6 2/2] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4
and above Support.
Hello,
Please refer to the inline comments below:
> -Original Mess
appropriately.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c| 2 +-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 4 +-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 21 +-
MdeModulePkg/Bus
Hello Hao,
Do you happen to have any update on this?
Thanks
Ashish
-Original Message-
From: Wu, Hao A
Sent: Tuesday, December 18, 2018 6:47 PM
To: Ashish Singhal ; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v7] MdeModulePkg/SdMmcPciHcDxe: Add SDMMC HC v4 and
above Support
No problem. Please let me know when you have reviewed it and I will send the
final patch with your name as reviewer.
Thanks
Ashish
From: Wu, Hao A
Sent: Tuesday, December 18, 2018 6:46:57 PM
To: Ashish Singhal; edk2-devel@lists.01.org
Subject: RE: [edk2
Missed one of your suggested compiler related change in Patch 5. Have posted
patch 6.
Thanks
Ashish Singhal
-Original Message-
From: Ashish Singhal
Sent: Thursday, November 29, 2018 11:48 AM
To: 'Wu, Hao A' ; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v3 2/2] MdeModulePkg
appropriately.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1359
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 4 +-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 328
check as
spec for previous SDMMC versions defines this field as reserved with
default value of 0.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1359
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
, November 28, 2018 12:25 AM
To: Ashish Singhal ; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v3 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit
SDMA and ADMA2 support.
Hello,
Sorry for the delayed response.
Apart from inserting the Bugzilla tracker information, several more general
level
Hello,
Any feedback on this patch yet?
Thanks
Ashish
-Original Message-
From: Ashish Singhal
Sent: Monday, November 19, 2018 1:59 PM
To: edk2-devel@lists.01.org
Cc: Ashish Singhal
Subject: [PATCH v3 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit SDMA and ADMA2
support.
If V4 64 bit
Separate V4 1/2 patch has been submitted with changes made as per feedback.
Thanks
Ashish
-Original Message-
From: Wu, Hao A
Sent: Wednesday, November 28, 2018 12:25 AM
To: Ashish Singhal ; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v3 1/2] MdeModulePkg/SdMmcPciHcDxe: Declare
check as
spec for previous SDMMC versions defines this field as reserved with
default value of 0.
Change-Id: I64fcb674ec566c46a37ea6597ae06cb194625cae
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 4
: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 4 +-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 273 +
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 28 ++-
3 files changed, 260
with and without enabling 64b
addressing support.
Thanks
Ashish
-Original Message-
From: Wu, Hao A
Sent: Friday, November 16, 2018 1:27 AM
To: Ashish Singhal ; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Add V4 64bit ADMA2
support.
> -Original Mess
: Tuesday, January 8, 2019 7:58 PM
To: Ashish Singhal ; edk2-devel@lists.01.org; Gao,
Liming ; Fu, Siyuan ; Wu, Jiaxin
; Kinney, Michael D
Subject: RE: [PATCH v3 0/2] Provide UEFILib functions for protocol
uninstallation.
Ashish,
When I do full platform builds and individual driver builds
v4.
Please let me know if you have any issues with this going in.
Thanks
Ashish
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, January 9, 2019 5:56 PM
To: Ashish Singhal ; edk2-devel@lists.01.org; Kinney,
Michael D
Cc: Gao, Liming ; Fu, Siyuan ; Wu,
Jiaxin
Subject: RE
Siyuan approved the patch from PATCH v2 which is exactly same
as in PATCH v4.
Thanks
Ashish
-Original Message-
From: Gao, Liming
Sent: Thursday, January 10, 2019 8:23 AM
To: Ashish Singhal ; Kinney, Michael D
; edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Wu, Jiaxin
Subject: RE: [PATCH v4
Thanks everyone.
-Original Message-
From: Gao, Liming
Sent: Thursday, January 10, 2019 8:39 AM
To: Ashish Singhal ; Kinney, Michael D
; edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Wu, Jiaxin
Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol
uninstallation
Pushed them
Use UEFILib provided protocol uninstallation abstraction
instead of direct API for a proper cleanup.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1444
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
NetworkPkg/DnsDxe/DnsDriver.c | 30
+ Maintainers
-Original Message-
From: Ashish Singhal
Sent: Sunday, January 6, 2019 9:38 PM
To: edk2-devel@lists.01.org
Cc: Ashish Singhal
Subject: [PATCH v3 0/2] Provide UEFILib functions for protocol uninstallation.
An issue was seen in IScsiDxe in NetworkPkg where driver cleanup
at
was used to install.
Thanks,
Mike
> -Original Message-
> From: Ashish Singhal [mailto:ashishsin...@nvidia.com]
> Sent: Monday, January 7, 2019 6:02 AM
> To: edk2-devel@lists.01.org; Kinney, Michael D
> ; Gao, Liming ; Fu,
> Siyuan ; Wu, Jiaxin
> Subject: RE: [PATCH
Add a helper function to operate upon protocol installation and
uninstallation instead of every function doing it by itself.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdePkg/Include/Library/UefiLib.h | 26 +-
MdePkg/Library/UefiLib
During cleanup in case of initialization failure, some driver
bindings are not installed. Using abstractions in UEFILib takes
care of it.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1428
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
Update interfaces as exposed by UEFILib for protocol
installation and uninstallation abstraction.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
NetworkPkg/IScsiDxe/IScsiDriver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NetworkPkg
uninstallation interfaces as a result of patch 3.
Ashish Singhal (4):
MdePkg/UefiLib: Abstract driver model protocol uninstallation
NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols.
MdePkg/UefiLib: Simplify protocol un/installation abstraction
NetworkPkg/IScsiDxe: Update UEFILib Usage
-off-by: Ashish Singhal
---
MdePkg/Include/Library/UefiLib.h | 103
MdePkg/Library/UefiLib/UefiDriverModel.c | 972 ++-
2 files changed, 1074 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
Thanks Mike. Please let me know if you have any more questions and/or comments.
Thanks
Ashish
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, January 8, 2019 9:26 AM
To: Ashish Singhal ; edk2-devel@lists.01.org; Gao,
Liming ; Fu, Siyuan ; Wu, Jiaxin
; Kinney, Michael D
it yet) also absorb the change?
Thanks
Ashish
From: Kinney, Michael D
Sent: Friday, January 4, 2019 10:15 AM
To: Ashish Singhal ; edk2-devel@lists.01.org; Kinney,
Michael D
Cc: Gao, Liming ; Fu, Siyuan ; Wu,
Jiaxin
Subject: RE: Uninstalling Invalid Protocol Interfaces
Ashish,
Thanks
Thanks Jiaxin. Please let me know if anything else is needed to mainline it.
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, January 10, 2019 6:01 PM
To: Ashish Singhal ; edk2-devel@lists.01.org
Cc: Fu, Siyuan
Subject: RE: [PATCH] NetworkPkg: Protocol Uninstallation Cleanup
Looks
in the future. Bug 1429 was found to track this. These 2 patches
take care of this.
Ashish Singhal (2):
MdePkg/UefiLib: Abstract driver model protocol uninstallation
NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols.
MdePkg/Include/Library/UefiLib.h | 103
MdePkg
-off-by: Ashish Singhal
---
MdePkg/Include/Library/UefiLib.h | 103
MdePkg/Library/UefiLib/UefiDriverModel.c | 972 ++-
2 files changed, 1074 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
During cleanup in case of initialization failure, some driver
bindings are not installed. Using abstractions in UEFILib takes
care of it.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1428
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
, January 3, 2019 5:09 PM
To: Ashish Singhal ; edk2-devel@lists.01.org; Kinney,
Michael D
Cc: Gao, Liming ; Fu, Siyuan ; Wu,
Jiaxin
Subject: RE: Uninstalling Invalid Protocol Interfaces
Hi Ashish,
Can you provide a pointer to the UninstallMultipleProtocolInterfaces() call
that is causing
appropriately.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1359
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
Reviewed-by: Hao Wu
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c| 3 +-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 5
Hello Hao,
I have submitted patch v8 which incorporates all the changes.
Thanks
Ashish
-Original Message-
From: Wu, Hao A
Sent: Tuesday, January 1, 2019 11:37 PM
To: Wu, Hao A ; Ashish Singhal ;
edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v7] MdeModulePkg/SdMmcPciHcDxe: Add
Hello,
As part of moving from MdeModulePkg implementation of IScsiDxe to the
implementation in NetworkPkg, I started hitting exception in the driver loaded
after IScsiDxe if IScsiDxe's installation fails for some reason. Upon
debugging, I found out that calls to
During cleanup in case of initialization failure, some driver
bindings are not installed. Using abstractions in UEFILib takes
care of it.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1428
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
uninstallation interfaces as a result of patch 3.
Ashish Singhal (4):
MdePkg/UefiLib: Abstract driver model protocol uninstallation
NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols.
MdePkg/UefiLib: Simplify protocol un/installation abstraction
NetworkPkg/IScsiDxe: Update UEFILib Usage
Add a helper function to operate upon protocol installation and
uninstallation instead of every function doing it by itself.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdePkg/Include/Library/UefiLib.h | 26 +-
MdePkg/Library/UefiLib
-off-by: Ashish Singhal
---
MdePkg/Include/Library/UefiLib.h | 103
MdePkg/Library/UefiLib/UefiDriverModel.c | 972 ++-
2 files changed, 1074 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
Update interfaces as exposed by UEFILib for protocol
installation and uninstallation abstraction.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
NetworkPkg/IScsiDxe/IScsiDriver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NetworkPkg
Mike,
I have addressed the issue along with some optimizations and have submitted
patches for review.
Thanks
Ashish
From: Ashish Singhal
Sent: Friday, January 4, 2019 10:33 AM
To: 'Kinney, Michael D' ; edk2-devel@lists.01.org
Cc: Gao, Liming ; Fu, Siyuan ; Wu,
Jiaxin
Subject: RE
Hello,
It seems building SCT is supported with edk2 UDK2017 and not something recent.
When I tried building it with tip, it fails. Is someone already working on
making sure SCT can be built with edk2 tip?
Thanks
Ashish
Mike,
Do you have any update on this change yet?
Thanks
Ashish
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, February 19, 2019 12:56 PM
To: Ashish Singhal ; edk2-devel@lists.01.org; Kinney,
Michael D
Cc: Gao, Liming
Subject: RE: [PATCH] MdePkg/UefiLib: Simplify protocol
.
Thanks
Ashish
-Original Message-
From: Cohen, Eugene
Sent: Thursday, February 28, 2019 4:24 AM
To: Wu, Hao A ; edk2-devel@lists.01.org
Cc: Ashish Singhal
Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit
systems
Hao,
> I remember the com
Support64BitDma = FALSE;
}
With this, we would be checking 64b capability based on the version we are
using and not for something we may not be using despite of being advertised in
the controller.
Thanks
Ashish
From: Cohen, Eugene
Sent: Thursday, February 28, 2019 2:59 PM
To: Ashish Singha
kef>
From: Cohen, Eugene
Sent: Thursday, February 28, 2019 5:11 PM
To: Ashish Singhal; Wu, Hao A; edk2-devel@lists.01.org; Ard Biesheuvel
Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit
systems
Ashish,
Agreed - #2 would be better in the long run
ULL
);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_WARN, "SdMmcPciHcDriverBindingStart: failed to enable
64-bit DMA (%r)\n", Status));
}
}
Thanks
Ashish
From: Cohen, Eugene
Sent: Thursday, February 28, 2019 12:56 PM
To: Ashish Singhal ; Wu, Hao A ;
edk
. This will take
maybe a day or two and can be done.
Thanks
Ashish
From: Cohen, Eugene
Sent: Thursday, February 28, 2019 3:40 PM
To: Ashish Singhal ; Wu, Hao A ;
edk2-devel@lists.01.org; Ard Biesheuvel
Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit
systems
Ashish,
I
-by: Ashish Singhal
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 10 +-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 +-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 199 ++---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 29 ++-
4 files changed
Eugene,
I have submitted a patch for supporting 64b DMA on V3 controllers. Can you
please validate it at your end as well?
Thanks
Ashish
From: Ashish Singhal
Sent: Friday, March 1, 2019 5:31 AM
To: Ard Biesheuvel ; Cohen, Eugene
Cc: Wu, Hao A ; edk2-devel@lists.01.org; Kim, Sangwoo (김상우
Liming,
I am OK waiting till the freeze is over.
Thanks
Ashish
-Original Message-
From: Gao, Liming
Sent: Saturday, March 2, 2019 9:01 AM
To: Ashish Singhal ; edk2-devel@lists.01.org
Cc: Wu, Hao A
Subject: RE: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3 64b DMA Support
Ashish
sense.
Eugene,
Please let me know once you have tried my patch on your board.
Thanks
Ashish
-Original Message-
From: Wu, Hao A
Sent: Sunday, March 3, 2019 7:39 PM
To: Cohen, Eugene ; Ashish Singhal ;
Ard Biesheuvel
Cc: edk2-devel@lists.01.org; Kim, Sangwoo (??? SW1Lab.)
Subject: RE
been verified to work on hardware.
Ashish Singhal (2):
DynamicTablesPkg/DynamicTableManagerDxe: Update DEPEX
DynamicTablesPkg/AcpiSpcrLibArm: Support 16550 UART.
.../Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 4 +++-
DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm
Add support for 16550 UART to ACPI SPCR table as it is a
supported UART type by HLOS.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
DynamicTableManagerDxe initialization fails if
gEdkiiDynamicTableFactoryProtocolGuid,
gEdkiiConfigurationManagerProtocolGuid and
gEfiAcpiTableProtocolGuid are not already available.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
.../Drivers
Hi Hao,
That is right. Also, I have addressed your comments and have submitted v2 patch.
Thanks
Ashish
-Original Message-
From: Wu, Hao A
Sent: Tuesday, March 5, 2019 8:01 PM
To: Ashish Singhal ; edk2-devel@lists.01.org
Cc: eug...@hp.com
Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe
-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 10 +-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 +-
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 189 ++---
MdeModulePkg/Bus/Pci
Hi Eugene,
Thanks for confirming. Can you please validate the v2 patch I sent as well for
completeness?
Thanks
Ashish
From: Cohen, Eugene
Sent: Wednesday, March 6, 2019 4:05 PM
To: Wu, Hao A ; Ashish Singhal ;
edk2-devel@lists.01.org
Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Add V3
Ok with me.
Get Outlook for iOS<https://aka.ms/o0ukef>
From: Ard Biesheuvel
Sent: Tuesday, March 5, 2019 6:39 AM
To: Wu, Hao A
Cc: edk2-devel@lists.01.org; Eugene Cohen; Ashish Singhal
Subject: Re: [PATCH v2 0/1] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on S
I've already started refactoring the driver to support V3 64b ADMA2.
Meanwhile, I'm OK with the proposed patch.
Thanks
Ashish
Get Outlook for iOS<https://aka.ms/o0ukef>
From: Ard Biesheuvel
Sent: Friday, March 1, 2019 4:40 AM
To: Cohen, Eugene
Cc:
Acked-by: Ashish Singhal
-Original Message-
From: Ard Biesheuvel
Sent: Friday, March 1, 2019 4:39 AM
To: Cohen, Eugene
Cc: Ashish Singhal ; Wu, Hao A ;
edk2-devel@lists.01.org; Kim, Sangwoo (김상우 SW1Lab.)
Subject: Re: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit
Hello Mike/Lao,
Were you able to have a look at this?
Thanks
Ashish
-Original Message-
From: Ashish Singhal
Sent: Monday, February 4, 2019 1:16 PM
To: edk2-devel@lists.01.org
Cc: michael.d.kin...@intel.com; liming@intel.com; Ashish Singhal
Subject: [PATCH] MdePkg/UefiLib
Hello Michael/Liming,
I am trying to use FmpDevicePkg for FMP based capsule update and am failing in
FmpPayloadHeaderLib while verifying FMP payload header. I am building capsule
and payload using FDF file itself and not calling Capsule tools explicitly from
basetools. Is there a special build
Add helper functions to operate upon protocol installation and
uninstallation instead of every function doing it by itself.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal
---
MdePkg/Library/UefiLib/UefiDriverModel.c | 2040 +-
1
Mike,
I have refactored my change and with this I am not seeing any size bloating in
DEBUG or RELEASE images I am building for my platform. The new change has been
submitted for consideration.
Thanks
Ashish
-Original Message-
From: Ashish Singhal
Sent: Tuesday, January 8, 2019 8:02
71 matches
Mail list logo
