Hi Star,
Yes. That's right. I missed the Ps2KeyboardDxe in MdeModulePkg.
I will send new patch to cover this driver. Thank you for your comments.
Regards,
Dandan
-Original Message-
From: Zeng, Star
Sent: Monday, June 19, 2017 10:41 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
C
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 5, 2017 2:49 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Gao, Liming
Subject: RE: [RFC v2 1/2] BaseTool/VfrCompile: Support Union type in VFR
Dandan,
Is it possible to avoid adding IsUnion member variable?
I remember .G syntax
Hi Ray,
I can update the logic in VfrCompiler to avoid using gUnionTypeStructure. New
patches will send out.
Thanks for your comments.
Regards,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 5, 2017 10:35 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Gao
Reviewed-by: Dandan Bi
-Original Message-
From: Zhang, Chao B
Sent: Thursday, April 6, 2017 3:21 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zhang, Chao B
Subject: [PATCH] SecurityPkg: SecureBootConfigDxe: Update CloseEnrolledFile
comment
Update function CloseEnrolledFile comment
Hi Liming,
It seems no need to change the comments in the implementation codes.
The comments in the implementation codes are correct.
Thanks,
Dandan
-Original Message-
From: Gao, Liming
Sent: Tuesday, March 14, 2017 12:23 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Dong
Hi Xiaofeng,
Do you have any comments on this patch?
This patch is to fix the bug you reported
(https://bugzilla.tianocore.org/show_bug.cgi?id=358).
Could you help to verify on your platform? Thank you very much!
Regards,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-bou
Jordan
Justen
Sent: Wednesday, February 8, 2017 2:49 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Laszlo Ersek ; Gao, Liming
Subject: Re: [edk2] [patch] OvmfPkg/QemuBootOrderLib: Fix NOOPT build failure
On 2017-02-07 21:55:52, Dandan Bi wrote:
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> C
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Monday, January 9, 2017 10:06 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Bi, Dandan ; Yao,
Jiewen ; Zhang, Chao B
Subject: [PATCH] SecurityPkg Tcg2ConfigDxe: Typecast to (CHAR8*) as para of
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zhang, Chao B
Sent: Friday, January 6, 2017 9:17 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zhang, Chao B
Subject: [PATCH] SecurityPkg: Tcg2ConfigDxe: Remove duplicate local variable
Remove duplicate local status
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang,
Chao B
Sent: Thursday, January 5, 2017 10:18 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zhang, Chao B
Subject: [edk2] [PATCH 1/2] SecuritPkg
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Fan, Jeff
Sent: Thursday, December 29, 2016 9:31 AM
To: edk2-devel@lists.01.org
Cc: Tian, Feng ; Bi, Dandan
Subject: [PATCH] UefiCpuPkg/MpInitLib: Set initialize value of TimerPeriod
This fix is to pass VS2010/VS2012
rd.biesheu...@linaro.org]
Sent: Thursday, December 15, 2016 7:41 PM
To: Bi, Dandan
Cc: edk2-devel@lists.01.org; Ni, Ruiyu
Subject: Re: [patch 2/2] MdeModulePkg/NonDiscoverablePciDevice: Make variable
definition follow rule
On 15 December 2016 at 07:11, Dandan Bi wrote:
> Cc: Ard Biesheuvel
&
Yes, I will do the enhancements base on the latest codes and re-send patches.
Thanks,
Dandan
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, December 15, 2016 3:46 PM
To: Bi, Dandan ; Ni, Ruiyu
Cc: edk2-devel@lists.01.org
Subject: Re: [patch 1
Got it ! I will submit a new patch. Thanks!
Regards,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Friday, December 9, 2016 8:58 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
Subject: RE: [patch 2/8] FatPkg\EnhancedFatDxe: Initialize variable after
declaration
Dandan,
Could you please
Reviewed-by: Dandan Bi
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Thursday, December 8, 2016 4:17 PM
To: edk2-devel@lists.01.org; Ni, Ruiyu
Cc: Ard Biesheuvel
Subject: [edk2] [PATCH] MdeModulePkg/NonDiscoverablePciDevi
Got it ! I will enhance the logic! Thanks!
Regards,
Dandan
From: Yao, Jiewen
Sent: Friday, November 25, 2016 10:01 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Pete Batard
Subject: RE: [patch] MdeModulePkg: Fix GCC build failure
Thanks
I am OK on most part.
However, I think we had
Yes, that's right! I will update it. Thanks!
Thanks,
Dandan
-Original Message-
From: Yao, Jiewen
Sent: Monday, November 21, 2016 9:29 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: RE: [edk2] [patch] MdeModulePkg/DxeCapsuleLibFmp: Use AllocatePoo
sword
sample in DriverSample driver? You may consider add such sample in some
SecurityPkg driver.
Thanks
Liming
-Original Message-
From: Bi, Dandan
Sent: Thursday, November 17, 2016 10:26 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Dong, Eric ; Yao,
Jiewen ; Tian, Feng ; Zeng,
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng Tian
Sent: Tuesday, November 15, 2016 1:10 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [edk2] [patch] MdeModulePkg/Emmc: coding style update
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, November 15, 2016 9:57 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH] ShellPkg: #ifndef of header files should have postfix
underscore
Contributed-under: TianoCore Contribution
Yes! I will correct them and send a V2 patch.
Thanks,
Dandan
-Original Message-
From: Long, Qin
Sent: Thursday, November 10, 2016 4:25 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Subject: RE: [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the
function
Dandan,
Could you
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, October 25, 2016 10:18 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH v2 2/3] MdeModulePkg/GraphicsOutputDxe.inf: Correct the
protocol/GUID usages
Contributed-under: TianoCore
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, October 20, 2016 10:01 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH 3/3] MdeModulePkg/HiiDatabaseDxe.inf: Correct the GUID usages
Contributed-under: TianoCore Contribution
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Thursday, October 20, 2016 10:01 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [edk2] [PATCH 1/3] MdeModulePkg: Add
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zhang, Chao B
Sent: Friday, October 21, 2016 1:25 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Long, Qin ; Zhang,
Chao B
Subject: [PATCH] SecurityPkg: SmmTcg2PhysicalPresenceLib: Fix coding style issue
Fix coding
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, October 20, 2016 9:50 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Fu, Siyuan
Subject: [Patch] NetworkPkg: Coding style refine for IpSecDxe
Cc: Bi Dandan
Cc: Fu Siyuan
Contributed-under
] MdeModulePkg/BMMUI: ...
Hi Liming/Eric
Please review the new patches and ignore this one. Sorry for any
inconvenience.
Regards,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, October 14, 2016 8:34 PM
To: Bi, Dandan ; edk2-de...@ml01.01.org
Cc: Dong, Eric
Ok! Thank you for your comments! I will send patch with V2 for review.
Thanks,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, September 22, 2016 9:07 AM
To: Bi, Dandan
Cc: edk2-de...@ml01.01.org; Justen, Jordan L ; Gao,
Liming
Subject: Re
Reviewed-by: Dandan Bi
-Original Message-
From: Gao, Liming
Sent: Wednesday, September 21, 2016 10:39 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Bi, Dandan
Subject: [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new
EFI_HII_IIBT_IMAGE_PNG type Image
HiiImage protocol
Reviewed-by: Dandan Bi
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, September 21, 2016 10:39 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Dong, Eric
Subject: [edk2] [Patch 1/3] MdePkg UefiHii: Add IMAGE_TOKEN
Our codes have already checked for "too few " case, and it will print " Too few
arguments" in this situation.
Thanks,
Dandan
-Original Message-
From: Carsey, Jaben
Sent: Thursday, September 1, 2016 12:12 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Ca
Reviewed-by: Dandan Bi
-Original Message-
From: Fan, Jeff
Sent: Friday, August 19, 2016 11:08 AM
To: edk2-de...@ml01.01.org
Cc: Ni, Ruiyu ; Bi, Dandan
Subject: [Patch v5] DuetPkg: Add DxeMpInitLib instance reference
Cc: Ruiyu Ni
Cc: Dandan Bi
Contributed-under: TianoCore
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Tuesday, July 19, 2016 10:27 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH] ShellPkg: Fix VS2010/2012 build failure
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by
Liming,
Got it! Thanks for your comments! I will update the patch!
Thanks,
Dandan
-Original Message-
From: Gao, Liming
Sent: Thursday, July 7, 2016 9:51 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: RE: [patch 2/2] IntelFrameworkModulePkg/LegacyUi: Get legacy
: Bi, Dandan ; edk2-de...@ml01.01.org
Cc: Dong, Eric ; Gao, Liming
Subject: Re: [edk2] [patch 0/2] Connect all devices in UiApp if needed
On 06/16/16 03:37, Dandan Bi wrote:
> Do the connect all action in UiApp if needed, and no need to do the
> connect action in other UI library.
>
>
Reviewed-by: Dandan Bi
-Original Message-
From: Zhang, Chao B
Sent: Thursday, June 16, 2016 2:26 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zhang, Chao B
Subject: [PATCH] SecurityPkg: SecurityPkg.uni: Update info string for
PcdTcgPhysicalPresenceInterfaceVer
Update Pcd info
Hi Cecil,
Thanks for your comments!
I agree with you proposal.
Hi All,
I will send a new patch to remove the useless code.
Please ignore this one!
Thanks,
Dandan
-Original Message-
From: Sheng, Cecil (HPS SW) [mailto:cecil.sh...@hpe.com]
Sent: Friday, May 20, 2016 7:52 AM
To: Bi
A minor comment:
There are some whitespace in the line " typedef struct _EFI_HII_IIBT_PNG_BLOCK
{ " and the line below " (C) Copyright 2016 Hewlett Packard Enterprise
Development LP ".
Please remove them when commit the patch. You can use the patch check tool
(BaseTools\Scripts\PatchCheck.py) t
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Samer
El-Haj-Mahmoud
Sent: Thursday, May 12, 2016 4:31 AM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Samer El-Haj-Mahmoud
; Gao, Liming
Subject: [edk
Liming:
Thanks for your comments! I will update the code and send a new version later.
Thanks,
Dandan
-Original Message-
From: Gao, Liming
Sent: Monday, April 25, 2016 3:22 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: RE: [patch] MdeModulePkg/HiiDatabaseDxe
Hi Cecil,
I have some comments for this patch.
1. For HiiFontEx.h
(1) The members name in the structure of _EFI_HII_FONT_EX_PROTOCOL are not
consistent with spec:
In spec :
typedef struct _EFI_HII_FONT_EX_PROTOCOL {
EFI_HII_STRING_TO_IMAGE_EX StringToI
Hi Laszlo,
Please help to commit these patches. Thanks!
Thanks,
Dandan
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Thursday, March 24, 2016 11:29 AM
To: Bi, Dandan
Cc: edk2-de...@ml01.01.org; Laszlo Ersek
Subject: Re: [edk2] [PATCH 2/2] SecurityPkg
For the series:
Reviewed-by: Dandan Bi
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Monday, March 21, 2016 5:05 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Laszlo Ersek
Subject: [PATCH 1/2] SecurityPkg/SecureBootConfigDxe: Declare EFIAPI for the
ChooseFile
o:ler...@redhat.com]
Sent: Monday, March 21, 2016 4:29 PM
To: Gary Lin ; edk2-de...@ml01.01.org
Cc: Bi, Dandan
Subject: Re: [edk2] [PATCH] SecurityPkg/SecureBootConfigDxe: Declare EFIAPI for
the ChooseFile handlers
Hi Gary,
On 03/21/16 09:00, Gary Lin wrote:
> The SecureBootConfig now uses Ch
ssage-
From: Sheng, Cecil (HPS SW) [mailto:cecil.sh...@hpe.com]
Sent: Wednesday, March 2, 2016 10:58 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Gao, Liming
Subject: RE: [edk2] [PATCH] MdePkg: Add UEFI2.6 HII Image Ex and Image Decoder
protocol definition.
Hi Dandan,
Thanks for
PM
To: Bi, Dandan ; edk2-de...@ml01.01.org
Cc: Qiu, Shumin ; Dong, Eric ;
Zhang, Chao B
Subject: Re: [edk2] [PATCH v2] SecurityPkg: SecureBootConfigDxe: Enhance the
code logic
On 03/02/16 04:39, Dandan Bi wrote:
> The function AllocateCopyPool may return NULL, so need to do check
>
Thanks for the comments! I will update the patch.
Thanks,
Dandan
-Original Message-
From: Zhang, Chao B
Sent: Tuesday, March 1, 2016 9:56 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Qiu, Shumin ; Dong, Eric
Subject: RE: [patch] SecurityPkg: SecureBootConfigDxe: Enhance the code
Hi Cecil,
I have some comments for this patch:
For EFI_HII_IMAGE_DECODER_PROTOCOL:
(1) There is a typo, it is EFI_HII_IMAGE_DECODER_PROTOCOL not
EFI_HII_IMAGE_DECO(R)DER_PROTOCOL, please double check to remove all the
incorrect case.
(2) EFI_HII_IMAGE_DECODER_PROTOCOL_GUID is not defin
5:45 PM
To: Bi, Dandan; edk2-de...@ml01.01.org
Cc: Ard Biesheuvel; Dong, Eric
Subject: Re: [patch] ArmVirPkg: Add FileExplorerLib.inf to the dsc file
Dandan,
On 02/25/16 08:26, Dandan Bi wrote:
> Because SecureBootConfigDxe use FileExplorerLib now, but
> FileExplorerLib is not in the dsc
, 2016 1:18 PM
To: Bi, Dandan; edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: RE: [patch] MdeModulePkg: Fix the build fail issue on VS2008
Reviewed-by: Liming Gao
-Original Message-
From: Bi, Dandan
Sent: Wednesday, February 24, 2016 1:08 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Dong
Hi Laszlo,
Thank you very much for giving me the comment and information! I will pay
attention to this!
Thanks,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, February 22, 2016 6:18 PM
To: Bi, Dandan; edk2-de...@ml01.01.org
Cc: Gao, Liming; Dong
Hi Liming,
Thanks for your comments! I will refine the patch and new version will send out
later.
Thanks,
Dandan
-Original Message-
From: Gao, Liming
Sent: Monday, February 22, 2016 5:52 PM
To: Bi, Dandan; edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: RE: [patch 2/2] MdeModulePkg
Hi Laszlo,
Thanks for your suggestions! I can add the FileExplorerLib to the
[LibraryClasses.common.DXE_DRIVER] section. I will send new patch to review.
Thanks,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, February 02, 2016 4:37 PM
To: Bi
...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Tuesday, February 02, 2016 4:41 PM
To: Bi, Dandan
Cc: edk2-de...@ml01.01.org; Dong, Eric; Zhang, Chao B
Subject: Re: [edk2] [patch 0/6] Use FileExplorerLib in SecureBootConfigDxe
On 02/02/16 03:17, Dandan Bi wrote:
> Using existing libr
Reviewed-by: Dandan Bi
-Original Message-
From: Zhang, Chao B
Sent: Friday, January 29, 2016 4:47 PM
To: edk2-de...@ml01.01.org
Cc: Yao, Jiewen; Bi, Dandan; Zhang, Chao B
Subject: [PATCH] SecurityPkg: TcgConfigDxe: Move TPM state string update to
CallBack function
TPM state string
1:45 PM
To: Bi, Dandan; Dong, Eric; ler...@redhat.com; edk2-devel@lists.01.org
Subject: RE: [patch 6/6] SecurityPkg:Use FileExplorerLib in SecureBootConfigDxe
Dandan:
1. The copyright head file change is not right.
2. Do we need to update NT32Pkg.dsc & Quark Platform dsc?
Other changes are
Hi Chao:
Thanks for your comments! I will update the check in log and give the specific
UI behavior changes.
Thanks,
Dandan
-Original Message-
From: Zhang, Chao B
Sent: Monday, February 1, 2016 10:10 PM
To: Bi, Dandan; Laszlo Ersek
Cc: Dong, Eric; edk2-de...@ml01.01.org
Subject: RE
Hi Laszlo,
Thanks for your comments. I will update the related package.dsc files, and new
patch series will send out later.
Thanks,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, February 1, 2016 5:22 PM
To: Bi, Dandan
Cc: Zhang, Chao B; Dong
Reviewed-by：Dandan Bi
-Original Message-
From: Kinney, Michael D
Sent: Thursday, January 21, 2016 9:31 AM
To: edk2-devel@lists.01.org
Cc: Steele, Kelly; Bi, Dandan
Subject: [Patch] QuarkPlatformPkg/Quark.dsc: Update for rename of UI libraries
Rename the Ui libraries,so need to update
Thanks for your comments. I will update the code and send patches later.
Thanks,
Dandan
-Original Message-
From: Gao, Liming
Sent: Wednesday, November 18, 2015 5:11 PM
To: Bi, Dandan; Dong, Eric; edk2-devel@lists.01.org
Subject: RE: [patch 0/7]MdeModulePkg:UiApp remodeling task
Dandan
-
From: Justen, Jordan L
Sent: Tuesday, July 28, 2015 2:33 AM
To: Bi, Dandan; Dong, Eric; Gao, Liming; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup
browser pop-up message box
On 2015-07-26 23:57:27, Bi, Dandan wrote:
> > .../Uni
e.
Thanks,
Dandan
-Original Message-
From: Justen, Jordan L
Sent: Monday, July 27, 2015 2:31 PM
To: Bi, Dandan; Dong, Eric; Gao, Liming; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH v2] MdeModulePkg:Add ESC key support in setup
browser pop-up message box
On 2015-07-26 22:19:04, Dan
101 - 162 of 162 matches
Mail list logo
