Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for "gPatchxxx"

Laszlo, I think I would rather see the ECC tool fixed. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Thursday, April 12, 2018 2:34 AM > To: Bi, Dandan ; edk2- > de...@lists.01.org > Cc:

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; > Gao, Liming <liming@intel.com>; Laszlo Ersek > <ler...@redhat.com>; udit.ku...@nxp.com > Subject: [PATCH] MdePkg: add big-endian MMIO > BaseBeIoLib > > When performing MMIO to

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

when built for that CPU would perform big endian operations. Am I missing something? Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Leif Lindholm > Sent: Friday, April 13, 2018 12:32 PM > To: Kinney, Michael D

[edk2] [Patch 1/2] SignedCapsulePkg/SystemFirmwareUpdateDxe: Single FMP

https://bugzilla.tianocore.org/show_bug.cgi?id=928 Uninstall all System FMP Protocols for the current FW device. If an FMP Protocol for the current FW device is already present, then install the new System FMP protocol onto the same handle as the FMP Protocol. Otherwise, install the FMP

[edk2] [Patch 0/2] SignedCapsulePkg/SystemFirmwareUpdate:

wen@intel.com> Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Kinney, Michael D (2): SignedCapsulePkg/SystemFirmwareUpdateDxe: Single FMP SignedCapsulePkg/SystemFirmwareReportDxe: Pass thru on same handle .../SystemFi

[edk2] [Patch 2/2] SignedCapsulePkg/SystemFirmwareReportDxe: Pass thru on same handle

https://bugzilla.tianocore.org/show_bug.cgi?id=928 Use HandleProtocol() to pass thru a SetImage() call to the System FMP Protocol that must be on the same handle as the FMP Protocol. Cc: Jiewen Yao Signed-off-by: Michael D Kinney

Re: [edk2] [Patch 9/9] SignedCapsulePkg/SystemFirmwareUpdateDxe: Use progress API

age- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, April 6, 2018 6:55 AM > To: Kinney, Michael D <michael.d.kin...@intel.com> > Cc: edk2-devel@lists.01.org; Yao, Jiewen > <jiewen@intel.com> > Subject: Re: [edk2] [Patch 9/9] > SignedCap

Re: [edk2] [PATCH V2] MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls

Ni, Ruiyu <ruiyu...@intel.com>; Yi Li > <phoenix.l...@huawei.com>; Dong, Eric > <eric.d...@intel.com>; Renhao Liang > <liangren...@huawei.com>; Gao, Liming > <liming@intel.com>; Heyi Guo <heyi@linaro.org>; > Kinney, Michael D <michael.d.k

[edk2] [Patch V2 2/9] MdeModulePkg: Add DisplayUpdateProgressLib instances

From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Add DisplayUpdateProgressLib instances for text consoles and graphical

[edk2] [Patch V2 5/9] MdeModulePkg/DxeCapsuleLibFmp: Add progress bar support

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport * Change Update_Image_Progress() to UpdateImageProcess() * Call DisplayUpdateProgressLib from UpdateImageProgress(). * Split out

[edk2] [Patch V2 3/9] Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib mapping

From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Sean Brogan Cc: David Wei

[edk2] [Patch V2 8/9] QuarkPlatformPkg/PlatformFlashAccessLib: Add progress API

From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware

[edk2] [Patch V2 7/9] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress API

From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware

[edk2] [Patch V2 9/9] SignedCapsulePkg/SystemFirmwareUpdateDxe: Use progress API

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Use PlatformFlashWriteWithProgress() instead of PlatformFLashWrite() so the user can be informed of the progress as a capsule is used to update a firmware image in a firmware device. Cc: Jiewen Yao Signed-off-by: Michael D

[edk2] [Patch V2 6/9] SignedCapsulePkg/PlatformFlashAccessLib: Add progress API

From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add a new API to the PlatformFlashAccessLib that passes in an optional Progress() function along with a start and end percentage to call the Progress() function with. If the Progress() function

[edk2] [Patch V2 4/9] QuarkPlatformPkg: Add DisplayUpdateProgressLib mapping

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Sean Brogan Cc: Kelly Steele Signed-off-by: Michael D Kinney

[edk2] [edk2-platforms Patch V2 4/6] AMD/OverdriveBoard: Add DisplayUpdateProgressLib mapping

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney

[edk2] [edk2-platforms Patch V2 2/6] Hisilicon/PlatformFlashAccessLib: Add progress API

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: Ard Biesheuvel

[edk2] [edk2-platforms Patch V2 1/6] Styx/PlatformFlashAccessLib: Add progress API

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: Ard Biesheuvel

[edk2] [edk2-platforms Patch V2 5/6] Socionext/DeveloperBox: Add DisplayUpdateProgressLib mapping

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney

[edk2] [edk2-platforms Patch V2 6/6] Socionext/SynQuacerEvalBoard: Add DisplayUpdateProgressLib mapping

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Michael D Kinney

Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Dandan Bi, Is it possible to move the enter/exit event signaling into the FormBrowwer SendForm() function? The current patch set adds these signal calls in all the places that SendForm() is called and if one of these is missed, a notification will be missed. Mike > -Original Message-

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

I have also posted a branch for review. https://github.com/mdkinney/edk2/tree/Bug_801_DisplayUpdateProgressLib_V2 Mike > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, April 11, 2018 5:48 PM > To: edk2-devel@lists.01.org > Cc: Sean Brogan <sean.br

[edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

om> Contributed-under: TianoCore Contribution Agreement 1.1 Kinney, Michael D (3): QuarkPlatformPkg: Add DisplayUpdateProgressLib mapping MdeModulePkg/DxeCapsuleLibFmp: Add progress bar support SignedCapsulePkg/SystemFirmwareUpdateDxe: Use progress API Michael D Kinney (6): MdeModulePkg: A

[edk2] [Patch V2 1/9] MdeModulePkg: Add DisplayUpdateProgressLib class

From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=801 Based on content from the following branch/commits: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport Add the DisplayUpdateProgressLib class that is used to inform the user of

[edk2] [edk2-platforms Patch V2 3/6] SynQuacer/PlatformFlashAccessLib: Add progress API

https://bugzilla.tianocore.org/show_bug.cgi?id=801 Add PerformFlashWriteWithProgress() to the PlatformFlashAccessLib. This allows the platform to inform the user of progress when a firmware storage device is being updated with a new firmware image. Cc: Ard Biesheuvel

[edk2] [edk2-platforms Patch V2 0/6] Add DisplayUpdateProgressLib for capsules

bar provided by DxeCapsuleLibFmp and DisplayUpdateProgressLib. Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: Leif Lindholm <leif.lindh...@linaro.org> Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Ki

Re: [edk2] [edk2-platforms Patch V2 3/6] SynQuacer/PlatformFlashAccessLib: Add progress API

Ard, I agree. I mentioned it in the patch summary. I will add it to the commit log for each patch. Thanks, Mike > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, April 11, 2018 11:18 PM > To: Kinney, Michael D &l

Re: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek to stewards

om>; Laszlo Ersek > <ler...@redhat.com>; Kinney, Michael D > <michael.d.kin...@intel.com> > Subject: [PATCH] Maintainers.txt: add Laszlo Ersek to > stewards > > Cc: Andrew Fish <af...@apple.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: M

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, April 17, 2018 6:27 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; > Gao, Liming <liming@intel.com>; Laszlo Ersek > <ler...@redhat.com> > Cc: edk2-devel@li

Re: [edk2] [RFC v2 0/4] Add FmpDevicePkg

was built and is only used when the LowestSupportedVersion value is not available from any other source. Mike > -Original Message- > From: Zeng, Star > Sent: Thursday, April 19, 2018 9:53 PM > To: Yao, Jiewen <jiewen@intel.com>; Kinney, Michael > D <michael.d.kin.

Re: [edk2] [RFC v2 0/4] Add FmpDevicePkg

How about: LowestSupportedVersionCheckRequired() LockFmpDeviceAtLockEventGuidRequired() Mike > -Original Message- > From: Yao, Jiewen > Sent: Thursday, April 19, 2018 9:18 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; > edk2-devel@lists.01.org > C

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

FMP consumers on the same handle as the FMP Protocol so the rules for usage are clear from a consumer perspective. Mike > -Original Message- > From: Zeng, Star > Sent: Thursday, April 19, 2018 9:51 PM > To: Yao, Jiewen <jiewen....@intel.com>; Kinney, Michael

Re: [edk2] [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

Jiewen, Thanks for the reminder. I will add a 32-bit Version field. Mike > -Original Message- > From: Yao, Jiewen > Sent: Thursday, April 19, 2018 9:23 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; > edk2-devel@lists.01.org > Cc: Sean Brogan &l

Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib

I/O. Use BaseIoLib * BE CPU, BE I/O. Use BaseIoLib * LE CPU, BE I/O. Use BaseIoSwapLib * BE CPU, LE I/O. Use BaseIoSwapLib Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, April 16, 2018 3:07 AM > To: Kinney, Michael D <m

Re: [edk2] [PATCH] SignedCapsulePkg SystemFirmwareUpdateDxe: Fix failure caused by d69d922

Star, Thanks for fixing these issues. Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> Mike > -Original Message- > From: Yao, Jiewen > Sent: Sunday, April 15, 2018 6:49 PM > To: Zeng, Star <star.z...@intel.com>; edk2- > de...@lists.01.

[edk2] [RFC v2 2/4] FmpDevicePkg: Add library instances

https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Add library instances for FmpDeviceLib, CapsuleUpdatePolicyLib, and FmpPayloadHeaderLib. Library Classes

[edk2] [RFC v2 0/4] Add FmpDevicePkg

Protocol instance is customized using libraries and PCDs. Cc: Sean Brogan <sean.bro...@microsoft.com> Cc: Jiewen Yao <jiewen@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> Kinney, Michael D (4):

[edk2] [RFC v2 1/4] FmpDevicePkg: Add package, library classes, and PCDs

https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Create FmpDevicePkg with library classes and PCDs used to customize the behavior of a Firmware Management Protocol

[edk2] [RFC v2 4/4] FmpDevicePkg: Add DSC file to build all package components

https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg Adds a DSC file that is used to verify that all of the FmpDevicePkg libraries and modules build without error. Cc:

[edk2] [RFC v2 3/4] FmpDevicePkg: Add FmpDxe module

https://bugzilla.tianocore.org/show_bug.cgi?id=922 Based on content from the following branch: https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg The FmpDxe directory contains 2 INF files. FmpDxe.inf is a DXE driver that is used in a platform to add a Firmware

[edk2] [Patch 5/5] Vlv2TbltDevicePkg: Sync FLASH libraries from UDK2017 branch

https://bugzilla.tianocore.org/show_bug.cgi?id=911 Update Minnow Max FLASH libraries to match libraries in the UDK2017 development branch in edk2-platforms. https://github.com/tianocore/edk2-platforms/tree/devel-MinnowBoardMax-UDK2017 Cc: David Wei Cc: Mang Guo

[edk2] [Patch 2/5] Vlv2TbltDevicePkg: Fix VS2015 build breaks

https://bugzilla.tianocore.org/show_bug.cgi?id=911 Fix minor code issues that break VS2015 builds. Cc: David Wei Cc: Mang Guo Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney

[edk2] [Patch 3/5] Vlv2TbltDevicePkg: Fix build issues in DSC/FDF

https://bugzilla.tianocore.org/show_bug.cgi?id=911 Fix a the following issues in DSC/FDF files * Remove references to drivers that are not present * Enable the Tianocore boot logo and BGRT table * Enable full UEFI shell * Enable more debug messages in DXE phase Cc: David Wei

[edk2] [Patch 4/5] Vlv2TbltDevicePkg: Display logo on BOOT_ON_FLASH_UPDATE

https://bugzilla.tianocore.org/show_bug.cgi?id=911 Update PlatformBdsLib to show boot logo when the boot mode is BOOT_ON_FLASH_UPDATE. Cc: David Wei Cc: Mang Guo Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement

[edk2] [Patch 1/5] Vlv2TbltDevicePkg: Fix build scripts

From: Michael D Kinney https://bugzilla.tianocore.org/show_bug.cgi?id=911 Update build scripts to work with edk2 and Vlv2Binaries in PACKAGES_PATH. Cc: David Wei Cc: Mang Guo Cc: Jiewen Yao

[edk2] [Patch 0/5] Fix Vlv2TbltDevicePkg build and boot issues

com> Cc: Mang Guo <mang@intel.com> Cc: Jiewen Yao <jiewen@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> Kinney, Michael D (4): Vlv2TbltDevicePkg: Fix VS2015 build breaks Vlv2TbltDev

[edk2] [Patch] MdeModulePkg/Gcd: Filter gCpu->SetMemoryAttributes() calls

This patch fixes an issue with VlvTbltDevicePkg introduced by commit: https://github.com/tianocore/edk2/commit/5b91bf82c67b586b9588cbe4bbffa1588f6b5926 This patch filters the call to gCpu->SetMemoryAttributes() if the requested attributes is 0. It also removes the #define

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

pril 1, 2018 10:59 PM > To: Heyi Guo <heyi@linaro.org>; edk2- > de...@lists.01.org > Cc: Yi Li <phoenix.l...@huawei.com>; Renhao Liang > <liangren...@huawei.com>; Dong, Eric > <eric.d...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.co

[edk2] [edk2-MetaDataExpressionSyntaxSpecification] Create release/1.30 branch

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- book.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/book.json b/book.json index 0cf1c3e..e535b93 100644 --- a/book.json +++ b/book.json @@ -1,8 +1,7

[edk2] [edk2-InfSpecification] Create release/1.27 branch

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- book.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/book.json b/book.json index 1fdd962..447dfe4 100644 --- a/book.json +++ b/book.json @@ -1,8 +1,7

[edk2] [edk2-BuildSpecification] Create release/1.28 branch

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- book.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/book.json b/book.json index 3450248..5a8fef1 100644 --- a/book.json +++ b/book.json @@ -1,8 +1,7

[edk2] [edk2-DecSpecification] Create release/1.27 branch

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- book.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/book.json b/book.json index 46135ac..45f99c9 100644 --- a/book.json +++ b/book.json @@ -1,8 +1,7

[edk2] [edk2-DscSpecification] Create release/1.28 branch

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- book.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/book.json b/book.json index 2ae4968..225e4eb 100644 --- a/book.json +++ b/book.json @@ -1,8 +1,7

[edk2] [edk2-FdfSpecification] Create release/1.28.01 branch

The release/1.28 branch already exists and contains the 1.27 version of the document. Renaming the this release branch may break links to the document, so the branch name is extended to 1.28.01. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney

Re: [edk2] [PATCH 1/1] MdeModulePkg/Gcd: Fix bug of attribute conversion

To: Zeng, Star <star.z...@intel.com>; Wang, Jian J > <jian.j.w...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Heyi Guo > <heyi@linaro.org>; edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Yi Li > <phoenix.l...@huawei.c

Re: [edk2] Question regarding structure PCD

Jeff, You can provide default values for structure fields in the DEC file. Liming has an example posted in the following branch: https://github.com/lgao4/edk2/tree/UDK2018 DEC file example in TestPkg: https://github.com/lgao4/edk2/blob/UDK2018/TestPkg/TestPkg.dec Mike > -Original

Re: [edk2] [edk2 UsbMassStorageDxe v1 1/1] MdeModulePkg/Usb: Replace macro USB_BOOT_IO_BLOCKS

Ni, Ruiyu > <ruiyu...@intel.com>; leif.lindh...@linaro.org; linaro- > u...@lists.linaro.org; edk2-devel@lists.01.org; Dong, > Eric <eric.d...@intel.com> > Cc: ard.biesheu...@linaro.org; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming > <liming@

Re: [edk2] [PATCH 00/14] rid PiSmmCpuDxeSmm of DB-encoded instructions

, Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, February 5, 2018 11:23 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; > edk2-devel-01 <edk2-devel@lists.01.org> > Cc: Ard Biesheuvel <ard.biesheu...@

Re: [edk2] [PATCH 1/2] MdePkg/Base.h: Ensure safe bitwise operations.

Sent: Thursday, March 1, 2018 3:11 AM > To: edk2-devel@lists.01.org; Kinney, Michael D > <michael.d.kin...@intel.com> > Cc: ler...@redhat.com; Gao, Liming > <liming@intel.com> > Subject: Re: [edk2] [PATCH 1/2] MdePkg/Base.h: Ensure > safe bitwise operations. &

Re: [edk2] [PATCH 01/20] OvmfPkg/MemEncryptSevLib: rewrap to 79 characters width

Laszlo, Sorting #includes looks strange to me. We usually include the top level environment include first (e.g. ) and then the libs, protocols, ppis, GUIDs grouped together. If it is a lib module, the produced libs are listed first followed by the consumed libs. Mike > -Original

Re: [edk2] Can you set a PCD value DSC default per ModuleType?

Andrew, DSC does not support module type specific syntax. Just arch specific syntax. https://edk2-docs.gitbooks.io/edk-ii-dsc-specification/content/2_dsc_overview/29_pcd_sections.html#29-pcd-sections Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- >

Re: [edk2] [PATCH] MdePkg/UefiDevicePathLib: Fix print logic in DevPathToTextiSCSI

Why divide by sizeof(UINT8)? sizeof() always returns the size in bytes. Index is type UINTN, so it will always be >=0, so I do think the loop will ever exit. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Songpeng Li > Sent:

Re: [edk2] [PATCH v3 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, September 27, 2018 3:59 AM > To: Zeng, Star > Cc: Kinney, Michael D ; > edk2-devel@lists.01.org; Zimmer, Vincent > ; Richardson, Brian > ; Andrew Fish > ; Leif Lindholm &

Re: [edk2] [PATCH v3 1/1] OvmfPkg/PlatformPei: clear CPU caches

Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of > marcandre.lur...@redhat.com > Sent: Tuesday, October 2, 2018 5:17 AM > To: edk2-devel@lists.01.org > Cc: Justen, Jordan L ; > Anthony Perard ; Laszlo

Re: [edk2] [PATCH] Maintainers.txt: add DynamicTablesPkg

Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, October 2, 2018 9:04 AM > To: edk2-devel@lists.01.org > Cc: Andrew Fish ; Laszlo Ersek > ; Kinney, Michael D > ; Evan Lloyd > ; S

Re: [edk2] [RFC] Create new edk2-test repo

rds, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Supreeth Venkatesh > Sent: Friday, October 5, 2018 9:53 AM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Dong Wei ; Jin, Eric > > Subject: Re: [

Re: [edk2] [PATCH v1 1/6] PcAtChipsetPkg: Add MMIO Support to SerialIo Lib

Sami, The BaseSerialPortLib16550 supports I/O port, MMIO, and PCI based UARTs. PCDs are used to select the modes. I would like to see the BaseSerialPortLib16550 used instead of the serial port lib in PcAtChipsetPkg. Mike > -Original Message- > From: edk2-devel

Re: [edk2] TianoCore Community Meeting Minutes

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > On Behalf Of Leif Lindholm > Sent: Friday, October 12, 2018 11:06 AM > To: Laszlo Ersek > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] TianoCore Community Meeting Minutes > > On Fri, Oct 12, 2018 at

Re: [edk2] [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, cleanups

-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Monday, October 15, 2018 11:05 AM > To: Kinney, Michael D ; Gao, > Liming > Cc: edk2-devel-01 > Subject: Re: [edk2] [PATCH 0/5] > MdePkg/BaseSynchronizationLib GCC: fixes, cleanups > >

Re: [edk2] [PATCH] MdePkg/BaseStackCheckLib: add MSFT toolchain support

Wednesday, October 17, 2018 7:16 PM > To: Kinney, Michael D ; Gao, > Liming ; edk2-devel boun...@lists.01.org>; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Andrew Fish > > Subject: RE: [edk2] [PATCH] MdePkg/BaseStackCheckLib: add > MSFT toolchain support > > Mike, > >

Re: [edk2] Community Discussion: General Code and Commit message standards

I would also hope that most (if not all) patches do have an associated BZ. For either a feature request or a bug fix. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] > On Behalf Of stephano > Sent: Thursday, October 18, 2018 10:21 AM > To: Andrew

Re: [edk2] [PATCH] MdePkg/BaseStackCheckLib: add MSFT toolchain support

Jian, Please add the list of VSxxx tool chain tags you tested with in the commit message. Mike > -Original Message- > From: Wang, Jian J > Sent: Wednesday, October 17, 2018 11:36 PM > To: Kinney, Michael D ; Gao, > Liming ; edk2-devel boun...@lists.01.org>; edk2-devel

Re: [edk2] [PATCH] MdePkg/BaseStackCheckLib: add MSFT toolchain support

> -Original Message- > From: Gao, Liming > Sent: Wednesday, October 17, 2018 6:22 PM > To: Wang, Jian J ; edk2-devel > ; edk2- > de...@lists.01.org > Cc: Kinney, Michael D ; Yao, > Jiewen ; Andrew Fish > > Subject: RE: [edk2] [PATCH] MdePkg/BaseStackCheckLib: add >

Re: [edk2] OpenProtocolInformation

The same protocol can be installed on many handles in the handle database. For example, if there are multiple mass storage devices in a platform, there will be multiple Block I/O Protocols in the handle database. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- >

Re: [edk2] ** NOTICE ** edk2-devel mailing list configuration changes

Leif, Very strange. When I do the same on that email, it shows Paul on the To address line. Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, October 29, 2018 1:40 PM > To: Kinney, Michael D > Cc: EDK II Develop

Re: [edk2] Test message. Please ignore.

Hi Chris, I am trying a different configuration setting to see if the posters reply-to address can be preserved. Please try both a Reply and a Reply-All to this test message. Thanks, Mike > -Original Message- > From: Kinney, Michael D > Sent: Monday, October 29, 2018

Re: [edk2] ** NOTICE ** edk2-devel mailing list configuration changes

of these changes is to enable those users to be re-activated. Thanks, Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, October 29, 2018 12:54 PM > To: EDK II Development > Cc: Kinney, Michael D ; > Cetola, Stephano > Subject:

[edk2] Another Test Message - please ignore

Start new test message thread. Mike ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] ** NOTICE ** edk2-devel mailing list configuration changes

I will put the reply_goes_to_list option back to "Poster". Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, October 29, 2018 2:10 PM > To: Kinney, Michael D > Cc: EDK II Development ; > Cetola, Stephano > Su

Re: [edk2] Test message. Please ignore.

Another test with reply_goes_to_list set to "Poster". Mike > -Original Message- > From: Chris Co [mailto:christopher...@microsoft.com] > Sent: Monday, October 29, 2018 1:12 PM > To: Kinney, Michael D ; EDK > II Development ; Gretzinger, > Adam R ; Jeremiah C

Re: [edk2] Another Test Message - please ignore

Chris, Thanks! That is working as expected now. Mike > -Original Message- > From: Chris Co [mailto:christopher...@microsoft.com] > Sent: Monday, October 29, 2018 3:50 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Subject: RE: Another Test Message - please i

Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.

that the need to pay attention to this change. Mike > -Original Message- > From: Fu, Siyuan > Sent: Tuesday, October 30, 2018 5:52 PM > To: Kinney, Michael D ; > Zeng, Star ; edk2- > de...@lists.01.org > Cc: Leif Lindholm ; Andrew > Fish (af...@apple.com) ; Laszlo Er

Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.

to guarantee no build breaks. Thanks, Mike > -Original Message- > From: Fu, Siyuan > Sent: Tuesday, October 30, 2018 1:23 AM > To: Zeng, Star ; edk2- > de...@lists.01.org > Cc: Kinney, Michael D ; Leif > Lindholm ; Andrew Fish > (af...@apple.com) ; Laszlo Ersek >

Re: [edk2] [PATCH 1/1] MdePkg/Base.h: Implement BASE_CR() via OFFSET_OF().

Marvin, Thanks. This is a good improvement. Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Gao, Liming > Sent: Thursday, November 1, 2018 6:33 PM > To: marvin.haeu...@outlook.com; edk2-devel@lists.01.org > Cc: Kinney, Michael D > Subject: RE:

Re: [edk2] [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64

Leif, The MSR definitions are only used by Mtrr.c, and Mtrr.c is only used for IA32 and X64 builds in the INF file. It would be simpler to move the #include into Mtrr.c. That would avoid the use of #if. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- >

Re: [edk2] [PATCH 3/6] IntelFrameworkPkg: fix build for AARCH64/ARM

Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, November 1, 2018 8:37 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Gao, Liming > Subject: [PATCH 3/6] IntelFr

Re: [edk2] Test message. Please ignore.

, Michael D ; Gretzinger, Adam R ; edk2-devel@lists.01.org Cc: Sean Brogan ; Jeremiah Cox ; Cetola, Stephano ; Chad Mace Subject: Test message. Please ignore. Test message. Checking for DMARC bounces... Chris ___ edk2-devel mailing list edk2-devel

Re: [edk2] Test message. Please ignore.

Chris, Thanks. That looks like what I expected. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Chris Co via edk2- > devel > Sent: Monday, October 29, 2018 11:22 AM > To: Kinney, Michael D ; > Gretzinger

[edk2] ** NOTICE ** edk2-devel mailing list configuration changes

Hello, Some configuration changes have been made to the edk2-devel mailing list to handle posts from a domain with a DMARC Reject/Quarantine policy enabled. If this is detected then the from address is now munged. One side effect of this setting is that the behavior of Reply has changed.

Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC

heuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, November 6, 2018 9:58 AM > To: edk2-devel@lists.01.org > Cc: Rabeda, Maciej ; Kinney, > Michael D ; Jin, Eric > ; leif.lindh...@linaro.org; Ard > Biesheuvel > Subject: [PATCH edk2-staging 00/19] > IntelUndiPkg/GigUndiDxe: b

Re: [edk2] [PATCH v1] Maintainers.txt: Change DynamicTablesPkg maintainer

ughes-f...@arm.com; > alexei.fedo...@arm.com; Andrew Fish ; > Laszlo Ersek ; Kinney, Michael D > > Subject: Re: [PATCH v1] Maintainers.txt: Change > DynamicTablesPkg maintainer > > +Andrew, Laszlo and Mike. > > Hi Sami, > > For my part, I can confirm that Evan is no l

Re: [edk2] [PATCH 3/4] SecurityPkg: add TpmIoLibMmio instance

that must be met before the new lib class meets the requirements for edk2/master. Mike From: Cohen, Eugene [mailto:eug...@hp.com] Sent: Tuesday, November 13, 2018 3:24 PM To: Kinney, Michael D ; edk2-devel@lists.01.org; Yao, Jiewen ; Zhang, Chao B Cc: Bin, Sung-Uk (빈성욱) Subject: RE: [PATCH 3

Re: [edk2] [PATCH 3/4] SecurityPkg: add TpmIoLibMmio instance

Eugene, It appears you are expecting the Address parameter to be the full MMIO address for DTPM. If you are wanting this lib class to abstract the access for different bus types, shouldn’t the Address be the relative address from a base? Or are you using the full DTPM MMIO address on purpose

Re: [edk2] [PATCH 1/4] SecurityPkg: enable TPM components to build for ARM and AARCH64

Jiewen, There are I2C examples for TPM12 in the QuarkPlatformPkg. Would that we a good example too? Could this new lib class be used for both TPM12 and TPM20 devices? Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Yao, Jiewen >

Re: [edk2] [PATCH 6/8] IntelFrameworkPkg: Remove the redundant INFs

; From: Zhang, Shenglei > Sent: Tuesday, November 13, 2018 7:32 PM > To: Ni, Ruiyu ; edk2- > de...@lists.01.org > Cc: Kinney, Michael D ; > Gao, Liming > Subject: RE: [edk2] [PATCH 6/8] IntelFrameworkPkg: > Remove the redundant INFs > > Ray > Thanks for your constructive

Re: [edk2] Edk2 uni file encoding

Sean, As a clarification. The UNI specs does list 2 on-disk formats. This was done so tools could support both in the transition from UTF-16LE with BOM to UTF-8 without BOM. The strong recommendation is for all EDK II open source packages to use UTF-8 without a BOM. Since platform packages not

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

Bob, Is this for edk2/master or for the Python 3 conversion in the edk2-staging branch? If it is for the edk-staging branch, then the Subject is not correct. Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of BobCF > Sent:

Re: [edk2] [Patch] BaseTools: Optimize string concatenation

improvement in the BZ. Mike > -Original Message- > From: Gao, Liming > Sent: Friday, November 9, 2018 6:17 AM > To: Kinney, Michael D ; > Feng, Bob C ; edk2- > de...@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [edk2] [Patch] BaseTools: Optimize string > concatenatio

Re: [edk2] [edk2-wiki PATCH] release planning: announce the soft and hard feature freezes

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, November 9, 2018 8:27 AM > To: Gao, Liming ; Leif Lindholm > > Cc: edk2-devel@lists.01.org; Andrew Fish > ; Richardson, Brian > ; Kinney, Michael D > ; Cetola, Stephano > > Subje

<    5   6   7   8   9   10   11   >