Re: [edk2] [Patch] BaseTools:remove the redundant directories for '-f' with absolute path.

It's good to me. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Zhu, Yonghong > Sent: Monday, October 26, 2015 11:59 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Wu, Hao A > Subject: [Patch] BaseTools:remove t

Re: [edk2] [Patch] BaseTools:remove the redundant directories for '-f' with absolute path.

Hi Yonghong, I think you missed defining the variable 'tempchar', could you please update the patch? Best Regards, Hao Wu > -Original Message- > From: Zhu, Yonghong > Sent: Monday, October 26, 2015 10:48 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Wu, Hao A &g

Re: [edk2] [Patch] BaseTools:remove the redundant directories for '-f' with absolute path.

It's good to me. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Zhu, Yonghong > Sent: Monday, October 26, 2015 11:59 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Wu, Hao A > Subject: [Patch] BaseTools:remove t

Re: [edk2] [PATCH v3 0/4] Add BlockIO2 support for UFS

Sorry for typo, 'a.' should be "ScsiDiskDxe" instead of "ScsiBusDxe" > -Original Message- > From: Wu, Hao A > Sent: Tuesday, December 08, 2015 2:54 PM > To: edk2-devel@lists.01.org; Tian, Feng > Cc: Wu, Hao A > Subject: [PATCH v3 0/4] Add BlockIO2

Re: [edk2] [patch 0/2] Fix MS tool chain 32bit /Od build failure

Patch series are good to me. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Thursday, January 07, 2016 10:56 AM > To: Wu, Hao A; Zeng, Star > Cc: edk2-devel@lists.01.org > Subject: [patch 0/2] Fix

Re: [edk2] [PATCH] MdeModulePkg BaseSerialPortLib: Fix VS2010 build error

OK, I will do it and sent out a patch series for these two fixes. Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Friday, January 08, 2016 10:17 AM > To: Wu, Hao A; edk2-devel@lists.01.org; Kinney, Michael D; Gao, Liming; Tian, > Feng; Yao, Jiewe

Re: [edk2] [PATCH 0/4] Raise Tpl to TPL_NOTIFY when dealing SCSI async I/O

Thanks for the feedback. I will update the codes before committing the patches. Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Tuesday, December 22, 2015 3:06 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wu, Hao A; Tian, Feng > Subject: RE:

Re: [edk2] [Patch] Update local variable type to avoid potential data overflow.

Hi Eric, The patch is good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Eric Dong > Sent: Wednesday, January 20, 2016 1:04 PM > To: edk2-devel@lists.01.org > Cc: Tian,

Re: [edk2] [PATCH 31/35] SourceLevelDebugPkg: DebugCommunicationLibUsb: remove set but unused variables

It is good to me. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, March 24, 2016 6:37 PM > To: edk2-devel-01 > Cc: Fan, Jeff; Wu, Hao A > Subject: [PATCH 31

Re: [edk2] [PATCH 30/35] SourceLevelDebugPkg: DebugAgentCommon: remove set but unused variables

It is good to me. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, March 24, 2016 6:37 PM > To: edk2-devel-01 > Cc: Fan, Jeff; Wu, Hao A > Subject: [PATCH 30

Re: [edk2] [patch 0/4] Add EDKII SD/MMC stack to manage SD/EMMC device

, 2016 10:51 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Zeng, Star > Subject: [patch 0/4] Add EDKII SD/MMC stack to manage SD/EMMC device > > The EDKII SD/MMC stack includes: > 1. Dxe phase support by: >i. SdMmcPciHcDxe driver to consume PciIo and produce SdMmcPassT

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Fix incorrect RAM disk memory address calculation

0, 2016 7:13 AM > To: edk2-devel@lists.01.org > Cc: tapands...@hpe.com; Wu, Hao A; Tian, Feng; Samer El-Haj-Mahmoud; > Samer El-Haj-Mahmoud > Subject: [PATCH] MdeModulePkg RamDiskDxe: Fix incorrect RAM disk > memory address calculation > > EndingAddress is calculated i

Re: [edk2] [PATCH v2 0/2] Report ACPI NFIT for reserved memory RAM disks

NFIT. Do you have comments for this proposal? Thanks in advance. Best Regards, Hao Wu > -Original Message- > From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Saturday, April 23, 2016 3:14 AM > To: Wu, Hao A; Laszlo Ersek > Cc: Justen, Jordan L; T

Re: [edk2] [PATCH v3 2/2] OvmfPkg: Modify fdf files due to RamDiskDxe driver's adding ASL code

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, April 28, 2016 7:31 PM > To: Wu, Hao A; edk2-de...@ml01.01.org; Tian, Feng; samer.el-haj- > mahm...@hpe.com; Yao, Jiewen > Cc: Justen, Jordan L > Subject: Re: [PATCH v3 2/2] OvmfPkg:

Re: [edk2] [PATCH v3 0/2] Report ACPI NFIT for reserved memory RAM disks

ud, Samer > Sent: Friday, April 29, 2016 4:59 AM > To: Wu, Hao A; edk2-devel@lists.01.org; Tian, Feng; Yao, Jiewen > Subject: Re: [edk2] [PATCH v3 0/2] Report ACPI NFIT for reserved memory RAM > disks > > Hao, > > One issue with this approach is that BDS may be downloading ISO

Re: [edk2] [patch] MdeModulePkg/NvmExpressDxe: comments update to meet implementation

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Tuesday, April 26, 2016 3:01 PM > To: edk2-devel@lists.01.org > Cc: Simon Lian-SSI; Wu; Wu, Hao A > Subject: [patch] MdeModulePkg/NvmExpressDxe:

Re: [edk2] [PATCH v2 0/2] Report ACPI NFIT for reserved memory RAM disks

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, April 21, 2016 7:10 PM > To: Wu, Hao A > Cc: Justen, Jordan L; Tian, Feng; Xiao Guangrong; edk2-de...@ml01.01.org; Yao, > Jiewen > Subject

Re: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM disks

11:57 PM > To: El-Haj-Mahmoud, Samer; edk2-devel@lists.01.org; Justen, Jordan L; Wu, > Hao A > Cc: Hsiung, Harry L > Subject: Re: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM > disks > > On 05/06/16 17:41, El-Haj-Mahmoud, Samer wrote: > > What is the st

Re: [edk2] [PATCH v2 2/2] OvmfPkg: Modify fdf files due to RamDiskDxe driver's adding ASL code

> -Original Message- > From: Justen, Jordan L > Sent: Wednesday, April 20, 2016 3:21 PM > To: Wu, Hao A; edk2-devel@lists.01.org; Tian, Feng; samer.el-haj- > mahm...@hpe.com; Yao, Jiewen > Cc: Wu, Hao A; Laszlo Ersek > Subject: Re: [PATCH v2 2/2] OvmfPkg: Modify fdf fi

Re: [edk2] [PATCH v2 0/2] Report ACPI NFIT for reserved memory RAM disks

Hi Laszlo, Thanks for the feedbacks, comments are made below. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, April 20, 2016 7:08 PM > To: Wu, Hao A > Cc: Tian, Feng; Xiao Guangrong; Justen,

Re: [edk2] [patch 0/3] Fix some bugs found in EDKII SD/MMC stack

Hi Feng, For patch 2, please update the copyright header. Except that, the series looks good to me. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Wednesday, April 13, 2016 10:39 AM > To: edk2-devel@lis

Re: [edk2] [PATCH 0/4] ATA PassThru & SATA device path PortMultiplier update

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, May 09, 2016 7:18 PM > To: Wu, Hao A; edk2-de...@ml01.01.org; Tian, Feng; Justen, Jordan L > Subject: Re: [edk2] [PATCH 0/4] ATA PassThru & SATA device path > PortMultiplier

Re: [edk2] [PATCH 0/4] ATA PassThru & SATA device path PortMultiplier update

OK. I will update the log message title as well. Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Tuesday, May 10, 2016 9:49 AM > To: Wu, Hao A; Laszlo Ersek; edk2-de...@ml01.01.org; Justen, Jordan L > Cc: Tian, Feng > Subject: RE: [edk2] [PATCH

Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Add RAW Ramdisk size change support in HII form

-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Tapan Shah > Sent: Friday, June 03, 2016 2:35 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben; Wu, Hao A; Tian, Feng > Subject: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Add RAW Ramdisk size > change support in HII form

Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Add Memory Type selection support in Ramdisk HII

Hi Tapan, Two comments below. Best Regards Hao Wu > -Original Message- > From: Tapan Shah [mailto:tapands...@hpe.com] > Sent: Friday, June 03, 2016 2:34 AM > To: edk2-devel@lists.01.org > Cc: samer.el-haj-mahm...@hpe.com; Carsey, Jaben; Wu, Hao A; Tian, Feng; > Ta

Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Add Memory Type selection support in Ramdisk HII

nal Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, > Hao A > Sent: Friday, June 03, 2016 10:14 AM > To: Tapan Shah; edk2-devel@lists.01.org > Cc: Carsey, Jaben; Tian, Feng > Subject: Re: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Add Memory Typ

Re: [edk2] [PATCH] MdeModulePkg/AtaBusDxe: Fix some ATA hard drives cannot be discovered

The patch is good to me. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Monday, June 06, 2016 12:08 PM > To: edk2-devel@lists.01.or

Re: [edk2] [PATCH] MdeModulePkg/AtaBusDxe: Fix some ATA hard drives cannot be discovered

Pushed at 2d273c8db95430b680e542e38cf07b97f9b57d11. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cinnamon Shia > Sent: Monday, June 06, 2016 12:08 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; el...@hpe.com; Tian

Re: [edk2] [PATCH] MdeModulePkg NvmExpressDxe: Add check before creating an aync IO queue

I will update the commit subject to: MdeModulePkg NvmExpressDxe: Fix invalid queue size when creating IO queues when committing the patch. Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Thursday, June 02, 2016 9:58 AM > To: Wu, Hao A; edk2-devel@lists

Re: [edk2] [patch] MdeModulePkg/SdMmc: update TPL to notify to fix UEFI SCT hang

guards? Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Thursday, June 23, 2016 3:53 PM > To: Wu, Hao A > Cc: edk2-devel@lists.01.org > Subject: [patch] MdeModulePkg/SdMmc: update TPL to notify to fix UEFI SCT > hang > > We have to upgrade

Re: [edk2] [patch v3] MdeModulePkg/SdMmc: update TPL to notify to fix UEFI SCT hang

The patch is good to me. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Friday, June 24, 2016 3:25 PM > To: Wu, Hao A > Cc: edk2-devel@lists.01.org > Subject: [patch v3] MdeModulePkg/SdMmc: update T

Re: [edk2] [PATCH 0/5] Additional fixes for the assertion removal work

For patch 5, please also update the declaration of function LoadPciRomConnectAllDriversToAllControllers() in LoadPciRom.c. Otherwise, GCC build will fail. With that change, series Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH 0/3] Add APIs IsZeroBuffer and IsZeroGuid in BaseMemoryLib

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, August 04, 2016 4:07 PM > To: Wu, Hao A > Cc: edk2-de...@ml01.01.org; Leif Lindholm (Linaro address); Ard Biesheuvel > Subject: Re: [edk2]

Re: [edk2] [patch] MdeModulePkg/BootMaintUi: Add error handling codes when AllocatePool fail

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Bi, Dandan > Sent: Tuesday, July 05, 2016 4:53 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Wu, Hao A > Subject: [patch] MdeModulePkg/BootMaintUi: Add error handling c

Re: [edk2] [patch] MdeModulePkg/EmmcDxe: Don't expose BlockIo interface for RPMB partition

The patch is good to me. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng > Tian > Sent: Wednesday, June 29, 2016 11:18 AM > To: Wu, Hao A > Cc:

Re: [edk2] [PATCH] ShellPkg/Ls: Handle the case when SearchString is NULL

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Tuesday, August 16, 2016 3:33 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subje

Re: [edk2] [PATCH 0/1] Refine casting expression result to bigger size

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, January 24, 2017 4:58 AM > To: Laszlo Ersek > Cc: Wu, Hao A; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/1] Refine casting expression result to bigger > size &g

Re: [edk2] [PATCH v2 1/1] MdePkg: Refine casting expression result to bigger size

> -Original Message- > From: Gao, Liming > Sent: Wednesday, January 25, 2017 1:58 PM > To: Wu, Hao A; Laszlo Ersek > Cc: edk2-de...@ml01.01.org > Subject: RE: [edk2] [PATCH v2 1/1] MdePkg: Refine casting expression result to > bigger size > > Hao: > Fo

Re: [edk2] [PATCH v2 1/1] MdePkg: Refine casting expression result to bigger size

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, January 24, 2017 5:54 PM > To: Wu, Hao A > Cc: edk2-de...@ml01.01.org > Subject: Re: [edk2] [PATCH v2 1/1] MdePkg: Refine casting expression result to > bigger size > > On 0

Re: [edk2] [PATCH 1/6] MdeModulePkg: Refine type cast for pointer subtraction

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, January 24, 2017 6:15 PM > To: Wu, Hao A > Cc: edk2-de...@ml01.01.org > Subject: Re: [edk2] [PATCH 1/6] MdeModulePkg: Refine type cast for pointer > subtraction > > On 0

Re: [edk2] [PATCH v2] MdePkg/BaseLib: Refine logic for (Ascii)StrnLenS to handle MaxSize = 0

el@lists.01.org > Cc: Wu, Hao A; Kinney, Michael D; Yao, Jiewen; Gao, Liming > Subject: [edk2] [PATCH v2] MdePkg/BaseLib: Refine logic for (Ascii)StrnLenS to > handle MaxSize = 0 > > https://bugzilla.tianocore.org/show_bug.cgi?id=378 > > Cc: Jiewen Yao <jiewen@intel.com&

Re: [edk2] [PATCH v3 6/6] ShellPkg: Refine type cast for pointer subtraction

> -Original Message- > From: Ni, Ruiyu > Sent: Monday, February 27, 2017 1:10 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH v3 6/6] ShellPkg: Refine type cast for pointer subtraction > > > > Thanks/Ray > > &

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s

Hi Ard, The NULL checks for the input Guids in APIs CopyGuid(), CompareGuid() and IsZeroGuid() are implicitly done within calls to BaseLib APIs ReadUnaligned64() and WriteUnaligned64(). So I think the functions behavior matches with their comments. What do you think? Best Regards, Hao Wu >

Re: [edk2] [Patch] BaseTools Build: Fix build break for clean target in Linux

The patch is good to me. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Gao, Liming > Sent: Thursday, September 29, 2016 10:48 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [Patch] BaseTools Build: F

Re: [edk2] GenFv error 3000 building OvmfPkg X64 RELEASE

Hi Cran, This issue was introduced by commit 2ff3293. And it has been fixed via commit 49d8f53. Could you help to update the repository and see whether this issue still exists? Thanks in advance. Best Regards, Hao Wu > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Wednesday, October 19, 2016 3:02 PM > To: edk2-devel@lists.01.org > Cc: Fan, Jeff; Wu, Hao A > Subject: [PATCH 31/33] Source

Re: [edk2] [patch] MdeModulePkg/Ufs: ensure the DBC field of UTP PRDT is dword-aligned

The patch is good to me. Please update the copyright info before checkin. Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Tuesday, October 18, 2016 1:19 PM > To: Wu, Hao A > Cc: edk2-devel@lists.01.

Re: [edk2] [PATCH 1/6] MdePkg/BaseLib: Refine (Ascii)StrnLenS functions logic

in the first MaxSize characters in String. Sorry for the issue, I will send out a V2 of the series with this patch updated. Best Regards, Hao Wu > -Original Message- > From: Kinney, Michael D > Sent: Friday, December 16, 2016 7:55 AM > To: Wu, Hao A; edk2-devel@lists.01

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: Compare SIZE_4GB with address type

Got it, I will update the codes before check in. Thanks for the feedback. Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, January 11, 2017 10:05 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wu, Hao A; Ard Biesheuvel > Subject:

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: Compare SIZE_4GB with address type

> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, January 11, 2017 3:55 PM > To: Ni, Ruiyu; Laszlo Ersek > Cc: Wu, Hao A; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: Compare > SIZE_

Re: [edk2] [PATCH] BaseTools/VolInfo: Fix printf issue using '%ls' in format string

Got it. I will move those 2 implementation before main() before code check-in. Best Regards, Hao Wu > -Original Message- > From: Gao, Liming > Sent: Friday, December 02, 2016 10:56 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Zhu, Yonghong > Subject: RE: [PATCH]

Re: [edk2] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Add check to avoid NULL ptr dereference

Got it. I will remove those debug messages before check-in. Best Regards, Hao Wu > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, December 20, 2016 10:35 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Fan, Jeff; Kinney, Michael D > Subject: RE: [PA

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add check to avoid NULL ptr dereference

I have send the V2 of the patch according to the comments. Thanks for the feedbacks. Best Regards, Hao Wu From: Yao, Jiewen Sent: Tuesday, December 20, 2016 10:06 AM To: Yao, Jiewen; Kinney, Michael D; Wu, Hao A; edk2-devel@lists.01.org Cc: Fan, Jeff Subject: RE: [PATCH] UefiCpuPkg

Re: [edk2] [PATCH 0/6] Refine code logics to prevent possible mis-reports by static code checkers

Related). Thanks in advance. Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi > Guo > Sent: Sunday, December 18, 2016 11:04 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Ye, Ting; Gao, Limin

Re: [edk2] [PATCH] ShellPkg/Shell: Avoid potential null pointer deference

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, March 28, 2017 10:27 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH] ShellPkg/Shell: Avoid potential null pointer deferenc

Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Tian, Feng > Sent: Monday, March 20, 2017 10:26 AM > To: Zeng, Star; Laszlo Ersek; edk2-devel-01 > Cc: Ard Biesheuvel; Wu, Hao A; Leif Lindholm; Tian, Feng > Subj

Re: [edk2] [PATCH-V1] MdeModulePkg/NvmExpressDxe: Memory leak fix in async code flow

Reviewed-by: Hao Wu I have removed some tab usages and trailing white space cases in the patch. Pushed as commit: f2333c707dd04f069c102bcae004561ec590a3a0 Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Fix potential implicit sign extension

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, April 10, 2017 11:47 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Tian, Feng; guoh...@huawei.com > Subject: Re: [edk2] [PATCH] MdeModulePkg/ScsiDiskDxe: Fix potential implici

Re: [edk2] [PATCH] MdeModulePkg/BootManagerMenu: Add assertion to indicate no DIV by 0

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, April 11, 2017 10:22 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH] MdeModulePkg/BootManagerMenu: Add assertion t

Re: [edk2] 答复: [ScsiDiskDxe] Implict type conversion bug

Hi Gary, Thanks for the reporting, I will take a look at all the cases you mentioned. Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Guoheyi > Sent: Tuesday, April 11, 2017 3:05 PM > To: Zeng, Star;

Re: [edk2] [patch] BaseTools/ECC: Change check rule for Ifndef statement

Reviewed-by: Hao Wu Also tested upon codes in MdePkg\Library\BaseLib, the reported issues for '#ifndef DISABLE_NEW_DEPRECATED_INTERFACES' used in file MdePkg\Library\BaseLib\String.c now go away. Best Regards, Hao Wu > -Original Message- > From: edk2-devel

Re: [edk2] [patch] MdeModulePkg/HiiDB: Avoid incorrect results of multiplication

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Bi, Dandan > Sent: Wednesday, April 12, 2017 3:09 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Gao, Liming; Wu, Hao A > Subject: [patch] MdeModulePkg/HiiDB:

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: fix to support EFI_ERASE_BLOCK_PROTOCOL

of the behavior of the EraseBlocks() by the UEFI spec to return an initialized/formatted value. Best Regards, Hao Wu > -Original Message- > From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] > Sent: Saturday, April 15, 2017 9:45 PM > To: Wu, Hao A; Tian, Feng

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Avoid running unnecessary code

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Monday, April 17, 2017 12:57 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A

Re: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: Handling return of write to sq and cq db

Thanks for the catch. The patch is good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Suman Prakash > Sent: Thursday, April 20, 2017 6:02 PM > To:

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: fix to support EFI_ERASE_BLOCK_PROTOCOL

to test if doing so can enable the erase operation on your UFS device? Thanks in advance. Best Regards, Hao Wu From: Haojian Zhuang [mailto:haojian.zhu...@linaro.org] Sent: Monday, April 17, 2017 10:03 PM To: Wu, Hao A Cc: Tian, Feng; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; edk2-devel

Re: [edk2] [PATCH] MdeModulePkg PiSmmCore: Enhance SMM FreePool to catch buffer overflow

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, > Jiewen > Sent: Wednesday, April 19, 2017 3:27 PM > To: Zeng, Star; edk2-devel@lists.01.org > C

Re: [edk2] [PATCH] ShellPkg/pci: Fix VS2012 build failure

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, April 20, 2017 10:51 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Bi, Dandan > Subject: [PATCH] ShellPkg/pci: Fix VS2012 build failur

Re: [edk2] [PATCH] MdeModulePkg/NvmExpressDxe: Handling return of write to sq and cq db

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, > Hao A > Sent: Friday, April 21, 2017 9:39 AM > To: Suman Prakash; edk2-devel@lists.01.org > Cc: Tian, Feng > Subject: Re: [edk2] [PATCH] MdeModulePkg/NvmExpres

Re: [edk2] [PATCH 2/2] MdeModulePkg/CapsuleLib: Free the buffer returned by GetVariable2 API

> -Original Message- > From: Yao, Jiewen > Sent: Friday, March 10, 2017 2:17 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Subject: RE: [PATCH 2/2] MdeModulePkg/CapsuleLib: Free the buffer returned > by GetVariable2 API > > According to GetVariable2() API, there i

Re: [edk2] [PATCH v2 1/2] MdeModulePkg/CapsuleLib: Add lib destructors to handle unclosed events

> -Original Message- > From: Yao, Jiewen > Sent: Friday, March 10, 2017 3:23 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: RE: [edk2] [PATCH v2 1/2] MdeModulePkg/CapsuleLib: Add lib > destructors to handle unclosed events > > I just fi

Re: [edk2] [PATCH v2 1/2] MdeModulePkg/CapsuleLib: Add lib destructors to handle unclosed events

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, > Hao A > Sent: Friday, March 10, 2017 3:40 PM > To: Yao, Jiewen; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v2 1/2] MdeModulePkg/CapsuleLib: Add lib > destructo

Re: [edk2] [patch] MdeModulePkg/SdMmc: Add break to avoid dead loop when polling OCR Reg

> -Original Message- > From: Tian, Feng > Sent: Monday, March 13, 2017 11:24 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [patch] MdeModulePkg/SdMmc: Add break to avoid dead loop when > polling OCR Reg > > At worst case, OCR register may always n

Re: [edk2] [PATCH] MdePkg/SafeString.c: Fix code to be more readable

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Monday, March 06, 2017 3:24 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH] MdePkg/SafeString.c: Fix code to be more readable >

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Lock should be acquired

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Fan, Jeff > Sent: Tuesday, April 18, 2017 10:16 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Tian, Feng; Kinney, Michael D > Subject: [PATCH] UefiCpuPkg/PiS

Re: [edk2] [PATCH] UefiCpuPkg SecCore: Fix operands of different size in bitwise operation

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Wednesday, August 02, 2017 10:10 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wu, Hao A; Gao, Liming; Fan, Jeff > Subject: [PATCH] UefiCpuP

Re: [edk2] [Patch V2 2/4] DuetPkg: Fix Xcode 9 Beta treating 32-bit left shift as undefined

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Zhu, Yonghong > Sent: Thursday, August 03, 2017 5:00 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Wu, Hao A; Andrew Fish > Subject: [Patch V2 2/4] DuetPkg: Fix Xcod

Re: [edk2] [PATCH v2] MdeModulePkg/EmmcDxe: Make sure no extra data is erased by EraseBlocks

> -Original Message- > From: Zeng, Star > Sent: Friday, August 11, 2017 10:37 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wu, Hao A; Ni, Ruiyu; Zeng, Star > Subject: RE: [edk2] [PATCH v2] MdeModulePkg/EmmcDxe: Make sure no extra > data is erased by EraseBlocks &g

Re: [edk2] [patch] MdeModulePkg/XhciDxe: Make comments align with function

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Bi, Dandan > Sent: Monday, July 10, 2017 2:11 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Wu, Hao A; Zeng, Star > Subject: [patch] MdeModulePkg/XhciDxe: Make comm

Re: [edk2] [patch] MdeModulePkg/XhciDxe: Make comments align with function

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, > Hao A > Sent: Tuesday, July 11, 2017 8:49 AM > To: Bi, Dandan; edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Zeng, Star > Subject: Re: [edk2] [patch] MdeModulePkg/XhciDxe

Re: [edk2] [PATCH v2 0/4] MdeModulePkg/XhciDxe: Check timeout URB again after stopping endpoint

The patch series is good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Tuesday, July 04, 2017 1:20 PM > To: edk2-devel@lists.01.org > Subject: [edk2]

Re: [edk2] [PATCH 2/3] MdeModulePkg/XhciDxe: Dump the CMD/EVENT/INT/BULK ring information

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Wednesday, June 28, 2017 6:40 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A

Re: [edk2] [PATCH 1/3] MdeModulePkg/XhciDxe: Refine IsTransferRingTrb and IsAsyncIntTrb

Comments are made below. Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Wednesday, June 28, 2017 6:40 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Tian, Feng; Zeng, Star > S

Re: [edk2] [PATCH 3/3] MdeModulePkg/XhciDxe: Check timeout URB again after stopping endpoint

in XhcControlTransfer() may need to get updated as well. Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Wednesday, June 28, 2017 6:40 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A

Re: [edk2] [PATCH 1/2] MdePkg: Add EFI Partition Information Protocol definitions

> -Original Message- > From: Ni, Ruiyu > Sent: Friday, July 07, 2017 10:27 AM > To: Wu, Hao A > Cc: Ni, Ruiyu; Kinney, Michael D; Gao, Liming; edk2-devel@lists.01.org > Subject: RE: [PATCH 1/2] MdePkg: Add EFI Partition Information Protocol > definitions > >

Re: [edk2] [PATCH 0/2] Notify NVME HW when system reset happens

> -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, August 09, 2017 3:57 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 0/2] Notify NVME HW when system reset happens > > The NVME controller requires notification for shutdown as par

Re: [edk2] [PATCH 0/2] Notify NVME HW when system reset happens

Hi Ray, Just for curiosity, I checked the NVME spec for the purpose of a shutdown notification to the controller when there is a power-off for the device. And found the following: 1. Will increase the field 'Unsafe Shutdowns' in the SMART/Health Information data (Section 5.10.1.2). 2.

Re: [edk2] [PATCH] MdeModulePkg/PciHostBridgeDxe: Make bitwise operands of the same size

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, June 09, 2017 4:40 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: Re: [edk2] [PATCH] MdeModulePkg/PciHostBridgeDxe: Make bitwise > operands of the same size &

Re: [edk2] MESSAGING_DEVICE_PATH Intel NVMe Vendor defined

Hi David, The UEFI spec defines the format of an NVMe device node, I think the driver (maybe on the NVME option rom) that produces the device path for the NVME device should get updated to follow the spec. For those vendor defined paths, I think the DevicePathLib will only dump the hex of device

Re: [edk2] [PATCH 2/8] DuetPkg/FvbRuntimeService: correct NumOfLba vararg type in EraseBlocks()

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, May 18, 2017 11:04 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu; Justen, Jordan L > Subject: [edk2]

Re: [edk2] [PATCH 4/8] Nt32Pkg/FvbServicesRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, May 18, 2017 11:04 PM > To: edk2-devel-01 > Cc: Ni, Ruiyu; Justen, Jordan L > Subject: [edk2]

Re: [edk2] Duet misbehaving.

Lyons, For the steps to create a usb boot disk, please follow the steps mentioned in file DuetPkg\ReadMe.txt. Please help to see if this can work for you. Best Regards, Hao Wu > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jd > Lyons >

Re: [edk2] [PATCH] MdeModulePkg/Xhci: Fill the 'interval' field for ISO endpoint context

> -Original Message- > From: Zeng, Star > Sent: Wednesday, May 31, 2017 11:27 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Wu, Hao A; Baranee; Zeng, Star > Subject: RE: [edk2] [PATCH] MdeModulePkg/Xhci: Fill the 'interval' field for > ISO > endpoint contex

Re: [edk2] [PATCH v2 1/5] MdePkg/DevicePath: Add BluetoothLe device path node support

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, June 06, 2017 11:36 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH v2 1/5] MdePkg/DevicePath: Add BluetoothLe de

Re: [edk2] [PATCH] CryptoPkg/BaseCryptLib: Add NULL pointer checks in DH and P7Verify

Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -Original Message- > From: Long, Qin > Sent: Friday, May 19, 2017 3:27 PM > To: Ye, Ting; Wu, Hao A; edk2-devel@lists.01.org > Cc: Long, Qin > Subject: [PATCH] CryptoPkg/BaseCryptLib: Add N

Re: [edk2] [PATCH 0/7] MdeModulePkg/Udf: Code refinements

Sure, I will keep an eye on the changes in UDF-related code. Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Tuesday, September 19, 2017 11:31 AM > To: Paulo Alcantara; Wu, Hao A; edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Dong, Eric; Bi, Dandan; Zeng,

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition

One small comment, within function PartitionInstallUdfChildHandles(): ... // // Install partition child handle for UDF file system // Status = PartitionInstallChildHandle ( ... ); if (!EFI_ERROR (Status)) { <- Is this a typo? "if (EFI_ERROR (Status)) {" Status =

Re: [edk2] [PATCH 5/6] MdeModulePkg/Crc32: Fix possible out of range left shift

> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, September 20, 2017 1:06 AM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Dong, Eric; Zeng, Star > Subject: Re: [edk2] [PATCH 5/6] MdeModulePk

Re: [edk2] NVME DXE Driver and PATA SS

Hi, Could you help to provide more information on the firmware which you are using? Is it built by yourself or provided by vender? As far as I know, the edk2 NVME driver only manages the devices, it will not create boot options for them. It's for the BDS-related modules to create boot options

Re: [edk2] [PATCH 3/6] MdeModulePkg/Tpl: Fix negative value left shift

Star and Paolo, Thanks for the feedbacks. I will refine the patch according to your suggestions. Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Thursday, September 21, 2017 10:57 AM > To: Paolo Bonzini; Wu, Hao A; edk2-devel@lists.01.org > Cc: D

  1   2   3   4   5   >