s BmMatchPartitionDevicePathNode() to iterate all
nested partitions so that the above boot option could work.
v2 - Simplify the node matching logic
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Jian J Wang
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin
---
.../L
On Wed, Jan 23, 2019 at 03:49:16AM +, Ni, Ray wrote:
>
>
> > -Original Message-
> > From: Ni, Ray
> > Sent: Wednesday, January 23, 2019 11:48 AM
> > To: 'Gary Lin'
> > Cc: edk2-devel@lists.01.org; Zeng, Star ; Wang, Jian J
> >
ad of using a
> loop. In this new way, you might be able to save some code.
Since my targets are the partition nodes after a partition, loop brings
a bit better performance by skipping the non-partition node check and
saves the overhead of function call.
If you prefer recursive call, I'll mo
RelocBaseEnd.
>
> Cc: Michael D Kinney
> Cc: Liming Gao
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi
Thanks for the patch.
Tested-by: Gary Lin
> ---
> MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 2 +-
> 1 file changed
On Tue, Jan 15, 2019 at 12:58:10PM +0100, Laszlo Ersek wrote:
> On 01/15/19 10:45, Gary Lin wrote:
> > In some cases, such as MD RAID1 in Linux, the bootloader may be in a
> > nested EFI system partition partition. For example, sda1 and sdb1 are
> > combined as md0 and the f
s BmMatchPartitionDevicePathNode() to iterate all
nested partitions so that the above boot option could work.
Cc: Ruiyu Ni
Cc: Star Zeng
Cc: Jian J Wang
Cc: Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin
---
.../Library/UefiBootManagerLib/BmBoot.c
n the latest git branch.
Thanks!
Gary Lin
> Thanks
> Liming
> >-Original Message-
> >From: Gary Lin [mailto:g...@suse.com]
> >Sent: Friday, December 28, 2018 6:40 PM
> >To: Gao, Liming
> >Cc: edk2-devel@lists.01.org; Kinney, Michael D
> >; Lasz
ls: Update windows and linux run scripts file to use Python3
Cheers,
Gary Lin
> But, we have no enough resource to fully verify Python2 and Python3 both.
> We will focus on Python3 validation. If anyone can help verify Python2, it
> will be great. And, if you meet with the issue on Pyth
On Tue, Nov 20, 2018 at 02:37:44PM +, Gao, Liming wrote:
> Reviewed-by: Liming Gao
>
Hi Liming,
Would you mind to help to push to fix into the git repo?
Thanks,
Gary Lin
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Beh
The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing
square bracket mistakenly.
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin
---
MdePkg/Include/IndustryStandard/Acpi61.h | 2 +-
MdePkg/Include/IndustryStandard
Dereference MatchLang before comparing it with a character.
Cc: David Wei
Cc: Mang Guo
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin
---
.../SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c| 2 +-
1 file changed, 1 insertion
On Mon, Oct 08, 2018 at 03:56:48PM +0800, Dongao Guo wrote:
>
> comment unused variable to avoid warning,and modify inf build option.
>
Why not just remove the variables altogether instead of commenting them out?
Is it on purpose?
Gary Lin
> Cc: Liming Gao
> Contributed-u
dling some cases, e.g. "python3:".
This commit adds `|| true` to the grep command to make sure the command
never returns 1 in any condition.
[NOTE: For the python3 branch]
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin
Cc: Liming Gao
Cc: Yonghong Zhu
should I send the patch? to the edk2-devel mailinglist directly?
or a pull request in github?
Thanks,
Gary Lin
> Current we still in doing some validation for this migration, and not finish
> the update for UPT, ECC, EOT, Tests those tools and scripts.
> We already did following on th
Sha384 and Sha512 were added to HashInstanceLib recently. To make them
available in Tcg2Pei and Tcg2Dxe, we have to link both libraries.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Marc-André Lureau
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin
On Tue, Aug 14, 2018 at 06:37:51PM +0200, Laszlo Ersek wrote:
> Hi Gary,
>
> (+ Marc-André)
>
> On 08/14/18 09:36, Gary Lin wrote:
> > Sha384 and Sha512 were added to HashInstanceLib recently. Resolve those
> > two libraries to enable SHA384 and SHA512 support in TPM.
Sha384 and Sha512 were added to HashInstanceLib recently. Resolve those
two libraries to enable SHA384 and SHA512 support in TPM.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin
---
OvmfPkg/OvmfPkgIa32.dsc
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel/doxygen.py
| 3 ++-
BaseTools/Sc
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 9 +
BaseTools/Source/Python/Work
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/UPT/Library/Parsing.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Table/TableDataModel.py | 3 ++-
BaseTools/Source/Python/Table/TableDec.py
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Eot/CParser.py | 5 +++--
BaseTools/Source/Python/Eot/CodeFragmentCollect
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Ecc/CParser.py | 5 ++--
BaseTools/Source/Python/Ecc/Che
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Common/Database.py | 8
BaseTools/Source/Python/Common/EdkLogg
* GenFds.FdfParser => GenFds.Fd => GenFds.GenFds => GenFds.FdfParser
* GenFds.FdfParser => GenFds.Fd => GenFds.Fv => GenFds.GenFds =>
GenFds.FdfParser
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
B
Since Ecc.py import modules from its own directory, add "-m" to the
python parameters so that they can import its own modules after adopting
absolute import.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
Signed-off-by
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/AutoGen/AutoGen.py| 17 +
BaseTools/Source/Python/AutoGen/Ge
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/BPDG/BPDG.py | 5 +++--
BaseTools/Source/Python/BPDG/GenVpd.py | 3 ++-
2 files chang
Since GenFds.py import modules from its own directory, add "-m" to the
python parameters so that they can import its own modules after adopting
absolute import.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
GenFds.OptionRom =>
GenFds.GenFds => GenFds.FdfParser
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/GenFds/AprioriSection.py | 5 +-
BaseTools/Source/Python/GenFds/Capsule.py
Since BPDG.py import modules from its own directory, add "-m" to the
python parameters so that they can import its own modules after adopting
absolute import.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
Move "class OverrideAttribs" to OptRomInfStatement.py to remove
"import OptionRom" which may form a circular import:
GenFds.OptionRom => GenFds.OptRomInfStatement => GenFds.OptionRom
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Ga
tor the
code in the follow-up patches to remove circular import completely.
The patch set is also available in my github branch:
https://github.com/lcp/edk2/tree/python3-absolute-import-v2
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by:
TAB_GUID => DataType.TAB_GUID
TAB_TOD_DEFINES_TARGET => DataType.TAB_TOD_DEFINES_TARGET
TAB_TOD_DEFINES_TOOL_CHAIN_TAG => DataType.TAB_TOD_DEFINES_TOOL_CHAIN_TAG
TAB_TOD_DEFINES_TARGET_ARCH => DataType.TAB_TOD_DEFINES_TARGET_ARCH
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zh
ueError: Attempted relative import in non-package
>
Hmmm, so BPDG also uses the module in its own directory. I'll modify
BPDG in BinWrappers as GenFds.
Thanks,
Gary Lin
> Best Regards,
> Zhu Yonghong
>
>
> -Original Message-
> From: Gary Lin [mailto:g...@suse
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Ecc/CParser.py | 5 ++--
BaseTools/Source/Python/Ecc/Che
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 9 +
BaseTools/Source/Python/Work
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Common/Database.py | 8
BaseTools/Source/Python/Common/EdkLogg
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Table/TableDataModel.py | 3 ++-
BaseTools/Source/Python/Table/TableDec.py
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Eot/CParser.py | 5 +++--
BaseTools/Source/Python/Eot/CodeFragmentCollect
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/BPDG/BPDG.py | 5 +++--
BaseTools/Source/Python/BPDG/GenVpd.py | 3 ++-
2 files chang
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/UPT/Library/Parsing.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel/doxygen.py
| 3 ++-
BaseTools/Sc
Based on "futurize -f libfuturize.fixes.fix_absolute_import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/AutoGen/AutoGen.py| 17 +
BaseTools/Source/Python/AutoGen/Ge
* GenFds.FdfParser => GenFds.Fd => GenFds.GenFds => GenFds.FdfParser
* GenFds.FdfParser => GenFds.Fd => GenFds.Fv => GenFds.GenFds =>
GenFds.FdfParser
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
B
GenFds.OptionRom =>
GenFds.GenFds => GenFds.FdfParser
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/GenFds/AprioriSection.py | 5 +-
BaseTools/Source/Python/GenFds/Capsule.py
Move "class OverrideAttribs" to OptRomInfStatement.py to remove
"import OptionRom" which may form a circular import:
GenFds.OptionRom => GenFds.OptRomInfStatement => GenFds.OptionRom
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Ga
TAB_GUID => DataType.TAB_GUID
TAB_TOD_DEFINES_TARGET => DataType.TAB_TOD_DEFINES_TARGET
TAB_TOD_DEFINES_TOOL_CHAIN_TAG => DataType.TAB_TOD_DEFINES_TOOL_CHAIN_TAG
TAB_TOD_DEFINES_TARGET_ARCH => DataType.TAB_TOD_DEFINES_TARGET_ARCH
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zh
Since GenFds.py import modules from its own directory, add "-m" to the
python parameters so that they can import its own modules after adopting
absolute import.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
also available in my github branch:
https://github.com/lcp/edk2/tree/python3-absolute-import
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
Gary Lin (14):
BaseTools: Treat GenFds.py as a python module
BaseTools: Use abs
the python3 migration:)
Thanks,
Gary Lin
> Best Regards,
> Zhu Yonghong
>
>
> -Original Message-
> From: Gary Lin [mailto:g...@suse.com]
> Sent: Wednesday, June 27, 2018 6:08 PM
> To: edk2-devel@lists.01.org
> Cc: Zhu, Yonghong ; Gao, Liming
> Subjec
so as to
> confirm whether there is the next message header. But it doesn't record the
> parsing message data/length correctly.
>
> This patch is refine the parsing logic so as to fix the potential failure.
>
> Cc: Ye Ting
> Cc: Fu Siyuan
> Cc: Gary Lin
> Contr
first, then I will
> try that.
>
Ah, ok. I'll send you the files privately.
> > bootx64.efi: 1208528 bytes
> > grub.efi: 1057792 bytes
>
> BTW, the issue only happened after applying this patches?
>
Yes. Without the patch, shim can download grub2 s
of bootx64.efi and grub.efi:
bootx64.efi: 1208528 bytes
grub.efi: 1057792 bytes
Gary Lin
> Thanks,
> Jiaxin
>
>
> >
> > > -Original Message-
> > > From: Gary Lin [mailto:g...@suse.com]
> > > Sent: Monday, July 2, 2018 12:17 PM
> &
the OVMF log:
TcpInput: Discard a packet
TcpSendIpPacket: No appropriate IpSender.
This only happened with HTTPS. If I replace the HTTPS URL in dhcpd.conf with
the HTTP URL, it works as expected.
Gary Lin
> Cc: Ye Ting
> Cc: Fu Siyuan
> Contributed-under: TianoCore Contribution
Replace "<>" with "!=" to be compatible with python3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
1 file changed, 1 insertion(+), 1
int' in python3. We can remove
the workaround after moving to python3 completely.
* long() is replaced with int() since int() returns a long when need.
(*) https://www.python.org/dev/peps/pep-0237/
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming
Please note that BaseTools is still not ready, so any error
from python3 interpreter is expected.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
Gary Lin (3):
BaseTools: Remove the old python "not-equal" in DscBuildData.py
./OvmfPkg/build.sh
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/BinWrappers/PosixLike/BPDG | 6 +-
BaseTools/BinWrappers/PosixLike/Ecc | 6 +-
BaseTools/BinWrappers
faceCrb &&
PcdGet8(PcdCRBIdleByPass) == 0xFF) {
^~~
PtpInterface
I assume you mean Tpm2PtpInterfaceCrb?
Cheers,
Gary Lin
> +IdleByPass = Tpm2GetIdleByPass((VOID *) (UI
On Mon, Jun 25, 2018 at 06:31:23PM +0800, Gary Lin wrote:
> v4 changes:
v4 is rebased to 3b03b5e990f8bb347dfdb91926d8ef015d0b607e
> - Remove the range() patch since it needs python-future
> - Remove the patch to unify long and int since it caused error in
> windows.
>
Replace StringIO.StringIO with io.BytesIO to be compatible with python3.
This commit also removes "import StringIO" from those python scripts
that don't really use it.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
"while 1:" into "while True:".
* Change both
v = list(EXPR)
v.sort()
foo(v)
and the more general
v = EXPR
v.sort()
foo(v)
into
v = sorted(EXPR)
foo(v)
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Ga
"types.TypeType" is now an alias of the built-in "type" and is not
compatible with python 3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Tests/TestTools.py | 3 +--
1 file changed, 1 inser
Make "raise" to be compatible with python3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/gcc/mingw-gcc-build.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/gcc
Change the octal literals according to PEP3127
https://www.python.org/dev/peps/pep-3127/
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Common/LongFilePathOs.py | 2 +-
BaseTools/Source/Python/UPT
uture.org/automatic_conversion.html#stage-1-safe-fixes
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
Gary Lin (13):
BaseTools: Fix a typo in ini.py
BaseTools: Refactor python except statements
BaseTools: Refactor python pr
Convert "except ... ," to "except ... as" to be compatible with python3.
Based on "futurize -f lib2to3.fixes.fix_except"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Script
Replace "has_key()" with "in" to be compatible with python3.
Based on "futurize -f lib2to3.fixes.fix_has_key"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Scripts/PackageDocumentTool
Replace "<>" with "!=" to be compatible with python3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +-
BaseT
According to PEP3113, tuple parameter is removed in python 3.
(PEP3113: https://www.python.org/dev/peps/pep-3113/)
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Common/VpdInfoFile.py | 3 ++-
1 file
"if mis not None:" => "if m is not None:"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Jaben Carsey
Cc: Yonghong Zhu
Cc: Liming Gao
Reviewed-by: Jaben Carsey
Signed-off-by: Gary Lin
---
BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel
StandardError has been removed from python 3.
Replace it with Exception.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/UPT/UPT.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Refactor print statements to be compatible with python 3.
Based on "futurize -f libfuturize.fixes.fix_print_with_import"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_
On Mon, Jun 25, 2018 at 05:58:42AM +, Zhu, Yonghong wrote:
> You're correct, it is Patch 13 cause the 'long' type issue.
>
Thanks for the confirmation! I'll revert the patch in the next version.
Gary Lin
> Best Regards,
> Zhu Yonghong
>
>
> --
reproduce the error, would you mind to bisect through
patch 1~13 if reverting patch 13 doesn't work?
Thanks,
Gary Lin
> Best Regards,
> Zhu Yonghong
>
>
> -Original Message-
> From: Gary Lin [mailto:g...@suse.com]
> Sent: Friday, June 22, 2018 5:48 PM
> T
ks,
Gary Lin
> Best Regards,
> Zhu Yonghong
>
>
> -Original Message-
> From: Zhu, Yonghong
> Sent: Friday, June 22, 2018 5:22 PM
> To: 'Gary Lin'
> Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhu,
> Yonghong
> Subject: RE: [edk2] [PATCH v3
#x27; or '/m' though. The goal is treat
build and GenFds as modules to avoid the error you saw.
Thanks,
Gary Lin
> Best Regards,
> Zhu Yonghong
>
>
> -Original Message-
> From: Gary Lin [mailto:g...@suse.com]
> Sent: Friday, June 22, 2018 4:46 PM
&g
On Fri, Jun 22, 2018 at 04:21:23PM +0800, Gary Lin wrote:
> On Fri, Jun 22, 2018 at 05:29:21AM +, Zhu, Yonghong wrote:
> > Hi Gary,
> >
> > Patch 03 used some Tab characters, Patch 17 has some Trailing whitespace.
> > You can use the BaseTools\Scripts\PatchC
uild OVMF platform, it directly report error:
> from .BuildReport import BuildReport
> ValueError: Attempted relative import in non-package
>
I didn't see this in my system. Will investigate what's wrong.
Thanks,
Gary Lin
> Best Regards,
> Zhu Yonghong
>
>
ly from
python-future.
I'll revert this patch and post a new patchset.
BTW, would you might review the first patch? It's just a typo fix and I
just caught it while running the futurize script, so the patch is
actually independent from this patch series.
Thanks,
Gary Lin
> Best
On Thu, Jun 21, 2018 at 12:43:28PM +0800, Gary Lin wrote:
> Convert "except ... ," to "except ... as" to be compatible with python3.
> Based on "futurize -f lib2to3.fixes.fix_except"
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Cc: Yo
Move "class OverrideAttribs" to OptRomInfStatement.py to remove
"import OptionRom" which may form a circular import:
GenFds.OptionRom => GenFds.OptRomInfStatement => GenFds.OptionRom
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Ga
TAB_GUID => DataType.TAB_GUID
TAB_TOD_DEFINES_TARGET => DataType.TAB_TOD_DEFINES_TARGET
TAB_TOD_DEFINES_TOOL_CHAIN_TAG => DataType.TAB_TOD_DEFINES_TOOL_CHAIN_TAG
TAB_TOD_DEFINES_TARGET_ARCH => DataType.TAB_TOD_DEFINES_TARGET_ARCH
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zh
According to PEP237, long int and int are unified.
https://www.python.org/dev/peps/pep-0237/
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Common/Expression.py | 3 +--
1 file changed, 1 insertion
GenFds.OptionRom =>
GenFds.GenFds => GenFds.FdfParser
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Scripts/PackageDocumentTools/packagedoc_cli.py
| 5 +-
BaseTools/Scripts/PackageDo
Since GenFds.py and build.py import modules from its own directory, add
"-m" to the python parameters so that they can import its own modules.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/BinWrappers
"while 1:" into "while True:".
* Change both
v = list(EXPR)
v.sort()
foo(v)
and the more general
v = EXPR
v.sort()
foo(v)
into
v = sorted(EXPR)
foo(v)
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Ga
* GenFds.FdfParser => GenFds.Fd => GenFds.GenFds => GenFds.FdfParser
* GenFds.FdfParser => GenFds.Fd => GenFds.Fv => GenFds.GenFds =>
GenFds.FdfParser
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
B
Change the octal literals according to PEP3127
https://www.python.org/dev/peps/pep-3127/
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/Common/LongFilePathOs.py | 2 +-
BaseTools/Source/Python/UPT
Make "raise" to be compatible with python3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/gcc/mingw-gcc-build.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/gcc
Replace StringIO.StringIO with io.BytesIO to be compatible with python3.
This commit also removes "import StringIO" from those python scripts
that don't really use it.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
Convert "except ... ," to "except ... as" to be compatible with python3.
Based on "futurize -f lib2to3.fixes.fix_except"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Script
ror
so far.
(*) http://python-future.org/automatic_conversion.html#stage-1-safe-fixes
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
Gary Lin (20):
BaseTools: Fix a typo in ini.py
BaseTools: Refactor python except statements
Replace "<>" with "!=" to be compatible with python3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +-
BaseT
StandardError has been removed from python 3.
Replace it with Exception.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Source/Python/UPT/UPT.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Replace "has_key()" with "in" to be compatible with python3.
Based on "futurize -f lib2to3.fixes.fix_has_key"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Scripts/PackageDocumentTool
Replace xrange() and range() with the newer range() function
Based on "futurize -f libfuturize.fixes.fix_xrange_with_import"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Scripts/B
"if mis not None:" => "if m is not None:"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Jaben Carsey
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel/ini.py | 2
+-
1 file cha
"types.TypeType" is now an alias of the built-in "type" and is not
compatible with python 3.
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu
Cc: Liming Gao
Signed-off-by: Gary Lin
---
BaseTools/Tests/TestTools.py | 3 +--
1 file changed, 1 inser
1 - 100 of 372 matches
Mail list logo