Re: [edk2] [PATCH 12/12] Vlv2TbltDevicePkg: Convert to build FatPkg from source
it is good for me. Reviewed-by: Tim He
Best Regards,
Tim
-Original Message-
From: Justen, Jordan L
Sent: Thursday, April 21, 2016 1:14 AM
To: edk2-devel@lists.01.org; Wei, David; He, Tim
Subject: Re: [PATCH 12/12] Vlv2TbltDevicePkg: Convert to build FatPkg from
source
David, Tim,
Any thoughts about this patch?
-Jordan
On 2016-04-06 08:15:01, Jordan Justen wrote:
> Now that FatPkg is open source (and therefore can be included in the
> EDK II tree) we build and use it directly.
>
> Note: Not build tested
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jordan Justen
> Cc: David Wei
> Cc: Tim He
> ---
> Vlv2TbltDevicePkg/PlatformPkg.fdf | 7 +++
> Vlv2TbltDevicePkg/PlatformPkgGcc.fdf| 7 +++
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 +
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc| 1 +
> 5 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf
> b/Vlv2TbltDevicePkg/PlatformPkg.fdf
> index 53d9dd4..f0c57b8 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkg.fdf
> +++ b/Vlv2TbltDevicePkg/PlatformPkg.fdf
> @@ -1,7 +1,7 @@
> #/** @file
> # FDF file of Platform.
> #
> -# Copyright (c) 2008 - 2015, Intel Corporation. All rights
> reserved.
> +# Copyright (c) 2008 - 2016, Intel Corporation. All rights
> +reserved.
> #
>
> # This program and the accompanying materials are licensed and made
> available under # the terms and conditions of the BSD License that
> accompanies this distribution.
> @@ -657,9 +657,8 @@ INF
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> #
> # FAT file system
> #
> -FILE DRIVER = 961578FE-B6B7-44c3-AF35-6BC705CD2B1F {
> -SECTION PE32 = FatBinPkg/EnhancedFatDxe/$(EDK_DXE_ARCHITECTURE)/Fat.efi
> - }
> +INF FatPkg/EnhancedFatDxe/Fat.inf
> +
> #
> # UEFI Shell
> #
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
> b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
> index d26530c..6474429 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
> +++ b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
> @@ -1,7 +1,7 @@
> #/** @file
> # FDF file of Platform.
> #
> -# Copyright (c) 2008 - 2015, Intel Corporation. All rights
> reserved.
> +# Copyright (c) 2008 - 2016, Intel Corporation. All rights
> +reserved.
> #
>
> # This program and the accompanying materials are licensed and made
> available under # the terms and conditions of the BSD License that
> accompanies this distribution.
> @@ -614,9 +614,8 @@ INF
> PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> #
> # FAT file system
> #
> -FILE DRIVER = 961578FE-B6B7-44c3-AF35-6BC705CD2B1F {
> -SECTION PE32 = FatBinPkg/EnhancedFatDxe/$(EDK_DXE_ARCHITECTURE)/Fat.efi
> - }
> +INF FatPkg/EnhancedFatDxe/Fat.inf
> +
> #
> # UEFI Shell
> #
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> index c78ff87..d76f08e 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> @@ -1400,6 +1400,7 @@
> $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
>MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>
> MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> + FatPkg/EnhancedFatDxe/Fat.inf
> !if $(SATA_ENABLE) == TRUE
>
> $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITEC
> TURE)/SataController.inf
> !endif
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index dd5f383..b0dabd9 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -1381,6 +1381,7 @@
> $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
>MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>
> MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> + FatPkg/EnhancedFatDxe/Fat.inf
> !if $(SATA_ENABLE) == TRUE
>
> $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ARCHITEC
> TURE)/SataController.inf
> !endif
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 7b04efa..bc5cfd8 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -1387,
Re: [edk2] [PATCH] Initialize century of RTC CMOS.
Reviewed-by: Tim He
-Original Message-
From: Wei, David
Sent: Wednesday, April 13, 2016 3:49 PM
To: edk2-devel@lists.01.org
Cc: He, Tim; ruiy...@intel.com
Subject: [PATCH] Initialize century of RTC CMOS.
Initialize century of RTC CMOS, in case that SetTime service does not set it.
---
Vlv2TbltDevicePkg/PlatformDxe/Rtc.c | 16
1 file changed, 16 insertions(+)
diff --git a/Vlv2TbltDevicePkg/PlatformDxe/Rtc.c
b/Vlv2TbltDevicePkg/PlatformDxe/Rtc.c
index caa042f..9415b7e 100644
--- a/Vlv2TbltDevicePkg/PlatformDxe/Rtc.c
+++ b/Vlv2TbltDevicePkg/PlatformDxe/Rtc.c
@@ -22,6 +22,13 @@
#define RTC_INIT_SECOND 0
#define RTC_INIT_MINUTE 0
#define RTC_INIT_HOUR 0
+
+#define RTC_ADDRESS_CENTURY 50 // R/W Range 19..20 Bit 8 is R/W
+
+#define RTC_ADDRESS_REGISTER 0x70
+#define RTC_DATA_REGISTER0x71
+
+
CHAR16 mBiosReleaseDate[20];
@@ -91,6 +98,7 @@ AdjustDefaultRtcTimeCallback ( {
EFI_STATUS Status;
EFI_TIMEEfiTime;
+ UINT8 Century;
CHAR16 BiosVersion[60];
CHAR16 BiosReleaseTime[20];
//
@@ -154,6 +162,14 @@ AdjustDefaultRtcTimeCallback (
//
Status = gRT->SetTime (&EfiTime);
ASSERT_EFI_ERROR(Status);
+
+//
+// Set the RTC century in case that UEFI SetTime sevice does not set this
register.
+//
+Century= DecimalToBcd8 ((UINT8) (EfiTime.Year / 100));
+IoWrite8 (RTC_ADDRESS_REGISTER, (UINT8) (RTC_ADDRESS_CENTURY | (UINT8)
(IoRead8 (PCAT_RTC_ADDRESS_REGISTER) & 0x80)));
+IoWrite8 (RTC_DATA_REGISTER, Century);
+
}
return;
--
2.7.1.windows.2
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] Vlv2DeviceRefCodePkg/Vlv2TbltDevicePkg: Reset BIOS Setup when Jumper is present on Turbot.
Reviewed-by: Tim He
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of lushifex
Sent: Thursday, December 03, 2015 6:15 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] Vlv2DeviceRefCodePkg/Vlv2TbltDevicePkg: Reset BIOS
Setup when Jumper is present on Turbot.
Signed-off-by: lushifex
---
.../SouthCluster/Include/Library/PchPlatformLib.h | 9 ++
Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 19 ++--
.../MultiPlatformLib/BoardClkGens/BoardClkGens.c | 6 +-
.../MultiPlatformLib/BoardClkGens/BoardClkGens.h | 2 +
.../MultiPlatformLib/BoardGpios/BoardGpios.c | 15 +++
.../MultiPlatformLib/BoardGpios/BoardGpios.h | 1 +
.../Library/MultiPlatformLib/MultiPlatformLib.inf | 1 +
.../Library/PchPlatformLib/PchPlatformLibrary.c| 108 +
.../Library/PlatformBdsLib/BdsPlatform.c | 29 --
.../Library/PlatformBdsLib/PlatformBdsLib.inf | 1 +
Vlv2TbltDevicePkg/PciPlatform/PciPlatform.c| 8 +-
Vlv2TbltDevicePkg/PciPlatform/PciPlatform.inf | 1 +
Vlv2TbltDevicePkg/PlatformDxe/ExI.c| 8 +-
Vlv2TbltDevicePkg/PlatformDxe/Platform.c | 51 +-
.../PlatformGopPolicy/PlatformGopPolicy.c | 9 +-
.../PlatformGopPolicy/PlatformGopPolicy.inf| 3 +
.../PlatformInfoDxe/PlatformInfoDxe.c | 9 +-
.../PlatformInfoDxe/PlatformInfoDxe.inf| 1 +
Vlv2TbltDevicePkg/PlatformInitPei/BootMode.c | 6 +-
.../PlatformInitPei/PlatformEarlyInit.c| 7 +-
Vlv2TbltDevicePkg/PlatformPei/BootMode.c | 16 +++
Vlv2TbltDevicePkg/PlatformPei/Platform.c | 7 +-
Vlv2TbltDevicePkg/PlatformPei/PlatformPei.inf | 1 +
.../PlatformSetupDxe/PlatformSetupDxe.inf | 1 +
.../PlatformSetupDxe/SetupInfoRecords.c| 7 +-
Vlv2TbltDevicePkg/PlatformSmm/Platform.c | 15 ++-
26 files changed, 300 insertions(+), 41 deletions(-)
diff --git
a/Vlv2DeviceRefCodePkg/ValleyView2Soc/SouthCluster/Include/Library/PchPlatformLib.h
b/Vlv2DeviceRefCodePkg/ValleyView2Soc/SouthCluster/Include/Library/PchPlatformLib.h
index 8f0ca02..9651f94 100644
---
a/Vlv2DeviceRefCodePkg/ValleyView2Soc/SouthCluster/Include/Library/PchPlatformLib.h
+++ b/Vlv2DeviceRefCodePkg/ValleyView2Soc/SouthCluster/Include/Library/P
+++ chPlatformLib.h
@@ -115,7 +115,16 @@ PchAlternateAccessMode (
@retval NONE
**/
;
+UINT32
+DetectTurbotBoard (
+VOID
+ );
+
+UINT32
+DetectGpioPinValue (
+VOID
+ );
#endif
diff --git a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c
b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c
index 2ff14ec..a7e54e3 100644
--- a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c
+++ b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c
@@ -646,10 +646,11 @@ OnReadyToBoot (
SYSTEM_CONFIGURATIONSetupVarBuffer;
UINTN VariableSize;
EFI_PLATFORM_CPU_INFO *PlatformCpuInfoPtr = NULL;
EFI_PLATFORM_CPU_INFO PlatformCpuInfo;
EFI_PEI_HOB_POINTERS GuidHob;
+ UINT32 DxeGpioValue;
if (mFirstNotify) {
return;
}
@@ -684,10 +685,12 @@ OnReadyToBoot (
if ((PlatformCpuInfoPtr != NULL)) {
CopyMem(&PlatformCpuInfo, PlatformCpuInfoPtr,
sizeof(EFI_PLATFORM_CPU_INFO));
}
+ DxeGpioValue = DetectGpioPinValue();
+
//
// Update the ACPI parameter blocks finally.
//
VariableSize = sizeof (SYSTEM_CONFIGURATION);
Status = gRT->GetVariable (
@@ -695,12 +698,12 @@ OnReadyToBoot (
&mSystemConfigurationGuid,
NULL,
&VariableSize,
&SetupVarBuffer
);
- if (EFI_ERROR (Status) || VariableSize != sizeof(SYSTEM_CONFIGURATION)) {
-//The setup variable is corrupted
+ if (EFI_ERROR (Status) || VariableSize != sizeof(SYSTEM_CONFIGURATION) ||
DxeGpioValue == 0) {
+//The setup variable is corrupted or detect GPIO_S5_17 Pin is low
VariableSize = sizeof(SYSTEM_CONFIGURATION);
Status = gRT->GetVariable(
L"SetupRecovery",
&mSystemConfigurationGuid,
NULL,
@@ -794,10 +797,11 @@ AcpiPlatformEntryPoint (
EFI_MP_SERVICES_PROTOCOL *MpService;
UINTN MaximumNumberOfCPUs;
UINTN NumberOfEnabledCPUs;
UINT32Data32;
PCH_STEPPING pchStepping;
+ UINT32DxeGpioValue;
mFirstNotify = FALSE;
TableVersion = EFI_ACPI_TABLE_VERSION_2_0;
Instance = 0;
@@ -813,11 +817,12 @@ AcpiPlatformEntryPoint (
if (GuidHob.Raw != NULL) {
if ((GuidHob.Raw = GetNextGuidHob (&gEfiPlatformInfoGuid, GuidHob.Raw)) !=
NULL) {
mPlatformInfo = GET_GUID_HOB_DATA (GuidHob.Guid);
}
}
-
+
+ DxeGpioValue = DetectGpioPinValue();
//
// Search for the Memory Configuration GUID HOB. If it is n
Re: [edk2] [Patch] [patch] Vlv2TbltDevicePkg: Add SsdtUpdate Application to update Ssdt table to ACPI table.
Reviewed-by: Tim He
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of lushifex
Sent: Tuesday, December 01, 2015 2:42 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] [patch] Vlv2TbltDevicePkg: Add SsdtUpdate Application
to update Ssdt table to ACPI table.
Signed-off-by: lushifex
---
.../Application/SsdtUpdate/SsdtUpdate.asl | 28 +++
.../Application/SsdtUpdate/SsdtUpdate.c| 200 +
.../Application/SsdtUpdate/SsdtUpdate.h| 39
.../Application/SsdtUpdate/SsdtUpdate.inf | 64 +++
Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc| 1 +
Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
7 files changed, 334 insertions(+)
create mode 100644 Vlv2TbltDevicePkg/Application/SsdtUpdate/SsdtUpdate.asl
create mode 100644 Vlv2TbltDevicePkg/Application/SsdtUpdate/SsdtUpdate.c
create mode 100644 Vlv2TbltDevicePkg/Application/SsdtUpdate/SsdtUpdate.h
create mode 100644 Vlv2TbltDevicePkg/Application/SsdtUpdate/SsdtUpdate.inf
diff --git a/Vlv2TbltDevicePkg/Application/SsdtUpdate/SsdtUpdate.asl
b/Vlv2TbltDevicePkg/Application/SsdtUpdate/SsdtUpdate.asl
new file mode 100644
index 000..bdf48fa
--- /dev/null
+++ b/Vlv2TbltDevicePkg/Application/SsdtUpdate/SsdtUpdate.asl
@@ -0,0 +1,28 @@
+/** @file
+ The definition block in ACPI table for Genernal device.
+
+ Copyright (c) 2015, Intel Corporation. All rights reserved.
+
+ This program and the accompanying materials are licensed and made
+ available under the terms and conditions of the BSD License which
+ accompanies this distribution. The full text of the license may be
+ found at http://opensource.org/licenses/bsd-license.php
+
+ THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+DefinitionBlock (
+ "Gene.aml",
+ "SSDT",
+ 2,
+ "INTEL ",
+ "GeneTabl",
+ 0x1000
+ )
+{
+ Scope (\_SB)
+ {
+ }
+}
diff --git a/Vlv2TbltDevicePkg/Application/SsdtUpdate/SsdtUpdate.c
b/Vlv2TbltDevicePkg/Application/SsdtUpdate/SsdtUpdate.c
new file mode 100644
index 000..f50a76d
--- /dev/null
+++ b/Vlv2TbltDevicePkg/Application/SsdtUpdate/SsdtUpdate.c
@@ -0,0 +1,200 @@
+/** @file
+ Update SSDT table to ACPI table.
+
+ Copyright (c) 2013 - 2015, Intel Corporation. All rights
+ reserved.
+
+ This program and the accompanying materials are licensed and made
+ available under the terms and conditions of the BSD License which
+ accompanies this distribution. The full text of the license may be
+ found at http://opensource.org/licenses/bsd-license.php
+
+ THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#include "SsdtUpdate.h"
+
+FV_INPUT_DATA mInputData = {0};
+
+/**
+ Read file data from given file name.
+
+ @param[in] FileNamePointer the readed given file name.
+ @param[out] Buffer The buffer which read the given file name's data.
+ @param[out] BufferSize The buffer size which read the given file name's
data.
+
+ @retval EFI_SUCCESS The file data is successfully readed.
+ @retval EFI_ERROR The file data is unsuccessfully readed.
+
+**/
+STATIC
+EFI_STATUS
+ReadFileData (
+ IN CHAR16 *FileName,
+ OUT UINT8**Buffer,
+ OUT UINT32 *BufferSize
+ )
+{
+ EFI_STATUS Status;
+ SHELL_FILE_HANDLE FileHandle;
+ UINT64 Size;
+ VOID *NewBuffer;
+ UINTN ReadSize;
+
+ FileHandle = NULL;
+ NewBuffer = NULL;
+ Size = 0;
+
+ Status = ShellOpenFileByName (FileName, &FileHandle,
+ EFI_FILE_MODE_READ, 0); if (EFI_ERROR (Status)) {
+goto Done;
+ }
+
+ Status = FileHandleIsDirectory (FileHandle); if (!EFI_ERROR
+ (Status)) {
+Status = EFI_NOT_FOUND;
+goto Done;
+ }
+
+ Status = FileHandleGetSize (FileHandle, &Size); if (EFI_ERROR
+ (Status)) {
+goto Done;
+ }
+
+ NewBuffer = AllocatePool ((UINTN) Size);
+
+ ReadSize = (UINTN) Size;
+ Status = FileHandleRead (FileHandle, &ReadSize, NewBuffer); if
+ (EFI_ERROR (Status)) {
+goto Done;
+ } else if (ReadSize != (UINTN) Size) {
+Status = EFI_INVALID_PARAMETER;
+goto Done;
+ }
+
+Done:
+ if (FileHandle != NULL) {
+ShellCloseFile (&FileHandle);
+ }
+
+ if (EFI_ERROR (Status)) {
+if (NewBuffer != NULL) {
+ FreePool (NewBuffer);
+}
+ } else {
+*Buffer = NewBuffer;
+*BufferSize = (UINT32) Size;
+ }
+
+ return Status;
+}
+
+/**
+ Initialize and publish device in ACPI table.
+
+ @param[in] Table The pointer to the ACPI table which will be
published.
+ @param[in] TableSize The size of ACPI table which will be published.
+
+ @retval EFI_SUCCESS The ACPI table is published successfully.
+ @retval Others
Re: [edk2] Vlv2TbltDevicePkg/GenBiosId binary
Yes, the GenBiosId is 32-bit ELF binary, because we need to support GCC build on Linux 32bit system. Best Regards, Tim -Original Message- From: Justen, Jordan L Sent: Wednesday, November 25, 2015 6:04 AM To: Wei, David; He, Tim Cc: edk2-devel@lists.01.org Subject: Vlv2TbltDevicePkg/GenBiosId binary David, Tim, I wonder why this binary exists in EDK II without source code. I also notice that Vlv2TbltDevicePkg/GenBiosId is a 32-bit ELF executable. What if someone wanted to build Vlv2TbltDevicePkg on X64 and they didn't have 32-bit userspace available? -Jordan ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] Add BIOS Item "RTC Battery Present"
Reviewed-by: Tim He
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of lushifex
Sent: Wednesday, November 04, 2015 1:05 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] Add BIOS Item "RTC Battery Present"
Signed-off-by: lushifex
---
Vlv2DeviceRefCodePkg/AcpiTablesPCAT/GloblNvs.asl | 5 +++--
Vlv2DeviceRefCodePkg/AcpiTablesPCAT/PciTree.asl| 14 --
Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 3 ++-
Vlv2TbltDevicePkg/Include/Guid/SetupVariable.h | 2 +-
Vlv2TbltDevicePkg/Include/Protocol/GlobalNvsArea.h | 3 ++-
.../PlatformSetupDxe/SouthClusterConfig.vfi| 10 +-
Vlv2TbltDevicePkg/PlatformSetupDxe/UqiList.uni | Bin 65892 -> 66540 bytes
Vlv2TbltDevicePkg/PlatformSetupDxe/VfrStrings.uni | Bin 214666 -> 215420 bytes
8 files changed, 29 insertions(+), 8 deletions(-)
diff --git a/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/GloblNvs.asl
b/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/GloblNvs.asl
index fffc829..21e526c 100644
--- a/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/GloblNvs.asl
+++ b/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/GloblNvs.asl
@@ -3,11 +3,11 @@
;**;
;*Intel Corporation - ACPI Reference Code for the Baytrail*;
;*Family of Customer Reference Boards.*;
;**;
;**;
-;*Copyright (c) 1999 - 2014, Intel Corporation. All rights reserved *;
+;*Copyright (c) 1999 - 2015, Intel Corporation. All rights reserved *;
;
; This program and the accompanying materials are licensed and made available
under ; the terms and conditions of the BSD License that accompanies this
distribution.
; The full text of the license may be found at ;
http://opensource.org/licenses/bsd-license.php.
@@ -345,8 +345,9 @@ Field(GNVS,AnyAcc,Lock,Preserve)
UTS, 8, //(788) Enable Test Device connected to URT for WHCK test.
SCPE, 8, //(789) Allow higher performance on AC/USB - Enable/Disable
Offset(792),
EDPV, 8, //(792) Check for eDP display device
DIDX, 32, //(793) Device ID for eDP device
- IOT, 8, //(794) MinnowBoard Max JP1 is configured for MSFT IOT
project.
+ IOT, 8, //(794) MinnowBoard Max JP1 is configured for MSFT IOT
project.
+ BATT, 8, //(795) The Flag of RTC Battery Prensent.
}
diff --git a/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/PciTree.asl
b/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/PciTree.asl
index 84a7ee2..2a57d0f 100644
--- a/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/PciTree.asl
+++ b/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/PciTree.asl
@@ -3,11 +3,11 @@
;**;
;*Intel Corporation - ACPI Reference Code for the Sandy Bridge*;
;*Family of Customer Reference Boards.*;
;**;
;**;
-;*Copyright (c) 2012 - 2014, Intel Corporation. All rights reserved*;
+;*Copyright (c) 2012 - 2015, Intel Corporation. All rights reserved*;
;
; This program and the accompanying materials are licensed and made available
under ; the terms and conditions of the BSD License that accompanies this
distribution.
; The full text of the license may be found at ;
http://opensource.org/licenses/bsd-license.php.
@@ -19,20 +19,30 @@
;**;
;**/
Scope(\_SB)
{
-
//RTC
Device(RTC)// RTC
{
Name(_HID,EISAID("PNP0B00"))
Name(_CRS,ResourceTemplate()
{
IO(Decode16,0x70,0x70,0x01,0x08)
})
+
+Method(_STA,0,Serialized) {
+
+ //
+ // Report RTC Battery is Prensent or Not Present.
+ //
+ If (LEqual(BATT, 1)) {
+Return (0xF)
+ }
+ Return (0x0)
+}
}
//RTC
Device(HPET) // High Performance Event Timer
{
diff --git a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c
b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c
index c39c36d..2ff14ec 100644
--- a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c
+++ b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c
@@ -1,8 +1,8 @@
/** @file
- Copyright (c) 2004 - 2014, Intel Corporation. All rights reserved.
+ Copyright (c) 2004 - 2015, Intel Corporation. All rights
+ reserved.
This program and the accompanying materials are licensed and made available
under
the terms and conditions of the BSD License that accompanies this
distribution.
@@ -966,10 +966,11 @@ Acpi
Re: [edk2] [Patch]Vlv2TbltDevicePkg: Update some smbios string and macro name for Turbot board
Adding patch file, which is to update some Smbios string and macro name for MinnowBoard Turbot board. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tim He mailto:tim...@intel.com>> Best Regards, Tim From: He, Tim Sent: Thursday, September 17, 2015 4:34 PM To: 'edk2-devel@lists.01.org'; Wei, David; Lu, ShifeiX A Subject: [edk2][Patch]Vlv2TbltDevicePkg: Update some smbios string and macro name for Turbot board Update some smbios string and macro name for MinnowBoard Turbot board. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tim He mailto:tim...@intel.com>> Best Regards, Tim ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [Patch]Vlv2TbltDevicePkg: Update some smbios string and macro name for Turbot board
Update some smbios string and macro name for MinnowBoard Turbot board. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Tim He mailto:tim...@intel.com>> Best Regards, Tim ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 08/15] Vlv2TbltDevicePkg: Add VarCheckLib library mapping
Reviewed-by: Tim He -Original Message- From: Zeng, Star Sent: Monday, August 17, 2015 4:24 PM To: edk2-devel@lists.01.org Cc: Wei, David; He, Tim Subject: [PATCH 08/15] Vlv2TbltDevicePkg: Add VarCheckLib library mapping Since Variable driver has been updated to consume the separated VarCheckLib. Cc: David Wei Cc: Tim He Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + Vlv2TbltDevicePkg/PlatformPkgX64.dsc| 1 + 3 files changed, 3 insertions(+) diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc index 45008a0..39884af 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc @@ -267,6 +267,7 @@ [LibraryClasses.common] TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf !endif + VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf !if $(RC_BINARY_RELEASE) == TRUE I2cLib|Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf !endif diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc index 2fa7a36..e89b5f9 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc @@ -267,6 +267,7 @@ [LibraryClasses.common] TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf !endif + VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf !if $(RC_BINARY_RELEASE) == TRUE I2cLib|Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf !endif diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc index 4e0a9f8..fc8334f 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc @@ -267,6 +267,7 @@ [LibraryClasses.common] TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf !endif + VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf !if $(RC_BINARY_RELEASE) == TRUE I2cLib|Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf !endif -- 1.9.5.msysgit.0 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 15/15] Vlv2TbltDevicePkg: Link separated VarCheckUefiLib NULL class library instance
Reviewed-by: Tim He
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, August 17, 2015 4:24 PM
To: edk2-devel@lists.01.org
Cc: He, Tim; Wei, David
Subject: [edk2] [PATCH 15/15] Vlv2TbltDevicePkg: Link separated VarCheckUefiLib
NULL class library instance
Cc: David Wei
Cc: Tim He
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 +
Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
Vlv2TbltDevicePkg/PlatformPkgX64.dsc| 1 +
3 files changed, 3 insertions(+)
diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
index 39884af..5c0b68a 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
@@ -1157,6 +1157,7 @@ [Components.X64]
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf {
+ NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
}
$(PLATFORM_PACKAGE)/FvbRuntimeDxe/FvbSmm.inf
diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
index e89b5f9..dad2eb0 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
@@ -1144,6 +1144,7 @@ [Components.IA32]
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf {
+ NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
}
$(PLATFORM_PACKAGE)/FvbRuntimeDxe/FvbSmm.inf
diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index fc8334f..e32092e 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -1150,6 +1150,7 @@ [Components.X64]
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf {
+ NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
}
$(PLATFORM_PACKAGE)/FvbRuntimeDxe/FvbSmm.inf
--
1.9.5.msysgit.0
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] Vlv2TbltDevicePkg: Fix the UEFI version reported in the Minnowboard MAX information screen
Sure, we'll apply the patch to change the string. Thank you Bruce. Best Regards, Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bruce Cran Sent: Wednesday, July 29, 2015 12:31 PM To: Wei, David; He, Tim Cc: edk2-devel@lists.01.org Subject: [edk2] Vlv2TbltDevicePkg: Fix the UEFI version reported in the Minnowboard MAX information screen Hi Tim and David, Could you apply the patch at https://github.com/bcran/edk2/commit/dfd96af00bf874a31fb16119ae1671f9f22da17c which changes the UEFI version reported in HII from 2.3.1 to 2.40 please? The patch makes the following changes: #string STR_CORE_VERSION_VALUE #language en-US "UEFI 2.3.1" to #string STR_CORE_VERSION_VALUE #language en-US "UEFI 2.40" This will make it match the output of the 'ver' command in the UEFI Shell, which reports: UEFI Interactive Shell v2.1 EDK II UEFI v2.40 (EDK II, 0x0001) Thanks. Bruce ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] Vlv2TbltDevicePkg: Exclude CapsuleX64 from IA32 build
Reviewed-by: Tim He
-Original Message-
From: Zeng, Star
Sent: Tuesday, July 28, 2015 6:08 PM
To: edk2-devel@lists.01.org
Cc: Wei, David; He, Tim
Subject: [PATCH] Vlv2TbltDevicePkg: Exclude CapsuleX64 from IA32 build
CapsuleX64 is for 64bits capsule data access in PEI phase, it is only needed
for X64 DXE build.
Cc: David Wei
Cc: Tim He
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
Vlv2TbltDevicePkg/PlatformPkg.fdf | 2 ++
Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 2 ++
Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 9 -
3 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf
b/Vlv2TbltDevicePkg/PlatformPkg.fdf
index 80ce20d..03cabb9 100644
--- a/Vlv2TbltDevicePkg/PlatformPkg.fdf
+++ b/Vlv2TbltDevicePkg/PlatformPkg.fdf
@@ -359,8 +359,10 @@ [FV.FVRECOVERY]
!if $(CAPSULE_ENABLE) == TRUE
INF MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
+!if $(DXE_ARCHITECTURE) == "X64"
INF MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
!endif
+!endif
!if $(MINNOW2_FSP_BUILD) == FALSE
!if $(PCIESC_ENABLE) == TRUE
diff --git a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
index f556853..9ec4ce5 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
+++ b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf
@@ -317,8 +317,10 @@ [FV.FVRECOVERY]
!if $(CAPSULE_ENABLE) == TRUE
INF MdeModulePkg/Universal/CapsulePei/CapsulePei.inf
+!if $(DXE_ARCHITECTURE) == "X64"
INF MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
!endif
+!endif
!if $(MINNOW2_FSP_BUILD) == FALSE
!if $(PCIESC_ENABLE) == TRUE
diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
index 39054cf..2fa7a36 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
@@ -1100,15 +1100,6 @@ [Components.IA32] !endif
}
-!if $(CAPSULE_ENABLE) == TRUE
- MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf {
-
-PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf
-
MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
-HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
- }
-!endif
-
MdeModulePkg/Universal/ReportStatusCodeRouter/Smm/ReportStatusCodeRouterSmm.inf
MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf{
--
1.9.5.msysgit.0
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] Vlv2DeviceRefCodePkg: don't redefine struct typedefs
Yes, these 2 typedefs is being defined twice, we need to remove the second
definition, I will check in the code patch. thank you Bruce.
Best Regards,
Tim
-Original Message-
From: Bruce Cran [mailto:br...@cran.org.uk]
Sent: Monday, July 27, 2015 11:22 PM
To: He, Tim
Cc: Wei, David; edk2-devel@lists.01.org
Subject: Re: [PATCH] Vlv2DeviceRefCodePkg: don't redefine struct typedefs
On Mon, Jul 27, 2015 at 08:08:55AM +0000, He, Tim wrote:
> I downloaded the patch from the Github URL that you sent, and reviewed the
> patch, we can't remove these 2 typedefs, it would build failed because we are
> using the typedefs.
As far as I know, I'm just removing the *second* definition of the typedefs;
they should still be defined. The code is:
// Forward reference for ANSI C compatibility // typedef struct
_PPM_PLATFORM_POLICY_PROTOCOL PPM_PLATFORM_POLICY_PROTOCOL;
then, 100 or so lines later:
typedef struct _PPM_PLATFORM_POLICY_PROTOCOL {
...
...
} PPM_PLATFORM_POLICY_PROTOCOL;
So, currently PPM_PLATFORM_POLICY_PROTOCOL is being defined twice. My patch
removes the second definition.
--
Bruce
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] edk2[18072] Fixed OS software shutdown when reporting actual processor temperature
yes, we will also sync the code and check into trunk tree. and the code could
be posted to edk2-devel for code review. Thanks for your information about the
commit message format. I will following it.
Best Regards,
Tim
-Original Message-
From: Jordan Justen [mailto:jljus...@gmail.com]
Sent: Monday, July 27, 2015 2:41 PM
To: Lu, ShifeiX A; He, Tim
Cc: edk2-devel@lists.01.org
Subject: Fwd: edk2[18072] Fixed OS software shutdown when reporting actual
processor temperature
Should this be included on master too? (Not just the UDK branch)
For future patches:
Could it be posted to edk2-devel for code review?
How about including the package name in the first line of the commit message?
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
Thanks,
-Jordan
-- Forwarded message --
From:
Date: Sun, Jul 26, 2015 at 8:14 PM
Subject: edk2[18072] Fixed OS software shutdown when reporting actual processor
temperature
To: edk2-comm...@lists.sourceforge.net
Revision: 18072
http://sourceforge.net/p/edk2/code/18072
Author: timhe
Date: 2015-07-27 03:14:33 + (Mon, 27 Jul 2015)
Log Message:
---
Fixed OS software shutdown when reporting actual processor temperature
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lu ShifeiX A
Reviewed-by: Tim He
Modified Paths:
--
branches/UDK2014.SP1/Vlv2TbltDevicePkg/PlatformDxe/Platform.c
branches/UDK2014.SP1/Vlv2TbltDevicePkg/PlatformSetupDxe/Thermal.vfi
branches/UDK2014.SP1/Vlv2TbltDevicePkg/PlatformSetupDxe/VfrStrings.uni
Modified: branches/UDK2014.SP1/Vlv2TbltDevicePkg/PlatformDxe/Platform.c
===
--- branches/UDK2014.SP1/Vlv2TbltDevicePkg/PlatformDxe/Platform.c
2015-07-27 03:10:37 UTC (rev 18071)
+++ branches/UDK2014.SP1/Vlv2TbltDevicePkg/PlatformDxe/Platform.c
2015-07-27 03:14:33 UTC (rev 18072)
@@ -564,6 +564,32 @@
}
}
+VOID
+EFIAPI
+InitThermalZone (
+ EFI_EVENT Event,
+ VOID *Context
+ )
+{
+ UINTN VarSize;
+ EFI_STATUS Status;
+ EFI_GLOBAL_NVS_AREA_PROTOCOL *GlobalNvsArea;
+ VarSize = sizeof(SYSTEM_CONFIGURATION);
+ Status = gRT->GetVariable(
+ NORMAL_SETUP_NAME,
+ &gEfiNormalSetupGuid,
+ NULL,
+ &VarSize,
+ &mSystemConfiguration
+ );
+ Status = gBS->LocateProtocol (
+ &gEfiGlobalNvsAreaProtocolGuid,
+ NULL,
+ (void **)&GlobalNvsArea
+ );
+ GlobalNvsArea->Area->CriticalThermalTripPoint =
mSystemConfiguration.CriticalThermalTripPoint;
+ GlobalNvsArea->Area->PassiveThermalTripPoint =
mSystemConfiguration.PassiveThermalTripPoint;
+}
#if defined SUPPORT_LVDS_DISPLAY && SUPPORT_LVDS_DISPLAY
#endif
@@ -818,7 +844,16 @@
&mReadyToBootEvent
);
}
-
+ //
+ // Create a ReadyToBoot Event to run the thermalzone init process //
+ Status = EfiCreateEventReadyToBootEx (
+ TPL_CALLBACK,
+ InitThermalZone,
+ NULL,
+ &mReadyToBootEvent
+ );
+
ReportStatusCodeEx (
EFI_PROGRESS_CODE,
EFI_COMPUTING_UNIT_CHIPSET | EFI_CU_PLATFORM_DXE_STEP1,
Modified: branches/UDK2014.SP1/Vlv2TbltDevicePkg/PlatformSetupDxe/Thermal.vfi
===
--- branches/UDK2014.SP1/Vlv2TbltDevicePkg/PlatformSetupDxe/Thermal.vfi
2015-07-27 03:10:37 UTC (rev 18071)
+++ branches/UDK2014.SP1/Vlv2TbltDevicePkg/PlatformSetupDxe/Thermal.vfi
2015-07-27 03:14:33 UTC (rev 18072)
@@ -42,8 +42,27 @@
title = STRING_TOKEN(STR_THERMAL_TITLE);
subtitle text = STRING_TOKEN(STR_THERMAL_CONFIGURATION);
+ oneof varid = Setup.CriticalThermalTripPoint,
+prompt = STRING_TOKEN(STR_ACPI_CRITICAL_THERMAL_TRIP_POINT),
+help= STRING_TOKEN(STR_ACPI_CRITICAL_THERMAL_TRIP_POINT_HELP),
+option text = STRING_TOKEN (STR_85_C), value = 85, flags=0 |
RESET_REQUIRED;
+option text = STRING_TOKEN (STR_87_C), value = 87, flags=0 |
RESET_REQUIRED;
+option text = STRING_TOKEN (STR_90_C), value = 90, flags=0 |
RESET_REQUIRED;
+option text = STRING_TOKEN (STR_105_C), value = 105, flags=0 |
RESET_REQUIRED;
+option text = STRING_TOKEN (STR_110_C), value = 110, flags=0 |
RESET_REQUIRED;
+option text = STRING_TOKEN (STR_200_C), value = 200,
flags=DEFAULT | MANUFACTURING | RESET_REQUIRED;
+ endoneof;
+ oneof varid = Setup.PassiveThermalTripPoint,
+prompt = STRING_TOKEN (STR_ACPI_PASSIVE_THERMAL_TRIP_POINT),
+help= STRING_TOKEN (STR_ACPI_PASSIVE_THERMAL_TRIP_POINT_HELP),
+option text = STRING_TOKEN (STR_85_C), value = 85, flags=0 |
RESET_REQUIRED;
+option text = STRING_TOKEN (STR_87_C), value = 87, flags=0 |
RESET_REQUIRED;
+opti
Re: [edk2] [PATCH] Vlv2DeviceRefCodePkg: don't redefine struct typedefs
I downloaded the patch from the Github URL that you sent, and reviewed the patch, we can't remove these 2 typedefs, it would build failed because we are using the typedefs. Best Regards, Tim -Original Message- From: Bruce Cran [mailto:br...@cran.org.uk] Sent: Tuesday, July 14, 2015 1:49 AM To: He, Tim Cc: Wei, David; edk2-de...@lists.sourceforge.net Subject: Re: [PATCH] Vlv2DeviceRefCodePkg: don't redefine struct typedefs On Mon, Jul 13, 2015 at 06:18:05AM +0000, He, Tim wrote: > I still couldn't apply the patch, could you please send me the patch again as > attached file? I suspect the email content ignored some character. I've attached the two patch files (type redefinitions and change of UEFI version string). I've also pushed the changesets to https://github.com/bcran/edk2/commits/svn/branches/UDK2014.SP1 . -- Bruce ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch]Vlv2TbltDevicePkg: Fixed OS software shutdown when reporting actual processor temperature
The patch looks good, thanks.. Best Regards, Tim From: Lu, ShifeiX A Sent: Monday, July 27, 2015 9:42 AM To: edk2-devel@lists.01.org Cc: Wei, David; Wu, Mike; He, Tim Subject: [edk2][Patch]Vlv2TbltDevicePkg: Fixed OS software shutdown when reporting actual processor temperature Fixed OS software shutdown when reporting actual processor temperature. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lu, ShifeiX A mailto:shifeix.a...@intel.com>> Modified in VfrStrings.uni, FYI. Removed duplicate String" DTS" and help info string" Enabled/Disable Digital Thermal Sensor". #string STR_DTS_PROMPT #language en-US "DTS " #string STR_DTS_PROMPT_HELP #language en-US "Enabled/Disable Digital Thermal Sensor" Removed unuseful Sting "\n\nNOTE: 100C is the Plan Of Record (POR) for all Intel mobile processors." Add String "100 C","105 C","110 C","180 C","200 C". #string STR_100_C #language en-US "100 C" #string STR_105_C #language en-US "105 C" #string STR_110_C #language en-US "110 C" #string STR_180_C #language en-US "180 C" #string STR_200_C #language en-US "200 C" Thanks. Shifei ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
