Reviewed-by : Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi
Sent: Tuesday, March 12, 2019 9:20 AM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Gao, Liming
Subject: [edk2] [patch v2 0/2] Remove duplicated BSD license
HI Jian:
Tks for the fix.
Reviewed-by: Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J
Wang
Sent: Friday, March 8, 2019 4:56 PM
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek ; Yao, Jiewen ;
Zhang, Chao B ; zh
HI Laszlo:
Thanks for catching this. Sorry about the inconvenience.
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Friday, March 8, 2019 4:02 PM
To: Zhang, Chao B ; edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Gao, Liming
Subject: Re: [edk2] [Patch
Cc: Yao Jiewen
Cc: Jian Wang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
---
Maintainers.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 7772926b2f..08a676b236 100644
--- a
Chen Chen:
I think you can add uCode format info into comments. Also please highlight
in comment
Which part is header checksum calculation, which part is for extended header
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen A
Chen
Sent: Mon
ChenChen:
Please add FileInfoBuffer[Index] NULL check before free
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen A
Chen
Sent: Monday, February 11, 2019 2:17 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Gao, Liming ; Zhang,
Chao B
Update "TCG ACPI Specification Level 00 Revision 00.37" to "TCG ACPI
Specification 1.2 Revision 8"
https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yao Jiewen
Signed-o
Update UEFI supporting TCG spec info
Zhang, Chao B (2):
SecurityPkg/TCG: Upgrade UEFI supporting TCG spec info
MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting TCG spec info
MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 +--
SecurityPkg/SecurityPkg.dec| 2
ttps://trustedcomputinggroup.org/wp-content/uploads/EFI-Protocol-Specification-Errata-v.5.pdf
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yao Jiewen
Signed-off-by: Zhang, Chao B
---
SecurityPkg/SecurityPkg.dec | 2 +-
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 4 +++-
Secu
Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Chen A Chen
> Sent: Friday, January 25, 2019 2:14 PM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Cc: Wu, Hao A mailto:hao.a...@intel.com>>; Zhang,
Reviewed-by : Chao Zhang
-Original Message-
From: Chen, Chen A
Sent: Thursday, January 17, 2019 10:03 AM
To: edk2-devel@lists.01.org
Cc: Chen, Chen A ; Ni, Ray ; Zhang,
Chao B
Subject: [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk
feature.
BZ: https
Reviewed-by : Chao Zhang
-Original Message-
From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com]
Sent: Wednesday, January 2, 2019 9:14 PM
To: edk2-devel@lists.01.org; Gao, Liming ; Zhang, Chao B
; leif.lindh...@linaro.org; ard.biesheu...@linaro.org;
achin.gu...@arm.com
Addressed warnings and remarks reported by IASL.EXE. Some methods had
unused arguments. A method was returning a value when it should not.
Cc: Zhang Chao B
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Thomas Rydman
Signed-off-by: Zhang, Chao B
Star :
Reviewed -by : Chao Zhang
-Original Message-
From: Zeng, Star
Sent: Friday, December 14, 2018 6:29 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Zhang, Chao B ;
Yao, Jiewen
Subject: [PATCH 2/7] SecurityPkg Tcg(2)Pei: Remove the using of
PcdPeiCoreMaxFvSupported
REF
Reviewed-by : Chao Zhang
-Original Message-
From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com]
Sent: Tuesday, December 11, 2018 2:22 PM
To: edk2-devel@lists.01.org; Gao, Liming ; Zhang, Chao B
; leif.lindh...@linaro.org
Subject: [RFC PATCH v4 11/12] SecurityPkg/AuthVariableLib: allow
Reviewed-by: Chao Zhang
-Original Message-
From: Zhang, Shenglei
Sent: Tuesday, December 11, 2018 9:32 AM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B ; Yao, Jiewen
Subject: [PATCH 2/2] SecurityPkg/Tcg: Fix typos in TcgDxe.c and Tcg2Dxe.c
Change EFI_RETURNING_FROM_EFI_APPLICATOIN to
Hi Chen Chen:
TCG part is good to me. For Opal part, please include Eric Dong as reviewer.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen A
Chen
Sent: Wednesday, November 28, 2018 2:27 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B
-Specific-Platform-Firmware-Profile-for-TPM-2-0-v1p03_r51-errata-v1p0_170426.pdf
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf | 4 +++-
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
-Specific-Platform-Firmware-Profile-for-TPM-2-0-v1p03_r51-errata-v1p0_170426.pdf
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf | 4 +++-
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
Add more event log type defined in TCG PTP spec 00.51
https://trustedcomputinggroup.org/wp-content/uploads/PC-ClientSpecific_Platform_Profile_for_TPM_2p0_Systems_v51.pdf
Cc:Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
---
MdePkg/Include
: Wednesday, November 14, 2018 10:59 PM
To: Zhang, Chao B ; Kinney, Michael D
; edk2-devel@lists.01.org; Yao, Jiewen
Cc: Bin, Sung-Uk (빈성욱)
Subject: RE: [PATCH 3/4] SecurityPkg: add TpmIoLibMmio instance
Mike, Chao, Jiewen
Ø [Chao] Infineon chip mentioned by Mike is an example but its register space
vember 14, 2018 8:44 AM
To: Cohen, Eugene ; edk2-devel@lists.01.org; Yao, Jiewen
; Zhang, Chao B ; Kinney, Michael
D
Cc: Bin, Sung-Uk (???)
Subject: RE: [PATCH 3/4] SecurityPkg: add TpmIoLibMmio instance
Hi Eugene,
My experience is with DTPM and some I2C TPMs at 1.2 level.
One of the I2C
, November 9, 2018 7:13 PM
To: Laszlo Ersek
Cc: Kinney, Michael D ; edk2-devel@lists.01.org;
Yao, Jiewen ; Zhang, Chao B
Subject: Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue
On Fri, Nov 09, 2018 at 09:04:46AM +0100, Laszlo Ersek wrote:
> On 11/09/18 07:02, Zhang, Chao B wr
intention to keep device compatibility, we still need to expose
enable/disable configuration.
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, November 9, 2018 4:05 PM
To: Zhang, Chao B ; edk2-devel@lists.01.org
Cc: Andrew Fish ; Leif Lindholm ;
Kinney, Michael D ; Yao, Jiewen
Reviewed-by : Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Jagadeesh Ujja
Sent: Wednesday, October 31, 2018 7:10 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [RFC PATCH 7/9] SecurityPkg/AuthVariableLib:allow reusability
as MM_STA
abnormally with this feature, causing extra
device compatibility issue.
Solution:
Add a policy indicator in PcdActiveTpmInterfaceType to disable TPM interface ID
cache to support those existing TPM devices
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
Cc
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
Cc: Jiewen Yao
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 7ebd53f662..43c487d461 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
Hi Jorge:
PCR 0 should change if you use different core boot payload + UEFI. So your
case seems to be an issue. Can you provide more detailed info?
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jorge
Fernandez Monteagudo
Sent: Monday, Se
Hi Ard:
I am good with this patch. I will help to push it.
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, September 20, 2018 5:47 AM
To: Laszlo Ersek
Cc: edk2-devel@lists.01.org; Zeng, Star ; Wang, Jian J
; Kinney, Michael D ; Gao,
Liming ; Zhang, Chao B ; Yao
Change file format to DOS
Cc: Bi Dandan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang Chao B
Signed-off-by: Zhang, Chao B
---
.../HashInstanceLibSha384/HashInstanceLibSha384.c | 310 ++---
.../HashInstanceLibSha384.inf | 90
Reviewed-by: Chao Zhang
-Original Message-
From: Zhang, Shenglei
Sent: Thursday, August 16, 2018 1:32 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Zhang, Chao B
Subject: [PATCH 3/5] SecurityPkg: Remove unused PCDs
The PCDs below are unused, so they have been removed from inf
Hi Laszlo：
8 667abfaf8a16 UefiCpuPkg: Removing ipf which is no longer supported from
edk2.
9 df49a85dbcc6 CorebootModulePkg: Removing ipf from edk2.
10 04c7f9023ffe CorebootPayloadPkg: Removing ipf from edk2.
11 4fcb0d54584f NetworkPkg: Removing ipf which is no longer supported from
On Behalf Of Laszlo
Ersek
Sent: Thursday, August 9, 2018 10:56 PM
To: Marc-André Lureau ; Zhang, Chao B
Cc: Zeng, Star ; edk2-devel@lists.01.org; Gao, Liming
Subject: Re: [edk2] Missing boot related measurements at TPM 2.0 PCRs 0-7 with
OVMF
On 08/09/18 16:09, Marc-André Lureau wrote:
> Hi
&g
...@redhat.com
Sent: Thursday, August 9, 2018 10:33 PM
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek ; Zhang, Chao B ;
Long, Qin
Subject: [edk2] [PATCH 1/1] SecurityPkg/Library/Tpm2DeviceLibDTpm: fix
s/Constructor/CONSTRUCTOR
From: Marc-André Lureau
The library constructor is not being called because of
Reviewed-by : Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
marcandre.lur...@redhat.com
Sent: Thursday, August 9, 2018 10:33 PM
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek ; Zhang, Chao B ;
Long, Qin
Subject: [edk2] [PATCH 1/1
Tks for comments. I will update GUID before check-in
From: Long, Qin
Sent: Thursday, August 9, 2018 2:22 PM
To: Zhang, Chao B ; edk2-devel@lists.01.org
Subject: RE: [edk2] [Patch] SecurityPkg: HashLib: Update HashLib file GUID
Chao, Please change the lowercase letters in the new GUID to
2 file GUIDs conflict with existing SHA256 Lib. Update them.
Cc: Long Qin
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf | 2 +-
SecurityPkg/Library/HashInstanceLibSha512
Reviewed-by : Chao Zhang
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Friday, August 3, 2018 8:16 PM
To: edk2-devel-01
Cc: Zhang, Chao B ; Yao, Jiewen ;
Roman Bacik
Subject: [PATCH v2 5/7] SecurityPkg/SecureBootConfigDxe: replace
OpenFileByDevicePath() with
e me the boot log?
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Friday, August 3, 2018 10:46 PM
To: Ricardo Araújo ; Zhang, Chao B
Cc: edk2-devel@lists.01.org; Zeng, Star ; Gao, Liming
Subject: Re: [edk2] Missing boot related measurements at TPM 2.0 PC
Tks Lazslo. And please make sure PcdLib is correctly lined in OVMF
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, August 2, 2018 9:14 PM
To: Zhang, Chao B ; Ricardo Araújo
; Marc-André Lureau
Cc: edk2-devel@lists.01.org; Gao, Liming ; Zeng, Star
Subject: Re: [edk2] Missing
ured as
DYN, DYNEx in DEC. I don’t know why you meet Set Failure
In OVMF. Here, I include PCD expert to explain this.
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, August 2, 2018 5:49 AM
To: Ricardo Araújo ; Zhang, Chao B
; Marc-André Lureau
Cc: edk2-devel@lists.01.org
Subject
Error is caused by SHA384/SHA512 hash lib change in.
Cc: Bi Dandan
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
---
SecurityPkg/SecurityPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/SecurityPkg/SecurityPkg.dsc b
Add SHA384, 512 Hash lib support. Now only CryptoPkg support PEI/DXE
version.
Cc: Long Qin
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Include/Library/HashLib.h | 2 +-
.../HashInstanceLibSha384
Reviewed-by: Chao Zhang
-Original Message-
From: Bi, Dandan
Sent: Thursday, July 19, 2018 2:44 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zhang, Chao B
Subject: [patch 2/2] SecurityPkg/Tcg: Add use case for new Perf macro
Add an example case for the usage of
PERF_CALLBACK_BEGIN
Reviewed-by： Chao Zhang
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, July 19, 2018 4:51 AM
To: edk2-devel-01
Cc: Zhang, Chao B ; Yao, Jiewen ;
Roman Bacik
Subject: [PATCH 4/6] SecurityPkg/SecureBootConfigDxe: replace
OpenFileByDevicePath() with
TPM1.2 is obsoleted by TPM2.0. switch TCG/TCG2 protocol check to apply this
trend
Cc: Long, Qin
Cc: Yao, Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
---
.../DxeTpmMeasurementLib/DxeTpmMeasurementLib.c| 23 +++---
1 file
Re-prioritize TCG/TCG2 protocol
Zhang, Chao B (2):
MdeModulePkg: Variable: Re-prioritize TCG/TCG2 protocol
MdeModulePkg: TpmMeasureLib: Re-prioritize TCG/TCG2 protocol
.../Universal/Variable/RuntimeDxe/TcgMorLockSmm.c | 10 +-
.../DxeTpmMeasurementLib/DxeTpmMeasurementLib.c| 23
TPM1.2 is obsoleted by TPM2.0. switch TCG/TCG2 protocol check to apply this
trend
Cc: Long, Qin
Cc: Yao, Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
---
MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockSmm.c | 10 +-
1 file changed
Add more logic to filter invalid function parameter in MOR Control SMI handler
Cc: Long Qin
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 4
SecurityPkg/Tcg/TcgSmm
edk2-devel@lists.01.org
Cc: Zhang, Chao B ; Yao, Jiewen ;
Laszlo Ersek ; Vladimir Olovyannikov
Subject: [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB
From: Roman Bacik
When secure boot is enabled, if one loads keys from a FAT formatted eMMC/SD/USB
when trying to provisio
"Triggle" is a typo. Fix it with "Trigger"
Cc: Long Qin
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Tcg/Tcg2Smm/Tpm.asl | 16
SecurityPkg/Tcg/
HI Dandan :
That patch is good to me. Reviewed-by: Chao Zhang
-Original Message-
From: Bi, Dandan
Sent: Friday, June 22, 2018 4:56 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Zhang, Chao B
Subject: [patch V2 8/9] SecurityPkg: Use new added Perf macros
Replace old Perf macros
Hi Gary:
It is caused by code merge. Tks for notification. We have fixed it.
From: Gary Lin [mailto:g...@suse.com]
Sent: Wednesday, June 27, 2018 4:19 PM
To: Zhang, Chao B
Cc: edk2-devel@lists.01.org; Yao, Jiewen ; Long, Qin
Subject: Re: [edk2] [Patch 2/2] SecurityPkg: Tpm2DeviceLib: Enable
Hi Liming:
Thanks for catching this. Reviewed-by: Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, June 27, 2018 10:49 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] SecurityPkg Tpm2DeviceLibDTpm: U
Directly transition from CMD completion to CMD Ready state if device
supports IdleByPass
Cc: Long Qin
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
Signed-off-by: Zhang, Chao B
---
.../Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.c | 19
Signed-off-by: Zhang, Chao B
---
MdePkg/Include/IndustryStandard/TpmPtp.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/TpmPtp.h
b/MdePkg/Include/IndustryStandard/TpmPtp.h
index 0796512688..c7ff8fdc58 100644
--- a/MdePkg/Include
Add CRB IdleByPass Support
Zhang, Chao B (2):
Add CapCRBIdleBypass definition to interface ID register. It complies
with existing register
SecurityPkg: Tpm2DeviceLib: Enable CapCRBIdleBypass support
MdePkg/Include/IndustryStandard/TpmPtp.h | 5 +-
.../Library
Cache TPM interface type info to avoid excessive interface ID register read
Cc: Long Qin
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Include/Library/Tpm2DeviceLib.h| 12 +++-
.../Library/Tpm2DeviceLibDTpm
Cache TPM interface type info to avoid excessive interface ID register read
Cc: Long Qin
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Include/Library/Tpm2DeviceLib.h| 12 +++-
.../Library
Enable SHA384/512 support in PEI phase.
Cc: Long Qin
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
Signed-off-by: Zhang, Chao B
---
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
Reviewed-by: Chao Zhang
-Original Message-
From: Nickle Wang [mailto:nickle.w...@hpe.com]
Sent: Tuesday, May 29, 2018 8:08 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B ; Yao, Jiewen ;
Nickle Wang ; cinnamon shia
Subject: [PATCH] SecurityPkg/SecureBootConfigDxe: Fix invalid NV data
Correct UpdatePossibleResource parameter attribute to align to comment
Change-Id: Id8f8be975f0e8666573decc3fbaaf326b7767ba8
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Long Qin
Cc: Yao Jiewen
Reviewed-by: Chao Zhang
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Tcg/Tcg2Smm
David:
Have you tried to enroll .crt from HII Secure Boot Configure Page?
Basically when PK exists , PhysicalPresence and Customized Mode must be
asserted in order to enroll a signature without CertData to KEK/DB…,
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of David F
Update package format info in _PRS to TcgNvs after memory is allocated.
Change-Id: Icfadb350e60d3ed2df332e92c257ce13309c0018
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yao Jiewen
Cc: Long Qin
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 19
Good catch！ Jiewen, I will add more check in CopyAuthSessionResponse()
From: Yao, Jiewen
Sent: Wednesday, March 21, 2018 2:39 PM
To: Zhang, Chao B ; Long, Qin ;
edk2-devel@lists.01.org
Subject: RE: [Patch] SecurityPkg Tpm2CommandLib: Fix TPM2.0 response memory
overflow
Some thought:
1) Would
Thanks Qin, I will add more comments to explain the magic code
-Original Message-
From: Long, Qin
Sent: Wednesday, March 21, 2018 10:58 AM
To: Zhang, Chao B ; edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: RE: [Patch] SecurityPkg Tpm2CommandLib: Fix TPM2.0 response memory
overflow
TPM12 command lib doesn't convert Response Size before using. Add logic
to fix the issue.
Cc: Long Qin
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
Signed-off-by: Zhang, Chao B
---
SecurityPkg/Library/Tpm12CommandLib/Tpm12GetCapabil
Contribution Agreement 1.1
Signed-off-by: Chao Zhang
Signed-off-by: Zhang, Chao B
---
.../Library/Tpm2CommandLib/Tpm2Capability.c| 21 ++-
.../Tpm2CommandLib/Tpm2EnhancedAuthorization.c | 16 ++-
SecurityPkg/Library/Tpm2CommandLib/Tpm2Integrity.c | 19
Series reviewed-by: Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang,
Chao B
Sent: Thursday, March 15, 2018 3:35 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [edk2] [PATCH 00/15] Remove TrEE*
From: Jiewen Yao
TrEE
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
SecurityPkg/Library/DxeTrEEPhysicalPresenceLib/DxeTrEEPhysicalPresenceLib.c
| 743
SecurityPkg/Library/DxeTrEEP
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
SecurityPkg/Library/Tpm2DeviceLibTrEE/Tpm2DeviceLibTrEE.c | 125
SecurityPkg/Library/Tpm2DeviceLibTrEE/Tpm2Devi
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
SecurityPkg/SecurityPkg.dec | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/SecurityPkg/Security
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
SecurityPkg/Tcg/TrEEConfig/TpmDetection.c | 105 --
SecurityPkg/Tcg/TrEEConfig/TrEEConfig.vfr | 68
SecurityP
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
SecurityPkg/Tcg/TrEEPei/TrEEPei.c| 690
SecurityPkg/Tcg/TrEEPei/TrEEPei.inf | 86 ---
SecurityPkg/Tc
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
SecurityPkg/Include/Guid/TrEEConfigHii.h | 25 ---
SecurityPkg/Include/Guid/TrEEPhysicalPresenceData.h | 67
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
SecurityPkg/Library/TrEEPpVendorLibNull/TrEEPpVendorLibNull.c | 131
SecurityPkg/Library/TrEEPpVendorLibNull/Tr
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
SecurityPkg/Tcg/TrEEDxe/MeasureBootPeCoff.c | 427 -
SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c | 1877
Secu
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
SecurityPkg/SecurityPkg.dsc | 44 +---
1 file changed, 1 insertion(+), 43 deletions(-)
diff --git a/SecurityPkg/Securi
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
SecurityPkg/Tcg/TrEESmm/Tpm.asl | 354 -
SecurityPkg/Tcg/TrEESmm/TrEESmm.c| 521
Secu
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: David Wei
Cc: Mang Guo
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c | 6 +++---
Vlv2TbltDevicePkg/Library/Platform
From: Jiewen Yao
TrEE is deprecated and not maintained any more.
We need use Tcg2.
*** BLURB HERE ***
Jiewen Yao (15):
ShellPkg/UefiHandleParsingLib: remove TrEE reference.
QuarkPlatformPkg: remove TrEE reference.
Vlv2TbltDevicePkg/Tcg2PhysicalPresenceLib: use Tcg2 instead of TrEE.
Vlv2
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Jaben Carsey
Cc: Ruiyu Ni
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 1 -
ShellPkg/Library/UefiHandleParsin
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: David Wei
Cc: Mang Guo
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
Vlv2TbltDevicePkg/PlatformPkg.fdf | 6 +++---
Vlv2TbltDevicePkg/PlatformPkgGcc.fdf| 6 +++---
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: Michael D Kinney
Cc: Kelly Steele
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
QuarkPlatformPkg/Quark.dsc | 2 +-
QuarkPlatformPkg/Quark.fdf | 2 +-
2 files changed, 2 insert
From: Jiewen Yao
TrEE is deprecated. We need use Tcg2.
Cc: David Wei
Cc: Mang Guo
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
Vlv2TbltDevicePkg/Library/{DxeTrEEPhysicalPresenceLibNull/DxeTrEEPhysicalPresenceLibNull.c
=> DxeTcg2Phy
Chen Chen:
Please update license header. Others are good to me.
Reviewed-by: Chao Zhang
-Original Message-
From: Chen, Chen A
Sent: Tuesday, March 13, 2018 3:37 PM
To: edk2-devel@lists.01.org
Cc: Chen, Chen A ; Ni, Ruiyu ;
Zhang, Chao B
Subject: [PATCH] ShellPkg/Dmpstore: Enhance
Reviewed-by: Chao Zhang
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Saturday, March 10, 2018 4:05 AM
To: edk2-devel-01
Cc: Zhang, Chao B ; Yao, Jiewen
Subject: [PATCH 2/2] SecurityPkg/TcgPei: drop PeiReadOnlyVariable from Depex
TcgPei doesn't actuall
Hi Lureau:
I think we can remove same dependency in TcgPei.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
marcandre.lur...@redhat.com
Sent: Wednesday, March 7, 2018 11:58 PM
To: edk2-devel@lists.01.org
Cc: qemu-de...@nongnu.org; javi...@redh
;
javi...@redhat.com; Marc-André Lureau ; Zhang,
Chao B ; Zeng, Star
Subject: [PATCH v2 1/8] SecurityPkg: also clear
HashInterfaceHob.SupportedHashMask
From: Marc-André Lureau
Commit 4cc2b63bd829426b05bad0d8952f1855a10d6ed7 fixed an out of bounds
ZeroMem() call. However, as Laszlo Ersek
dré Lureau ; edk2-devel@lists.01.org
Cc: Laszlo Ersek ; Yao, Jiewen ;
Zhang, Chao B ; Zeng, Star
Subject: RE: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob
Yes, since the V1 has been pushed.
Just adding one line like below based on V1 should be ok.
HashInterface
Reviewed-by: Chao Zhang
-Original Message-
From: Bi, Dandan
Sent: Wednesday, March 7, 2018 1:54 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B
Subject: [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: Fix coding style issue
Boolean values do not need to use explicit comparisons to
Reviewed-by: Chao Zhang
-Original Message-
From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com]
Sent: Wednesday, March 7, 2018 4:27 AM
To: edk2-devel@lists.01.org
Cc: Marc-André Lureau ; Yao, Jiewen
; Zhang, Chao B ; Zeng, Star
; Laszlo Ersek
Subject: [PATCH 1/1
Reviewed-by: Chao Zhang
-Original Message-
From: Zhang, Chao B
Sent: Wednesday, February 28, 2018 2:19 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Zhang, Chao B
Subject: [PATCH] Maintainers.txt: Add Jiewen to be co-maintainer of SecurityPkg.
From: Jiewen Yao
Cc: Chao B Zhang
From: Jiewen Yao
Cc: Chao B Zhang
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 74f2538..e103f85 100644
--- a/Maintainers.txt
+++ b/Maintainers.tx
this
interface clearer. But I think current implementation is good from spec point
of view.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Lin,
Derek (HPS UEFI Dev)
Sent: Friday, February 23, 2018 4:08 PM
To: Zhang, Chao B ; edk2-devel@
k (HPS UEFI Dev) [mailto:derek.l...@hpe.com]
Sent: Thursday, February 22, 2018 7:25 PM
To: edk2-devel@lists.01.org; Zhang, Chao B
Cc: Yao, Jiewen ; Zeng, Star
Subject: TPM 2.0 Manufacutre ID wrong byte order
Hi TPM expert,
The line in
https://github.com/tianocore/edk2/commit/73126ac2bd9804632255b2fdd
Fix type casting issue when calculating pointers offset
Cc: Wu Hao
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
---
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
b/Sec
Update Tcg2Smm _PRS patching logic to fix compile issue
Cc: Liming Gao
Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chao Zhang
---
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/SecurityPkg/Tc
Reviewed-by: Chao Zhang
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Tuesday, January 30, 2018 1:34 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] SecurityPkg: Don't build AuthVariableLib for EBC arch
EBC build failur
Qin & Jiewen
Tks for your comments , I will follow up to update the patch.
-Original Message-
From: Yao, Jiewen
Sent: Tuesday, February 6, 2018 10:33 AM
To: Long, Qin ; Zhang, Chao B ;
edk2-devel@lists.01.org
Subject: RE: [PATCH] SecurityPkg: Support PP version lower than 1.3
Yea
1 - 100 of 405 matches
Mail list logo
