Re: [edk2] [patch v2 0/2] Remove duplicated BSD license

2019-03-12 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Tuesday, March 12, 2019 9:20 AM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2] [patch v2 0/2] Remove duplicated BSD license

Re: [edk2] [PATCH] Maintainers.txt: remove unexpected unicode BOM

2019-03-08 Thread Zhang, Chao B
HI Jian: Tks for the fix. Reviewed-by: Chao Zhang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J Wang Sent: Friday, March 8, 2019 4:56 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Yao, Jiewen ; Zhang, Chao B ; zh

Re: [edk2] [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.

2019-03-08 Thread Zhang, Chao B
HI Laszlo: Thanks for catching this. Sorry about the inconvenience. From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, March 8, 2019 4:02 PM To: Zhang, Chao B ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Gao, Liming Subject: Re: [edk2] [Patch

[edk2] [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.

2019-03-07 Thread Zhang, Chao B
Cc: Yao Jiewen Cc: Jian Wang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B --- Maintainers.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 7772926b2f..08a676b236 100644 --- a

Re: [edk2] [PATCH] UefiCpuPkg/Microcode: Fix incorrect checksum issue for extended table

2019-02-18 Thread Zhang, Chao B
Chen Chen: I think you can add uCode format info into comments. Also please highlight in comment Which part is header checksum calculation, which part is for extended header -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen A Chen Sent: Mon

Re: [edk2] [PATCH] MdeModulePkg/CapsuleApp: Fix memory leak issue.

2019-02-11 Thread Zhang, Chao B
ChenChen: Please add FileInfoBuffer[Index] NULL check before free -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen A Chen Sent: Monday, February 11, 2019 2:17 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Gao, Liming ; Zhang, Chao B

[edk2] [Patch 2/2] MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting TCG spec info

2019-01-25 Thread Zhang, Chao B
Update "TCG ACPI Specification Level 00 Revision 00.37" to "TCG ACPI Specification 1.2 Revision 8" https://trustedcomputinggroup.org/wp-content/uploads/TCG_ACPIGeneralSpecification_v1.20_r8.pdf Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yao Jiewen Signed-o

[edk2] [Patch 0/2] Update UEFI supporting TCG spec info

2019-01-25 Thread Zhang, Chao B
Update UEFI supporting TCG spec info Zhang, Chao B (2): SecurityPkg/TCG: Upgrade UEFI supporting TCG spec info MdeModulePkg:Tpm2Acpi.h: Upgrade UEFI supporting TCG spec info MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 +-- SecurityPkg/SecurityPkg.dec| 2

[edk2] [Patch 1/2] SecurityPkg/TCG: Upgrade UEFI supporting TCG spec info

2019-01-25 Thread Zhang, Chao B
ttps://trustedcomputinggroup.org/wp-content/uploads/EFI-Protocol-Specification-Errata-v.5.pdf Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yao Jiewen Signed-off-by: Zhang, Chao B --- SecurityPkg/SecurityPkg.dec | 2 +- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 4 +++- Secu

Re: [edk2] [PATCH 1/3] MdeModulePkg/CapsuleApp: Refine code logic of parsing parameter.

2019-01-24 Thread Zhang, Chao B
Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Chen A Chen > Sent: Friday, January 25, 2019 2:14 PM > To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > Cc: Wu, Hao A mailto:hao.a...@intel.com>>; Zhang,

Re: [edk2] [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature.

2019-01-22 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Chen, Chen A Sent: Thursday, January 17, 2019 10:03 AM To: edk2-devel@lists.01.org Cc: Chen, Chen A ; Ni, Ray ; Zhang, Chao B Subject: [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature. BZ: https

Re: [edk2] [PATCH v2 10/11] SecurityPkg/AuthVariableLib: allow MM_STANDALONE drivers to use this library

2019-01-02 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com] Sent: Wednesday, January 2, 2019 9:14 PM To: edk2-devel@lists.01.org; Gao, Liming ; Zhang, Chao B ; leif.lindh...@linaro.org; ard.biesheu...@linaro.org; achin.gu...@arm.com

[edk2] [Patch] SecurityPkg/Tcg: Fix Warnings and Remarks reported by IASL

2019-01-02 Thread Zhang, Chao B
Addressed warnings and remarks reported by IASL.EXE. Some methods had unused arguments. A method was returning a value when it should not. Cc: Zhang Chao B Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Thomas Rydman Signed-off-by: Zhang, Chao B

Re: [edk2] [PATCH 2/7] SecurityPkg Tcg(2)Pei: Remove the using of PcdPeiCoreMaxFvSupported

2018-12-16 Thread Zhang, Chao B
Star : Reviewed -by : Chao Zhang -Original Message- From: Zeng, Star Sent: Friday, December 14, 2018 6:29 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Zhang, Chao B ; Yao, Jiewen Subject: [PATCH 2/7] SecurityPkg Tcg(2)Pei: Remove the using of PcdPeiCoreMaxFvSupported REF

Re: [edk2] [RFC PATCH v4 11/12] SecurityPkg/AuthVariableLib: allow MM_STANDALONE drivers to use this library

2018-12-16 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Jagadeesh Ujja [mailto:jagadeesh.u...@arm.com] Sent: Tuesday, December 11, 2018 2:22 PM To: edk2-devel@lists.01.org; Gao, Liming ; Zhang, Chao B ; leif.lindh...@linaro.org Subject: [RFC PATCH v4 11/12] SecurityPkg/AuthVariableLib: allow

Re: [edk2] [PATCH 2/2] SecurityPkg/Tcg: Fix typos in TcgDxe.c and Tcg2Dxe.c

2018-12-16 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Zhang, Shenglei Sent: Tuesday, December 11, 2018 9:32 AM To: edk2-devel@lists.01.org Cc: Zhang, Chao B ; Yao, Jiewen Subject: [PATCH 2/2] SecurityPkg/Tcg: Fix typos in TcgDxe.c and Tcg2Dxe.c Change EFI_RETURNING_FROM_EFI_APPLICATOIN to

Re: [edk2] [PATCH] SecurityPkg: Remove dead code and inf redundant definitions.

2018-11-28 Thread Zhang, Chao B
Hi Chen Chen: TCG part is good to me. For Opal part, please include Eric Dong as reviewer. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen A Chen Sent: Wednesday, November 28, 2018 2:27 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B

[edk2] [PATCH v2] SecurityPkg: Update TCG PFP spec revision.

2018-11-19 Thread Zhang, Chao B
-Specific-Platform-Firmware-Profile-for-TPM-2-0-v1p03_r51-errata-v1p0_170426.pdf Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B --- SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf | 4 +++- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf

[edk2] [Patch] SecurityPkg: Update TCG PTP spec revision.

2018-11-19 Thread Zhang, Chao B
-Specific-Platform-Firmware-Profile-for-TPM-2-0-v1p03_r51-errata-v1p0_170426.pdf Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B --- SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.inf | 4 +++- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf

[edk2] [Patch] SecurityPkg: TCG Add more Event type

2018-11-17 Thread Zhang, Chao B
Add more event log type defined in TCG PTP spec 00.51 https://trustedcomputinggroup.org/wp-content/uploads/PC-ClientSpecific_Platform_Profile_for_TPM_2p0_Systems_v51.pdf Cc:Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B --- MdePkg/Include

Re: [edk2] [PATCH 3/4] SecurityPkg: add TpmIoLibMmio instance

2018-11-15 Thread Zhang, Chao B
: Wednesday, November 14, 2018 10:59 PM To: Zhang, Chao B ; Kinney, Michael D ; edk2-devel@lists.01.org; Yao, Jiewen Cc: Bin, Sung-Uk (빈성욱) Subject: RE: [PATCH 3/4] SecurityPkg: add TpmIoLibMmio instance Mike, Chao, Jiewen Ø [Chao] Infineon chip mentioned by Mike is an example but its register space

Re: [edk2] [PATCH 3/4] SecurityPkg: add TpmIoLibMmio instance

2018-11-13 Thread Zhang, Chao B
vember 14, 2018 8:44 AM To: Cohen, Eugene ; edk2-devel@lists.01.org; Yao, Jiewen ; Zhang, Chao B ; Kinney, Michael D Cc: Bin, Sung-Uk (???) Subject: RE: [PATCH 3/4] SecurityPkg: add TpmIoLibMmio instance Hi Eugene, My experience is with DTPM and some I2C TPMs at 1.2 level. One of the I2C

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Zhang, Chao B
, November 9, 2018 7:13 PM To: Laszlo Ersek Cc: Kinney, Michael D ; edk2-devel@lists.01.org; Yao, Jiewen ; Zhang, Chao B Subject: Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue On Fri, Nov 09, 2018 at 09:04:46AM +0100, Laszlo Ersek wrote: > On 11/09/18 07:02, Zhang, Chao B wr

Re: [edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-09 Thread Zhang, Chao B
intention to keep device compatibility, we still need to expose enable/disable configuration. From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, November 9, 2018 4:05 PM To: Zhang, Chao B ; edk2-devel@lists.01.org Cc: Andrew Fish ; Leif Lindholm ; Kinney, Michael D ; Yao, Jiewen

Re: [edk2] [RFC PATCH 7/9] SecurityPkg/AuthVariableLib:allow reusability as MM_STANDALONE

2018-11-08 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jagadeesh Ujja Sent: Wednesday, October 31, 2018 7:10 PM To: edk2-devel@lists.01.org Subject: [edk2] [RFC PATCH 7/9] SecurityPkg/AuthVariableLib:allow reusability as MM_STA

[edk2] [Patch] SecurityPkg: Fix TPM device compatibility issue

2018-11-08 Thread Zhang, Chao B
abnormally with this feature, causing extra device compatibility issue. Solution: Add a policy indicator in PcdActiveTpmInterfaceType to disable TPM interface ID cache to support those existing TPM devices Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B Cc

[edk2] [Patch] Maintainer.txt: Add Chao to be co-maintainer of SignedCapsulePkg

2018-11-05 Thread Zhang, Chao B
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B Cc: Jiewen Yao --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 7ebd53f662..43c487d461 100644 --- a/Maintainers.txt +++ b/Maintainers.txt

Re: [edk2] Tianocore and TPM2 pcr values

2018-09-25 Thread Zhang, Chao B
Hi Jorge: PCR 0 should change if you use different core boot payload + UEFI. So your case seems to be an issue. Can you provide more detailed info? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jorge Fernandez Monteagudo Sent: Monday, Se

Re: [edk2] [PATCH v2 3/3] SecurityPkg: remove PE/COFF header workaround for ELILO on IPF

2018-09-20 Thread Zhang, Chao B
Hi Ard: I am good with this patch. I will help to push it. From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, September 20, 2018 5:47 AM To: Laszlo Ersek Cc: edk2-devel@lists.01.org; Zeng, Star ; Wang, Jian J ; Kinney, Michael D ; Gao, Liming ; Zhang, Chao B ; Yao

[edk2] [Patch] SecurityPkg: HashLib: Change dos format

2018-09-07 Thread Zhang, Chao B
Change file format to DOS Cc: Bi Dandan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang Chao B Signed-off-by: Zhang, Chao B --- .../HashInstanceLibSha384/HashInstanceLibSha384.c | 310 ++--- .../HashInstanceLibSha384.inf | 90

Re: [edk2] [PATCH 3/5] SecurityPkg: Remove unused PCDs

2018-08-16 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Zhang, Shenglei Sent: Thursday, August 16, 2018 1:32 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zhang, Chao B Subject: [PATCH 3/5] SecurityPkg: Remove unused PCDs The PCDs below are unused, so they have been removed from inf

Re: [edk2] EDK II Stable Tag release edk2-stable201808 and quiet period starting today

2018-08-14 Thread Zhang, Chao B
Hi Laszlo: 8 667abfaf8a16 UefiCpuPkg: Removing ipf which is no longer supported from edk2. 9 df49a85dbcc6 CorebootModulePkg: Removing ipf from edk2. 10 04c7f9023ffe CorebootPayloadPkg: Removing ipf from edk2. 11 4fcb0d54584f NetworkPkg: Removing ipf which is no longer supported from

Re: [edk2] Missing boot related measurements at TPM 2.0 PCRs 0-7 with OVMF

2018-08-09 Thread Zhang, Chao B
On Behalf Of Laszlo Ersek Sent: Thursday, August 9, 2018 10:56 PM To: Marc-André Lureau ; Zhang, Chao B Cc: Zeng, Star ; edk2-devel@lists.01.org; Gao, Liming Subject: Re: [edk2] Missing boot related measurements at TPM 2.0 PCRs 0-7 with OVMF On 08/09/18 16:09, Marc-André Lureau wrote: > Hi &g

Re: [edk2] [PATCH 1/1] SecurityPkg/Library/Tpm2DeviceLibDTpm: fix s/Constructor/CONSTRUCTOR

2018-08-09 Thread Zhang, Chao B
...@redhat.com Sent: Thursday, August 9, 2018 10:33 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Zhang, Chao B ; Long, Qin Subject: [edk2] [PATCH 1/1] SecurityPkg/Library/Tpm2DeviceLibDTpm: fix s/Constructor/CONSTRUCTOR From: Marc-André Lureau The library constructor is not being called because of

Re: [edk2] [PATCH 1/1] SecurityPkg/Library/Tpm2DeviceLibDTpm: fix s/Constructor/CONSTRUCTOR

2018-08-09 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of marcandre.lur...@redhat.com Sent: Thursday, August 9, 2018 10:33 PM To: edk2-devel@lists.01.org Cc: Laszlo Ersek ; Zhang, Chao B ; Long, Qin Subject: [edk2] [PATCH 1/1

Re: [edk2] [Patch] SecurityPkg: HashLib: Update HashLib file GUID

2018-08-09 Thread Zhang, Chao B
Tks for comments. I will update GUID before check-in From: Long, Qin Sent: Thursday, August 9, 2018 2:22 PM To: Zhang, Chao B ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch] SecurityPkg: HashLib: Update HashLib file GUID Chao, Please change the lowercase letters in the new GUID to

[edk2] [Patch] SecurityPkg: HashLib: Update HashLib file GUID

2018-08-08 Thread Zhang, Chao B
2 file GUIDs conflict with existing SHA256 Lib. Update them. Cc: Long Qin Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B --- SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf | 2 +- SecurityPkg/Library/HashInstanceLibSha512

Re: [edk2] [PATCH v2 5/7] SecurityPkg/SecureBootConfigDxe: replace OpenFileByDevicePath() with UefiLib API

2018-08-07 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, August 3, 2018 8:16 PM To: edk2-devel-01 Cc: Zhang, Chao B ; Yao, Jiewen ; Roman Bacik Subject: [PATCH v2 5/7] SecurityPkg/SecureBootConfigDxe: replace OpenFileByDevicePath() with

Re: [edk2] Missing boot related measurements at TPM 2.0 PCRs 0-7 with OVMF

2018-08-06 Thread Zhang, Chao B
e me the boot log? From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, August 3, 2018 10:46 PM To: Ricardo Araújo ; Zhang, Chao B Cc: edk2-devel@lists.01.org; Zeng, Star ; Gao, Liming Subject: Re: [edk2] Missing boot related measurements at TPM 2.0 PC

Re: [edk2] Missing boot related measurements at TPM 2.0 PCRs 0-7 with OVMF

2018-08-02 Thread Zhang, Chao B
Tks Lazslo. And please make sure PcdLib is correctly lined in OVMF From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, August 2, 2018 9:14 PM To: Zhang, Chao B ; Ricardo Araújo ; Marc-André Lureau Cc: edk2-devel@lists.01.org; Gao, Liming ; Zeng, Star Subject: Re: [edk2] Missing

Re: [edk2] Missing boot related measurements at TPM 2.0 PCRs 0-7 with OVMF

2018-08-01 Thread Zhang, Chao B
ured as DYN, DYNEx in DEC. I don’t know why you meet Set Failure In OVMF. Here, I include PCD expert to explain this. From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, August 2, 2018 5:49 AM To: Ricardo Araújo ; Zhang, Chao B ; Marc-André Lureau Cc: edk2-devel@lists.01.org Subject

[edk2] [Patch] SecurityPkgDSC: Fix 2 DSC build error

2018-07-27 Thread Zhang, Chao B
Error is caused by SHA384/SHA512 hash lib change in. Cc: Bi Dandan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B --- SecurityPkg/SecurityPkg.dsc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/SecurityPkg/SecurityPkg.dsc b

[edk2] [Patch] SecurityPkg: HashLib: Add SHA384, SHA512 HashLib

2018-07-26 Thread Zhang, Chao B
Add SHA384, 512 Hash lib support. Now only CryptoPkg support PEI/DXE version. Cc: Long Qin Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B --- SecurityPkg/Include/Library/HashLib.h | 2 +- .../HashInstanceLibSha384

Re: [edk2] [patch 2/2] SecurityPkg/Tcg: Add use case for new Perf macro

2018-07-23 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Bi, Dandan Sent: Thursday, July 19, 2018 2:44 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhang, Chao B Subject: [patch 2/2] SecurityPkg/Tcg: Add use case for new Perf macro Add an example case for the usage of PERF_CALLBACK_BEGIN

Re: [edk2] [PATCH 4/6] SecurityPkg/SecureBootConfigDxe: replace OpenFileByDevicePath() with UefiLib API

2018-07-23 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, July 19, 2018 4:51 AM To: edk2-devel-01 Cc: Zhang, Chao B ; Yao, Jiewen ; Roman Bacik Subject: [PATCH 4/6] SecurityPkg/SecureBootConfigDxe: replace OpenFileByDevicePath() with

[edk2] [Patch 2/2] MdeModulePkg: TpmMeasureLib: Re-prioritize TCG/TCG2 protocol

2018-07-20 Thread Zhang, Chao B
TPM1.2 is obsoleted by TPM2.0. switch TCG/TCG2 protocol check to apply this trend Cc: Long, Qin Cc: Yao, Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B --- .../DxeTpmMeasurementLib/DxeTpmMeasurementLib.c| 23 +++--- 1 file

[edk2] [Patch 0/2] Re-prioritize TCG/TCG2 protocol

2018-07-20 Thread Zhang, Chao B
Re-prioritize TCG/TCG2 protocol Zhang, Chao B (2): MdeModulePkg: Variable: Re-prioritize TCG/TCG2 protocol MdeModulePkg: TpmMeasureLib: Re-prioritize TCG/TCG2 protocol .../Universal/Variable/RuntimeDxe/TcgMorLockSmm.c | 10 +- .../DxeTpmMeasurementLib/DxeTpmMeasurementLib.c| 23

[edk2] [Patch 1/2] MdeModulePkg: Variable: Re-prioritize TCG/TCG2 protocol

2018-07-20 Thread Zhang, Chao B
TPM1.2 is obsoleted by TPM2.0. switch TCG/TCG2 protocol check to apply this trend Cc: Long, Qin Cc: Yao, Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B --- MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockSmm.c | 10 +- 1 file changed

[edk2] [Patch] SecurityPkg: TcgSmm: Handle invalid parameter in MOR SMI handler

2018-07-19 Thread Zhang, Chao B
Add more logic to filter invalid function parameter in MOR Control SMI handler Cc: Long Qin Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B --- SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 4 SecurityPkg/Tcg/TcgSmm

Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB

2018-07-16 Thread Zhang, Chao B
edk2-devel@lists.01.org Cc: Zhang, Chao B ; Yao, Jiewen ; Laszlo Ersek ; Vladimir Olovyannikov Subject: [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB From: Roman Bacik When secure boot is enabled, if one loads keys from a FAT formatted eMMC/SD/USB when trying to provisio

[edk2] [Patch] SecurityPkg:Tcg: Fix comment typos

2018-07-16 Thread Zhang, Chao B
"Triggle" is a typo. Fix it with "Trigger" Cc: Long Qin Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B --- SecurityPkg/Tcg/Tcg2Smm/Tpm.asl | 16 SecurityPkg/Tcg/

Re: [edk2] [patch V2 8/9] SecurityPkg: Use new added Perf macros

2018-07-03 Thread Zhang, Chao B
HI Dandan : That patch is good to me. Reviewed-by: Chao Zhang -Original Message- From: Bi, Dandan Sent: Friday, June 22, 2018 4:56 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhang, Chao B Subject: [patch V2 8/9] SecurityPkg: Use new added Perf macros Replace old Perf macros

Re: [edk2] [Patch 2/2] SecurityPkg: Tpm2DeviceLib: Enable CapCRBIdleBypass support

2018-07-03 Thread Zhang, Chao B
Hi Gary: It is caused by code merge. Tks for notification. We have fixed it. From: Gary Lin [mailto:g...@suse.com] Sent: Wednesday, June 27, 2018 4:19 PM To: Zhang, Chao B Cc: edk2-devel@lists.01.org; Yao, Jiewen ; Long, Qin Subject: Re: [edk2] [Patch 2/2] SecurityPkg: Tpm2DeviceLib: Enable

Re: [edk2] [Patch] SecurityPkg Tpm2DeviceLibDTpm: Update enum type name to match the one in lib

2018-06-27 Thread Zhang, Chao B
Hi Liming: Thanks for catching this. Reviewed-by: Chao Zhang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, June 27, 2018 10:49 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] SecurityPkg Tpm2DeviceLibDTpm: U

[edk2] [Patch 2/2] SecurityPkg: Tpm2DeviceLib: Enable CapCRBIdleBypass support

2018-06-24 Thread Zhang, Chao B
Directly transition from CMD completion to CMD Ready state if device supports IdleByPass Cc: Long Qin Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B --- .../Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.c | 19

[edk2] [Patch 1/2] Add CapCRBIdleBypass definition to interface ID register. It complies with existing register

2018-06-24 Thread Zhang, Chao B
Signed-off-by: Zhang, Chao B --- MdePkg/Include/IndustryStandard/TpmPtp.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/TpmPtp.h b/MdePkg/Include/IndustryStandard/TpmPtp.h index 0796512688..c7ff8fdc58 100644 --- a/MdePkg/Include

[edk2] [Patch 0/2] Add CRB IdleByPass Support

2018-06-24 Thread Zhang, Chao B
Add CRB IdleByPass Support Zhang, Chao B (2): Add CapCRBIdleBypass definition to interface ID register. It complies with existing register SecurityPkg: Tpm2DeviceLib: Enable CapCRBIdleBypass support MdePkg/Include/IndustryStandard/TpmPtp.h | 5 +- .../Library

[edk2] [Patch V2] SecurityPkg: Cache TPM interface type info

2018-06-21 Thread Zhang, Chao B
Cache TPM interface type info to avoid excessive interface ID register read Cc: Long Qin Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhang, Chao B --- SecurityPkg/Include/Library/Tpm2DeviceLib.h| 12 +++- .../Library/Tpm2DeviceLibDTpm

[edk2] [Patch] SecurityPkg: Cache TPM interface type info

2018-06-20 Thread Zhang, Chao B
Cache TPM interface type info to avoid excessive interface ID register read Cc: Long Qin Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B --- SecurityPkg/Include/Library/Tpm2DeviceLib.h| 12 +++- .../Library

[edk2] [Patch] CryptoPkg PeiCryptLib: Enable SHA384/512 support

2018-06-07 Thread Zhang, Chao B
Enable SHA384/512 support in PEI phase. Cc: Long Qin Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B --- CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [edk2] [PATCH] SecurityPkg/SecureBootConfigDxe: Fix invalid NV data issue.

2018-06-04 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Nickle Wang [mailto:nickle.w...@hpe.com] Sent: Tuesday, May 29, 2018 8:08 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B ; Yao, Jiewen ; Nickle Wang ; cinnamon shia Subject: [PATCH] SecurityPkg/SecureBootConfigDxe: Fix invalid NV data

[edk2] [Patch] SecurityPkg/Tcg2Smm: Correct function parameter attribute

2018-05-28 Thread Zhang, Chao B
Correct UpdatePossibleResource parameter attribute to align to comment Change-Id: Id8f8be975f0e8666573decc3fbaaf326b7767ba8 Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Long Qin Cc: Yao Jiewen Reviewed-by: Chao Zhang Signed-off-by: Zhang, Chao B --- SecurityPkg/Tcg/Tcg2Smm

Re: [edk2] Set "db" variable in secure boot setup mode still requires generating PKCS#7?

2018-05-20 Thread Zhang, Chao B
David: Have you tried to enroll .crt from HII Secure Boot Configure Page? Basically when PK exists , PhysicalPresence and Customized Mode must be asserted in order to enroll a signature without CertData to KEK/DB…, From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of David F

[edk2] [Patch] SecurityPkg:Tcg2Smm: Update TcgNvs info after memory is allocated

2018-05-20 Thread Zhang, Chao B
Update package format info in _PRS to TcgNvs after memory is allocated. Change-Id: Icfadb350e60d3ed2df332e92c257ce13309c0018 Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yao Jiewen Cc: Long Qin Signed-off-by: Zhang, Chao B --- SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 19

Re: [edk2] [Patch] SecurityPkg Tpm2CommandLib: Fix TPM2.0 response memory overflow

2018-03-20 Thread Zhang, Chao B
Good catch! Jiewen, I will add more check in CopyAuthSessionResponse() From: Yao, Jiewen Sent: Wednesday, March 21, 2018 2:39 PM To: Zhang, Chao B ; Long, Qin ; edk2-devel@lists.01.org Subject: RE: [Patch] SecurityPkg Tpm2CommandLib: Fix TPM2.0 response memory overflow Some thought: 1) Would

Re: [edk2] [Patch] SecurityPkg Tpm2CommandLib: Fix TPM2.0 response memory overflow

2018-03-20 Thread Zhang, Chao B
Thanks Qin, I will add more comments to explain the magic code -Original Message- From: Long, Qin Sent: Wednesday, March 21, 2018 10:58 AM To: Zhang, Chao B ; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [Patch] SecurityPkg Tpm2CommandLib: Fix TPM2.0 response memory overflow

[edk2] [Patch] SecurityPkg Tpm12CommandLib: Fix TPM12 GetCapability response error

2018-03-20 Thread Zhang, Chao B
TPM12 command lib doesn't convert Response Size before using. Add logic to fix the issue. Cc: Long Qin Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B --- SecurityPkg/Library/Tpm12CommandLib/Tpm12GetCapabil

[edk2] [Patch] SecurityPkg Tpm2CommandLib: Fix TPM2.0 response memory overflow

2018-03-20 Thread Zhang, Chao B
Contribution Agreement 1.1 Signed-off-by: Chao Zhang Signed-off-by: Zhang, Chao B --- .../Library/Tpm2CommandLib/Tpm2Capability.c| 21 ++- .../Tpm2CommandLib/Tpm2EnhancedAuthorization.c | 16 ++- SecurityPkg/Library/Tpm2CommandLib/Tpm2Integrity.c | 19

Re: [edk2] [PATCH 00/15] Remove TrEE*

2018-03-15 Thread Zhang, Chao B
Series reviewed-by: Chao Zhang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Thursday, March 15, 2018 3:35 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [edk2] [PATCH 00/15] Remove TrEE* From: Jiewen Yao TrEE

[edk2] [PATCH 12/15] SecurityPkg/TrEEPhysicalPresenceLib: remove TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- SecurityPkg/Library/DxeTrEEPhysicalPresenceLib/DxeTrEEPhysicalPresenceLib.c | 743 SecurityPkg/Library/DxeTrEEP

[edk2] [PATCH 11/15] SecurityPkg/Tpm2DeviceLibTrEE: remove TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- SecurityPkg/Library/Tpm2DeviceLibTrEE/Tpm2DeviceLibTrEE.c | 125 SecurityPkg/Library/Tpm2DeviceLibTrEE/Tpm2Devi

[edk2] [PATCH 15/15] SecurityPkg/dec: remove TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dec | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/SecurityPkg/Security

[edk2] [PATCH 10/15] SecurityPkg/TrEEConfig: remove TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- SecurityPkg/Tcg/TrEEConfig/TpmDetection.c | 105 -- SecurityPkg/Tcg/TrEEConfig/TrEEConfig.vfr | 68 SecurityP

[edk2] [PATCH 09/15] SecurityPkg/TrEEPei: remove TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- SecurityPkg/Tcg/TrEEPei/TrEEPei.c| 690 SecurityPkg/Tcg/TrEEPei/TrEEPei.inf | 86 --- SecurityPkg/Tc

[edk2] [PATCH 14/15] SecurityPkg/include: remove TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- SecurityPkg/Include/Guid/TrEEConfigHii.h | 25 --- SecurityPkg/Include/Guid/TrEEPhysicalPresenceData.h | 67

[edk2] [PATCH 13/15] SecurityPkg/TrEEVendorLib: remove TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- SecurityPkg/Library/TrEEPpVendorLibNull/TrEEPpVendorLibNull.c | 131 SecurityPkg/Library/TrEEPpVendorLibNull/Tr

[edk2] [PATCH 08/15] SecurityPkg/TrEEDxe: remove TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- SecurityPkg/Tcg/TrEEDxe/MeasureBootPeCoff.c | 427 - SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c | 1877 Secu

[edk2] [PATCH 06/15] SecurityPkg/dsc: remove TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dsc | 44 +--- 1 file changed, 1 insertion(+), 43 deletions(-) diff --git a/SecurityPkg/Securi

[edk2] [PATCH 07/15] SecurityPkg/TrEESmm: remove TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- SecurityPkg/Tcg/TrEESmm/Tpm.asl | 354 - SecurityPkg/Tcg/TrEESmm/TrEESmm.c| 521 Secu

[edk2] [PATCH 04/15] Vlv2TbltDevicePkg/Bds: use Tcg2 instead of TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: David Wei Cc: Mang Guo Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c | 6 +++--- Vlv2TbltDevicePkg/Library/Platform

[edk2] [PATCH 00/15] Remove TrEE*

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated and not maintained any more. We need use Tcg2. *** BLURB HERE *** Jiewen Yao (15): ShellPkg/UefiHandleParsingLib: remove TrEE reference. QuarkPlatformPkg: remove TrEE reference. Vlv2TbltDevicePkg/Tcg2PhysicalPresenceLib: use Tcg2 instead of TrEE. Vlv2

[edk2] [PATCH 01/15] ShellPkg/UefiHandleParsingLib: remove TrEE reference.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Jaben Carsey Cc: Ruiyu Ni Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 1 - ShellPkg/Library/UefiHandleParsin

[edk2] [PATCH 05/15] Vlv2TbltDevicePkg/dsc/fdf: use Tcg2 instead of TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: David Wei Cc: Mang Guo Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- Vlv2TbltDevicePkg/PlatformPkg.fdf | 6 +++--- Vlv2TbltDevicePkg/PlatformPkgGcc.fdf| 6 +++---

[edk2] [PATCH 02/15] QuarkPlatformPkg: remove TrEE reference.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: Michael D Kinney Cc: Kelly Steele Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- QuarkPlatformPkg/Quark.dsc | 2 +- QuarkPlatformPkg/Quark.fdf | 2 +- 2 files changed, 2 insert

[edk2] [PATCH 03/15] Vlv2TbltDevicePkg/Tcg2PhysicalPresenceLib: use Tcg2 instead of TrEE.

2018-03-15 Thread Zhang, Chao B
From: Jiewen Yao TrEE is deprecated. We need use Tcg2. Cc: David Wei Cc: Mang Guo Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- Vlv2TbltDevicePkg/Library/{DxeTrEEPhysicalPresenceLibNull/DxeTrEEPhysicalPresenceLibNull.c => DxeTcg2Phy

Re: [edk2] [PATCH] ShellPkg/Dmpstore: Enhance display information for Auth3 variable.

2018-03-14 Thread Zhang, Chao B
Chen Chen: Please update license header. Others are good to me. Reviewed-by: Chao Zhang -Original Message- From: Chen, Chen A Sent: Tuesday, March 13, 2018 3:37 PM To: edk2-devel@lists.01.org Cc: Chen, Chen A ; Ni, Ruiyu ; Zhang, Chao B Subject: [PATCH] ShellPkg/Dmpstore: Enhance

Re: [edk2] [PATCH 2/2] SecurityPkg/TcgPei: drop PeiReadOnlyVariable from Depex

2018-03-12 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Saturday, March 10, 2018 4:05 AM To: edk2-devel-01 Cc: Zhang, Chao B ; Yao, Jiewen Subject: [PATCH 2/2] SecurityPkg/TcgPei: drop PeiReadOnlyVariable from Depex TcgPei doesn't actuall

Re: [edk2] [PATCH v2 2/8] SecurityPkg/Tcg2Pei: drop PeiReadOnlyVariable from Depex

2018-03-07 Thread Zhang, Chao B
Hi Lureau: I think we can remove same dependency in TcgPei. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of marcandre.lur...@redhat.com Sent: Wednesday, March 7, 2018 11:58 PM To: edk2-devel@lists.01.org Cc: qemu-de...@nongnu.org; javi...@redh

Re: [edk2] [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask

2018-03-07 Thread Zhang, Chao B
; javi...@redhat.com; Marc-André Lureau ; Zhang, Chao B ; Zeng, Star Subject: [PATCH v2 1/8] SecurityPkg: also clear HashInterfaceHob.SupportedHashMask From: Marc-André Lureau Commit 4cc2b63bd829426b05bad0d8952f1855a10d6ed7 fixed an out of bounds ZeroMem() call. However, as Laszlo Ersek

Re: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob

2018-03-07 Thread Zhang, Chao B
dré Lureau ; edk2-devel@lists.01.org Cc: Laszlo Ersek ; Yao, Jiewen ; Zhang, Chao B ; Zeng, Star Subject: RE: [edk2] [PATCH v2 1/1] SecurityPkg: fix ZeroMem HashInterfaceHob Yes, since the V1 has been pushed. Just adding one line like below based on V1 should be ok. HashInterface

Re: [edk2] [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: Fix coding style issue

2018-03-06 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Bi, Dandan Sent: Wednesday, March 7, 2018 1:54 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: Fix coding style issue Boolean values do not need to use explicit comparisons to

Re: [edk2] [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations

2018-03-06 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: marcandre.lur...@redhat.com [mailto:marcandre.lur...@redhat.com] Sent: Wednesday, March 7, 2018 4:27 AM To: edk2-devel@lists.01.org Cc: Marc-André Lureau ; Yao, Jiewen ; Zhang, Chao B ; Zeng, Star ; Laszlo Ersek Subject: [PATCH 1/1

Re: [edk2] [PATCH] Maintainers.txt: Add Jiewen to be co-maintainer of SecurityPkg.

2018-03-01 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: Zhang, Chao B Sent: Wednesday, February 28, 2018 2:19 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Zhang, Chao B Subject: [PATCH] Maintainers.txt: Add Jiewen to be co-maintainer of SecurityPkg. From: Jiewen Yao Cc: Chao B Zhang

[edk2] [PATCH] Maintainers.txt: Add Jiewen to be co-maintainer of SecurityPkg.

2018-02-27 Thread Zhang, Chao B
From: Jiewen Yao Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 74f2538..e103f85 100644 --- a/Maintainers.txt +++ b/Maintainers.tx

Re: [edk2] TPM 2.0 Manufacutre ID wrong byte order

2018-02-23 Thread Zhang, Chao B
this interface clearer. But I think current implementation is good from spec point of view. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Lin, Derek (HPS UEFI Dev) Sent: Friday, February 23, 2018 4:08 PM To: Zhang, Chao B ; edk2-devel@

Re: [edk2] TPM 2.0 Manufacutre ID wrong byte order

2018-02-22 Thread Zhang, Chao B
k (HPS UEFI Dev) [mailto:derek.l...@hpe.com] Sent: Thursday, February 22, 2018 7:25 PM To: edk2-devel@lists.01.org; Zhang, Chao B Cc: Yao, Jiewen ; Zeng, Star Subject: TPM 2.0 Manufacutre ID wrong byte order Hi TPM expert, The line in https://github.com/tianocore/edk2/commit/73126ac2bd9804632255b2fdd

[edk2] [PATCH] SecurityPkg: Tcg2Smm: Fix type casting issue

2018-02-07 Thread Zhang, Chao B
Fix type casting issue when calculating pointers offset Cc: Wu Hao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang --- SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c b/Sec

[edk2] [PATCH] SecurityPkg:Tcg2Smm: Fix compile issue

2018-02-06 Thread Zhang, Chao B
Update Tcg2Smm _PRS patching logic to fix compile issue Cc: Liming Gao Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chao Zhang --- SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/SecurityPkg/Tc

Re: [edk2] [Patch] SecurityPkg: Don't build AuthVariableLib for EBC arch

2018-02-05 Thread Zhang, Chao B
Reviewed-by: Chao Zhang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, January 30, 2018 1:34 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] SecurityPkg: Don't build AuthVariableLib for EBC arch EBC build failur

Re: [edk2] [PATCH] SecurityPkg: Support PP version lower than 1.3

2018-02-05 Thread Zhang, Chao B
Qin & Jiewen Tks for your comments , I will follow up to update the patch. -Original Message- From: Yao, Jiewen Sent: Tuesday, February 6, 2018 10:33 AM To: Long, Qin ; Zhang, Chao B ; edk2-devel@lists.01.org Subject: RE: [PATCH] SecurityPkg: Support PP version lower than 1.3 Yea

  1   2   3   4   5   >