Re: [edk2] [PATCH] Platform/ARM: Correct LevelID in PLPI packages of DSDT

2018-07-10 Thread Evan Lloyd
Reviewed-by: Evan Lloyd > -Original Message- > From: AlexeiFedorov > Sent: 04 July 2018 14:05 > To: edk2-devel@lists.01.org > Cc: Arvind Chauhan ; Thomas Abraham > ; ard.biesheu...@linaro.org; > leif.lindh...@linaro.org; Matteo Carlini ; > Stephanie Hughes-Fitt

Re: [edk2] [PATCH edk2-platforms v2 3/3] Readme.md: Add instructions to build in a Windows Environment

2018-07-03 Thread Evan Lloyd
Reviewed-by: Evan Lloyd Leif - would it make sense/be acceptable to add a GNU make.exe image to edk2-non-osi? Evan > -Original Message- > From: Leif Lindholm > Sent: 03 July 2018 11:24 > To: Chris Co > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Michael D K

Re: [edk2] [PATCH] MdePkg/BaseLib: Add bit field Hamming weight calculation methods

2018-07-02 Thread Evan Lloyd
Range 0..31. > + @param EndBitThe ordinal of the most significant bit in the bit field. > +Range 0..31. > + > + @return The number of bits set between StartBit and EndBit. > + > +**/ > +UINT8 > +EFIAPI > +BitFieldHammingWeight32 ( > + IN UINT

Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

2018-06-29 Thread Evan Lloyd
> -Original Message- > From: edk2-devel On Behalf Of Evan > Lloyd > Sent: 27 June 2018 17:58 > To: Sami Mujawar ; edk2-devel@lists.01.org > Cc: Arvind Chauhan ; Stephanie Hughes-Fitt > ; nd > Subject: Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/dev

Re: [edk2] [RFC] EDK II stable tag releases

2018-06-28 Thread Evan Lloyd
nd > > testing activities along with the dates associated for future EDK II > > stable tag releases. > > > > Please provide any feedback you have on this proposal. > > I welcome it. :) > > Thanks! > Laszlo [[Evan Lloyd]] I too think this is a good idea. &

Re: [edk2] [PATCH v1 1/1] BaseTools/Trim: Canonicalize filepaths to fix comparison

2018-06-28 Thread Evan Lloyd
Hi Chris. > -Original Message- > From: Chris Co > Sent: 27 June 2018 21:03 > To: Evan Lloyd ; edk2-devel@lists.01.org; Liming Gao > > Cc: Leif Lindholm ; Sami Mujawar > > Subject: RE: [PATCH v1 1/1] BaseTools/Trim: Canonicalize filepaths to fix > comparison

Re: [edk2] [PATCH edk2-platforms v1 0/6][platforms/devel-dynamictables] Fix issues reported by ecc tool

2018-06-27 Thread Evan Lloyd
Signed-off-by: Evan Lloyd > -Original Message- > From: Sami Mujawar > Sent: 27 June 2018 17:49 > To: edk2-devel@lists.01.org > Cc: Arvind Chauhan ; Daniil Egranov > ; Thomas Abraham > ; leif.lindh...@linaro.org; Evan Lloyd > ; Matteo Carlini ; > Stephanie Hu

Re: [edk2] [staging/dynamictables PATCH v1 0/5] Fix issues reported by ecc tool

2018-06-27 Thread Evan Lloyd
Signed-off-by: Evan Lloyd > -Original Message- > From: Sami Mujawar > Sent: 27 June 2018 17:48 > To: edk2-devel@lists.01.org > Cc: leif.lindh...@linaro.org; Evan Lloyd ; Matteo > Carlini ; Stephanie Hughes-Fitt > ; nd > Subject: [staging/dynamictables PATCH v1

Re: [edk2] [PATCH v1 1/1] BaseTools/Trim: Canonicalize filepaths to fix comparison

2018-06-27 Thread Evan Lloyd
9694a 100644 > --- a/BaseTools/Source/Python/Trim/Trim.py > +++ b/BaseTools/Source/Python/Trim/Trim.py > @@ -166,6 +166,8 @@ def TrimPreprocessedFile(Source, Target, ConvertHex, > TrimLong): > if len(MatchList) == 2: > LineNumber = int(MatchList[0], 0) >

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-18 Thread Evan Lloyd
Hi Laszlo, Star. Looking at the e-mail thread, I think I also made the mistake of getting Star's name inverted. I'm sorry, especially as in this case it is not as unclear as some Chinese names can be for foreigners. I can only put this one down to approaching senility. Sorry, Star - I'll try

Re: [edk2] [PATCH v2] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-15 Thread Evan Lloyd
Hi Ard, Zeng > -Original Message- > From: Ard Biesheuvel > Sent: 15 June 2018 15:17 > To: Sami Mujawar > Cc: edk2-devel@lists.01.org; Zeng, Star ; Eric Dong > ; Ruiyu Ni ; Leif Lindholm > ; Matteo Carlini ; > Stephanie Hughes-Fitt ; Evan Lloyd > ; Thomas Ab

Re: [edk2] [PATCH v1] MdeModulePkg: Enable SATA Controller PCI mem space

2018-06-14 Thread Evan Lloyd
Reviewed-by: Evan Lloyd > -Original Message- > From: Sami Mujawar > Sent: 14 June 2018 12:38 > To: edk2-devel@lists.01.org > Cc: star.z...@intel.com; eric.d...@intel.com; ruiyu...@intel.com; > ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Matteo Carlini > ;

Re: [edk2] [PATCH edk2-platforms v2 0/3][platforms/devel-dynamictables] Update for ACPICA compiler enhancements

2018-05-18 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> Leif, Ard - are you happy to accept this for the patchset, or should I respond to each patch? Regards, Evan > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Sami > Mujawar >

Re: [edk2] [staging/dynamictables PATCH v2] Update Readme.md to reflect ACPICA compiler update

2018-05-18 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: Sami Mujawar <sami.muja...@arm.com> > Sent: 18 May 2018 12:09 > To: edk2-devel@lists.01.org > Cc: ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Matteo Carlini > <matteo.c

Re: [edk2] [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update

2018-05-11 Thread Evan Lloyd
t; > +C)](https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63 > b > > +29626852a0b5f37)'***, to enable this support has been integrated to > > +the ACPICA source repository. > > Linux distributions tend to use dates to refer to what particular point a > version is based o

Re: [edk2] Incorrect Author on patch

2018-05-02 Thread Evan Lloyd
a brilliant idea, but it does introduce problems. If, post review, the merge were to be from a pull request then there would be no risk of "meta-data corruption". Regards Evan > -Original Message- > From: Laszlo Ersek <ler...@redhat.com> > Sent: 25 April 20

[edk2] Incorrect Author on patch

2018-04-25 Thread Evan Lloyd
someone for whom the stats are significant. Regards, Evan Evan Lloyd | Technical Lead for Windows on Arm | Arm . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . m. +44 (0)7825256132 110 Fulbourn Road, Cambridge, CB1 9NJ Arm.com IMPORTANT NOTICE: The contents of this email and any

Re: [edk2] [PATCH edk2-platforms v3 12/17] ARM/VExpressPkg: Allocate framebuffer using EfiRuntimeServicesData

2018-03-22 Thread Evan Lloyd
> >> runtime, the firmware itself will never access it, so > >> EfiRuntimeServicesData is not appropriate > >> > >> Please use EfiReservedMemory instead. > > > > Specification (UEFI Spec 2_7_A Sept 6.pdf) describes > > EfiReservedMem

Re: [edk2] [staging/dynamictables PATCH 0/2] Dynamic Tables Framework core

2018-03-21 Thread Evan Lloyd
ot; provide any useful > information for the reader? I recommend the name "DynamicAcpiTableDxe". [[Evan Lloyd]] The problem with " DynamicAcpiTableDxe" is that the table manager can be used for SMBIOS tables and even, should you be so inclined (perverse?) Device Tree. The &

Re: [edk2] [PATCH edk2-platforms v3 00/17] Update GOP

2018-03-21 Thread Evan Lloyd
To minimise the spam involved, I'm hoping the maintainers will accept this as covering all the patches listed. (Please?) Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pa

Re: [edk2] [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 15/16] ArmPkg: MTL Library interface and Null library implementation

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 03/16] ArmPlatformPkg: Tidy Lcd code: Coding standard

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 13/16] ArmPlatformPkg: Reserving framebuffer at build

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 14/16] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 12/16] ArmPlatformPkg: Additional display modes

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 04/16] ArmPlatformPkg: Tidy Lcd code: Updated comments

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 09/16] ArmPlatformPkg: Redefine LcdPlatformGetTimings function

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 05/16] ArmPlatformPkg: HDLCD and PL111: Update debug ASSERTS

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 10/16] ArmPlatformPkg: Add PCD to select pixel format

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 11/16] ArmPlatformPkg: PCD to swap red/blue format for HDLCD

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 01/16] ArmPlatformPkg: Rectify line endings of LcdHwNullLib

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 02/16] ArmPlatformPkg: Rectify line endings of LcdPlatformNullLib

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 06/16] ArmPlatformPkg: PL111Lcd: Replace magic number with macro

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 07/16] ArmPlatformPkg: PL111Lcd: Combine two writes to LCDControl

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [PATCH v3 08/16] ArmPlatformPkg: Implement LcdIdentify function for HDLCD GOP

2018-03-21 Thread Evan Lloyd
Reviewed-by: Evan Lloyd <evan.ll...@arm.com> > -Original Message- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd <n...@arm.com>; Stephanie Hu

Re: [edk2] [staging/dynamictables PATCH 1/2] MdePkg: SMMUv3 updates for IORT table definitions

2018-03-19 Thread Evan Lloyd
> -Original Message- > From: Sami Mujawar [mailto:sami.muja...@arm.com] > Sent: 19 March 2018 15:19 > To: edk2-devel@lists.01.org > Cc: Evan Lloyd <evan.ll...@arm.com>; leif.lindh...@linaro.org; Matteo > Carlini <matteo.carl...@arm.com>; Stephanie Hug

Re: [edk2] [PATCH 2/2][platforms/dynamictables] Platform/ARM: Dynamic Tables support for FVP

2018-03-19 Thread Evan Lloyd
> -Original Message- > From: Sami Mujawar [mailto:sami.muja...@arm.com] > Sent: 19 March 2018 15:22 > To: edk2-devel@lists.01.org > Cc: Arvind Chauhan <arvind.chau...@arm.com>; Daniil Egranov > <daniil.egra...@arm.com>; Thomas Abraham > <thomas.a

Re: [edk2] [PATCH 1/2][platforms/dynamictables] Platform/ARM: Dynamic Tables support for Juno

2018-03-19 Thread Evan Lloyd
> -Original Message- > From: Sami Mujawar [mailto:sami.muja...@arm.com] > Sent: 19 March 2018 15:22 > To: edk2-devel@lists.01.org > Cc: Arvind Chauhan <arvind.chau...@arm.com>; Daniil Egranov > <daniil.egra...@arm.com>; Thomas Abraham > <thomas.a

[edk2] GOP:Frame Buffer memory type?

2018-03-15 Thread Evan Lloyd
he "available for general use" basically means overwritten by OS memory usage, so the pixels corrupt OS data. So - can anyone advise us on whether there is some "Standard" way of doing this, is this an undefined area, or have we missed something? Regards

[edk2] AARCH64:Use of EFI_MEMORY_XP

2018-03-14 Thread Evan Lloyd
, Evan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Evan Lloyd > Sent: 08 January 2018 18:51 > To: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: "matteo.carl...@arm.com"@arm.com; > "leif.lindh...@l

Re: [edk2] [PATCH edk2-platforms v2 06/18] ARM/VExpressPkg: Add and update debug ASSERTS

2018-03-05 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 02 March 2018 19:07 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: leif.lindh...@linaro.org; Girish Pathak <girish.pat...@arm.com>; > Matteo Carlini <matteo.carl...@arm.co

Re: [edk2] [PATCH edk2-platforms v2 06/18] ARM/VExpressPkg: Add and update debug ASSERTS

2018-02-28 Thread Evan Lloyd
nt: 04 January 2018 19:55 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: Girish Pathak <girish.pat...@arm.com>; Matteo Carlini > <matteo.carl...@arm.com>; nd <n...@arm.com>; edk2-devel@lists.01.org; > Thomas Abraham <thomas.abra...@arm.com>; Arvind Chauhan &

[edk2] [PATCH] Platform/ARM: Fix flash alignment access

2018-01-22 Thread evan . lloyd
bution Agreement 1.1 Signed-off-by: Alexei Fedorov <alxei.fedo...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- Platform/ARM/JunoPkg/ArmJuno.dsc | 1 + Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc| 3 ++- Platform/ARM/VExpressPkg/ArmVExpress-F

Re: [edk2] [PATCH v2 13/13] ArmPlatformPkg: Introduce SCMI protocol

2018-01-11 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 23 December 2017 14:06 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; "ard.biesheu...@linaro.org"@arm.com; > "leif.lindh...@linaro.org"

Re: [edk2] [PATCH edk2-platforms v2 18/18] ARM/JunoPkg: Add HDLCD platform library

2018-01-09 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 23 December 2017 16:23 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; Arvind Chauhan <arvind.chau...@arm.com>; > Daniil Egranov <daniil

Re: [edk2] [PATCH edk2-platforms v2 15/18] ARM/VExpressPkg: New DP500/DP550/DP650 platform library.

2018-01-08 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 23 December 2017 16:07 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; Arvind Chauhan <arvind.chau...@arm.com>; > Daniil Egranov <daniil

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 4/5] Fix Chapter 4 Typo

2018-01-08 Thread Evan Lloyd
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 03 January 2018 16:56 > To: Evan Lloyd <evan.ll...@arm.com>; edk2-devel@lists.01.org > Cc: "ard.biesheu...@linaro.org"@arm.com; > "leif.lindh...@linaro.org"@arm.c

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 5/5] Fix Chapter 5 Typos

2018-01-08 Thread Evan Lloyd
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 03 January 2018 17:08 > To: Evan Lloyd <evan.ll...@arm.com>; edk2-devel@lists.01.org > Cc: "ard.biesheu...@linaro.org"@arm.com; > "leif.lindh...@linaro.org"@arm.c

Re: [edk2] [PATCH edk2-platforms v2 06/18] ARM/VExpressPkg: Add and update debug ASSERTS

2018-01-04 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 04 January 2018 19:24 > To: Girish Pathak <girish.pat...@arm.com> > Cc: Evan Lloyd <evan.ll...@arm.com>; Matteo Carlini > <matteo.carl...@arm.com>; nd <n...@arm.

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 4/5] Fix Chapter 4 Typo

2018-01-04 Thread Evan Lloyd
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 03 January 2018 16:56 > To: Evan Lloyd <evan.ll...@arm.com>; edk2-devel@lists.01.org > Cc: "ard.biesheu...@linaro.org"@arm.com; > "leif.lindh...@linaro.org"@arm.c

Re: [edk2] [edk2-CCodingStandardsSpecification PATCH 1/5] Fix Chapter 1 Typos

2018-01-04 Thread Evan Lloyd
Hi Laszlo > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: 03 January 2018 16:51 > To: Evan Lloyd <evan.ll...@arm.com>; edk2-devel@lists.01.org > Cc: "ard.biesheu...@linaro.org"@arm.com; > "leif.lindh...@linaro.org"

Re: [edk2] [PATCH v2 01/13] ArmPlatformPkg: Tidy Lcd code: Coding standard

2018-01-03 Thread Evan Lloyd
Hi Ard > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 02 January 2018 15:21 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; Matteo Carlini <matteo.carl...@arm.com>; > eif.lindh...@linaro.org; n

[edk2] [edk2-CCodingStandardsSpecification PATCH 4/5] Fix Chapter 4 Typo

2018-01-03 Thread evan . lloyd
From: Evan Lloyd <evan.ll...@arm.com> 4.1.3.2 - remove "See" from 'as specified in See "File Heading"' Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- 4_naming_conventions/README.md | 418 +

[edk2] [edk2-CCodingStandardsSpecification PATCH 5/5] Fix Chapter 5 Typos

2018-01-03 Thread evan . lloyd
From: Evan Lloyd <evan.ll...@arm.com> 5.1.1 - Replace "less" with "fewer" (because columns is plural and countable) 5.1.5 - Correct tense. (because the C specification still defines...) Insert full stop. Insert comma. 5.1.8 - Correct "provid

[edk2] [edk2-CCodingStandardsSpecification PATCH 1/5] Fix Chapter 1 Typos

2018-01-03 Thread evan . lloyd
From: Evan Lloyd <evan.ll...@arm.com> 1.1 Abstract - replace "then" with "can" (to make meaningful) 1.2 Rationale - change "commit to conforming to standards of this specification" to commit to conforming with the standards of th

[edk2] [edk2-CCodingStandardsSpecification PATCH 0/5] Typographic Corrections

2018-01-03 Thread evan . lloyd
From: Evan Lloyd <evan.ll...@arm.com> https://bugzilla.tianocore.org/show_bug.cgi?id=839 This patch set contains a number of minor typographical corrections. They have no specific theme, being only that set of things I happened to notice during recent code review sessions where I was freq

[edk2] [edk2-CCodingStandardsSpecification PATCH 3/5] Fix Chapter 3 Typos

2018-01-03 Thread evan . lloyd
From: Evan Lloyd <evan.ll...@arm.com> 3_quick_reference.md has some obviously invalid extra characters at the end of line 55 ( ",). This patch removes them. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- 3_quick_refer

[edk2] [edk2-CCodingStandardsSpecification PATCH 2/5] Fix Chapter 2 Typos

2018-01-03 Thread evan . lloyd
From: Evan Lloyd <evan.ll...@arm.com> 2.1 Accessibility - remove erroneous "as" 2.1 Confirmation - insert missing full stop 2.1 Forgiveness - excise superfluous "errors" 2.1 Standard techniques - remove redundant "be to" Contributed-under: TianoCore Contributi

Re: [edk2] [PATCH edk2-platforms v2 14/18] ARM/VExpressPkg: Reserving framebuffer at build

2018-01-03 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 23 December 2017 16:03 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; Arvind Chauhan <arvind.chau...@arm.com>; > Daniil Egranov <daniil

Re: [edk2] [PATCH v2 01/13] ArmPlatformPkg: Tidy Lcd code: Coding standard

2018-01-02 Thread Evan Lloyd
iesheu...@linaro.org] > Sent: 23 December 2017 13:19 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; "ard.biesheu...@linaro.org"@arm.com; > "leif.lindh...@linaro.org"@arm.com; > "matteo.carl...@arm.com"@arm.com; "n...@arm.com"@ar

Re: [edk2] [PATCH edk2-platforms v2 00/18] ARM: Update GOP

2018-01-02 Thread Evan Lloyd
iesheu...@linaro.org] > Sent: 22 December 2017 19:30 > To: Evan Lloyd <evan.ll...@arm.com>; Leif Lindholm > <leif.lindh...@linaro.org>; Ard Biesheuvel <ard.biesheu...@linaro.org>; > Matteo Carlini <matteo.carl...@arm.com> > Cc: edk2-devel@lists.01.org; Arvind Chauh

[edk2] [PATCH edk2-platforms v2 11/18] ARM/VExpressPkg: HdLcdArmVExpressLib: Remove redundant Bpp

2017-12-22 Thread evan . lloyd
TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 42 ++-- 1 file changed, 13 insertions(+), 29 de

[edk2] [PATCH edk2-platforms v2 15/18] ARM/VExpressPkg: New DP500/DP550/DP650 platform library.

2017-12-22 Thread evan . lloyd
Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- Platform/ARM/VExpressPkg/ArmVExpressPkg.dec| 3 +- Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.inf | 45 +++

[edk2] [PATCH edk2-platforms v2 17/18] ARM/JunoPkg: Adding SCMI MTL library

2017-12-22 Thread evan . lloyd
From: Girish Pathak This change adds a new Mailbox Transport Layer library for the Juno platform. This library is required for ArmScmiDxe driver communication with the SCP. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak

[edk2] [PATCH edk2-platforms v2 18/18] ARM/JunoPkg: Add HDLCD platform library

2017-12-22 Thread evan . lloyd
From: Girish Pathak This change adds the HDLCD platform lib for the Juno plaform. This library will be instantiated as a LcdPlatformLib to link with LcdGraphicsOutputDxe for the Juno platform. HDLCD platform library depends on the Arm SCMI DXE driver for communication

[edk2] [PATCH edk2-platforms v2 12/18] ARM/VExpressPkg: Redefine LcdPlatformGetTimings function

2017-12-22 Thread evan . lloyd
1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 104 +--- Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpr

[edk2] [PATCH edk2-platforms v2 14/18] ARM/VExpressPkg: Reserving framebuffer at build

2017-12-22 Thread evan . lloyd
the framebuffer to appear as "I/O memory" outside of the normal RAM map, which is similar to the "VRAM" case. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> ---

[edk2] [PATCH edk2-platforms v2 16/18] ARM/JunoPkg: Mapping Non-Trused SRAM as device memory

2017-12-22 Thread evan . lloyd
From: Girish Pathak This fix changes the cache attribute of Non-Trusted SRAM on the Juno platform to device memory. This change is required to avoid coherency problems as Non-Trusted SRAM is used as a shared memory between the application processor and the SCP for

[edk2] [PATCH edk2-platforms v2 05/18] ARM/VExpressPkg: PL111 and HDLCD: add const qualifier

2017-12-22 Thread evan . lloyd
From: Girish Pathak This change adds some STATIC and CONST qualifiers (mainly to arguments of functions) in PL111 and HdLcd platform libraries. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd &l

[edk2] [PATCH edk2-platforms v2 07/18] ARM/VExpressPkg: PL111LcdArmVExpressLib: Minor code cleanup

2017-12-22 Thread evan . lloyd
From: Girish Pathak This minor change removes some unecessary initializations and variables in PL111LcdArmVExpress.c Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> ---

[edk2] [PATCH edk2-platforms v2 06/18] ARM/VExpressPkg: Add and update debug ASSERTS

2017-12-22 Thread evan . lloyd
From: Girish Pathak This change adds some debug assertions e.g to catch NULL pointer errors missing in PL11Lcd and HdLcd platform libraries. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll..

[edk2] [PATCH edk2-platforms v2 03/18] ARM/VExpressPkg: Tidy HdLcd/PL111Lcd code: Updated comments

2017-12-22 Thread evan . lloyd
Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf | 2 +- Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdA

[edk2] [PATCH edk2-platforms v2 13/18] ARM/VExpressPkg: PL111 and HDLCD: Add PCD to select pixel format

2017-12-22 Thread evan . lloyd
is allowed as it might suit a custom platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf

[edk2] [PATCH edk2-platforms v2 09/18] ARM/VExpressPkg: PL11LcdArmVExpressLib: Improvement conditional

2017-12-22 Thread evan . lloyd
Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 40 +++- 1 file changed, 14 insertions(+), 26 deletions(-)

[edk2] [PATCH edk2-platforms v2 08/18] ARM/VExpressPkg: PL111 and HDLCD: Use FixedPcdGet32

2017-12-22 Thread evan . lloyd
From: Girish Pathak This change replaces PcdGet32 with FixedPcdGet32 for the PCDs which are defined as fixed PCDs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> ---

[edk2] [PATCH edk2-platforms v2 10/18] ARM/VExpressPkg: HdLcdArmVExpressLib: Remove status check EFI_TIMEOUT

2017-12-22 Thread evan . lloyd
Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 22 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/Platform/ARM/VExpres

[edk2] [PATCH edk2-platforms v2 00/18] ARM: Update GOP

2017-12-22 Thread evan . lloyd
From: EvanLloyd This patch series addresses comments on the original (https://lists.01.org/pipermail/edk2-devel/2017-September/015356.html) reworking of the Graphics Output Protocol code in Platform/ARM. It also contains updates for the new SCMI protocol (MTL Library). After

[edk2] [PATCH edk2-platforms v2 01/18] ARM/VExpressPkg: Fix MODULE_TYPE of HDLCD/PL111 platform libraries

2017-12-22 Thread evan . lloyd
From: Ard Biesheuvel This change fixes incorrect MODULE_TYPE of HDLCD and PL111 LcdPlatformLibs. Currently set MODUL_TYPE DXE_DRIVER is incorrect for these platform libraries. Hence set this to type BASE. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH edk2-platforms v2 04/18] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf

2017-12-22 Thread evan . lloyd
From: Girish Pathak PCD PcdPL111LcdMaxMode is not used in HDLCD platform library. Presence of this PCD in HDLCD is probably due to copy/paste code from PL111 Lcd platform library. This change removes it from the HdLcdArmVExpressLib.inf file. Contributed-under: TianoCore

[edk2] [PATCH v2 09/13] ArmPlatformPkg: PCD to swap red/blue format for HDLCD

2017-12-22 Thread evan . lloyd
: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- ArmPlatformPkg/ArmPlatformPkg.dec | 3 +++ ArmPlatformPkg/Library/HdLcd/HdLcd.inf | 2 ++ ArmPlatformPkg/Library/HdLcd/HdLcd.c | 4 3 file

[edk2] [PATCH v2 11/13] ArmPlatformPkg: Reserving framebuffer at build

2017-12-22 Thread evan . lloyd
ff-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- ArmPlatformPkg/ArmPlatformPkg.dec | 4 1 file changed, 4 insertions(+) diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec index 9a61e4a5

[edk2] [PATCH v2 12/13] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver.

2017-12-22 Thread evan . lloyd
for rendering the RGB/BGR format frame buffer to satisfy the UEFI GOP requirements Other layers e.g. video layers are not configured. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll..

[edk2] [PATCH v2 10/13] ArmPlatformPkg: Additional display modes

2017-12-22 Thread evan . lloyd
From: Girish Pathak Add definitions for new display modes such as HD 720. This has no effect on existing display drivers. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll..

[edk2] [PATCH v2 04/13] ArmPlatformPkg: HDLCD and PL111: Update debug ASSERTS

2017-12-22 Thread evan . lloyd
From: Girish Pathak This change moves some ASSERTs in error handling code to improve efficiency in DEBUG build. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- ArmPlatfor

[edk2] [PATCH v2 02/13] ArmPlatformPkg: Tidy Lcd code: Updated comments

2017-12-22 Thread evan . lloyd
<girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- ArmPlatformPkg/Include/Library/LcdPlatformLib.h| 92 +++- ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c | 20 ++--- ArmPlatformPkg/Library/H

[edk2] [PATCH v2 01/13] ArmPlatformPkg: Tidy Lcd code: Coding standard

2017-12-22 Thread evan . lloyd
-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h | 10 +- ArmPlatformPkg/Include/Library/LcdPlatformLib.h| 14 +- ArmPlatformPkg/Library/H

[edk2] [PATCH v2 05/13] ArmPlatformPkg: PL111Lcd: Replace magic number with macro

2017-12-22 Thread evan . lloyd
From: Girish Pathak Minor code change, replaces magic number with macro in LCD disable. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- ArmPlatformPkg/Library/PL111Lcd/PL

[edk2] [PATCH v2 00/13] ArmPlatformPkg: Update GOP

2017-12-22 Thread evan . lloyd
From: EvanLloyd This patch series addresses comments on the original (https://lists.01.org/pipermail/edk2-devel/2017-September/015321.html) reworking of the Graphics Output Protocol code in ArmPlatformPkg. It also contains updates for the new SCMI protocol. After a number

[edk2] [PATCH v2 03/13] ArmPlatformPkg: PL111 and HDLCD: add const qualifier

2017-12-22 Thread evan . lloyd
From: Girish Pathak This change adds CONST qualifiers (mainly to arguments of functions) in PL111 and HdLcd libraries. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- Ar

Re: [edk2] [PATCH] ShellPkg: Add acpiview tool to dump ACPI tables

2017-12-15 Thread Evan Lloyd
ng smbiosview Debug1 Shell > command. > > Many tables are not explicitly handled, in part because no examples are > available for our testing. > > The program is designed to be extended to new tables with minimal > effort, and contributions are invited. > > Contr

[edk2] [staging/DynamicTables] What about edk2-platforms.

2017-12-14 Thread Evan Lloyd
We are about to submit a new (ACPI 6.2) version of Sami's Dynamic Tables module. As suggested in previous threads, the aim is to submit it to edk2-staging. To that end, following the instructions at https://github.com/tianocore/edk2-staging/blob/about/README (paragraph 4 a) "Maintainer sends

Re: [edk2] [PATCH 19/19] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver.

2017-12-07 Thread Evan Lloyd
Hi Ard. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 05 December 2017 21:28 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; Matteo Carlini <matteo.carl...@arm.com>; > Leif Lindholm <leif.li

Re: [edk2] [PATCH 02/19] ArmPlatformPkg: Tidy LcdGraphicsOutputDxe code: Added comments

2017-12-05 Thread Evan Lloyd
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: 05 December 2017 19:59 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 02/19] ArmPlatformPkg: Tidy > LcdGraphicsOutputDxe code

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-12-05 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 01 December 2017 17:35 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org@arm.com > <"ard.biesheu...@linaro.org"@arm.com

Re: [edk2] [PATCH 03/19] ArmPlatformPkg: PL111 and HDLCD: add const qualifier

2017-12-05 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 01 December 2017 17:32 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org@arm.com > <"ard.biesheu...@linaro.org"@arm.com

Re: [edk2] [PATCH 19/19] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver.

2017-12-05 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 01 December 2017 17:19 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; Matteo Carlini <matteo.carl...@arm.com>; > Leif Lindholm <leif.li

Re: [edk2] [PATCH 02/19] ArmPlatformPkg: Tidy LcdGraphicsOutputDxe code: Added comments

2017-12-05 Thread Evan Lloyd
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: 12 October 2017 20:02 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 02/19] ArmPlatformPkg: Tidy > LcdGraphicsOutputDxe cod

Re: [edk2] [PATCH 18/19] ArmPlatformPkg: Reserving framebuffer at build

2017-12-01 Thread Evan Lloyd
Responses inline > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 25 October 2017 19:10 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; "ard.biesheu...@linaro.org"@arm.com; > "leif.lindh

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-12-01 Thread Evan Lloyd
Responses inline: > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 13 October 2017 08:33 > To: Evan Lloyd <evan.ll...@arm.com> > Cc: edk2-devel@lists.01.org; "ard.biesheu...@linaro.org"@arm.com; > "leif.lindh

  1   2   3   >