Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib

[Carsey, Jaben]

Reviewed-by: Jaben Carsey 

> -Original Message-
> From: Ni, Ray
> Sent: Thursday, March 28, 2019 6:50 PM
> To: Zhang, Shenglei ; edk2-devel@lists.01.org
> Cc: Carsey, Jaben 
> Subject: RE: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib
> Importance: High
> 
> Reviewed-by: Ray Ni 
> 
> > -Original Message-
> > From: Zhang, Shenglei
> > Sent: Friday, March 29, 2019 9:41 AM
> > To: edk2-devel@lists.01.org
> > Cc: Carsey, Jaben ; Ni, Ray 
> > Subject: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib
> >
> > With Itanium architecture unsupported, gEfiSalSystemTableGuid and
> > gEfiMpsTableGuid will be no longer used.
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1560
> >
> > Cc: Jaben Carsey 
> > Cc: Ray Ni 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang 
> > ---
> >  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 10 --
> >  .../UefiShellDebug1CommandsLib.inf |  2 --
> >  2 files changed, 12 deletions(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> > index a4c18c9b68..023806742d 100644
> > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> > @@ -17,9 +17,7 @@
> >  #include "UefiShellDebug1CommandsLib.h"
> >  #include   #include 
> > -#include   #include  -#include
> > 
> >
> >  /**
> >Make a printable character.
> > @@ -186,10 +184,6 @@ ShellCommandRunDmem (
> >AcpiTableAddress = (UINT64)(UINTN)gST-
> > >ConfigurationTable[TableWalker].VendorTable;
> >continue;
> >  }
> > -if (CompareGuid(
> >ConfigurationTable[TableWalker].VendorGuid,
> > )) {
> > -  SalTableAddress = (UINT64)(UINTN)gST-
> > >ConfigurationTable[TableWalker].VendorTable;
> > -  continue;
> > -}
> >  if
> > (CompareGuid(>ConfigurationTable[TableWalker].VendorGuid,
> > )) {
> >SmbiosTableAddress = (UINT64)(UINTN)gST-
> > >ConfigurationTable[TableWalker].VendorTable;
> >continue;
> > @@ -198,10 +192,6 @@ ShellCommandRunDmem (
> >SmbiosTableAddress = (UINT64) (UINTN) gST-
> > >ConfigurationTable[TableWalker].VendorTable;
> >continue;
> >  }
> > -if (CompareGuid(
> >ConfigurationTable[TableWalker].VendorGuid,
> > )) {
> > -  MpsTableAddress = (UINT64)(UINTN)gST-
> > >ConfigurationTable[TableWalker].VendorTable;
> > -  continue;
> > -}
> >}
> >
> >ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN
> > (STR_DMEM_SYSTEM_TABLE), gShellDebug1HiiHandle, diff --git
> >
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsL
> > i
> > b.inf
> >
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsL
> > i
> > b.inf
> > index ec1f87ae19..f2666b7ff9 100644
> > ---
> >
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsL
> > i
> > b.inf
> > +++
> >
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> d
> > +++ sLib.inf
> > @@ -130,8 +130,6 @@
> >gEfiGlobalVariableGuid  ## SOMETIMES_CONSUMES ## GUID
> >gEfiSmbiosTableGuid ## SOMETIMES_CONSUMES ## SystemTable
> >gEfiSmbios3TableGuid## SOMETIMES_CONSUMES ## SystemTable
> > -  gEfiMpsTableGuid## SOMETIMES_CONSUMES ## SystemTable
> > -  gEfiSalSystemTableGuid  ## SOMETIMES_CONSUMES ## SystemTable
> >gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable
> >gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable
> >gShellDebug1HiiGuid ## SOMETIMES_CONSUMES ## HII
> > --
> > 2.18.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib

[Ni, Ray]

Reviewed-by: Ray Ni 

> -Original Message-
> From: Zhang, Shenglei
> Sent: Friday, March 29, 2019 9:41 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Ni, Ray 
> Subject: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib
> 
> With Itanium architecture unsupported, gEfiSalSystemTableGuid and
> gEfiMpsTableGuid will be no longer used.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1560
> 
> Cc: Jaben Carsey 
> Cc: Ray Ni 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang 
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 10 --
>  .../UefiShellDebug1CommandsLib.inf |  2 --
>  2 files changed, 12 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> index a4c18c9b68..023806742d 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> @@ -17,9 +17,7 @@
>  #include "UefiShellDebug1CommandsLib.h"
>  #include 
>  #include 
> -#include 
>  #include 
> -#include 
> 
>  /**
>Make a printable character.
> @@ -186,10 +184,6 @@ ShellCommandRunDmem (
>AcpiTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
>continue;
>  }
> -if (CompareGuid(>ConfigurationTable[TableWalker].VendorGuid,
> )) {
> -  SalTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
> -  continue;
> -}
>  if (CompareGuid(>ConfigurationTable[TableWalker].VendorGuid,
> )) {
>SmbiosTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
>continue;
> @@ -198,10 +192,6 @@ ShellCommandRunDmem (
>SmbiosTableAddress = (UINT64) (UINTN) gST-
> >ConfigurationTable[TableWalker].VendorTable;
>continue;
>  }
> -if (CompareGuid(>ConfigurationTable[TableWalker].VendorGuid,
> )) {
> -  MpsTableAddress = (UINT64)(UINTN)gST-
> >ConfigurationTable[TableWalker].VendorTable;
> -  continue;
> -}
>}
> 
>ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_DMEM_SYSTEM_TABLE),
> gShellDebug1HiiHandle, diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> index ec1f87ae19..f2666b7ff9 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command
> +++ sLib.inf
> @@ -130,8 +130,6 @@
>gEfiGlobalVariableGuid  ## SOMETIMES_CONSUMES ## GUID
>gEfiSmbiosTableGuid ## SOMETIMES_CONSUMES ## SystemTable
>gEfiSmbios3TableGuid## SOMETIMES_CONSUMES ## SystemTable
> -  gEfiMpsTableGuid## SOMETIMES_CONSUMES ## SystemTable
> -  gEfiSalSystemTableGuid  ## SOMETIMES_CONSUMES ## SystemTable
>gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable
>gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable
>gShellDebug1HiiGuid ## SOMETIMES_CONSUMES ## HII
> --
> 2.18.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib

[Shenglei Zhang]

With Itanium architecture unsupported, gEfiSalSystemTableGuid
and gEfiMpsTableGuid will be no longer used.
https://bugzilla.tianocore.org/show_bug.cgi?id=1560

Cc: Jaben Carsey 
Cc: Ray Ni 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang 
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 10 --
 .../UefiShellDebug1CommandsLib.inf |  2 --
 2 files changed, 12 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c 
b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
index a4c18c9b68..023806742d 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
@@ -17,9 +17,7 @@
 #include "UefiShellDebug1CommandsLib.h"
 #include 
 #include 
-#include 
 #include 
-#include 
 
 /**
   Make a printable character.
@@ -186,10 +184,6 @@ ShellCommandRunDmem (
   AcpiTableAddress = 
(UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
   continue;
 }
-if (CompareGuid(>ConfigurationTable[TableWalker].VendorGuid, 
)) {
-  SalTableAddress = 
(UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
-  continue;
-}
 if (CompareGuid(>ConfigurationTable[TableWalker].VendorGuid, 
)) {
   SmbiosTableAddress = 
(UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
   continue;
@@ -198,10 +192,6 @@ ShellCommandRunDmem (
   SmbiosTableAddress = (UINT64) (UINTN) 
gST->ConfigurationTable[TableWalker].VendorTable;
   continue;
 }
-if (CompareGuid(>ConfigurationTable[TableWalker].VendorGuid, 
)) {
-  MpsTableAddress = 
(UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
-  continue;
-}
   }
 
   ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_DMEM_SYSTEM_TABLE), 
gShellDebug1HiiHandle,
diff --git 
a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf 
b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
index ec1f87ae19..f2666b7ff9 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
@@ -130,8 +130,6 @@
   gEfiGlobalVariableGuid  ## SOMETIMES_CONSUMES ## GUID
   gEfiSmbiosTableGuid ## SOMETIMES_CONSUMES ## SystemTable
   gEfiSmbios3TableGuid## SOMETIMES_CONSUMES ## SystemTable
-  gEfiMpsTableGuid## SOMETIMES_CONSUMES ## SystemTable
-  gEfiSalSystemTableGuid  ## SOMETIMES_CONSUMES ## SystemTable
   gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable
   gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable
   gShellDebug1HiiGuid ## SOMETIMES_CONSUMES ## HII
-- 
2.18.0.windows.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable

[Qiu, Shumin]

Hi Ard,
Thanks for catching this.

Reviewed-by: Qiu Shumin 

-Shumin

-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] 
Sent: Thursday, March 24, 2016 2:28 PM
To: edk2-devel@lists.01.org; ler...@redhat.com; Gao, Liming; Zeng, Star; Tian, 
Feng; Qiu, Shumin; Carsey, Jaben; Fan, Jeff
Cc: Ard Biesheuvel
Subject: [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib: remove unused but set 
variable

Remove variable FStartRow that is declared, assigned but never referenced.
This fixes a warning emitted by GCC when -Wunused-but-set-variable is in effect.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel 
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c 
b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
index fb0c76e2e9db..5acd8d49f765 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
@@ -759,7 +759,6 @@ FileBufferRefresh (
 
   UINTN   StartRow;
   UINTN   EndRow;
-  UINTN   FStartRow;
   UINTN   Tmp;
 
   Orig  = MainEditor.ColorAttributes;
@@ -832,8 +831,6 @@ FileBufferRefresh (
 EndRow= Tmp;
   }
 
-  FStartRow = StartRow;
-
   StartRow  = 2 + StartRow - FileBuffer.LowVisibleRange.Row;
   EndRow= 2 + EndRow - FileBuffer.LowVisibleRange.Row;
 
@@ -841,7 +838,6 @@ FileBufferRefresh (
   //
   // not mouse selection actions
   //
-  FStartRow = FileBuffer.LowVisibleRange.Row;
   StartRow  = 2;
   EndRow= (MainEditor.ScreenSize.Row - 1);
 }
--
1.9.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable

[Laszlo Ersek]

On 03/24/16 07:28, Ard Biesheuvel wrote:
> Remove variable FStartRow that is declared, assigned but never referenced.
> This fixes a warning emitted by GCC when -Wunused-but-set-variable is in
> effect.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel 
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 4 
>  1 file changed, 4 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c 
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> index fb0c76e2e9db..5acd8d49f765 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> @@ -759,7 +759,6 @@ FileBufferRefresh (
>  
>UINTN   StartRow;
>UINTN   EndRow;
> -  UINTN   FStartRow;
>UINTN   Tmp;
>  
>Orig  = MainEditor.ColorAttributes;
> @@ -832,8 +831,6 @@ FileBufferRefresh (
>  EndRow= Tmp;
>}
>  
> -  FStartRow = StartRow;
> -
>StartRow  = 2 + StartRow - FileBuffer.LowVisibleRange.Row;
>EndRow= 2 + EndRow - FileBuffer.LowVisibleRange.Row;
>  
> @@ -841,7 +838,6 @@ FileBufferRefresh (
>//
>// not mouse selection actions
>//
> -  FStartRow = FileBuffer.LowVisibleRange.Row;
>StartRow  = 2;
>EndRow= (MainEditor.ScreenSize.Row - 1);
>  }
> 

Ah, so this fixes up a new issue; namely the one you reported in the

  [edk2] [PATCH] ShellPkg: Make the USB mouse behavior in 'edit'
 consistent with 'hexedit'.

thread.

Reviewed-by: Laszlo Ersek 
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable

[Ard Biesheuvel]

Remove variable FStartRow that is declared, assigned but never referenced.
This fixes a warning emitted by GCC when -Wunused-but-set-variable is in
effect.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel 
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c 
b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
index fb0c76e2e9db..5acd8d49f765 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
@@ -759,7 +759,6 @@ FileBufferRefresh (
 
   UINTN   StartRow;
   UINTN   EndRow;
-  UINTN   FStartRow;
   UINTN   Tmp;
 
   Orig  = MainEditor.ColorAttributes;
@@ -832,8 +831,6 @@ FileBufferRefresh (
 EndRow= Tmp;
   }
 
-  FStartRow = StartRow;
-
   StartRow  = 2 + StartRow - FileBuffer.LowVisibleRange.Row;
   EndRow= 2 + EndRow - FileBuffer.LowVisibleRange.Row;
 
@@ -841,7 +838,6 @@ FileBufferRefresh (
   //
   // not mouse selection actions
   //
-  FStartRow = FileBuffer.LowVisibleRange.Row;
   StartRow  = 2;
   EndRow= (MainEditor.ScreenSize.Row - 1);
 }
-- 
1.9.1

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel