Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

2018-03-14 Thread Ming Huang
@intel.com>; Dong, Eric <eric.d...@intel.com>; >> Kinney, Michael D <michael.d.kin...@intel.com> >> Cc: huangmin...@huawei.com; wanghuiqi...@huawei.com; >> ard.biesheu...@linaro.org; zhangjinso...@huawei.com; >> Gao, Liming <liming@intel.com>; guo

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

2018-03-12 Thread Kinney, Michael D
com; > ard.biesheu...@linaro.org; zhangjinso...@huawei.com; > Gao, Liming <liming@intel.com>; guoh...@huawei.com; > wai...@126.com; mengfanr...@huawei.com; > huangda...@hisilicon.com > Subject: RE: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use > Pcd for UsbBootIoBlocks

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

2018-03-12 Thread Zeng, Star
; guoh...@huawei.com; wai...@126.com; mengfanr...@huawei.com; > huangda...@hisilicon.com > Subject: Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for > UsbBootIoBlocks > > Any comments about this patch? > > > On 2018/3/2 14:36, Ming Huang wrote: > > > > On 2

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

2018-03-12 Thread Kinney, Michael D
<eric.d...@intel.com> > Cc: huangmin...@huawei.com; wanghuiqi...@huawei.com; > ard.biesheu...@linaro.org; zhangjinso...@huawei.com; > Kinney, Michael D <michael.d.kin...@intel.com>; Gao, > Liming <liming@intel.com>; guoh...@huawei.com; > wai...@126.com; mengfanr...@hua

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

2018-03-12 Thread Ming Huang
Any comments about this patch? On 2018/3/2 14:36, Ming Huang wrote: > > On 2018/2/27 18:01, Ni, Ruiyu wrote: >> On 2/27/2018 5:25 PM, Ming Huang wrote: >>> >>> On 2018/2/27 13:25, Ni, Ruiyu wrote: I don't prefer to add PCD, unless we cannot find: 1. spec content  to describe the

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

2018-03-01 Thread Ming Huang
On 2018/2/27 18:01, Ni, Ruiyu wrote: > On 2/27/2018 5:25 PM, Ming Huang wrote: >> >> >> On 2018/2/27 13:25, Ni, Ruiyu wrote: >>> I don't prefer to add PCD, unless we cannot find: >>> 1. spec content  to describe the max/min blocks >> There is no spec about the max/min blocks in my mind. I had

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

2018-02-27 Thread Ni, Ruiyu
On 2/27/2018 5:25 PM, Ming Huang wrote: On 2018/2/27 13:25, Ni, Ruiyu wrote: I don't prefer to add PCD, unless we cannot find: 1. spec content to describe the max/min blocks There is no spec about the max/min blocks in my mind. I had checked this in several pdf document like Universal

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

2018-02-27 Thread Ming Huang
On 2018/2/27 13:25, Ni, Ruiyu wrote: > I don't prefer to add PCD, unless we cannot find: > 1. spec content to describe the max/min blocks There is no spec about the max/min blocks in my mind. I had checked this in several pdf document like Universal Serial Bus Mass Storage Class Specification

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

2018-02-26 Thread Ni, Ruiyu
I don't prefer to add PCD, unless we cannot find: 1. spec content to describe the max/min blocks 2. error handling when the blocks number is bigger than HW expects. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ming Huang >