Re: [edk2] [PATCH] BaseTools/GenFw: ignore dynamic RELA sections

2016-08-22 Thread Gao, Liming
Ard: I have no comment. Reviewed-by: Liming Gao > Thanks Liming From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, August 22, 2016 7:33 PM To: Shi, Steven Cc: edk2-devel@lists.01.org; Gao, Liming

Re: [edk2] [PATCH] BaseTools/GenFw: ignore dynamic RELA sections

2016-08-22 Thread Ard Biesheuvel
On 22 August 2016 at 13:28, Shi, Steven wrote: > Hi Ard, > I like you path, and it makes the code look more clear. But in fact, old code > should already ignore the dynamic RELA sections implicitly. > > Like below code, when the GenFw use .rela section info value, which is

Re: [edk2] [PATCH] BaseTools/GenFw: ignore dynamic RELA sections

2016-08-22 Thread Shi, Steven
Hi Ard, I like you path, and it makes the code look more clear. But in fact, old code should already ignore the dynamic RELA sections implicitly. Like below code, when the GenFw use .rela section info value, which is 0, to get .rela target applying section address in SecShdr, it will point to

[edk2] [PATCH] BaseTools/GenFw: ignore dynamic RELA sections

2016-08-22 Thread Ard Biesheuvel
When building PIE (ET_DYN) executables, an additional RELA section is emitted (in addition to the per-section .rela.text and .rela.data sections) that is intended to be resolved at runtime by a ET_DYN compatible loader. At the moment, due to the fact that we don't support GOT based relocations,