Re: [edk2] [PATCH] IntelFsp2Pkg: FSP should not override IDT

2018-10-23 Thread Chiu, Chasel
Hi Jiewen, Thanks for the good catch! Since some platforms might have smaller temporary memory that cannot support 255 interrupt, could we define a FixedAtBuild PCD so platform decides maximum supported interrupt? If FSP found boot loader IDT table too large, it will "deadloop" to let boot lo

Re: [edk2] [PATCH] IntelFsp2Pkg: FSP should not override IDT

2018-10-22 Thread Yao, Jiewen
Hi Chasel Good idea to reserve bootloader IDT. I have a little concern on the code below. It unconditionally limits the boot loader IDT to our IdtTableInStack. #define SEC_IDT_ENTRY_COUNT34 typedef struct _SEC_IDT_TABLE { EFI_PEI_SERVICES *PeiService; UINT64IdtTable[SEC_IDT

[edk2] [PATCH] IntelFsp2Pkg: FSP should not override IDT

2018-10-19 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1265 FSP should not override IDT table when it is initialized by boot loader. IDT should be re-initialized in FSP only when it is invalid. Test: Verified on internal platform and boots successfully. Cc: Jiewen Yao Cc: Desimone Nathaniel L Con