Re: [edk2] [PATCH] MdeModulePkg PcdDxe: ASSERT PcdSetNvStoreDefaultId set

2018-10-14 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Zeng, Star > Sent: Friday, October 12, 2018 6:23 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Gao, Liming ; > Yao, Jiewen ; Wang, Jian J > Subject: [PATCH] MdeModulePkg PcdDxe: ASSERT PcdSetNvStoreDefaultId set > > REF:

Re: [edk2] [PATCH] MdeModulePkg PcdDxe: ASSERT PcdSetNvStoreDefaultId set

2018-10-14 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Zeng, Star >Sent: Friday, October 12, 2018 6:23 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star ; Gao, Liming ; >Yao, Jiewen ; Wang, Jian J >Subject: [PATCH] MdeModulePkg PcdDxe: ASSERT PcdSetNvStoreDefaultId >set > >REF:

[edk2] [PATCH] MdeModulePkg PcdDxe: ASSERT PcdSetNvStoreDefaultId set

2018-10-12 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1245 In current implementation and according to the description in MdeModulePkg.dec, PcdSetNvStoreDefaultId should be set in PEI phase to take effect. This patch ASSERTs PcdSetNvStoreDefaultId set in PcdDxe to alert the invalid operation. Cc: