Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly

2018-09-27 Thread Laszlo Ersek
On 09/27/18 11:28, Shao, Ming wrote: > Hi Laszlo, > > I build Ruiyu's code with gcc 4.8.5 as X64. And got below disassembled > code: > > [cid:image002.jpg@01D45686.AFEDF140] > > So I didn't see register used as both destination and source of xadd > instruction. > > Then I build your patch, and got

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly

2018-09-27 Thread Shao, Ming
] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly Forwarded Message Subject: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly Date: Tue, 25 Sep 2018 21:48:57 +0200 From: Laszlo Ersek mailto:ler

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly

2018-09-26 Thread Laszlo Ersek
On 09/26/18 11:34, Ni, Ruiyu wrote: > On 9/26/2018 5:05 PM, Laszlo Ersek wrote: >> Hi, >> >> On 09/25/18 21:48, Laszlo Ersek wrote: >>> Currently, "gcc-4.8.5-28.el7_5.1.x86_64" generates the following code >>> for >>> me, from the XADD inline assembly added to "X64/GccInline.c" in commit >>>

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly

2018-09-26 Thread Ni, Ruiyu
On 9/26/2018 5:05 PM, Laszlo Ersek wrote: Hi, On 09/25/18 21:48, Laszlo Ersek wrote: Currently, "gcc-4.8.5-28.el7_5.1.x86_64" generates the following code for me, from the XADD inline assembly added to "X64/GccInline.c" in commit 17634d026f96: 4383 : UINT32 EFIAPI

Re: [edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly

2018-09-26 Thread Laszlo Ersek
Hi, On 09/25/18 21:48, Laszlo Ersek wrote: > Currently, "gcc-4.8.5-28.el7_5.1.x86_64" generates the following code for > me, from the XADD inline assembly added to "X64/GccInline.c" in commit > 17634d026f96: > >> 4383 : >> UINT32 >> EFIAPI >> InternalSyncIncrement ( >> IN

[edk2] [PATCH] MdePkg/BaseSynchronizationLib: fix XADD operands in GCC IA32/X64 assembly

2018-09-25 Thread Laszlo Ersek
Currently, "gcc-4.8.5-28.el7_5.1.x86_64" generates the following code for me, from the XADD inline assembly added to "X64/GccInline.c" in commit 17634d026f96: > 4383 : > UINT32 > EFIAPI > InternalSyncIncrement ( > IN volatile UINT32*Value > ) > { > 4383: 55