Re: [edk2] [PATCH] MinPlatformPkg: Support TCO base locked by FSP

2019-01-15 Thread Chiu, Chasel
Good point! I will send another patch for this. Thanks! Chasel > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, January 15, 2019 4:12 PM > To: Chiu, Chasel ; edk2-devel@lists.01.org > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: RE: [PATCH] MinPlatformPkg: Suppo

Re: [edk2] [PATCH] MinPlatformPkg: Support TCO base locked by FSP

2019-01-15 Thread Kubacki, Michael A
According to the function description, PchTcoBaseSet ( ) should ensure the following steps are done before returning success: 1. set Smbus PCI offset 54h [8] to enable TCO base address. 2. program Smbus PCI offset 50h [15:5] to TCO base address. 3. set Smbus PCI offset 54h [8] to enable TCO

Re: [edk2] [PATCH] MinPlatformPkg: Support TCO base locked by FSP

2019-01-14 Thread Chiu, Chasel
+ Michael to review this too. Thanks! Chasel > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, January 15, 2019 12:07 PM > To: edk2-devel@lists.01.org > Cc: Desimone, Nathaniel L ; Zeng, Star > ; Chiu, Chasel > Subject: [PATCH] MinPlatformPkg: Support TCO base locked by FSP >

[edk2] [PATCH] MinPlatformPkg: Support TCO base locked by FSP

2019-01-14 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1457 Per security recommendation TCO Base should be initialized and locked by FSP and MinPlatform should support both TCO Base locked and not locked scenarios. Cc: Nate DeSimone Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement