Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-05 Thread Laszlo Ersek
> > > Thank you > > Yao Jiewen > > > > > > > > *From:*Laszlo Ersek [mailto:ler...@redhat.com] > *Sent:* Thursday, January 5, 2017 7:48 PM > *To:* Yao, Jiewen <jiewen....@intel.com>; Justen, Jordan L > <jordan.l.jus...@intel.com>; ed

Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-05 Thread Yao, Jiewen
iewen From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, January 5, 2017 7:48 PM To: Yao, Jiewen <jiewen@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; edk2-devel-01 <edk2-de...@ml01.01.org> Subject: Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct

Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-05 Thread Laszlo Ersek
you > Yao Jiewen > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan > Justen > Sent: Thursday, January 5, 2017 6:02 AM > To: Laszlo Ersek <ler...@redhat.com > <mailto:ler...@redhat.com>>; edk2-devel-01 <edk2-devel@lists.01.org > &

Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-04 Thread Yao, Jiewen
, January 5, 2017 9:03 AM To: Justen, Jordan L <jordan.l.jus...@intel.com>; Laszlo Ersek <ler...@redhat.com>; edk2-devel-01 <edk2-devel@lists.01.org> Subject: Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script Hi I agree we do use EFI_ prefix her

Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-04 Thread Yao, Jiewen
; edk2-devel-01 <edk2-devel@lists.01.org> Subject: Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script On 2017-01-04 03:19:20, Laszlo Ersek wrote: > On 01/04/17 02:30, Jordan Justen wrote: > > On 2016-12-02 02:48:44, Laszlo Ersek wrote:

Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-04 Thread Laszlo Ersek
On 01/04/17 02:30, Jordan Justen wrote: > On 2016-12-02 02:48:44, Laszlo Ersek wrote: >> EFI_BOOT_SCRIPT_PCI_CONFIG_READ_WRITE_OPCODE expects the PCI address to >> access in UEFI encoding, not in edk2/PciLib encoding. Convert the >> ICH9_GEN_PMCON_1 register's address to UEFI representation before

Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-03 Thread Jordan Justen
On 2016-12-02 02:48:44, Laszlo Ersek wrote: > EFI_BOOT_SCRIPT_PCI_CONFIG_READ_WRITE_OPCODE expects the PCI address to > access in UEFI encoding, not in edk2/PciLib encoding. Convert the > ICH9_GEN_PMCON_1 register's address to UEFI representation before storing > it in the boot script. > > Cc:

Re: [edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2017-01-03 Thread Laszlo Ersek
Jordan, Ray, Jiewen, can one of you please review this patch? The change is not specific to OVMF / QEMU behavior, it's about the correct encoding of PCI config space addresses, for the related S3 boot script operations. The POWER_MGMT_REGISTER_Q35() macro seen below is #define

[edk2] [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script

2016-12-02 Thread Laszlo Ersek
EFI_BOOT_SCRIPT_PCI_CONFIG_READ_WRITE_OPCODE expects the PCI address to access in UEFI encoding, not in edk2/PciLib encoding. Convert the ICH9_GEN_PMCON_1 register's address to UEFI representation before storing it in the boot script. Cc: Jordan Justen