Re: [edk2] [PATCH] SD/eMMC : Fix Command Argument for SD/eMMC R/W operation.

2019-01-23 Thread Leif Lindholm
Well, if we don't hear back, I can just commit it anyway before the end of the week. One question/comment inline below: On Tue, Jan 22, 2019 at 04:29:50AM +, Meenakshi Aggarwal wrote: > Hi Jun, Haojian, > > Please review the patch. > > Thanks, > Meenakshi > > > -Original Message- >

Re: [edk2] [PATCH] SD/eMMC : Fix Command Argument for SD/eMMC R/W operation.

2019-01-21 Thread Meenakshi Aggarwal
Hi Jun, Haojian, Please review the patch. Thanks, Meenakshi > -Original Message- > From: Leif Lindholm > Sent: Thursday, January 17, 2019 4:54 PM > To: Meenakshi Aggarwal > Cc: ard.biesheu...@linaro.org; edk2-devel@lists.01.org; Jun Nie > ; Haojian Zhuang > Subject: Re: [PATCH]

Re: [edk2] [PATCH] SD/eMMC : Fix Command Argument for SD/eMMC R/W operation.

2019-01-17 Thread Leif Lindholm
Jun, Haojian - any comments? On Wed, Jan 16, 2019 at 06:51:36PM +0530, Meenakshi Aggarwal wrote: > Issue : SD read failure for high capacity cards e.g. 64 GB > i > Reason : Command argument value exceeds 32 bit for block number 0x3787FFF > and cant be fit into 32 bit wide SD host controller

[edk2] [PATCH] SD/eMMC : Fix Command Argument for SD/eMMC R/W operation.

2019-01-15 Thread Meenakshi Aggarwal
Issue : SD read failure for high capacity cards e.g. 64 GB i Reason : Command argument value exceeds 32 bit for block number 0x3787FFF and cant be fit into 32 bit wide SD host controller register. Fix : AccessMode bits [29:30] of OCR is a valid definition to calculate data address for eMMC cards.