Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

2016-11-30 Thread Tian, Feng
om>; Tian, Feng <feng.t...@intel.com>; Yao, Jiewen <jiewen....@intel.com> Subject: Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path On 11/30/16 01:43, Fan, Jeff wrote: > Laszlo, > > Thanks your comments. I added my comments as below in

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

2016-11-30 Thread Laszlo Ersek
--- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 30, 2016 4:49 AM > To: Fan, Jeff; edk2-de...@ml01.01.org > Cc: Kinney, Michael D; Yao, Jiewen; Tian, Feng > Subject: Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores > on S3 boot p

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

2016-11-29 Thread Fan, Jeff
: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path On 11/29/16 08:51, Jeff Fan wrote: > Some semaphores are not cleared on S3 boot path. For example, > mSmmMpSyncData->CpuData[CpuIndex].Present. It may still keeps the > mSmmMpSyncData->value set a

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

2016-11-29 Thread Laszlo Ersek
On 11/29/16 08:51, Jeff Fan wrote: > Some semaphores are not cleared on S3 boot path. For example, > mSmmMpSyncData->CpuData[CpuIndex].Present. It may still keeps the value set at > SMM runtime during S3 resume. It may causes BSP have the wrong judgement on > SMM > AP's present state. > > We

[edk2] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Clear some semaphores on S3 boot path

2016-11-28 Thread Jeff Fan
Some semaphores are not cleared on S3 boot path. For example, mSmmMpSyncData->CpuData[CpuIndex].Present. It may still keeps the value set at SMM runtime during S3 resume. It may causes BSP have the wrong judgement on SMM AP's present state. We have one related fix at