Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

2017-07-27 Thread Marvin Häuser
July 26, 2017 4:36 PM > > To: edk2-devel@lists.01.org > > Cc: Fan, Jeff <jeff@intel.com> > > Subject: Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return > statements. > > > > Hi Jeff, > > > > Visual Studio 2005 (and .NET 2003, though i

Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

2017-07-27 Thread Gao, Liming
c: Fan, Jeff <jeff@intel.com> > Subject: Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return > statements. > > Hi Jeff, > > Visual Studio 2005 (and .NET 2003, though it is too old to compile using > EDK2. Maybe it should be deprecated?) is the version > gene

Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

2017-07-26 Thread Marvin Häuser
Hi Jeff, Visual Studio 2005 (and .NET 2003, though it is too old to compile using EDK2. Maybe it should be deprecated?) is the version generating those errors, all newer versions are fine. Thanks and regards, Marvin. > -Original Message- > From: Fan, Jeff [mailto:jeff@intel.com] >

Re: [edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

2017-07-25 Thread Fan, Jeff
Marvin, Could you tell what VS version you are using? Jeff -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, July 21, 2017 6:20 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff Subject: [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements. Old

[edk2] [PATCH] UefiCpuPkg: Add BOOLEAN casts to return statements.

2017-07-21 Thread Marvin Häuser
Old versions of the Visual Studio C compiler return a value of type 'int' for comparisons, which is what the C99 standard defines in the sections 6.5.8 and 6.5.9. When the result of a comparison is returned, int is implicitely casted to BOOLEAN, which is smaller, and hence a warning about a