Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

2016-11-30 Thread Laszlo Ersek
November 30, 2016 5:54 AM > To: Yao, Jiewen <jiewen@intel.com > <mailto:jiewen@intel.com>>; edk2-de...@ml01.01.org > <mailto:edk2-de...@ml01.01.org> > Cc: Kinney, Michael D <michael.d.kin...@intel.com > <mailto:michael.d.kin...@intel.com>>; Fan, Jeff <je

Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

2016-11-30 Thread Fan, Jeff
edk2-de...@ml01.01.org<mailto:edk2-de...@ml01.01.org> Cc: Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; Fan, Jeff <jeff@intel.com<mailto:jeff@intel.com>> Subject: Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on s

Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

2016-11-29 Thread Yao, Jiewen
com>; Fan, Jeff <jeff@intel.com> Subject: Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split. Comments below: From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 30, 2016 5:54 AM To: Yao, Jiewen <jiewen@intel.com<mailto:jiewen..

Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

2016-11-29 Thread Yao, Jiewen
Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split. On 11/29/16 08:39, Jiewen Yao wrote: > PiSmmCpu driver may split page for page attribute request. > Current logic will propagate the super page attribute attribute. > However, it might be wrong because we cannot clear protection

Re: [edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

2016-11-29 Thread Laszlo Ersek
On 11/29/16 08:39, Jiewen Yao wrote: > PiSmmCpu driver may split page for page attribute request. > Current logic will propagate the super page attribute attribute. > However, it might be wrong because we cannot clear protection > without touch super page attribute. > > We should always clear

[edk2] [PATCH] UefiCpuPkg:PiSmmCpu: Set correct attribute on split.

2016-11-28 Thread Jiewen Yao
PiSmmCpu driver may split page for page attribute request. Current logic will propagate the super page attribute attribute. However, it might be wrong because we cannot clear protection without touch super page attribute. We should always clear protection on super page and set protection on end