Re: [edk2] [PATCH 00/52] Resolve issues for C source codes in BaseTools

2016-10-17 Thread Gao, Liming
Hao, I have some comments for three patches. Others are good to me. Patch: BaseTools/TianoCompress: Avoid possible NULL pointer dereference Comment: Please free allocated buffer after error happens. Patch: BaseTools/C/Common: Fix parameter format mismatch in scanf functions Comment:

[edk2] [PATCH 00/52] Resolve issues for C source codes in BaseTools

2016-10-12 Thread Hao Wu
The patch series fixes the following types of issues for C source codes in BaseTools: 1. Avoid possible NULL pointer dereference 2. Initialize local variables before use 3. Remove unused local variables 4. Avoid accessing over array bounds 5. Resolve possible memory leak 6. Resolve file handles