Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-12-08 Thread Ard Biesheuvel
On 7 December 2017 at 16:53, Alexei Fedorov wrote: > As expected with new ASSERT_EFI_ERROR () definition compiler generates 1 > conditional branch at the start: > > > // r:\edk2\ArmPlatformPkg\Drivers\LcdGraphicsOutputDxe\HdLcd.c:79: > ASSERT_EFI_ERROR (Status); > .loc

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-12-07 Thread Alexei Fedorov
As expected with new ASSERT_EFI_ERROR () definition compiler generates 1 conditional branch at the start: // r:\edk2\ArmPlatformPkg\Drivers\LcdGraphicsOutputDxe\HdLcd.c:79: ASSERT_EFI_ERROR (Status); .loc 1 79 0 tbzx0, #63, .L4// Status,

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-12-07 Thread Ard Biesheuvel
On 7 December 2017 at 14:55, Alexei Fedorov wrote: > Hi, > > I've compiled current HdLcd.c code with different optimisation levels for > DEBUG build using GCC 7.2.1, and the assembler code below was generated for: > > ASSERT_EFI_ERROR (Status); > if (EFI_ERROR( Status

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-12-07 Thread Alexei Fedorov
Evan Lloyd <evan.ll...@arm.com> Sent: 05 December 2017 20:46 To: Ard Biesheuvel Cc: edk2-devel@lists.01.org; leif.lindh...@linaro.org@arm.com; n...@arm.com@arm.com; ard.biesheu...@linaro.org@arm.com; matteo.carl...@arm.com@arm.com Subject: Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraph

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-12-05 Thread Evan Lloyd
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 01 December 2017 17:35 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org@arm.com > <"ard.biesheu...@linaro.org"@arm.com>; > leif.lindh...@linaro.org@arm.com

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-12-01 Thread Leif Lindholm
On Fri, Dec 01, 2017 at 05:34:52PM +, Ard Biesheuvel wrote: > On 1 December 2017 at 16:33, Evan Lloyd wrote: > > Responses inline: > > > >> -Original Message- > >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > >> Sent: 13 October 2017 08:33 > >> To:

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-12-01 Thread Ard Biesheuvel
On 1 December 2017 at 16:33, Evan Lloyd wrote: > Responses inline: > >> -Original Message- >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> Sent: 13 October 2017 08:33 >> To: Evan Lloyd >> Cc: edk2-devel@lists.01.org;

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-12-01 Thread Evan Lloyd
Responses inline: > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 13 October 2017 08:33 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org; "ard.biesheu...@linaro.org"@arm.com; > "leif.lindh...@linaro.org"@arm.com; >

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-10-13 Thread Ard Biesheuvel
On 26 September 2017 at 21:15, wrote: > From: Girish Pathak > > This change adds some debug assertions e.g to catch NULL pointer errors > missing in PL11Lcd and HdLcd modules. > > This change also improves related error handling code. > >

Re: [edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-10-12 Thread Leif Lindholm
On Tue, Sep 26, 2017 at 09:15:14PM +0100, evan.ll...@arm.com wrote: > From: Girish Pathak > > This change adds some debug assertions e.g to catch NULL pointer errors > missing in PL11Lcd and HdLcd modules. > > This change also improves related error handling code. > >

[edk2] [PATCH 04/19] ArmPlatformPkg: LcdGraphicsOurputDxe: Add debug asserts

2017-09-26 Thread evan . lloyd
From: Girish Pathak This change adds some debug assertions e.g to catch NULL pointer errors missing in PL11Lcd and HdLcd modules. This change also improves related error handling code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Girish Pathak