Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-20 Thread Ard Biesheuvel
On Thu, 20 Dec 2018 at 10:01, Jagadeesh Ujja wrote: > > hi Ard, > > On Tue, Dec 18, 2018 at 7:38 AM Yao, Jiewen wrote: > > > > + Wu Hao, since he contributed the original patch. > > > > Ard > > Would you please file a Bugzilla for that? Then we can start working on > > that. > > > > Can you

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-20 Thread Jagadeesh Ujja
; > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf > > Of > > > > Ard Biesheuvel > > > > Sent: Monday, December 17, 2018 4:35 PM > > > > To: Yao, Jiewen > > > > Cc: edk2-devel@lists.01.org; Gao, Liming ; > > Zhang

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Yao, Jiewen
10:12 AM > To: Yao, Jiewen ; Ard Biesheuvel > ; Wu, Hao A > Cc: edk2-devel@lists.01.org; Zhang, Chao B > Subject: RE: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add > AsmLfence function > > Jiewen: > New SpeculationBarrier() will be for all ARCHs. IA32 and

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Gao, Liming
Liming >-Original Message- >From: Yao, Jiewen >Sent: Tuesday, December 18, 2018 10:08 AM >To: Ard Biesheuvel ; Wu, Hao A > >Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhang, >Chao B >Subject: RE: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add >AsmLfence

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Yao, Jiewen
> To: Yao, Jiewen > Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhang, > Chao B > Subject: Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add > AsmLfence function > > On Mon, 17 Dec 2018 at 09:44, Yao, Jiewen wrote: > > > > Thanks Ard. > > I have litt

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Ard Biesheuvel
--Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Ard Biesheuvel > > Sent: Monday, December 17, 2018 4:35 PM > > To: Yao, Jiewen > > Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhang, > > Chao B > > Subjec

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Yao, Jiewen
Sent: Monday, December 17, 2018 4:35 PM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhang, > Chao B > Subject: Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add > AsmLfence function > > On Mon, 17 Dec 2018 at 09:30, Yao, Jiewen wrote: > &

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Ard Biesheuvel
sage- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Yao, Jiewen > > Sent: Monday, December 17, 2018 4:25 PM > > To: Ard Biesheuvel ; Leif Lindholm > > > > Cc: edk2-devel@lists.01.org; Zhang, Chao B ; > > Gao, Liming &

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Yao, Jiewen
l-boun...@lists.01.org] On Behalf Of > Yao, Jiewen > Sent: Monday, December 17, 2018 4:25 PM > To: Ard Biesheuvel ; Leif Lindholm > > Cc: edk2-devel@lists.01.org; Zhang, Chao B ; > Gao, Liming > Subject: Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add > AsmLfen

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Yao, Jiewen
ISB instruction here as well as some kind of other > > barrier. Calling it LoadFence() makes no sense whatsoever. > > > > > > > > > > > > > > > > > -----Original Message----- > > > > From: edk2-devel [mailto:edk2-devel-boun...@li

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-17 Thread Ard Biesheuvel
nce() makes no sense whatsoever. > > > > > > > > > > -Original Message- > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > > Gao, Liming > > > Sent: Monday, December 17, 2018 10:04 AM > > > To: Ard

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-16 Thread Ard Biesheuvel
gt; > To: Ard Biesheuvel ; Jagadeesh Ujja > > ; Leif Lindholm > > Cc: edk2-devel@lists.01.org; Zhang, Chao B > > Subject: Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add > > AsmLfence function > > > > Ard: > > My first comment is to sug

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-16 Thread Yao, Jiewen
, 2018 10:04 AM > To: Ard Biesheuvel ; Jagadeesh Ujja > ; Leif Lindholm > Cc: edk2-devel@lists.01.org; Zhang, Chao B > Subject: Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add > AsmLfence function > > Ard: > My first comment is to suggest updating the call

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-16 Thread Gao, Liming
Ard: My first comment is to suggest updating the caller code for the arch specific code. But, there are two drivers that have the same usage. This way will introduce the duplicated code logic. So, I suggest another way to extend AsmLfence() API scope for the different ARCHs. If you think it

Re: [edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-14 Thread Ard Biesheuvel
On Fri, 14 Dec 2018 at 13:13, Jagadeesh Ujja wrote: > > Variable service driver includes a call to AsmLfence. To reuse this > driver on AArch64 based platforms, add an implementation of AsmLfence > that acts as a wrapper on the AArch64 specific MemoryFence function. > > Contributed-under:

[edk2] [PATCH 05/13] MdePkg/Library/BaseLib/AArch64: Add AsmLfence function

2018-12-14 Thread Jagadeesh Ujja
Variable service driver includes a call to AsmLfence. To reuse this driver on AArch64 based platforms, add an implementation of AsmLfence that acts as a wrapper on the AArch64 specific MemoryFence function. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja ---