Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-03-07 Thread Ni, Ruiyu
On 3/7/2018 9:54 AM, Guo Heyi wrote: Hi Ray, Sorry to disturb, but I didn't find the patch committed. Could you help to do that? Thanks, Heyi On Thu, Mar 01, 2018 at 12:46:32PM +0800, Ni, Ruiyu wrote: On 3/1/2018 10:39 AM, Heyi Guo wrote: Function BmRepairAllControllers may recursively call

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-03-06 Thread Guo Heyi
Hi Ray, Sorry to disturb, but I didn't find the patch committed. Could you help to do that? Thanks, Heyi On Thu, Mar 01, 2018 at 12:46:32PM +0800, Ni, Ruiyu wrote: > On 3/1/2018 10:39 AM, Heyi Guo wrote: > >Function BmRepairAllControllers may recursively call itself if some > >driver health pro

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-28 Thread Ni, Ruiyu
On 3/1/2018 10:39 AM, Heyi Guo wrote: Function BmRepairAllControllers may recursively call itself if some driver health protocol returns EfiDriverHealthStatusReconnectRequired. However, driver health protocol of some buggy third party driver may always return such status even after one and anothe

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-28 Thread Guo Heyi
Sorry, forgot to add a "v2" mark in the subjuect prefix... Regards, Heyi On Thu, Mar 01, 2018 at 10:39:32AM +0800, Heyi Guo wrote: > Function BmRepairAllControllers may recursively call itself if some > driver health protocol returns EfiDriverHealthStatusReconnectRequired. > However, driver healt

[edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-28 Thread Heyi Guo
Function BmRepairAllControllers may recursively call itself if some driver health protocol returns EfiDriverHealthStatusReconnectRequired. However, driver health protocol of some buggy third party driver may always return such status even after one and another reconnect. The endless iteration will

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-27 Thread Guo Heyi
Thanks Ray and Laszlo, I will create v2 according to your comments. Regards, Heyi On Tue, Feb 27, 2018 at 11:29:18AM +0100, Laszlo Ersek wrote: > On 02/27/18 06:48, Ni, Ruiyu wrote: > > On 2/27/2018 8:48 AM, Guo Heyi wrote: > >> Hi Laszlo, > >> > >> I agree the current patch makes the code ugly,

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-27 Thread Laszlo Ersek
On 02/27/18 06:48, Ni, Ruiyu wrote: > On 2/27/2018 8:48 AM, Guo Heyi wrote: >> Hi Laszlo, >> >> I agree the current patch makes the code ugly, and turning the logic >> into a >> normal loop should be the perfect solution. If Ray also agrees on it, >> I can try >> to do that. >> >> Thanks and regard

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-26 Thread Ni, Ruiyu
On 2/27/2018 8:48 AM, Guo Heyi wrote: Hi Laszlo, I agree the current patch makes the code ugly, and turning the logic into a normal loop should be the perfect solution. If Ray also agrees on it, I can try to do that. Thanks and regards, Heyi On Mon, Feb 26, 2018 at 05:23:29PM +0100, Laszlo Er

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-26 Thread Wang, Sunny (HPS SW)
g > Cc: Ruiyu Ni ; Heyi Guo ; > Eric Dong ; Star Zeng > Subject: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit > recursive call depth > > Function BmRepairAllControllers may recursively call itself if some driver > health protocol returns EfiDriverHealthStatusRec

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-26 Thread Guo Heyi
Hi Laszlo, I agree the current patch makes the code ugly, and turning the logic into a normal loop should be the perfect solution. If Ray also agrees on it, I can try to do that. Thanks and regards, Heyi On Mon, Feb 26, 2018 at 05:23:29PM +0100, Laszlo Ersek wrote: > On 02/26/18 09:29, Heyi Guo

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-26 Thread Laszlo Ersek
On 02/26/18 09:29, Heyi Guo wrote: > Function BmRepairAllControllers may recursively call itself if some > driver health protocol returns EfiDriverHealthStatusReconnectRequired. > However, driver health protocol of some buggy third party driver may > always return such status even after one and ano

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-26 Thread Guo Heyi
> > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi > Guo > Sent: Monday, February 26, 2018 4:30 PM > To: edk2-devel@lists.01.org > Cc: Ruiyu Ni ; Heyi Guo ; Eric Dong > ; Star Zeng > Subject: [edk2] [PATCH 1/1] Mde

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-26 Thread Wang, Sunny (HPS SW)
: Monday, February 26, 2018 4:30 PM To: edk2-devel@lists.01.org Cc: Ruiyu Ni ; Heyi Guo ; Eric Dong ; Star Zeng Subject: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth Function BmRepairAllControllers may recursively call itself if some driver health protocol

[edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

2018-02-26 Thread Heyi Guo
Function BmRepairAllControllers may recursively call itself if some driver health protocol returns EfiDriverHealthStatusReconnectRequired. However, driver health protocol of some buggy third party driver may always return such status even after one and another reconnect. The endless iteration will