Re: [edk2] [PATCH 1/1] OvmfPkg/IoMmuDxe: shut up "unused-const-variable" gcc-6 warning in RELEASE

2017-09-07 Thread Laszlo Ersek
On 09/07/17 07:47, Thomas Lamprecht wrote: > On 09/07/2017 05:38 AM, Gao, Liming wrote: >> Laszlo: >>    I add -Wno-unused-const-variable option in GCC5 RELEASE option, and >> build OvmfPkg with GCC5.3. I don't meet any warning or error. Do you >> meet any issue? So, you think we can't add this

Re: [edk2] [PATCH 1/1] OvmfPkg/IoMmuDxe: shut up "unused-const-variable" gcc-6 warning in RELEASE

2017-09-06 Thread Thomas Lamprecht
On 09/07/2017 05:38 AM, Gao, Liming wrote: Laszlo: I add -Wno-unused-const-variable option in GCC5 RELEASE option, and build OvmfPkg with GCC5.3. I don't meet any warning or error. Do you meet any issue? So, you think we can't add this option in GCC5 tool chain. Yes, he is right, looking

Re: [edk2] [PATCH 1/1] OvmfPkg/IoMmuDxe: shut up "unused-const-variable" gcc-6 warning in RELEASE

2017-09-06 Thread Laszlo Ersek
On 09/06/17 19:12, Ard Biesheuvel wrote: > On 6 September 2017 at 18:09, Laszlo Ersek wrote: >> On 09/06/17 18:56, Ard Biesheuvel wrote: >>> On 6 September 2017 at 17:48, Laszlo Ersek wrote: Starting with gcc-6, a new warning option called

Re: [edk2] [PATCH 1/1] OvmfPkg/IoMmuDxe: shut up "unused-const-variable" gcc-6 warning in RELEASE

2017-09-06 Thread Ard Biesheuvel
On 6 September 2017 at 18:09, Laszlo Ersek wrote: > On 09/06/17 18:56, Ard Biesheuvel wrote: >> On 6 September 2017 at 17:48, Laszlo Ersek wrote: >>> Starting with gcc-6, a new warning option called "-Wunused-const-variable" >>> has become available (and

Re: [edk2] [PATCH 1/1] OvmfPkg/IoMmuDxe: shut up "unused-const-variable" gcc-6 warning in RELEASE

2017-09-06 Thread Laszlo Ersek
On 09/06/17 18:56, Ard Biesheuvel wrote: > On 6 September 2017 at 17:48, Laszlo Ersek wrote: >> Starting with gcc-6, a new warning option called "-Wunused-const-variable" >> has become available (and enabled by default under our build settings): >> >>

Re: [edk2] [PATCH 1/1] OvmfPkg/IoMmuDxe: shut up "unused-const-variable" gcc-6 warning in RELEASE

2017-09-06 Thread Ard Biesheuvel
On 6 September 2017 at 17:48, Laszlo Ersek wrote: > Starting with gcc-6, a new warning option called "-Wunused-const-variable" > has become available (and enabled by default under our build settings): > > https://gcc.gnu.org/onlinedocs/gcc-6.4.0/gcc/Warning-Options.html > >

[edk2] [PATCH 1/1] OvmfPkg/IoMmuDxe: shut up "unused-const-variable" gcc-6 warning in RELEASE

2017-09-06 Thread Laszlo Ersek
Starting with gcc-6, a new warning option called "-Wunused-const-variable" has become available (and enabled by default under our build settings): https://gcc.gnu.org/onlinedocs/gcc-6.4.0/gcc/Warning-Options.html We should give it the same treatment as Ard gave "unused-but-set-variable" in