Re: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg
Laszlo, thanks a bunch for this information. I hadn’t realized I had to do that manually. Jaben > On Nov 5, 2018, at 8:52 AM, Laszlo Ersek wrote: > >> On 11/01/18 12:31, Leif Lindholm wrote: >>> On Thu, Nov 01, 2018 at 06:03:22AM +, Zhang, Shenglei wrote: >>> Hi Leif, >>> >>> Thanks for your comments. Actually there is a cover letter. >>> https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html >> >> Ah, I missed that one since I was on cc on the rest of the set, but >> not the cover letter. > > Indeed it is important to collect all CC's from the individual patches > and to add them to the cover letter. > > Laszlo > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg
On 11/01/18 12:31, Leif Lindholm wrote: > On Thu, Nov 01, 2018 at 06:03:22AM +, Zhang, Shenglei wrote: >> Hi Leif, >> >> Thanks for your comments. Actually there is a cover letter. >> https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html > > Ah, I missed that one since I was on cc on the rest of the set, but > not the cover letter. Indeed it is important to collect all CC's from the individual patches and to add them to the cover letter. Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg
On Thu, Nov 01, 2018 at 06:03:22AM +, Zhang, Shenglei wrote: > Hi Leif, > > Thanks for your comments. Actually there is a cover letter. > https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html Ah, I missed that one since I was on cc on the rest of the set, but not the cover letter. > It may not be needed to rework but I 'll push the patches in order according > to > the comments you mentioned. If you do that: Reviewed-by: Leif Lindholm (After the November stable tag has been made.) Regards, Leif > Thanks, > Shenglei > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Wednesday, October 31, 2018 7:02 PM > > To: Zhang, Shenglei > > Cc: edk2-devel@lists.01.org; Andrew Fish ; Laszlo Ersek > > ; Kinney, Michael D > > Subject: Re: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and > > EkdShellBinPkg > > > > Hi Shenglei, > > > > I am happy with this change, but I think the deletion from > > Maintainers.txt should come last (as 3/3). > > Could you rework and resubmit, and add a cover letter (0/3)? > > > > Best Regards, > > > > Leif > > > > On Wed, Oct 31, 2018 at 02:05:23PM +0800, shenglei wrote: > > > Given that EdkShellPkg and EkdShellBinPkg will be removed, > > > information about them in Maintainers.txt should also be > > > deleted. > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1107 > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1108 > > > > > > Cc: Andrew Fish > > > Cc: Laszlo Ersek > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: shenglei > > > --- > > > Maintainers.txt | 6 -- > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > > index 36c6689afd..98f104b674 100644 > > > --- a/Maintainers.txt > > > +++ b/Maintainers.txt > > > @@ -114,12 +114,6 @@ EdkCompatibilityPkg > > > W: > > https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg > > > M: Liming Gao > > > > > > -EdkShellPkg, EdkShellBinPkg > > > -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg > > > -M: Ruiyu Ni > > > -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/ > > > -S: Obsolete (Use ShellPkg & ShellBinPkg instead) > > > - > > > EmbeddedPkg > > > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > > > M: Leif Lindholm > > > -- > > > 2.18.0.windows.1 > > > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg
Hi Leif, Thanks for your comments. Actually there is a cover letter. https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html It may not be needed to rework but I 'll push the patches in order according to the comments you mentioned. Thanks, Shenglei > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, October 31, 2018 7:02 PM > To: Zhang, Shenglei > Cc: edk2-devel@lists.01.org; Andrew Fish ; Laszlo Ersek > ; Kinney, Michael D > Subject: Re: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and > EkdShellBinPkg > > Hi Shenglei, > > I am happy with this change, but I think the deletion from > Maintainers.txt should come last (as 3/3). > Could you rework and resubmit, and add a cover letter (0/3)? > > Best Regards, > > Leif > > On Wed, Oct 31, 2018 at 02:05:23PM +0800, shenglei wrote: > > Given that EdkShellPkg and EkdShellBinPkg will be removed, > > information about them in Maintainers.txt should also be > > deleted. > > https://bugzilla.tianocore.org/show_bug.cgi?id=1107 > > https://bugzilla.tianocore.org/show_bug.cgi?id=1108 > > > > Cc: Andrew Fish > > Cc: Laszlo Ersek > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: shenglei > > --- > > Maintainers.txt | 6 -- > > 1 file changed, 6 deletions(-) > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > index 36c6689afd..98f104b674 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -114,12 +114,6 @@ EdkCompatibilityPkg > > W: > https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg > > M: Liming Gao > > > > -EdkShellPkg, EdkShellBinPkg > > -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg > > -M: Ruiyu Ni > > -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/ > > -S: Obsolete (Use ShellPkg & ShellBinPkg instead) > > - > > EmbeddedPkg > > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > > M: Leif Lindholm > > -- > > 2.18.0.windows.1 > > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg
Hi Shenglei, I am happy with this change, but I think the deletion from Maintainers.txt should come last (as 3/3). Could you rework and resubmit, and add a cover letter (0/3)? Best Regards, Leif On Wed, Oct 31, 2018 at 02:05:23PM +0800, shenglei wrote: > Given that EdkShellPkg and EkdShellBinPkg will be removed, > information about them in Maintainers.txt should also be > deleted. > https://bugzilla.tianocore.org/show_bug.cgi?id=1107 > https://bugzilla.tianocore.org/show_bug.cgi?id=1108 > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > Maintainers.txt | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 36c6689afd..98f104b674 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -114,12 +114,6 @@ EdkCompatibilityPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg > M: Liming Gao > > -EdkShellPkg, EdkShellBinPkg > -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg > -M: Ruiyu Ni > -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/ > -S: Obsolete (Use ShellPkg & ShellBinPkg instead) > - > EmbeddedPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > M: Leif Lindholm > -- > 2.18.0.windows.1 > ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, October 31, 2018 2:05 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Laszlo Ersek > > Subject: [edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and > EkdShellBinPkg > > Given that EdkShellPkg and EkdShellBinPkg will be removed, information > about them in Maintainers.txt should also be deleted. > https://bugzilla.tianocore.org/show_bug.cgi?id=1107 > https://bugzilla.tianocore.org/show_bug.cgi?id=1108 > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > Maintainers.txt | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt index 36c6689afd..98f104b674 > 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -114,12 +114,6 @@ EdkCompatibilityPkg > W: > https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg > M: Liming Gao > > -EdkShellPkg, EdkShellBinPkg > -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg > -M: Ruiyu Ni > -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/ > -S: Obsolete (Use ShellPkg & ShellBinPkg instead) > - > EmbeddedPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > M: Leif Lindholm > -- > 2.18.0.windows.1 > > ___ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg
Given that EdkShellPkg and EkdShellBinPkg will be removed, information about them in Maintainers.txt should also be deleted. https://bugzilla.tianocore.org/show_bug.cgi?id=1107 https://bugzilla.tianocore.org/show_bug.cgi?id=1108 Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- Maintainers.txt | 6 -- 1 file changed, 6 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 36c6689afd..98f104b674 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -114,12 +114,6 @@ EdkCompatibilityPkg W: https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg M: Liming Gao -EdkShellPkg, EdkShellBinPkg -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg -M: Ruiyu Ni -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/ -S: Obsolete (Use ShellPkg & ShellBinPkg instead) - EmbeddedPkg W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg M: Leif Lindholm -- 2.18.0.windows.1 ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
