Re: [edk2] [PATCH 1/8] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2015-12-31 Thread Ard Biesheuvel
On 18 December 2015 at 04:05, Gao, Liming wrote: > Reviewed-by: Liming Gao > Thanks. Committed as SVN r19580 > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, December 17, 2015 6:01 PM > To:

[edk2] [PATCH 1/8] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2015-12-17 Thread Ard Biesheuvel
The runtime test whether the compiler supports arithmetic shift of negative signed numbers currently relies on undefined behavior in C, which means that all bets are off regarding whether the condition that follows passes or fails, regardless of whether the compiler in fact supports arithmetic

Re: [edk2] [PATCH 1/8] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2015-12-17 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 17, 2015 6:01 PM To: edk2-devel@lists.01.org; Gao, Liming Cc: Ard Biesheuvel Subject: [PATCH 1/8] MdePkg/BaseLib: do not rely on undefined