Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

-de...@ml01.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Fan, Jeff <jeff....@intel.com> > Subject: Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to > initialize ACPI_CPU_DATA for S3 > > On 11/24/15 07:24, Michael Kinney wrote: > > This module in

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

ovember 24, 2015 11:57 AM >> To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-de...@ml01.01.org >> Cc: Yao, Jiewen <jiewen@intel.com>; Fan, Jeff <jeff@intel.com> >> Subject: Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to >> init

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Hi Mike This patch is great. We can have a generic S3 support module now. After check the code, I am not sure if we have to allocate AcpiNvs for these data. Per my understanding, SMM CPU driver will always copy them into SMRAM, for security consideration. If so, do you think it is enough to

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Jiewen, ACPI NVS is required for SMM disabled case. Mike > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, November 24, 2015 6:14 AM > To: Kinney, Michael D ; edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Fan, Jeff

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

On 11/24/15 15:13, Yao, Jiewen wrote: > Hi Mike > This patch is great. > We can have a generic S3 support module now. > > After check the code, I am not sure if we have to allocate AcpiNvs for these > data. > Per my understanding, SMM CPU driver will always copy them into SMRAM, for > security

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Got it. Agree. -Original Message- From: Kinney, Michael D Sent: Tuesday, November 24, 2015 10:47 PM To: Yao, Jiewen; edk2-devel@lists.01.org; Kinney, Michael D Cc: Laszlo Ersek; Fan, Jeff Subject: RE: [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Re: [edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

Yes, I found only ApMachineCheckHandlerBase is copied back, because it is code. CopyMem ((VOID *)(UINTN) mAcpiCpuData.ApMachineCheckHandlerBase, mMachineCheckHandlerForAp, mAcpiCpuData.ApMachineCheckHandlerSize); There is no need to copy other data back to original place because it just

[edk2] [PATCH 2/2] UefiCpuPkg:CpuS3DataDxe - Add module to initialize ACPI_CPU_DATA for S3

This module initializes the ACPI_CPU_DATA structure and registers the address of this structure in the PcdCpuS3DataAddress PCD. This is simplest version of this module. It does not provide a machine check handler or CPU register initialization tables for ACPI S3 resume. This module can be copied