Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib AARCH64: get rid of needless TLB invalidation

2019-01-29 Thread Ard Biesheuvel
On Mon, 28 Jan 2019 at 19:01, Leif Lindholm wrote: > > On Mon, Jan 28, 2019 at 01:29:54PM +0100, Ard Biesheuvel wrote: > > > > > > > > @@ -296,7 +297,8 @@ GetBlockEntryListFromAddress ( > > > > > > > > > > > > > > > > // Fill the BlockEntry with the new TranslationTable > > > > > > > >

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib AARCH64: get rid of needless TLB invalidation

2019-01-28 Thread Leif Lindholm
On Mon, Jan 28, 2019 at 01:29:54PM +0100, Ard Biesheuvel wrote: > > > > > > > @@ -296,7 +297,8 @@ GetBlockEntryListFromAddress ( > > > > > > > > > > > > > > // Fill the BlockEntry with the new TranslationTable > > > > > > > ReplaceLiveEntry (BlockEntry, > > > > > > > -

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib AARCH64: get rid of needless TLB invalidation

2019-01-28 Thread Ard Biesheuvel
On Wed, 23 Jan 2019 at 17:20, Leif Lindholm wrote: > > On Wed, Jan 23, 2019 at 05:16:57PM +0100, Ard Biesheuvel wrote: > > On Wed, 23 Jan 2019 at 17:13, Leif Lindholm > > wrote: > > > > > > On Wed, Jan 23, 2019 at 04:55:28PM +0100, Ard Biesheuvel wrote: > > > > On Wed, 23 Jan 2019 at 16:46,

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib AARCH64: get rid of needless TLB invalidation

2019-01-23 Thread Ard Biesheuvel
On Wed, 23 Jan 2019 at 17:13, Leif Lindholm wrote: > > On Wed, Jan 23, 2019 at 04:55:28PM +0100, Ard Biesheuvel wrote: > > On Wed, 23 Jan 2019 at 16:46, Leif Lindholm > > wrote: > > > > > > On Mon, Jan 07, 2019 at 08:15:01AM +0100, Ard Biesheuvel wrote: > > > > Currently, we always invalidate

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib AARCH64: get rid of needless TLB invalidation

2019-01-23 Thread Leif Lindholm
On Wed, Jan 23, 2019 at 05:16:57PM +0100, Ard Biesheuvel wrote: > On Wed, 23 Jan 2019 at 17:13, Leif Lindholm wrote: > > > > On Wed, Jan 23, 2019 at 04:55:28PM +0100, Ard Biesheuvel wrote: > > > On Wed, 23 Jan 2019 at 16:46, Leif Lindholm > > > wrote: > > > > > > > > On Mon, Jan 07, 2019 at

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib AARCH64: get rid of needless TLB invalidation

2019-01-23 Thread Leif Lindholm
On Wed, Jan 23, 2019 at 04:55:28PM +0100, Ard Biesheuvel wrote: > On Wed, 23 Jan 2019 at 16:46, Leif Lindholm wrote: > > > > On Mon, Jan 07, 2019 at 08:15:01AM +0100, Ard Biesheuvel wrote: > > > Currently, we always invalidate the TLBs entirely after making > > > any modification to the page

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib AARCH64: get rid of needless TLB invalidation

2019-01-23 Thread Ard Biesheuvel
On Wed, 23 Jan 2019 at 16:46, Leif Lindholm wrote: > > On Mon, Jan 07, 2019 at 08:15:01AM +0100, Ard Biesheuvel wrote: > > Currently, we always invalidate the TLBs entirely after making > > any modification to the page tables. Now that we have introduced > > strict memory permissions in quite a

Re: [edk2] [PATCH 2/5] ArmPkg/ArmMmuLib AARCH64: get rid of needless TLB invalidation

2019-01-23 Thread Leif Lindholm
On Mon, Jan 07, 2019 at 08:15:01AM +0100, Ard Biesheuvel wrote: > Currently, we always invalidate the TLBs entirely after making > any modification to the page tables. Now that we have introduced > strict memory permissions in quite a number of places, such > modifications occur much more often,

[edk2] [PATCH 2/5] ArmPkg/ArmMmuLib AARCH64: get rid of needless TLB invalidation

2019-01-06 Thread Ard Biesheuvel
Currently, we always invalidate the TLBs entirely after making any modification to the page tables. Now that we have introduced strict memory permissions in quite a number of places, such modifications occur much more often, and it is better for performance to flush only those TLB entries that are